Re: [PATCH] Avoid ambiguities when prettifying snapshot names

[Jason A. Donenfeld]

Hey Lukas,

I appreciate that this unifies the 'v' detection code as well. I also
like the "(a==0 + b==0 + c==0) == 1" trick. I'll merge this, and base
the fixes for tags with / in them on this commit.

Thanks,
Jason
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Avoid ambiguities when prettifying snapshot names

[Lukas Fleischer]

On Tue, 24 May 2016 at 18:15:18, Lukas Fleischer wrote:
> When composing snapshot file names for a tag with a prefix of the form
> v[0-9] (resp. V[0-9]), the leading "v" (resp. "V") is stripped. This
> leads to conflicts if a tag with the stripped name already exists or if
> there are tags only differing in the capitalization of the leading "v".
> Make sure we do not strip the "v" in these cases.
> 
> Reported-by: Juuso Lapinlampi 
> Signed-off-by: Lukas Fleischer 
> ---
> Note: The code that actually generates the snapshots works fine as it
> always tries an exact match first.
> 
>  ui-refs.c   | 24 +---
>  ui-shared.c | 26 +-
>  ui-shared.h |  2 ++
>  3 files changed, 32 insertions(+), 20 deletions(-)

Any comments on this?
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit