Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger
On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse l...@eworm.de wrote: Looks better, though not perfect. At least firefox still scales the image a bit. Can you investigate the whole px to pt situation, line-height, and the best way to manage this? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit
Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger
Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 18:23:
On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse l...@eworm.de wrote:
Looks better, though not perfect.
At least firefox still scales the image a bit.
Can you investigate the whole px to pt situation, line-height, and
the best way to manage this?
pixels = points * 96 / 72
So for 10pt:
10 * 96 / 72 = 13.334
The browser scales the image, then keeps the full pixels.
Probably the only way to not have this is to use pixel only for images.
Want a patch?
--
main(a){char*c=/*Schoene Gruesse */B?IJj;MEH
CX:;,b;for(a/*Chris get my mail address:*/=0;b=c[a++];)
putchar(b-1/(/* gcc -o sig sig.c ./sig*/b/42*2-3)*42);}
signature.asc
Description: PGP signature
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger
Am 14.01.2014 18:35, schrieb Christian Hesse: Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 18:23: On Tue, Jan 14, 2014 at 6:22 PM, Christian Hesse l...@eworm.de wrote: Looks better, though not perfect. At least firefox still scales the image a bit. Can you investigate the whole px to pt situation, line-height, and the best way to manage this? pixels = points * 96 / 72 96 only iff DPI=96, isn't it? signature.asc Description: OpenPGP digital signature ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit
Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger
On Tue, Jan 14, 2014 at 6:35 PM, Christian Hesse l...@eworm.de wrote: Probably the only way to not have this is to use pixel only for images. Want a patch? I think I have it handled. Would you look at git.zx2c4.com/cgit/log/ and tell me if that looks better to you? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit
Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger
Jason A. Donenfeld ja...@zx2c4.com on Tue, 2014/01/14 18:51:
On Tue, Jan 14, 2014 at 6:35 PM, Christian Hesse l...@eworm.de wrote:
Probably the only way to not have this is to use pixel only for images.
Want a patch?
I think I have it handled. Would you look at git.zx2c4.com/cgit/log/
and tell me if that looks better to you?
Looks good to me.
Though this may result in images that do not fit font size if dpi is a lot
more or less than 96 as René pointed.
--
main(a){char*c=/*Schoene Gruesse */B?IJj;MEH
CX:;,b;for(a/*Chris get my mail address:*/=0;b=c[a++];)
putchar(b-1/(/* gcc -o sig sig.c ./sig*/b/42*2-3)*42);}
signature.asc
Description: PGP signature
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger
On Tue, Jan 14, 2014 at 6:58 PM, Christian Hesse l...@eworm.de wrote: Looks good to me. Though this may result in images that do not fit font size if dpi is a lot more or less than 96 as René pointed. Anybody want to try with a fancy retina iPad or the like? ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit
Re: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger
Jason A. Donenfeld ja...@zx2c4.com on Thu, 2014/01/09 16:19:
On Thu, Jan 9, 2014 at 10:18 AM, Christian Hesse l...@eworm.de wrote:
You modified the code to make the icon match the font size, which is 10pt
by default. This is hard coded to the css file. Please note the URL
includes a size argument. Does it make sense to just retrieve a 10x10
pixel image?
Generally, 10pt is actually 13px, not 10px. I did see the size
argument of the URL, and played with changing this. But I was thinking
that often times, I make the font size slightly bigger, and requesting
the 3px larger image (16px instead of 13px) gives a little bit of
leeway for this sort of forced scaling. For my particular avatar, the
difference winds up being 13 bytes of data.
Your avatar (and mine as well) are fine when scaled down. But if there is no
avatar on gravatar you get the arcade-style pixelated faces, which look
very fuzzy when scaled by the browser...
--
main(a){char*c=/*Schoene Gruesse */B?IJj;MEH
CX:;,b;for(a/*Chris get my mail address:*/=0;b=c[a++];)
putchar(b-1/(/* gcc -o sig sig.c ./sig*/b/42*2-3)*42);}
signature.asc
Description: PGP signature
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
