Re: [Chicken-hackers] [PATCH] Don't enable debugging on Android by default
On Fri, Aug 08, 2014 at 10:29:59PM +0200, Felix Winkelmann wrote: If it's occasionally useful in general, we can put it behind a DEBUGBUILD check. Alternatively, the Ant (or whatever) infrastructure could toggle this via a XML config option or so. DEBUGBUILD sounds good. How about the attached patch? Cheers, Peter -- http://www.more-magic.net From a7beb90ae87f7738afe63358f51a87fefca2c7cb Mon Sep 17 00:00:00 2001 From: Peter Bex peter@xs4all.nl Date: Sun, 5 Oct 2014 20:46:29 +0200 Subject: [PATCH] Enable debug_mode on Android only for DEBUGBUILDs --- runtime.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime.c b/runtime.c index 5585c9b..fd3a3be 100644 --- a/runtime.c +++ b/runtime.c @@ -640,7 +640,7 @@ int CHICKEN_initialize(int heap, int stack, int symbols, void *toplevel) if(chicken_is_initialized) return 1; else chicken_is_initialized = 1; -#ifdef __ANDROID__ +#if defined(__ANDROID__) defined(DEBUGBUILD) debug_mode = 2; #endif -- 1.7.10.4 ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Don't enable debugging on Android by default
From: Peter Bex peter@xs4all.nl Subject: Re: [Chicken-hackers] [PATCH] Don't enable debugging on Android by default Date: Sun, 5 Oct 2014 20:43:16 +0200 On Fri, Aug 08, 2014 at 10:29:59PM +0200, Felix Winkelmann wrote: If it's occasionally useful in general, we can put it behind a DEBUGBUILD check. Alternatively, the Ant (or whatever) infrastructure could toggle this via a XML config option or so. DEBUGBUILD sounds good. How about the attached patch? Pushed, thanks. felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Don't enable debugging on Android by default
On Mon, Aug 04, 2014 at 07:01:03PM +0200, Felix Winkelmann wrote: From: Moritz Heidkamp moritz.heidk...@bevuta.com Subject: [Chicken-hackers] [PATCH] Don't enable debugging on Android by default Date: Mon, 04 Aug 2014 18:30:44 +0200 This was probably accidentally left in when generating the Android patch. That's mostly correct - I thought it might be handy, since the adb-log is all one has for debugging an app on android Has it been useful in practice for debugging your app? Note that I'm not interested in whether it was useful in getting CHICKEN initially running on Android (obviously that required some fiddling, and CHICKEN hackers may be expected to tweak the code a bit to debug stuff), but specifically in debugging apps. If it's occasionally useful in general, we can put it behind a DEBUGBUILD check. Alternatively, the Ant (or whatever) infrastructure could toggle this via a XML config option or so. Cheers, Peter -- http://www.more-magic.net ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Don't enable debugging on Android by default
Has it been useful in practice for debugging your app? Note that I'm not interested in whether it was useful in getting CHICKEN initially running on Android (obviously that required some fiddling, and CHICKEN hackers may be expected to tweak the code a bit to debug stuff), but specifically in debugging apps. When you develop for android, you are pretty dependent on it, I'd say. Once the thing runs, it isn't that crucial anymore. If it's occasionally useful in general, we can put it behind a DEBUGBUILD check. Alternatively, the Ant (or whatever) infrastructure could toggle this via a XML config option or so. DEBUGBUILD sounds good. felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
[Chicken-hackers] [PATCH] Don't enable debugging on Android by default
This was probably accidentally left in when generating the Android patch. -- bevuta IT GmbH - professionelle IT-Lösungen Marktstraße 10 | http://www.bevuta.com/ | HRB 62476 AG Köln 50968 Köln | Tel.: +49 221 282678-0 | Geschäftsführer: Pablo Beyen From 8d21fae15e69c65d0b3d1e721de557588f0a4dfa Mon Sep 17 00:00:00 2001 From: Moritz Heidkamp moritz.heidk...@bevuta.com Date: Mon, 4 Aug 2014 18:29:26 +0200 Subject: [PATCH] Don't enable debugging on Android by default --- runtime.c | 4 1 file changed, 4 deletions(-) diff --git a/runtime.c b/runtime.c index 1a68906..8608506 100644 --- a/runtime.c +++ b/runtime.c @@ -640,10 +640,6 @@ int CHICKEN_initialize(int heap, int stack, int symbols, void *toplevel) if(chicken_is_initialized) return 1; else chicken_is_initialized = 1; -#ifdef __ANDROID__ - debug_mode = 2; -#endif - if(debug_mode) C_dbg(C_text(debug), C_text(application startup...\n)); -- 1.9.4 ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Don't enable debugging on Android by default
From: Moritz Heidkamp moritz.heidk...@bevuta.com Subject: [Chicken-hackers] [PATCH] Don't enable debugging on Android by default Date: Mon, 04 Aug 2014 18:30:44 +0200 This was probably accidentally left in when generating the Android patch. That's mostly correct - I thought it might be handy, since the adb-log is all one has for debugging an app on android, but for production use it's probably a bit much. felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
