Re: [PATCH 1/1] Fix typo'd procedure name in "emit-import-library" declaration handling

[megane]

Evan Hanson  writes:

Thanks, pushed.

> This is intended to check for a pair of strings when this declaration is
> used in its `(MODULENAME FILENAME)' form, but we currently use `string'
> instead of `string?' to check the second item, which will always trigger
> an error ("bad argument type").

ITYM it'll never trigger an error, even if the the filname is symbol for
example.

I grepped the svn eggs repo for declaration usage, and found nothing.
This has the possibility of breaking existing wrong code. We'll see...

[PATCH 1/1] Fix typo'd procedure name in "emit-import-library" declaration handling

[Evan Hanson]

This is intended to check for a pair of strings when this declaration is
used in its `(MODULENAME FILENAME)' form, but we currently use `string'
instead of `string?' to check the second item, which will always trigger
an error ("bad argument type").
---
 core.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core.scm b/core.scm
index e548bbc0..9e5a8c62 100644
--- a/core.scm
+++ b/core.scm
@@ -1717,7 +1717,7 @@
  (cond ((symbol? il)
 (cons il (string-append (symbol->string il) 
".import.scm")) )
((and (list? il) (= 2 (length il))
- (symbol? (car il)) (string (cadr il)))
+ (symbol? (car il)) (string? (cadr il)))
 (cons (car il) (cadr il)))
(else
 (warning
-- 
2.29.3