[chromium-dev] Mac painting problems
I was informed that I may have broken mac tab contents painting in 18363. I have to leave now, so if this is causing you problems you can back me out. If somebody wants to fix it instead, I'll make you chocolate chip cookies :) Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Poting Chromium and security
On Thu, Jun 11, 2009 at 8:59 AM, Berend-Jan Weverskyli...@chromium.org wrote: All in all this means that it would be very useful to maintain a list of implementation and design differences between the various ports. I am looking for practical and efficient ways to create and maintain such a list. Ideally, it should be easy/mandatory to update the list to prevent it from ever becoming out-dated. I can start do a brain dump of the current differences between the Linux and Windows port: We have a secondary IPC system: http://code.google.com/p/chromium/wiki/LinuxSandboxIPC We have a different process model: http://code.google.com/p/chromium/wiki/LinuxZygote We will soon be using harfbuzz in the renderer to perform complex text shaping. That's all the security sensitive stuff which pops into mind. Cheers AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac painting problems
I am not a mac person but since you cleaned
up:PlatformCanvasMac::Initialize(int
width, int height, bool is_opaque, int8_t* data)
to call:
BitmapPlatformDevice::Create(NULL, width, height, is_opaque)
I have looked inside that function:
BitmapPlatformDevice::Create(CGContextRef context, int width, int height,
bool is_opaque)
And its doing:
if (!context) {
...
// Change the coordinate system to match WebCore's
CGContextTranslateCTM(context, 0, height);
CGContextScaleCTM(context, 1.0, -1.0);
CGColorSpaceRelease(color_space);
}
Whereas the previous change was:
if (!context)
return false;
// Change the coordinate system to match WebCore's
CGContextTranslateCTM(context, 0, height);
CGContextScaleCTM(context, 1.0, -1.0);
I don't have chromium installed on my mac (only win/linux) so I can't test.
I might be totally wrong.
-- Mohamed Mansour
On Sun, Jun 14, 2009 at 1:21 PM, Brett Wilson bre...@chromium.org wrote:
I was informed that I may have broken mac tab contents painting in
18363. I have to leave now, so if this is causing you problems you can
back me out.
If somebody wants to fix it instead, I'll make you chocolate chip cookies
:)
Brett
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] If you break the build, update the buildbot status
When the buildbot detects a critical failure it automatically closes the tree with a message like this: Tree is closed (Automatic: compile on Amiga Debug from 27294: elgo...@chromium.org) It's not clear from this message whether or not the mysterious el goato understands that he's broken the build. Maybe he knows and is fixing it or has scheduled a clobber (which aren't visible on the waterfall console), or maybe he doesn't know and has gone to lunch. Don't be like the mysterious el goato - if you break the build, update the status immediately so people know you're working on it, otherwise you can expect to be pinged relentlessly by people who aren't sure if you know! -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] activex_shim and urlmon
I've landed (finally) a change that takes urlmon.lib out of activex_shim.lib. If you update and build, Visual Studio won't automatically rebuild activex_shim.lib, which means it will still have the urlmon.lib symbols in it. This may lead to errors like those appended below when your build tries to link chrome.dll. You should be able to return to normal by rebuilding the activex_shim project (or, if you're feeling draconian, just rebuild everything). --SK Linking... urlmon.lib(urlmon.dll) : error LNK2005: urlmon_NULL_THUNK_DATA_DLB already defined in activex_shim.lib(urlmon.dll) urlmon.lib(urlmon.dll) : error LNK2005: urlmon_NULL_THUNK_DATA_DLA already defined in activex_shim.lib(urlmon.dll) urlmon.lib(urlmon.dll) : error LNK2005: urlmon_NULL_THUNK_DATA_DLN already defined in activex_shim.lib(urlmon.dll) Creating library C:\b\slave\chromium-dbg-builder\build\src\chrome\Debug\lib\chrome_dll.lib and object C:\b\slave\chromium-dbg-builder\build\src\chrome\Debug\lib\chrome_dll.exp C:\b\slave\chromium-dbg-builder\build\src\chrome\Debug\obj\chrome_dll\chrome.dll : fatal error LNK1169: one or more multiply defined symbols found Error executing link.exe (tool returned code: 1169) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Gmock compilation errors on VS2008SP1
C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(498) : error C2065: '_Is_swap_move' : undeclared identifier and many more like it i clobbered my build, synced --force, did revert this only started to happen in the last 24 hours or so is anyone able to compile it on their VS2008SP1 machines ? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
