[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

2009-07-03 Thread Dean McNamee
Hey Bradley,

Thanks, I can build again from the command line.  My CPU utilization
is still annoying low.  I made sure and NUM_CPUS is 4.  Compare this
to the Linux make build, which keeps my 4 cores at 100% cpu all the
way through.

Thanks
-- dean

On Sun, Jun 28, 2009 at 2:06 AM, Bradley Nelsonbradnel...@google.com wrote:
 Hi Dean,
 So I've dropped in a change that switches directories to have name like:
 (base)
 (test_shell)
 This will allow you to run things at the command line again.
 I don't find this choice particularly ascetic myself. But the options where
 limited, because the following characters cannot appear in solution folder
 names:
 / ? :  \ *| # %
 Let me know if you run into any more problems with this.
 Also definitely let me know if someone thinks of something less ugly.
 -BradN


 On Fri, Jun 19, 2009 at 3:10 AM, Dean McNamee de...@chromium.org wrote:

 This also broke building from the command line.

 I usually never open Visual Studio as an IDE.  I build on the command
 line with something like:

 devenv chrome\\chrome.sln /Build release /Project test_shell

 It looks like project names like test_shell now have complicated names
 like test_shell (webkit\tools\test_shell\test_shell), and I haven't
 been able to manage supplying those on the command line.

 Is there a way we can get back our nice project names test_shell,
 chrome, etc?

 On Fri, Jun 19, 2009 at 1:30 AM, Andrew Scherkusscher...@chromium.org
 wrote:
  Here's a quick example:
   1) Delete whole Debug directory
   2) gclient runhooks --force
   3) Set test_shell as startup project
   4) Hit F5
  Sample output of things that shouldn't be dependencies (mostly because
  they're other executables)
      sandbox (sandbox\sandbox) - Debug Win32
      chrome_dll - Debug Win32
      net_perftests - Debug Win32
      base_unittests - Debug Win32
      net_unittests - Debug Win32
      v8_shell - Debug Win32
      mini_installer - Debug Win32
      test_support_unit - Debug Win32
      test_support_ui - Debug Win32
      codesighs (third_party\codesighs\codesighs) - Debug Win32
      automated_ui_tests - Debug Win32
      memory_test - Debug Win32
      activex_test_control - Debug Win32
 
  On Thu, Jun 18, 2009 at 4:08 PM, Bradley Nelson bradnel...@google.com
  wrote:
 
  Andrew, can you give an example of something that built that shouldn't
  have for test_shell?  Maybe we have some overspecified dependencies as
  well.
 
  -BradN
 
  On Thu, Jun 18, 2009 at 3:49 PM, Andrew Scherkus
  scher...@chromium.org
  wrote:
 
  I'll see if I can repro this again before filing a bug, but similar to
  what Daniel and John reported, when I right click on test_shell and
  say
  Build it builds the minimal set required to fully build+link
  test_shell.exe
  However when I set test_shell as the start-up project and launch the
  debugger, Visual Studio warns that every other project in chrome.sln
  must be
 
  built before running (not true!).  Is there a difference in build vs. runtime dependencies?
  Andrew
 
  On Thu, Jun 18, 2009 at 3:25 PM, Steven Knight s...@chromium.org
  wrote:
 
  All--
  When you notice missing dependencies, pleased add them to the
  necessary
  .gyp file(s)!  One of the main reasons we've been trying to land all
  this
  stuff is so that tracking down all these pieces isn't single-threaded
  through one person (or two).  If you're not comfortable making the
  change
  yourself, then please file a bug so the dependency problems get
  tracked and
  fixed in an organized fashion.
  Re:  unnecessary rebuilds:  please file bugs so they don't get lost.
   Please include the target you were building, and the the
  libs/targets that
  were rebuilt unnecessarily.  You don't have to be exhaustive about
  the list,
  it's more important here that at least some information gets
  collected and
  doesn't languish on the ML or get dropped on the floor.
  I'm working on a buildbot script that will test for missing
  dependencies
  by building every target from scratch individually, and will then
  test for
  unnecessary rebuilds by rebuilding each target after no updates.
   That's
  been taking a back seat to just getting the conversion completed, but
  I've
  accelerated my work on it as we wind down to the last few targets.
          --SK
 
  On Thu, Jun 18, 2009 at 3:11 PM, John Abd-El-Malek j...@chromium.org
  wrote:
 
 
  On Thu, Jun 18, 2009 at 3:10 PM, John Abd-El-Malek
  j...@chromium.org
  wrote:
 
  Yeah it happened to me before as well, I just figured I'd complain
  now..  Note another missing dependency is on crash_service.exe
  , npapi_layout_test_plugin, and npapi_test_plugin
 
  btw just to be clear, these are missing dependencies on ui_tests.
 
 
  On Thu, Jun 18, 2009 at 3:00 PM, Jeremy Orlow jor...@google.com
  wrote:
 
  I actually had this problem _before_ this change.  Guess I should
  have brought it up, but I figured it was just something funny on
  my system.
 
  On Thu, Jun 18, 2009 at 2:21 PM, John 

[chromium-dev] F5 Debug process

2009-07-03 Thread Thiago Farina

Anyone knows how to speed up the process of debugging chromium in
Visual Studio 2008?

Everytime I click in F5 to start debugging chromium it takes a long
time to compile and build project test with him.

How can I avoid the project tests like ipc_tests,
interactive_ui_tests, perf_tests, etc, are compiled with chrome(exe)
project?
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread PhistucK
At least in Visual Studio 2005, you can right click on the solution and in
Configuration Options (or something like that), you can select what to
build and what not to build.It does speed up the compiling process by at
least half (for me). It still, generally, takes a lot of time.

☆PhistucK


On Fri, Jul 3, 2009 at 19:21, Thiago Farina thiago.far...@gmail.com wrote:


 Anyone knows how to speed up the process of debugging chromium in
 Visual Studio 2008?

 Everytime I click in F5 to start debugging chromium it takes a long
 time to compile and build project test with him.

 How can I avoid the project tests like ipc_tests,
 interactive_ui_tests, perf_tests, etc, are compiled with chrome(exe)
 project?
 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Mohamed Mansour
It depends on the machine you have. CPU power. HD etc. ... If you have
incremental build turned on /MP it will take less time to compile as well.
-- Mohamed Mansour


On Fri, Jul 3, 2009 at 12:26 PM, PhistucK phist...@gmail.com wrote:

 At least in Visual Studio 2005, you can right click on the solution and in
 Configuration Options (or something like that), you can select what to
 build and what not to build.It does speed up the compiling process by at
 least half (for me). It still, generally, takes a lot of time.

 ☆PhistucK



 On Fri, Jul 3, 2009 at 19:21, Thiago Farina thiago.far...@gmail.comwrote:


 Anyone knows how to speed up the process of debugging chromium in
 Visual Studio 2008?

 Everytime I click in F5 to start debugging chromium it takes a long
 time to compile and build project test with him.

 How can I avoid the project tests like ipc_tests,
 interactive_ui_tests, perf_tests, etc, are compiled with chrome(exe)
 project?



 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Finnur Thorarinsson
I had a similar problem on VS 2005, maybe it is the same as yours. Turned
out VS was set to build everything as opposed to just building what the
project depended on.
Not sure how to do it in VS2008, but in VS 2005, under Tools \ Options, go
to: Projects and Solutions \ Build and Run
Make sure Only build startup projects and dependencies on Run is checked.

Then (if you make sure chrome is set as the startup project) it should not
be building all those tests.

Hope that helps.

Finnur

On Fri, Jul 3, 2009 at 09:32, Mohamed Mansour m...@chromium.org wrote:

 It depends on the machine you have. CPU power. HD etc. ... If you have
 incremental build turned on /MP it will take less time to compile as well.
 -- Mohamed Mansour



 On Fri, Jul 3, 2009 at 12:26 PM, PhistucK phist...@gmail.com wrote:

 At least in Visual Studio 2005, you can right click on the solution and in
 Configuration Options (or something like that), you can select what to
 build and what not to build.It does speed up the compiling process by at
 least half (for me). It still, generally, takes a lot of time.

 ☆PhistucK



 On Fri, Jul 3, 2009 at 19:21, Thiago Farina thiago.far...@gmail.comwrote:


 Anyone knows how to speed up the process of debugging chromium in
 Visual Studio 2008?

 Everytime I click in F5 to start debugging chromium it takes a long
 time to compile and build project test with him.

 How can I avoid the project tests like ipc_tests,
 interactive_ui_tests, perf_tests, etc, are compiled with chrome(exe)
 project?






 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Peter Kasting
On Fri, Jul 3, 2009 at 9:32 AM, Mohamed Mansour m...@chromium.org wrote:

 It depends on the machine you have. CPU power. HD etc. ... If you have
 incremental build turned on /MP it will take less time to compile as well.


Note: /MP is multiprocess build, not incremental build.

PK

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread PhistucK
Where exactly do I add /MP (using Visual Basic Professional 2005)?(I know
extremely little about the whole environment..)


Thank you.

☆PhistucK


On Fri, Jul 3, 2009 at 20:08, Peter Kasting pkast...@chromium.org wrote:

 On Fri, Jul 3, 2009 at 9:32 AM, Mohamed Mansour m...@chromium.org wrote:

 It depends on the machine you have. CPU power. HD etc. ... If you have
 incremental build turned on /MP it will take less time to compile as well.


 Note: /MP is multiprocess build, not incremental build.

 PK


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Is there an option to block file downloads in Chromium?

2009-07-03 Thread Daniel Cowx

If not, where would be the most logical place to add this
functionality?
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Is there an option to block file downloads in Chromium?

2009-07-03 Thread PhistucK
Are you referring to some kind of an administrative feature that will not
allow the user to download, even if one wants to?
☆PhistucK


On Fri, Jul 3, 2009 at 20:22, Daniel Cowx daniel.c...@gmail.com wrote:


 If not, where would be the most logical place to add this
 functionality?
 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Is there an option to block file downloads in Chromium?

2009-07-03 Thread Peter Kasting
On Fri, Jul 3, 2009 at 10:22 AM, Daniel Cowx daniel.c...@gmail.com wrote:

 If not, where would be the most logical place to add this
 functionality?


No, and I Don't Know, but presumably as an extension, assuming we have an
API or proposed API that allows an extension to respond to queries like
what should the disposition of the link be.

PK

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Is there an option to block file downloads in Chromium?

2009-07-03 Thread Daniel Cowx

Yeah, it would be an administrative feature for a version of Chromium
that is being developed for Library use. The library admins don't want
users to be able to download files.

On Jul 3, 10:26 am, Peter Kasting pkast...@google.com wrote:
 On Fri, Jul 3, 2009 at 10:22 AM, Daniel Cowx daniel.c...@gmail.com wrote:
  If not, where would be the most logical place to add this
  functionality?

 No, and I Don't Know, but presumably as an extension, assuming we have an
 API or proposed API that allows an extension to respond to queries like
 what should the disposition of the link be.

 PK
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Thiago Farina

I was having exactly this problem. It this configuration now when I
click F5 (with chrome as my startup project) they build only the
project and dependencies, no more the projects tests.

Thanks for your hint, it was exactly what I was looking for to avoid
the compilation of project tests(that are not necessary for me to
debug chromium).

On Jul 3, 2:04 pm, Finnur Thorarinsson fin...@chromium.org wrote:
 I had a similar problem on VS 2005, maybe it is the same as yours. Turned
 out VS was set to build everything as opposed to just building what the
 project depended on.
 Not sure how to do it in VS2008, but in VS 2005, under Tools \ Options, go
 to: Projects and Solutions \ Build and Run
 Make sure Only build startup projects and dependencies on Run is checked.

 Then (if you make sure chrome is set as the startup project) it should not
 be building all those tests.

 Hope that helps.

 Finnur



 On Fri, Jul 3, 2009 at 09:32, Mohamed Mansour m...@chromium.org wrote:
  It depends on the machine you have. CPU power. HD etc. ... If you have
  incremental build turned on /MP it will take less time to compile as well.
  -- Mohamed Mansour

  On Fri, Jul 3, 2009 at 12:26 PM, PhistucK phist...@gmail.com wrote:

  At least in Visual Studio 2005, you can right click on the solution and in
  Configuration Options (or something like that), you can select what to
  build and what not to build.It does speed up the compiling process by at
  least half (for me). It still, generally, takes a lot of time.

  ☆PhistucK

  On Fri, Jul 3, 2009 at 19:21, Thiago Farina thiago.far...@gmail.comwrote:

  Anyone knows how to speed up the process of debugging chromium in
  Visual Studio 2008?

  Everytime I click in F5 to start debugging chromium it takes a long
  time to compile and build project test with him.

  How can I avoid the project tests like ipc_tests,
  interactive_ui_tests, perf_tests, etc, are compiled with chrome(exe)
  project?
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Is there an option to block file downloads in Chromium?

2009-07-03 Thread Marc-Antoine Ruel
Since you're building your own fork, you could simply disable the code by
adding the #ifdef at the right places. You could use git to more easily
manage the merge tracking.
You could also setup a continuous build but note that our buildbot code
doesn't support git at the moment.
http://sites.google.com/a/chromium.org/dev/developers/testing/chromium-build-infrastructure

M-A

On Fri, Jul 3, 2009 at 1:33 PM, Daniel Cowx daniel.c...@gmail.com wrote:


 Yeah, it would be an administrative feature for a version of Chromium
 that is being developed for Library use. The library admins don't want
 users to be able to download files.

 On Jul 3, 10:26 am, Peter Kasting pkast...@google.com wrote:
  On Fri, Jul 3, 2009 at 10:22 AM, Daniel Cowx daniel.c...@gmail.com
 wrote:
   If not, where would be the most logical place to add this
   functionality?
 
  No, and I Don't Know, but presumably as an extension, assuming we have
 an
  API or proposed API that allows an extension to respond to queries like
  what should the disposition of the link be.
 
  PK
 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Finnur Thorarinsson
Glad to hear its fixed.-F

On Fri, Jul 3, 2009 at 10:40, Thiago Farina thiago.far...@gmail.com wrote:


 I was having exactly this problem. With this configuration, now when
 I
 click F5 (with chrome as my startup project) VS build only the
 project and dependencies, no more the projects tests.

 Thanks for your hint, it was exactly what I was looking for to avoid
 the compilation of project tests(that are not necessary for me to
 debug chromium).

 On Jul 3, 2:04 pm, Finnur Thorarinsson fin...@chromium.org wrote:
  I had a similar problem on VS 2005, maybe it is the same as yours. Turned
  out VS was set to build everything as opposed to just building what the
  project depended on.
  Not sure how to do it in VS2008, but in VS 2005, under Tools \ Options,
 go
  to: Projects and Solutions \ Build and Run
  Make sure Only build startup projects and dependencies on Run is
 checked.
 
  Then (if you make sure chrome is set as the startup project) it should
 not
  be building all those tests.
 
  Hope that helps.
 
  Finnur
 
 
 
  On Fri, Jul 3, 2009 at 09:32, Mohamed Mansour m...@chromium.org wrote:
   It depends on the machine you have. CPU power. HD etc. ... If you have
   incremental build turned on /MP it will take less time to compile as
 well.
   -- Mohamed Mansour
 
   On Fri, Jul 3, 2009 at 12:26 PM, PhistucK phist...@gmail.com wrote:
 
   At least in Visual Studio 2005, you can right click on the solution
 and in
   Configuration Options (or something like that), you can select what
 to
   build and what not to build.It does speed up the compiling process by
 at
   least half (for me). It still, generally, takes a lot of time.
 
   ☆PhistucK
 
   On Fri, Jul 3, 2009 at 19:21, Thiago Farina thiago.far...@gmail.com
 wrote:
 
   Anyone knows how to speed up the process of debugging chromium in
   Visual Studio 2008?
 
   Everytime I click in F5 to start debugging chromium it takes a long
   time to compile and build project test with him.
 
   How can I avoid the project tests like ipc_tests,
   interactive_ui_tests, perf_tests, etc, are compiled with chrome(exe)
   project?
 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Jeremy Orlow
Actually, there are a couple spots to edit:
http://codereview.chromium.org/155057  -- maybe more

Is it time to make this default yet?  It speeds up the build considerably
and almost everyone uses it now.  It does make things a bit less
deterministic, but you can always clobber build if something gets into a bad
state.  And it's _much_ faster.

J

On Fri, Jul 3, 2009 at 10:22 AM, Tommi to...@chromium.org wrote:

 Don't know if this is what most do but I ended up adding it to
 build\common.gpyi (line 471 in my case)
 ...
   'VCCLCompilerTool': {
 *'AdditionalOptions': '/MP',*
 'MinimalRebuild': 'false',
 'ExceptionHandling': '0',
 'BufferSecurityCheck': 'true',
 'EnableFunctionLevelLinking': 'true',
 'RuntimeTypeInfo': 'false',
 'WarningLevel': '3',
 'WarnAsError': 'true',
 'DebugInformationFormat': '3',
   },
 ...

 If that's not what everyone else is doing, please let me know.

 On Fri, Jul 3, 2009 at 1:11 PM, PhistucK phist...@gmail.com wrote:

 Where exactly do I add /MP (using Visual Basic Professional 2005)?(I
 know extremely little about the whole environment..)


 Thank you.

 ☆PhistucK



 On Fri, Jul 3, 2009 at 20:08, Peter Kasting pkast...@chromium.orgwrote:

 On Fri, Jul 3, 2009 at 9:32 AM, Mohamed Mansour m...@chromium.orgwrote:

 It depends on the machine you have. CPU power. HD etc. ... If you have
 incremental build turned on /MP it will take less time to compile as well.


 Note: /MP is multiprocess build, not incremental build.

 PK






 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: [Windows CRichEditCtrl] question on parenthesis handling in right-to-Left CRichEditCtrl

2009-07-03 Thread Peter Kasting
On Thu, Jul 2, 2009 at 11:17 AM, Xiaomei Ji x...@chromium.org wrote:

 2. If CRichEditCtrl does not support this out of the box, we can do the
 dirty and hard work to make it work. It wont be easy since we need to handle
 all kinds of opening/closing punctuations, and we need back-trace to change
 the punctuation depending on the surrounding characters (for example, after
 abc, U+0028 will be displayed as ), but if we type in d, ) need to
 be changed to (.), and we might need some states-saving as well. I think
 the performance in textfield and omnibox will be degraded a lot by those. Is
 there any better way?


The better way is use a WebKit textfield instead of a native control to
provide the UI here.

This was something I had hoped to prototype in Q2 but didn't get to.  Help
welcomed.  Talk with Darin (Fisher) if you're interested.

PK

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Tommi
thanks jeremy - applied that cl and got my cpus pegged even more ;)

On Fri, Jul 3, 2009 at 2:10 PM, Jeremy Orlow jor...@chromium.org wrote:

 Actually, there are a couple spots to edit:
 http://codereview.chromium.org/155057  -- maybe more

 Is it time to make this default yet?  It speeds up the build considerably
 and almost everyone uses it now.  It does make things a bit less
 deterministic, but you can always clobber build if something gets into a bad
 state.  And it's _much_ faster.

 J


 On Fri, Jul 3, 2009 at 10:22 AM, Tommi to...@chromium.org wrote:

 Don't know if this is what most do but I ended up adding it to
 build\common.gpyi (line 471 in my case)
 ...
   'VCCLCompilerTool': {
 *'AdditionalOptions': '/MP',*
 'MinimalRebuild': 'false',
 'ExceptionHandling': '0',
 'BufferSecurityCheck': 'true',
 'EnableFunctionLevelLinking': 'true',
 'RuntimeTypeInfo': 'false',
 'WarningLevel': '3',
 'WarnAsError': 'true',
 'DebugInformationFormat': '3',
   },
 ...

 If that's not what everyone else is doing, please let me know.

 On Fri, Jul 3, 2009 at 1:11 PM, PhistucK phist...@gmail.com wrote:

 Where exactly do I add /MP (using Visual Basic Professional 2005)? (I
 know extremely little about the whole environment..)


 Thank you.

 ☆PhistucK



 On Fri, Jul 3, 2009 at 20:08, Peter Kasting pkast...@chromium.orgwrote:

 On Fri, Jul 3, 2009 at 9:32 AM, Mohamed Mansour m...@chromium.orgwrote:

 It depends on the machine you have. CPU power. HD etc. ... If you have
 incremental build turned on /MP it will take less time to compile as well.


 Note: /MP is multiprocess build, not incremental build.

 PK






 



--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Full pass of acid3.

2009-07-03 Thread Dimitri Glazkov

As of r19910 (and with --enable-remote-fonts flag), we now fully pass
the acid3 test. Thanks to brettw for his patience and to pkasting for
guilting me into fixing this the right way.

:DG

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Fwd: [webkit-dev] [V8] It's time for V8Proxy to come to Jesus

2009-07-03 Thread Jeremy Orlow
FYI because some people might not be on webkit-dev.

BUT if this seems even remotely interesting to you, get on that list!  (They
recently split it into webkit-dev and webkit-help, so signal to noise should
get better than it was before...in case that was a concern of yours.)

J

-- Forwarded message --
From: Adam Barth aba...@webkit.org
Date: Fri, Jul 3, 2009 at 12:23 PM
Subject: [webkit-dev] [V8] It's time for V8Proxy to come to Jesus
To: webkit-...@lists.webkit.org
Cc: Mike Belshe mbel...@google.com


If you're uninterested in the V8 bindings, you can skip this email.

Clocking in at 3255 lines (plus a 682-line header file), V8Proxy is
out of control.  Historically a bridge from the V8 bindings to the V8
engine, V8Proxy is responsible for a number of tasks including:

1) Creating new contexts
2) Implementing security checks
3) Supervising garbage collection
4) Caching event listeners
5) Executing scripts
6) Converting between frames, contexts, and global objects
7) Manging DOM wrappers
8) etc, etc, etc

I propose we separate these concerns into a number of distinct classes
that have clear, understandable purposes before things get worse.

Please let me know if you have any in-progress patches to V8Proxy.
I'd like to lock that file sometime next week while I rip it apart and
put it back together.

Thanks,
Adam

P.S., FrameLoader: you've escaped for now, but don't think I'm not watching
you.
___
webkit-dev mailing list
webkit-...@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Mohamed Mansour
Would be nice if we can make multiprocess build (/MP) integrated with gyp.
Don't know how that could be done.
-- Mohamed Mansour


On Fri, Jul 3, 2009 at 2:10 PM, Jeremy Orlow jor...@chromium.org wrote:

 Actually, there are a couple spots to edit:
 http://codereview.chromium.org/155057  -- maybe more

 Is it time to make this default yet?  It speeds up the build considerably
 and almost everyone uses it now.  It does make things a bit less
 deterministic, but you can always clobber build if something gets into a bad
 state.  And it's _much_ faster.

 J


 On Fri, Jul 3, 2009 at 10:22 AM, Tommi to...@chromium.org wrote:

 Don't know if this is what most do but I ended up adding it to
 build\common.gpyi (line 471 in my case)
 ...
   'VCCLCompilerTool': {
 *'AdditionalOptions': '/MP',*
 'MinimalRebuild': 'false',
 'ExceptionHandling': '0',
 'BufferSecurityCheck': 'true',
 'EnableFunctionLevelLinking': 'true',
 'RuntimeTypeInfo': 'false',
 'WarningLevel': '3',
 'WarnAsError': 'true',
 'DebugInformationFormat': '3',
   },
 ...

 If that's not what everyone else is doing, please let me know.

 On Fri, Jul 3, 2009 at 1:11 PM, PhistucK phist...@gmail.com wrote:

 Where exactly do I add /MP (using Visual Basic Professional 2005)? (I
 know extremely little about the whole environment..)


 Thank you.

 ☆PhistucK



 On Fri, Jul 3, 2009 at 20:08, Peter Kasting pkast...@chromium.orgwrote:

 On Fri, Jul 3, 2009 at 9:32 AM, Mohamed Mansour m...@chromium.orgwrote:

 It depends on the machine you have. CPU power. HD etc. ... If you have
 incremental build turned on /MP it will take less time to compile as well.


 Note: /MP is multiprocess build, not incremental build.

 PK






 



--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Full pass of acid3.

2009-07-03 Thread Peter Kasting
Woot!

What's --enable-remote-fonts, and will it be on by default soon?

Thanks dglazkov!

PK

On Jul 3, 2009 12:13 PM, Dimitri Glazkov dglaz...@google.com wrote:


As of r19910 (and with --enable-remote-fonts flag), we now fully pass
the acid3 test. Thanks to brettw for his patience and to pkasting for
guilting me into fixing this the right way.

:DG


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Joy of generated files

2009-07-03 Thread Marc-Antoine Ruel
* PUBLIC SERVICE ANNOUNCEMENT *

As long as the generated project files will be in src/ and not in the
$(outdir) http://code.google.com/p/chromium/issues/detail?id=15924, PLEASE
fix the svn:ignore everytime generated project files are added or removed.

For examples, see 19914 and 19915.

Thanks,

M-A

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] About hunspell

2009-07-03 Thread Dmitry.Skiba

Recently I was playing with hunspell and got very displeased with its
code (which claims to be cpp, but in fact 'classified' c). I even
started to think about rewriting it in, you know, correct cpp. Then
I realized that Chrome also uses hunspell and went to the repository.
I saw a very useful patch to HashMgr, which in fact alters its
behaviour pretty much. And at the same time all old code were left as
is.

So I have a question: why? Why didn't you just remove all that old and
unused code? It's unlikely that your patches will be merged into
hunspell.

I'm asking because, as I said, I'm thinking of rewriting (well,
'correcting') hunspell and want to know in advance that someone else
is interested.

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: cygwin dependence missing?

2009-07-03 Thread Dirk Pranke

Debugging this a bit more ... it seems to be some sort of XP vs. Vista
thing. If I run wdiff exp.txt act.txt in a bash shell or a command
prompt on Vista, it works. On XP, it works in a bash shell, but in a
command prompt, I get the /tmp error. It looks like XP is expecting
to find the cygwin environment, but isn't, and it is finding it on
Vista. I don't see anything obvious in my environment that is
different.

I am running Cygwin 1.5.25, though. At this point, my knowledge of
cygwin falters, so I'm out of ideas. Anyone else?

-- Dirk

On Thu, Jul 2, 2009 at 6:08 PM, Dirk Prankedpra...@google.com wrote:
 Oh, I should add that if I run the same binaries under Vista,
 everything works fine (no error from wdiff).

 -- Dirk

 On Thu, Jul 2, 2009 at 6:07 PM, Dirk Prankedpra...@google.com wrote:
 Hi Marc-Antoine,

 I am getting the same wdiff: /tmp/t101c.0: No such file or directory
 errors ... I'm running an XP VM on a Vista 64 host, but I've tried
 both local files (running the tests on a virtual drive) as well as a
 network share to the host VM. I've tried the /etc/fstab, the
 CYGWIN=nontsec, and the changing of directory ACLs, all to no avail.
 Any other ideas?

 -- Dirk

 On Thu, Jul 2, 2009 at 5:53 PM, Marc-Antoine Ruelmar...@chromium.org wrote:
 2009/7/1 Bradley Nelson bradnel...@google.com

 gyp should be setting CYGWIN=nontsec for actions and rules (unless you use
 the msvs_use_cygwin_shell:0).

 FYI, cygwin 1.7 doesn't honour CYGWIN=NONTSEC anymore. You need to modify
 /etc/fstab, e.g. c:\cygwin\etc\fstab to add something line:
 none /cygdrive cygdrive binary,posix=0,user,noacl 0 0
 to have the same effect.
 M-A
 




--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Issue 4576: Home/End and PageUp/PageDn buttons do not do anything in drop down lists

2009-07-03 Thread Vamsi Kalyan
Hi,

To fix issue #4576 how to get the page size? Fixing where would be
considered as the best?

Below I elaborate the issue.

In WebCore, HTML Select element is rendered using either RenderMenuList or
RenderListBox. RenderMenuList further uses PopupListBox as a popup. When
popup is visible, PageUp/PageDn are working fine. Issue comes only when
popup is closed. When popup is not visible, SelectElement.cpp present in dom
folder of WebCore handles keyboard events and notifies its corresponding
renderer.

So the place where PageUp/PageDn events are handled knows only renderer.
Only renderer can tell the number of visible lines considering current zoom
level etc. Is it a good idea to ask renderer from SelectElement.cpp to
return number of visible items?

In case of RenderMenuList, it has to ask PopupListBox under platform
chromium, and in the else part of this platform check we need to write code
that will get called by rest of Webkit users. But is it fine if we decide
what is correct for other users of Webkit?

In case of RenderListBox, the method, numVisibleItems() that can return
number of visible items is a private method. Changing it to public lets
SelectElement.cpp to know the page size, but is it a good thing to do?

Please suggest.

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Sample Extension failing to install.

2009-07-03 Thread Hundasupa

When attempting to install the Google Reader extension, Chromium gives
this error. This is on a Chromium build 3.0.192.0 (19907) on a Windows
7 OS 7100 build. Install breaks also after Save Link As downloading
it.
Any ideas?


---Extension error---
Could not install extension from 'C:\Users\Doddi\Documents\Downloads
\subscribe_page_action.crx'. Required value 'page_actions[0].icons' is
missing or invalid.
---OK--

The Following link show's the error on a Save Link As
downloaded .crx
http://imgur.com/kuJLyl.png

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: cygwin dependence missing?

2009-07-03 Thread Dirk Pranke

Hi Marc-Antoine,

I am getting the same wdiff: /tmp/t101c.0: No such file or directory
errors ... I'm running an XP VM on a Vista 64 host, but I've tried
both local files (running the tests on a virtual drive) as well as a
network share to the host VM. I've tried the /etc/fstab, the
CYGWIN=nontsec, and the changing of directory ACLs, all to no avail.
Any other ideas?

-- Dirk

On Thu, Jul 2, 2009 at 5:53 PM, Marc-Antoine Ruelmar...@chromium.org wrote:
 2009/7/1 Bradley Nelson bradnel...@google.com

 gyp should be setting CYGWIN=nontsec for actions and rules (unless you use
 the msvs_use_cygwin_shell:0).

 FYI, cygwin 1.7 doesn't honour CYGWIN=NONTSEC anymore. You need to modify
 /etc/fstab, e.g. c:\cygwin\etc\fstab to add something line:
 none /cygdrive cygdrive binary,posix=0,user,noacl 0 0
 to have the same effect.
 M-A
 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: About hunspell

2009-07-03 Thread Brett Wilson

On Fri, Jul 3, 2009 at 12:00 AM, Dmitry.Skibadmitry.sk...@gmail.com wrote:

 Recently I was playing with hunspell and got very displeased with its
 code (which claims to be cpp, but in fact 'classified' c). I even
 started to think about rewriting it in, you know, correct cpp. Then
 I realized that Chrome also uses hunspell and went to the repository.
 I saw a very useful patch to HashMgr, which in fact alters its
 behaviour pretty much. And at the same time all old code were left as
 is.

Glad you like it!

 So I have a question: why? Why didn't you just remove all that old and
 unused code? It's unlikely that your patches will be merged into
 hunspell.

We do this so we can tell what we changed so it's easier to merge to
future versions of Hunspell. Of course it should be possible to do
with SVN logs only, but it makes it a little easier. I believe there
are some new capabilities we would like to take advantage of in the
newer ones.

Brett

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---