[chromium-dev] Updated UsingGit wiki for WebKit developers
I added an optional setup step and a link to WebKit's using git wiki for those of us who do side-by-side development of chromium and webkit. Let me know if I missed something. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Updated UsingGit wiki for WebKit developers
Thanks! I rearranged it a bit because the checkout instructions were starting to get intimidating. On Tue, Sep 15, 2009 at 1:59 PM, Yaar Schnitman y...@chromium.org wrote: I added an optional setup step and a link to WebKit's using git wiki for those of us who do side-by-side development of chromium and webkit. Let me know if I missed something. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Layout tests can now be run on both XP and Vista
On Tue, Sep 15, 2009 at 4:26 AM, Dirk Pranke dpra...@chromium.org wrote: I have just landed a patch that enables us to run layout tests on Vista as well as XP. Thanks for doing this! Needing to run the tests on a 32bit XP machine sucks. I don't think we can call running the tests on Vista supported until the tooling people rely on also supports it. Otherwise, we are causing more burden than benefit (e.g. we'll essentially be requiring everyone to have both Vista and XP machines). Things that come to mind: - Vista bot on the primary (non-fyi) waterfall - Vista layout test try server - Vista canary bot for tip of tree webkit - Rebaseline tool support We'll also need the same before we consider Win7 supported. I'm OK with adding Win7 baselines and a Win7 fyi bot before that, but the team should not be expected to support it until the tools do. It's not clear to me what our desired end result should be. Do we need a full set of bots for WebKit Vista and WebKit Win7? Is just having release bots for each enough? The waterfall is already very crowded. My first intuition is that we should have release and debug bots for the latest supported platform (which will soon be Vista) and just release bots for other platforms (definitely XP, what about Win7?). Also, the checkin involved updating 700 images, so I didn't have anyone but me review them. I'm confused by this. Are you saying you didn't get this code reviewed? If so, why not? Can you provide a link to the checkin so it can get reviewed? Test rebaselines should not get checked in without review. Simple, mistakes are made all the time. Ojan --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Updated UsingGit wiki for WebKit developers
Evan just did that. Thanks guys! On Tue, Sep 15, 2009 at 2:08 PM, Jeremy Moskovich jer...@chromium.orgwrote: Major kudos for helping to improve our documentation!!! Evan [I think] actually created a script in 'tools/sync-webkit-git.py' which has support for syncing the right version of WebKit (the one gclient expects) via git into our source tree. So I think referring to that would provide better documentation. Best regards, Jeremy On Tue, Sep 15, 2009 at 1:59 PM, Yaar Schnitman y...@chromium.org wrote: I added an optional setup step and a link to WebKit's using git wiki for those of us who do side-by-side development of chromium and webkit. Let me know if I missed something. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Layout tests can now be run on both XP and Vista
On Tue, Sep 15, 2009 at 2:15 PM, Ojan Vafai o...@chromium.org wrote: On Tue, Sep 15, 2009 at 4:26 AM, Dirk Pranke dpra...@chromium.org wrote: I have just landed a patch that enables us to run layout tests on Vista as well as XP. Thanks for doing this! Needing to run the tests on a 32bit XP machine sucks. I don't think we can call running the tests on Vista supported until the tooling people rely on also supports it. Otherwise, we are causing more burden than benefit (e.g. we'll essentially be requiring everyone to have both Vista and XP machines). Things that come to mind: Vista bot on the primary (non-fyi) waterfall Vista layout test try server Vista canary bot for tip of tree webkit Rebaseline tool support Well, practically, there's very little difference between XP and Vista (about 10 baselines). Victor is updating the rebaselining tool to properly support Vista, and we need to get a release mode bot as well. While I agree that it would be good to have a layout test try server on vista and a canary bot, we didn't have those until very recently for XP, either :) I think it's a more general issue that we should discuss how we want to divide our build machines between XP, Vista, and, soon, Win 7 (as you say below). Just doubling or tripling the number of machines seems like it has minimal ROI. On the other hand, flipping the machines to 64-bit Vista may speed them up substantially ... We'll also need the same before we consider Win7 supported. I'm OK with adding Win7 baselines and a Win7 fyi bot before that, but the team should not be expected to support it until the tools do. It's not clear to me what our desired end result should be. Do we need a full set of bots for WebKit Vista and WebKit Win7? Is just having release bots for each enough? The waterfall is already very crowded. My first intuition is that we should have release and debug bots for the latest supported platform (which will soon be Vista) and just release bots for other platforms (definitely XP, what about Win7?). Also, the checkin involved updating 700 images, so I didn't have anyone but me review them. I'm confused by this. Are you saying you didn't get this code reviewed? If so, why not? Can you provide a link to the checkin so it can get reviewed? The code that I changed did get reviewed, but only I reviewed the images themselves. I did this after discussing the pros and cons with Darin yesterday. I'm not sure that there's a lot of value in two people staring at the sets of images. The link to the checkin is here: http://src.chromium.org/viewvc/chrome?view=revrevision=26204 . I can also probably pull you a couple of tarballs of the chromium-win directory pre- and post- checkin if you're volunteering to review them after the fact :) Test rebaselines should not get checked in without review. Simple, mistakes are made all the time. Generally speaking, I agree. In this case, the changes were so repetitive in nature it was pretty easy to be sure that things were okay. -- Dirk --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Layout tests can now be run on both XP and Vista
On Tue, Sep 15, 2009 at 2:24 PM, Dirk Pranke dpra...@chromium.org wrote: Well, practically, there's very little difference between XP and Vista (about 10 baselines). I see. Looking at your rebaseline checkin, it looks like it's entirely complex font tests as well. I think given that, it will be very rare that we'll need to deal with XP rebaselines, so the current state of the world is probably fine. I think it's a more general issue that we should discuss how we want to divide our build machines between XP, Vista, and, soon, Win 7 (as you say below). Just doubling or tripling the number of machines seems like it has minimal ROI. On the other hand, flipping the machines to 64-bit Vista may speed them up substantially ... I agree that this is the primary issue to address. Changing to 64 bit machines should considerably help with cycle time if the machines have a lot of RAM and 2 cores. Nicolas, Marc-Antoine, do you have opinions on this? Do you know if we'd be able to get Vista or Win7 machines with more RAM/CPUs? Also, what do you think of the idea of having only Release bots for XP/Win7 and having both Release and Debug bots for Vista? The code that I changed did get reviewed, but only I reviewed the images themselves. I did this after discussing the pros and cons with Darin yesterday. I'm not sure that there's a lot of value in two people staring at the sets of images. With these large rebaseline changes it's valuable just to get a sanity check on the images from someone else. In practice, I've seen a number of cases where the code reviewer did actually have substantive feedback. Ojan --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Add Jank to appropriate bugs
Tomorrow afternoon a couple of us will be triaging all bugs with the Jank label. Jankiness is sluggishness in the UI, so things like slow startup or shutdown, tabs taking a while to paint or to close, keyboard accelerators and button clicks being unresponsive, and other similar Chrome doesn't do what I tell it to, when I tell it to bugs are all Jank. In preparation for this triage, please add this label to applicable bugs you've filed or are following. If you know bugs that should have this added but don't have the ability to change them yourself, send me an email with the bug numbers and I'll take a look. This will ensure we don't miss any issues in our triage. Thanks, PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Forcing the common.gypi include
FYI: As of revision 26302 ( http://src.chromium.org/viewvc/chrome?view=revrevision=26302), gyp_chromium automatically enforces the inclusion of src/build/common.gypi for all chromium-related gyp files. To avoid conflicts, *all explicit* inclusions of src/build/common.gypi have been *removed*. Its possible that I missed something, and I apologize in advance if you encounter build problems in any of the chromium sub-projects. Please reach out to me if you need any help. -Yaar --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Forcing the common.gypi include
Thanks for the heads up. As it happens, I think this will conflict with the sync deps, which I landed in the last hour. I'll try to get this sorted out promptly. - nick On Tue, Sep 15, 2009 at 5:12 PM, Yaar Schnitman y...@chromium.org wrote: FYI: As of revision 26302 ( http://src.chromium.org/viewvc/chrome?view=revrevision=26302), gyp_chromium automatically enforces the inclusion of src/build/common.gypi for all chromium-related gyp files. To avoid conflicts, *all explicit*inclusions of src/build/common.gypi have been *removed*. Its possible that I missed something, and I apologize in advance if you encounter build problems in any of the chromium sub-projects. Please reach out to me if you need any help. -Yaar --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Layout tests can now be run on both XP and Vista
Hi Dirk, Thank you so much for your great work! By the way, I have been using XP Mode of Windows 7 (*1) to run layout tests since I changed my development PC to Windows 7. (It's not so fast, but it's OK.) Does this Win7 baselines mean we don't need to use XP Mode? (I assume yes.) (*1) http://www.microsoft.com/windows/virtual-pc/ Sorry for my stupid question in advance. Regards, Hironori Bono E-mail: hb...@chromium.org On Tue, Sep 15, 2009 at 8:26 PM, Dirk Pranke dpra...@chromium.org wrote: Hi all, I have just landed a patch that enables us to run layout tests on Vista as well as XP. In theory, you should continue to use the tools just as you have in the past, and everything will work transparently. In practice, I may have screwed up something, so if you notice problems please let me know. One important change is that we now have a few XP-specific baselines in webkit/data/layout_tests/platform/chromium-win-xp (mostly in the way we handle various international characters and font differences between XP and Vista). We do not have any Vista-specific baselines (although one could argue that if there is a baseline in chromium-win and a baseline in chromium-win-xp then the chromium-win one is Vista-specific). We will be following the WebKit convention that the generic platform directory represents the most recent version of the platform (meaning that until Win 7 is released, all Vista baselines go in chromium-win. When Win 7 is released, Vista-specific baselines will go in chromium-win-vista). In practice, this means you might need to be careful about where your new baselines end up when using the rebaselining tool. You should make sure they end up in chromium-win unless you are sure they are XP-specific (in which case you will be responsible for landing baselines for both XP and Vista). If you have any questions about this, or run into problems, please let me know ASAP. One last thing for those who might look at this stuff in detail - test_shell has been changed to use a generic theme for rendering form controls, scroll bars, and other native widgets, in order to not have any differences from the different themes on the different versions of Windows. If you are wondering why the scroll bars and other controls in the baselines look really odd, that's why. Also, the checkin involved updating 700 images, so I didn't have anyone but me review them. Let me know if you see anything that doesn't look right :) Also, we will probably be landing Win 7 baselines Real Soon Now, since adding them is a very small additional amount of work on top of the stuff I just landed. Cheers, -- Dirk --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Forcing the common.gypi include
This probably obsoletes a variety of build instructions we have on the wiki (all of my build scripts broke, in part because gyp_chromium eats all the flags you give it). If you see obsolete docs somewhere, please be bold[1] and fix it or bring it to my attention so I can fix it. [1] http://en.wikipedia.org/wiki/Be_bold_in_editing_articles On Tue, Sep 15, 2009 at 5:12 PM, Yaar Schnitman y...@chromium.org wrote: FYI: As of revision 26302 (http://src.chromium.org/viewvc/chrome?view=revrevision=26302), gyp_chromium automatically enforces the inclusion of src/build/common.gypi for all chromium-related gyp files. To avoid conflicts, all explicit inclusions of src/build/common.gypi have been removed. Its possible that I missed something, and I apologize in advance if you encounter build problems in any of the chromium sub-projects. Please reach out to me if you need any help. -Yaar --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Forcing the common.gypi include
Sorry, but I forgot to mention that we moved gyp_chromium from src/tools/gyp to its rightful place at src/build. If any other tools other than DEPS use it, update those tools to the correct location. On Tue, Sep 15, 2009 at 6:19 PM, Evan Martin e...@chromium.org wrote: This probably obsoletes a variety of build instructions we have on the wiki (all of my build scripts broke, in part because gyp_chromium eats all the flags you give it). If you see obsolete docs somewhere, please be bold[1] and fix it or bring it to my attention so I can fix it. [1] http://en.wikipedia.org/wiki/Be_bold_in_editing_articles On Tue, Sep 15, 2009 at 5:12 PM, Yaar Schnitman y...@chromium.org wrote: FYI: As of revision 26302 (http://src.chromium.org/viewvc/chrome?view=revrevision=26302), gyp_chromium automatically enforces the inclusion of src/build/common.gypi for all chromium-related gyp files. To avoid conflicts, all explicit inclusions of src/build/common.gypi have been removed. Its possible that I missed something, and I apologize in advance if you encounter build problems in any of the chromium sub-projects. Please reach out to me if you need any help. -Yaar --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Layout tests can now be run on both XP and Vista
Hi Hironori, That's not a stupid question at all. I haven't actually tried using XP mode, or Win 7 at all yet. I will be installing Win 7 as soon as I can get my hands on a copy, and then we should get some Win 7 baselines. Once we have those, and can get some Win 7 build bots configured, then you should be able to stop using XP mode. I will send out more notes to the list as we get closer to this. -- Dirk 2009/9/15 Hironori Bono (坊野 博典) hb...@chromium.org: Hi Dirk, Thank you so much for your great work! By the way, I have been using XP Mode of Windows 7 (*1) to run layout tests since I changed my development PC to Windows 7. (It's not so fast, but it's OK.) Does this Win7 baselines mean we don't need to use XP Mode? (I assume yes.) (*1) http://www.microsoft.com/windows/virtual-pc/ Sorry for my stupid question in advance. Regards, Hironori Bono E-mail: hb...@chromium.org On Tue, Sep 15, 2009 at 8:26 PM, Dirk Pranke dpra...@chromium.org wrote: Hi all, I have just landed a patch that enables us to run layout tests on Vista as well as XP. In theory, you should continue to use the tools just as you have in the past, and everything will work transparently. In practice, I may have screwed up something, so if you notice problems please let me know. One important change is that we now have a few XP-specific baselines in webkit/data/layout_tests/platform/chromium-win-xp (mostly in the way we handle various international characters and font differences between XP and Vista). We do not have any Vista-specific baselines (although one could argue that if there is a baseline in chromium-win and a baseline in chromium-win-xp then the chromium-win one is Vista-specific). We will be following the WebKit convention that the generic platform directory represents the most recent version of the platform (meaning that until Win 7 is released, all Vista baselines go in chromium-win. When Win 7 is released, Vista-specific baselines will go in chromium-win-vista). In practice, this means you might need to be careful about where your new baselines end up when using the rebaselining tool. You should make sure they end up in chromium-win unless you are sure they are XP-specific (in which case you will be responsible for landing baselines for both XP and Vista). If you have any questions about this, or run into problems, please let me know ASAP. One last thing for those who might look at this stuff in detail - test_shell has been changed to use a generic theme for rendering form controls, scroll bars, and other native widgets, in order to not have any differences from the different themes on the different versions of Windows. If you are wondering why the scroll bars and other controls in the baselines look really odd, that's why. Also, the checkin involved updating 700 images, so I didn't have anyone but me review them. Let me know if you see anything that doesn't look right :) Also, we will probably be landing Win 7 baselines Real Soon Now, since adding them is a very small additional amount of work on top of the stuff I just landed. Cheers, -- Dirk --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Need help on how to send data from RenderView to a custom DOMUI instantly
Hi all, I am having trouble trying to figure out how I could replace the contents of a specific WebFrame while I am in RenderView with a custom DOMUI page that I have created. Here is a scenario: 1. User visits http://www.google.com 2. User waits till page is done loading 3. User selects Options Print Preview 4. The current page will be replaced with a custom PrintPreview DOMUI page (print:http://www.google.com) where I would be passing some Data such as a vector of bytes (image) from RenderView to PrintPreviewDOMUI I have created the DOMUI page and made sure it works, and created the bitmap and encoded it with JPEGEncoder, but I am clueless on how the connection would be from RenderView to DOMUI. Any assistance is appreciated. The reason why I want to replace the current contents is because print preview depends on what is exactly visible at that time. Unless there is a better way. Thanks in advance! - Mohamed Mansour --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Need help on how to send data from RenderView to a custom DOMUI instantly
On Tue, Sep 15, 2009 at 7:31 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Hi all, I am having trouble trying to figure out how I could replace the contents of a specific WebFrame while I am in RenderView with a custom DOMUI page that I have created. Here is a scenario: User visits http://www.google.com User waits till page is done loading User selects Options Print Preview The current page will be replaced with a custom PrintPreview DOMUI page (print:http://www.google.com) where I would be passing some Data such as a vector of bytes (image) from RenderView to PrintPreviewDOMUI I have created the DOMUI page and made sure it works, and created the bitmap and encoded it with JPEGEncoder, but I am clueless on how the connection would be from RenderView to DOMUI. Any assistance is appreciated. The reason why I want to replace the current contents is because print preview depends on what is exactly visible at that time. Unless there is a better way. Thanks in advance! Is the code you're writing in C++ or JS? Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Need help on how to send data from RenderView to a custom DOMUI instantly
The UI is going to be in JavaScript with callbacks from the DOMUI page same as NTP, Downloads, History, etc... Therefore in render_view.cc, I need to replace the WebFrame with the DOMUI (I think). I don't want to introduce my own set of methods that exposes this, that is why I am asking for some thoughts, on the right approach. How do you recommend making print preview to work? The UI team's mockup was visioning a domui that handles the print preview/settings. Should we open a new tab for print preview, or should we use the same tab? In either case, how can I pass data, in particular the Bitmap image that is created in RenderView to the DOMUI page so I can view it. Any help is appreciated. - Mohamed On Wed, Sep 16, 2009 at 12:06 AM, Brett Wilson bre...@chromium.org wrote: On Tue, Sep 15, 2009 at 7:31 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Hi all, I am having trouble trying to figure out how I could replace the contents of a specific WebFrame while I am in RenderView with a custom DOMUI page that I have created. Here is a scenario: User visits http://www.google.com User waits till page is done loading User selects Options Print Preview The current page will be replaced with a custom PrintPreview DOMUI page (print:http://www.google.com) where I would be passing some Data such as a vector of bytes (image) from RenderView to PrintPreviewDOMUI I have created the DOMUI page and made sure it works, and created the bitmap and encoded it with JPEGEncoder, but I am clueless on how the connection would be from RenderView to DOMUI. Any assistance is appreciated. The reason why I want to replace the current contents is because print preview depends on what is exactly visible at that time. Unless there is a better way. Thanks in advance! Is the code you're writing in C++ or JS? Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Linux views trybot
We need one. I have broken the Linux views build three times in the past three days. This is wasting my time and the sheriffs' both. Is someone working on making this happen? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
