Re: [chromium-dev] Date of M5 drop?
On Thu, Jan 14, 2010 at 4:21 PM, Peter Kasting pkast...@google.com wrote: On Thu, Jan 14, 2010 at 4:48 AM, OwenCM owencmo...@googlemail.com wrote: Hi, I've been scouring the groups and can't find the answer anywhere, what time scale are we looking at until the dev branch hits m5? If you're looking for a branch date for version 5, we don't generally announce those, I don't think. There used to be dates for M4 on the release calendarhttp://dev.chromium.org/developers/calendar. There aren't any events for M5, though. As an external contributor, I think it'd be helpful to have this information available. rsesek / @chromium.org -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Core Principles: A refresher (especially for newer contributors/team members)
I was actually thinking about these principles today, and I think we need to do a better job of conveying some of them to our users. Frequently I see requests such as can't you just add an option for X? in bug reports. The answer is most often No, but it'd be great if we could point users to something that explains the rationale behind that answer. I think it'd be beneficial for both developers and users to have a less-technical document (or an expanded paragraph, at least) explaining our philosophy on options and why we take such an aggressive stance against adding them. I think your summary is a good start at that. rsesek / @chromium.org On Wed, Jan 6, 2010 at 7:33 PM, Peter Kasting pkast...@google.com wrote: A while ago, Ben Goodger (our fearless tech lead) wrote up a set of core principles around Chromium. If you have not read and pondered these, please do: http://dev.chromium.org/developers/core-principles In particular, as we've had more contributors both inside and outside Google over the past year, I feel there have been an increasing number of debates about things like adding more options and prompts, or making the UI more complex in other ways. One of our design goals is never to present users information and choices they don't understand or care about, and to make the browser automatically do the right thing, so that it's a natural extension of your will instead of a piece of software (in the words of the document). While this presents us with hard choices, and we can't always accommodate every user (including some of us developers!), it's important that we share a unified vision of what the product should be. Ben once mused that he'd love for us to be able to _remove_ options and prefs in each subsequent version. My own summary is this: trying to please everyone results in a product that doesn't perfectly please anyone; we should be willing to be bold, be arrogant, and create a product that is unsuitable for a few users, if that means it is exceptional for most. There are many good choices in the browser space today, and it's perfectly fine if an individual finds that Firefox, Safari, or any other browser is a better fit for him--as long as we understand and accept the tradeoff that triggers that decision. I hope you're passionate about making something great, and that whatever you're working on is focused around these core principles. PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Red Tree 2010/1/6
Good evening, At 9pm ET, the tree was significantly red and Erik Kay closed the tree: Win browser_tests, Win Mac perf, Linux views, and Win Webkit all were red. I cleaned up the Win browser_tests, Linux Views, and Win WebKit redness, but the Win Mac perf regressions are still in play. mpcompete, jamesr, and I debated about what to do with this since it originated from a fairly significant WebKit roll: http://src.chromium.org/viewvc/chrome?view=revrevision=35646. Backing out didn't seem like the best option because it was large jump and another roll happened later at r35669. The tree *is still closed* as of 11pm ET because http://crbug.com/31698 (tracking bug for this perf regression) does not yet have an owner and it desperately needs one! If in the morning someone more knowledgeable feels like we can open, please do. Also, I didn't have time to track it down tonight, but Windows UI Interactive (dbg) has been red on and off for the past couple of cycles, starting at http://build.chromium.org/buildbot/waterfall/builders/Interactive%20Tests%20(dbg)/builds/19501. I'm hesitant to mark it as flaky without knowing a little more, but I backed out oshima's change (the likely candidate) and the redness continued. Help appreciated :). Thanks and good night! rsesek / @chromium.org -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] How does make determine which files to compile in chromium
Project files (Make, Visual Studios, and Xcode) are all generated from GYP (Generate Your Projects). These are the .gyp and .gypi files in the source directories. For chrome/browser/, look at chrome/browser/chrome_browser.gypi. rsesek / @chromium.org On Wed, Dec 30, 2009 at 8:55 PM, hap 497 hap...@gmail.com wrote: Hi, Can you please tell me how does make determine which files to compile in chromium? I add a test.cc file under chrome/browser, and then do 'make out/Debug/chrome' again, but nothing is compiled. I have looked for *.mk file to find the list of files to compile, but nothing like that is there. Thank you for any pointers. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] How to compile and run TabSwitchingUITest on Linux
test_binary was just an example. The target you want is named tab_switching_test. rsesek / @chromium.org On Sat, Dec 26, 2009 at 4:29 PM, n179911 n179...@gmail.com wrote: Thank you. I tried to compile 'test_binary', but there is no such executable. $ make out/Debug/test_binary make: *** No rule to make target `out/Debug/test_binary'. Stop. $ ./out/Debug/test_binary bash: ./out/Debug/test_binary: No such file or directory And I tried to run 'automation_proxy_uitest' and that did not work either. $ make out/Debug/automation_proxy_uitest make: *** No rule to make target `out/Debug/automation_proxy_uitest'. Stop. On Fri, Dec 25, 2009 at 2:15 PM, Robert Sesek rse...@chromium.org wrote: The --gtest_filter switch should do what you want: ./test_binary --gtest_filter='TestClassName.*'. You can replace the .* with a specific test case name. The quotes are necessary if your shell expands the asterisk. Find out more with the --help flag. Also, I don't think TabSwitchingUITest is in base_unittests but rather its own binary (Debug/tab_switching_test), though I'm not sure about that. rsesek / @chromium.org On Fri, Dec 25, 2009 at 2:02 PM, n179911 n179...@gmail.com wrote: Hi, Here is how to compile and run all tests on linux: $make ./out/Debug/base_unittests $./out/Debug/base_unittests Can you please tell me how can I run 1 specific test, namely TabSwitchingUITest? Thank you. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Command Line switches persisted in Preferences
This would be nice for Mac users as they cannot create shortcuts with command line options, unlike in Windows. Instead, they have to be passed to the application every time, which means always opening Chromium through Terminal. If this is implemented, though, should we not persist some flags (like --single-process and --disable-sandbox)? There was a recent discussion on chromium-dev about putting up an infobar for some of these options. That said, I'm not sure persisting command line flags automatically is a good idea. For example, if I wanted to run with --log-level 0 one time, I wouldn't want that enabled every future time I run Chromium. To disable a flag, the user would need to know the default value, which she may not know. rsesek / @chromium.org On Thu, Dec 24, 2009 at 10:28 AM, Mohamed Mansour m...@chromium.org wrote: Hi everyone, first, I want to say Merry Christmas :) We have many command line switches in Chromium that many users would like to have switched on every time. And managing them using registry or even modifying the shortcut directly doesn't always work (Windows7) and its very tedious. Is their any argument not allowing command line options to be persisted in the Preferences file? There is even a limit on how many arguments you can put that small Shortcut Properties dialog which makes it even more unusable. Many users on the forums, would always like to run specific command line switches, many of them run more than 1, some of them turn on ~5. Can't we just include another pref name that we name switches that users can put whatever they want inside that? That will make many people happy. Since the UI team doesn't like to add more customizable preferences in the UI, this would be the next simplest place to tell users to customize a couple of stuff without affecting the UI at all. -Mohamed Mansour -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Can't build on Snow Leopard anymore
I've tried to build on Snow Leopard twice. I've tried both an incremental
and a clobber, but both times I get this error:
=== BUILD AGGREGATE TARGET webkit_system_interface Support OF PROJECT
WebCore WITH THE DEFAULT CONFIGURATION (Debug) ===
Check dependencies
PhaseScriptExecution Action \Adjust Visibility\
../../../../xcodebuild/WebCore.build/Debug/webkit_system_interface
Support.build/Script-C2FA7E609918094ADF85F31E.sh
cd
/Users/rsesek/Projects/chromium/src/third_party/WebKit/WebCore/WebCore.gyp
/bin/sh -c
\/Users/rsesek/Projects/chromium/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/Debug/webkit_system_interface
Support.build/Script-C2FA7E609918094ADF85F31E.sh\
ar: input.a is a fat file (use libtool(1) or lipo(1) and ar(1) on it)
ar: input.a: Inappropriate file type or format
ld: file not found:
/Users/rsesek/Projects/chromium/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/DerivedSources/Debug/adjust_visibility/self/*.o
Command /bin/sh failed with exit code 1
Command /bin/sh failed with exit code 1
** BUILD FAILED **
The following build commands failed:
webkit_system_interface Support:
PhaseScriptExecution Action \Adjust Visibility\
/Users/rsesek/Projects/chromium/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/Debug/webkit_system_interface
Support.build/Script-C2FA7E609918094ADF85F31E.sh
(1 failure)
This script contains:
#!/bin/sh
exec mac/adjust_visibility.sh
../../WebKitLibraries/libWebKitSystemInterfaceLeopard.a
${BUILT_PRODUCTS_DIR}/libWebKitSystemInterfaceLeopardPrivateExtern.a
${INTERMEDIATE_DIR}/adjust_visibility
exit 1
Any ideas? This only started happening recently (last 2 days or so).
rsesek / @chromium.org
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Can't build on Snow Leopard anymore
Thanks Mark. I've filed
http://code.google.com/p/chromium/issues/detail?id=29533. The value of ARCHS
is empty, which I'm guessing is the problem.
rsesek / @chromium.org
On Sun, Dec 6, 2009 at 10:24 AM, Mark Mentovai m...@chromium.org wrote:
This script runs on
third_party/WebKit/WebKitLibraries/libWebKitSystemInterfaceLeopard.a,
but that file hasn't changed in the past couple of days, so I don't
see why this would be happening.
The script that's driving the failed step is at
third_party/WebKit/WebCore/WebCore.gyp/mac/adjust_visibility.sh. I'd
be curious to figure out what value you're getting for ARCHS at line
58 of that script.
You should file a bug and assign it to me, and you can put the answer
to this question there.
Mark
Robert Sesek wrote:
I've tried to build on Snow Leopard twice. I've tried both an incremental
and a clobber, but both times I get this error:
=== BUILD AGGREGATE TARGET webkit_system_interface Support OF PROJECT
WebCore WITH THE DEFAULT CONFIGURATION (Debug) ===
Check dependencies
PhaseScriptExecution Action \Adjust Visibility\
../../../../xcodebuild/WebCore.build/Debug/webkit_system_interface
Support.build/Script-C2FA7E609918094ADF85F31E.sh
cd
/Users/rsesek/Projects/chromium/src/third_party/WebKit/WebCore/WebCore.gyp
/bin/sh -c
\/Users/rsesek/Projects/chromium/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/Debug/webkit_system_interface
Support.build/Script-C2FA7E609918094ADF85F31E.sh\
ar: input.a is a fat file (use libtool(1) or lipo(1) and ar(1) on it)
ar: input.a: Inappropriate file type or format
ld: file not found:
/Users/rsesek/Projects/chromium/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/DerivedSources/Debug/adjust_visibility/self/*.o
Command /bin/sh failed with exit code 1
Command /bin/sh failed with exit code 1
** BUILD FAILED **
The following build commands failed:
webkit_system_interface Support:
PhaseScriptExecution Action \Adjust Visibility\
/Users/rsesek/Projects/chromium/src/third_party/WebKit/WebCore/WebCore.gyp/../../../../xcodebuild/WebCore.build/Debug/webkit_system_interface
Support.build/Script-C2FA7E609918094ADF85F31E.sh
(1 failure)
This script contains:
#!/bin/sh
exec mac/adjust_visibility.sh
../../WebKitLibraries/libWebKitSystemInterfaceLeopard.a
${BUILT_PRODUCTS_DIR}/libWebKitSystemInterfaceLeopardPrivateExtern.a
${INTERMEDIATE_DIR}/adjust_visibility
exit 1
Any ideas? This only started happening recently (last 2 days or so).
rsesek / @chromium.org
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
Re: [chromium-dev] workflow for cross-platform development
On Sat, Nov 21, 2009 at 1:52 PM, Chris Bentzel cbent...@google.com wrote: Do you mostly rely on the try-bots, or do you also patch the diffs to your different dev environments and build and test locally? If you do the patching, do you tend to do a gcl upload and grab the diffs from there, or do you copy the diffs from machine to machine prior to the upload? If you do an initial gcl upload, do you skip the trybots until you validate that it works on all platforms to reduce load on the trybots? The try bots are helpful, but it's often nice to be able to attach a debugger or to locally build things you're not sure about. Cross-machine work is greatly eased by using githttp://code.google.com/p/chromium/wiki/UsingGit because you can push/pull local-only commits to/from different repositories. I also keep my one main machine as the one to actually perform Rietveld uploads and commits on. rsesek / @chromium.org -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: Uber Page Info Window (Was: Re: [chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API)
For reference: http://code.google.com/p/chromium/issues/detail?id=5973 I'd be interested in helping out with this on the Mac side. I filed a Camino bug https://bugzilla.mozilla.org/show_bug.cgi?id=297376 a couple of years ago about something similar. Safari has a helpful tool in Window -- Activity that allows you to download all resources of a page (including XHR and others loaded through JS). DevTools does something similar, but compared to Safari's interface it's slower and harder to find things (the entries in the list take up more vertical space). rsesek / @chromium.org On Fri, Sep 25, 2009 at 10:25 PM, Ben Goodger (Google) b...@chromium.orgwrote: BTW I should note what I mean by Uber Page Info Window. For some time, we've talked about improving the page info window in Chrome. Right now it shows only the security information for a SSL page. In the future we'd like to extend this to show other information. The idea is there'd be a few tabs showing things like: - general page info in addition to security info - web capabilities/permissions used by the page, along with the ability to control these, including the effect of any active blacklist - media attached to the page, which a convenient way to download - eventually an additional surface for extensions to add tabs/features based on content-script scanning of the page The idea anyway is for any web capability there'd be a toggle in here. We also envisage some kind of app/extension page where one can visit the properties/capabilities for an individual installed app/extension too. Anyway any time the notion of site-specific capability control comes up, the response from the UX team tends to be uber page info window. It's on our list, we just have been busy with other stuff. I mocked this some years ago in Firefox as a bottom bar http://web.archive.org/web/20051220182808/wiki.mozilla.org/Firefox:Info_Window but I am not advocating that approach necessarily. -Ben On Fri, Sep 25, 2009 at 7:13 PM, Ben Goodger (Google) b...@chromium.org wrote: On Fri, Sep 25, 2009 at 6:13 PM, Jeremy Orlow jor...@chromium.org wrote: I had the same thoughts. Does Firefox not implement anything like this? Another question that this brings up: how could a user un-register something even if the web site doesn't do anything to make it possible? In other words, we might need some piece of UI to remove registrations even beyond having an API for it. Uber page info dialog. -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: [linux] user feedback one month in
On Sun, Sep 20, 2009 at 10:43 PM, Evan Martin e...@chromium.org wrote: - He's bookmarking by pasting urls into add page dialog found via the bookmark manager(!). Maybe he doesn't realize the star is the add bookmark button? My response: I'm no UI designer, but I wonder if it'd help to put the bookmark button star in some of the dialogs related to bookmarking? If you don't hover the star you'll never learn what it does; on the other hand, there are only seven buttons on the toolbar and I kind of don't have much pity for people who haven't looked at them. At least on Mac, in the bookmark menu/bar we use the generic globe favicon for sites that don't have their own icon. Perhaps we should switch this to be a star icon? That way there'd be a subtle suggestion to the user that star=bookmark. rsesek / @chromium.org --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Make CL summary prefix tags a formal convention?
It seems to be an informal convention amongst some Mac developers to prefix their changes with [Mac] in the CL subject line. This is extremely helpful for quickly picking out changes that only affect the single platform, especially if that information is not clear from the CL's description. I was wondering if we could formalize this convention across all three platforms, using [Windows], [Linux], and [Mac] when a change only affects a single platform? For bi-platform changes we could also use [Windows, Linux]. Thoughts? rsesek / @chromium.org --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is there any good tool on Linux to browser and cross reference chromium source code?
+1 for an LXR-like tool. Codesearch is decent if you're just trying to find something, but symbols and .h files aren't hyperlinked, which makes it a lot less useful. OpenGrok http://www.opensolaris.org/os/project/opengrok/ seems pretty cool, but it requires a Java serverlet container (I'm not sure how much of a barrier to setup that would impose). It also doubles as a SCM viewer, which would be a nice alternative to ViewVC. rsesek / @chromium.org On Thu, Sep 17, 2009 at 12:39 AM, James Su su...@chromium.org wrote: I just found DXR http://dxr.proximity.on.ca/dxr/index.html, which is awesome. Might be worth to have a try. Regards James Su 2009/9/17 Evan Martin e...@chromium.org I'd like to set up a web-based code browser on chromium.org, but I played around with a couple and wasn't too happy with any of them. Suggestions are welcome. On Tue, Sep 15, 2009 at 9:19 PM, James Su su...@chromium.org wrote: Hi, I'm currently using cscope + vim, but it's so slow and hard to use. Is there any better choice? Regards James Su --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Clear Strict-Transport-Security state checkbox added
It clears the list of hosts in StrictTransportSecurityState: // StrictTransportSecurityState // // Tracks which hosts have enabled StrictTransportSecurityState. After a host // enables StrictTransportSecurityState, then we refuse to talk to the host // over HTTP, treat all certificate errors as fatal, and refuse to load any // mixed content. // rsesek / @chromium.org On Thu, Sep 17, 2009 at 7:28 PM, Erik Kay erik...@chromium.org wrote: For those of us who are curious, could someone explain what this does? Erik On Thu, Sep 17, 2009 at 4:20 PM, Finnur Thorarinsson fin...@chromium.org wrote: +1 to what Peter is saying. Like Brett, I have no clue what this checkbox means and think it shouldn't have been added. However, the question I have... is it appropriate to tuck this in with something like deleting the history (like we do with last session, recently closed tabs, autogenerated keywords, etc)? It is hard for me to evaluate that, not knowing what this does... :) -F On Thu, Sep 17, 2009 at 16:09, Evan Martin e...@chromium.org wrote: On Thu, Sep 17, 2009 at 3:54 PM, Brett Wilson bre...@chromium.org wrote: On Thu, Sep 17, 2009 at 3:50 PM, Evan Martin e...@chromium.org wrote: On Thu, Sep 17, 2009 at 3:38 PM, Adam Langley a...@chromium.org wrote: On Thu, Sep 17, 2009 at 3:37 PM, Ben Goodger (Google) b...@chromium.org wrote: Whoever added this UI, please remove it before I have to when I get back next week. Very well, reverting. Why not #ifdef around it? I fear if you revert you'll never check it in again. If that happens, it's the best possible argument that this is a silly thing to add. No, it's just the argument that it's not the sort of thing people are willing to expend the energy to argue about. With this sort of response I'd be tempted to just give up on the patch. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac resources and bundles
On Tue, Aug 18, 2009 at 12:38 PM, Thomas Van Lenten thoma...@chromium.orgwrote: Anyone adding more resources (xibs, etc.) to the Mac, please remember always fetch them from mac_util::MainAppBundle() (base/mac_util.h) and do *not* use any Cocoa apis that assume [NSBundle mainBundle]. As part of the l10n, packaging, and updating, where resources live and what bundle is running as the main bundle isn't always what you expect. TVL Also helpful is nsimage_cache::ImageNamed(), which loads (and caches) an NSImage from mac_util::MainAppBundle() via just an image file name. rsesek / @chromium.org --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac History Menu
On Thu, Aug 13, 2009 at 11:08, Julian Harris k...@google.com wrote: What about Cmd-Opt-H? Cmd+Opt+H is also bound by the system for Hide Others. 2. Currently, items in the history menu open in the current foreground tab. I'm currently working on a CL to make it so that if you hold down the Cmd modifier while selecting a history/bookmark menu item, it will open in a new tab. I was wondering, though, if we should instead reverse this behavior so that history items (and maybe bookmark?) open in a new tab, and you can use the modifier to open in the current tab. Historically on the Mac, the option key has been used for this kind of action -- just a suggestion. I think Cmd is the right modifier because, as I said above, Cmd+click is used to open links in new tabs. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Mac History Menu
Two things about the Mac history menu that I'd like people to weigh in on: 1. The Show All History command should have a keyboard shortcut. We can't use the logical Cmd+H because it's bound by the system. Stuart suggested Cmd+Y, as that's what Camino uses. Firefox and Safari both lack keyboard shortcuts for this menu command, so it's really up to us to define it. So Cmd+Y seems as good as any other. Thoughts? 2. Currently, items in the history menu open in the current foreground tab. I'm currently working on a CL to make it so that if you hold down the Cmd modifier while selecting a history/bookmark menu item, it will open in a new tab. I was wondering, though, if we should instead reverse this behavior so that history items (and maybe bookmark?) open in a new tab, and you can use the modifier to open in the current tab. - Robert --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac History Menu
On Wed, Aug 12, 2009 at 15:33, Scott Violet s...@chromium.org wrote: I would suggest you create something like browser/views/event_utils on the Mac (and Linux) side. Any place you're opening a URL from a user gesture you map the event to a WindowOpenDisposition. This way the UI is consistent with regards to what user gestures do. This sounds like a great idea. Thanks for pointing it out. On Wed, Aug 12, 2009 at 15:59, Mike Pinkerton pinker...@chromium.orgwrote: The few times I've needed to use the history menu (gak, i just closed something by accident, let me get it back), re-using the current tab is exactly what i don't want, as it clobbers something totally unrelated that I had open. That's what prompted this discussion. I agree that it should behave like bookmarks in theory, since it's effectively the same presentation, but it seems to get in the way of my workflow when I try to actually use it. Exactly. That's the problem I'm having with the menu as-is and why I brought it up. I know we won't do this because it reeks of inconsistency, but recently closed items should open in a new tab and most-visited should open in the current one. The modifier key is a good alternative to this, I think, and it's unobtrusive. I'm just unsure which should be the default and which should be the modified behavior. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: PSA: irc awareness [Was: Trick question: Who is responsible for repairing a red tree?]
Dirk, Adium should automatically do it for your full IRC nick. You can also go into Adium -- Preferences -- Advanced -- Mention to have it watch for other things. Also, you can go into the Events preference and change the You are mentioned (Group Chat) notification options. - Robert On Aug 5, 10:25 pm, Dirk Pranke dpra...@google.com wrote: I would love to enable that feature ... anyone know how to do that for Adium on the Mac (IRC support is new in the 1.4 beta)? Failing that, Colloquy? -- Dirk On Wed, Aug 5, 2009 at 5:48 PM, Marc-Antoine Ruelmar...@chromium.org wrote: Most irc clients have an option to beep, flash or shutdown your computer when your nick is mentioned on a channel. It may not be enabled by default so please enable this. Ask around if you can't find how to enable this. Thanks, M-A On Wed, Aug 5, 2009 at 5:48 PM, Dan Kegel d...@kegel.com wrote: On Wed, Aug 5, 2009 at 2:45 PM, Tim Steelet...@chromium.org wrote: you have to keep asking, unless you're always on IRC and can cleverly search the window contents. A constant place to go looking for this would make it easier, at least in my opinion. Like right now I don't know what's up with Chromium Mac (valgrind) You need to be on IRC and scroll back: [13:55] dkegel mac valgrind unit - rohitrao? [13:57] motownavi dkegel: very likely [13:58] dkegel emailed rohit [14:02] rohitrao dkegel, jar: looking [14:30] rohitrao jar, dkegel: reverted 22517 I doubt anything more durable than IRC is going to help... IRC and the tree status are the place to go, I'm afraid. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: chrome always break in debugger when run under XCode
Hi Nathan,
I started noticing the same problem this week, too. The class looks
like it's supposed to help developers by attaching a C++ debugger
whenever a critical exception is raised, so they can view the stack
trace and inspect variables. What I think happens is that Chromium
thinks that Xcode's debugger is listening when it really isn't, and it
crashes.
When you run Chromium.app via Run -- Debug, you can get over the
breakpoint by pressing the continue button, or typing 'c' in gdb. But
if you run the application via Run -- Run or by opening it in Finder,
the breakpoint turns fatal and terminates the app.
I've just commented out the two asm() lines in my tree because I find
the breakpoints more annoying than helpful. I think it would be better
if DebugUtil's features were enabled with a build or runtime flag,
rather than having to resort to commenting it out.
- Robert Sesek
On Jun 6, 10:48 pm, Nathan Summer nathan.charles.sum...@gmail.com
wrote:
Hi,
I compile chrome and run under XCode.
But it breaks here, can you please tell me why? And what does BreakDebugger
do?
// static
void DebugUtil::BreakDebugger() {
#if defined(ARCH_CPU_ARM_FAMILY)
asm(bkpt 0);
#else
asm(int3);
#endif
}
Here is the stack trace:
#0 0x0058c43f in DebugUtil::BreakDebugger at debug_util_posix.cc:116
#1 0x005ad984 in logging::LogMessage::~LogMessage at logging.cc:545
#2 0x0040e751 in SafeBrowsingService::UpdateStarted at
safe_browsing_service.cc:466
#3 0x003e7c4a in SafeBrowsingProtocolManager::IssueUpdateRequest at
protocol_manager.cc:486
#4 0x003e7cc9 in SafeBrowsingProtocolManager::GetNextUpdate at
protocol_manager.cc:157
#5 0x003ed24a in DispatchToMethodSafeBrowsingProtocolManager, void
(SafeBrowsingProtocolManager::*)() at tuple.h:412
#6 0x003ed28d in base::BaseTimerSafeBrowsingProtocolManager,
false::TimerTask::Run at timer.h:160
#7 0x005b07c3 in MessageLoop::RunTask at message_loop.cc:309
#8 0x005b0b87 in MessageLoop::DeferOrRunPendingTask at message_loop.cc:317
#9 0x005b0d0a in MessageLoop::DoDelayedWork at message_loop.cc:450
#10 0x005bb154 in base::MessagePumpLibevent::Run at
message_pump_libevent.cc:228
#11 0x005b18bb in MessageLoop::RunInternal at message_loop.cc:198
#12 0x005b18d7 in MessageLoop::RunHandler at message_loop.cc:181
#13 0x005b1962 in MessageLoop::Run at message_loop.cc:155
#14 0x005f30a9 in base::Thread::ThreadMain at thread.cc:156
#15 0x005c72c4 in ThreadFunc at platform_thread_posix.cc:26
#16 0x92129155 in _pthread_start
#17 0x92129012 in thread_start
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] chrome-bisect.py: Mac Chrome Continuous Build Archive Bisecting
Tonight I wrote a Python script called chrome-bisect.py that performs a binary search on the Mac continuous build archive. It takes a starting known-good and bad revision and then downloads, unzips, and opens the archived builds for you. You can then test the running build and report back to chrome-bisect if the build is good or bad. The binary search will then continue until it finds the version in which the regression was introduced. You can download it here: http://www.bluestatic.org/git/?p=Toolchain.git;a=blob_plain;f=chrome-bisect.py;hb=HEAD The script will not work on Windows (it should work on Linux, for the most part) because it uses `unzip` and `open` commands via os.system (). Patches are welcome to make it more cross-platform. You can clone the git repository it lives in here: http://www.bluestatic.org/git/Toolchain.git - Robert Sesek --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac History Menu Implementation
On Tue, May 26, 2009 at 00:59, Ben Goodger (Google) b...@chromium.orgwrote: I think we had discussed adding most visited/recently closed items here, sort of like a NTP without the NTP. I think this is an interesting idea, particularly the most recently closed items. Are you thinking this is supplemental to the typical (i.e., what other browsers do) history menu, or as a replacement for it? - Robert --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Mac History Menu Implementation
I was in IRC today and asked around if anybody had started the History menu on the Mac and Mike Pinkerton said he didn't think anybody had. If that's the case, then I'd like to investigate it (and I'll open an issue that states such). But since there is no corresponding menu in either the Windows or Linux ports, there isn't a design doc or reference for how the menu should behave. If we look at a couple of Mac browsers, this is how they implement it: Safari: Full history in long menus organized by date. Firefox: Last 10 items visited. Camino: Last 12 items visited in the menu before being broken down into sub-menus by date. I think that Firefox's implemntation makes the most sense from a usability perspective. Those long menus in Safari are next to worthless if you have a decent-sized browsing history and really just clutter things up. Camino's implemntation isn't bad, either. That being said, I think 10 is too few items to include in the menu, and I'd like to see 15-20. Where do other people stand on this? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
