[chromium-dev] Re: Make found no targets (missing Makefile)
On Dec 27, 12:19 am, Andrew Ames a...@amesgames.net wrote:
I am having trouble compiling on
Ubuntu 9.10 (karmic)
Kernel Linux 2.6.31-14-generic
GNOME 2.28.1
AMD Athlon 64
I have successfully built before on a 32-bit i386 Ubuntu installation.
Any ideas?
Here's my session:
BEGIN
a...@ubuntu:~/projects/chromium$ export GYP_GENERATORS=make
a...@ubuntu:~/projects/chromium$ gclient config
\http://src.chromium.org/svn/trunk/src\http://chromium-status.appspot.com/lkgr
a...@ubuntu:~/projects/chromium$ gclient sync
a...@ubuntu:~/projects/chromium$ gclient runhooks --force --verbose
solutions = [
{ name : src,
url : http://src.chromium.org/svn/trunk/src;,
custom_deps : {
src/third_party/WebKit/LayoutTests: None
},
safesync_url: http://chromium-status.appspot.com/lkgr;
},
]
DEBUG:root:['/usr/bin/python', 'src/build/gyp_chromium']
running '/usr/bin/python src/build/gyp_chromium' in
'/home/andy/projects/chromium'
Updating projects from gyp files...
DEBUG:root:['/usr/bin/python',
'src/build/win/clobber_generated_headers.py']
running '/usr/bin/python
src/build/win/clobber_generated_headers.py' in
'/home/andy/projects/chromium'
DEBUG:root:['/usr/bin/python',
'src/build/mac/clobber_generated_headers.py']
running '/usr/bin/python
src/build/mac/clobber_generated_headers.py' in
'/home/andy/projects/chromium'
a...@ubuntu:~/projects/chromium$ make chrome
make: *** No rule to make target `chrome'. Stop.
a...@ubuntu:~/projects/chromium$
END
You could try run:
$ export GYP_GENERATORS=make
$ gclient runhooks --force
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Cannot find -lffmpegasm
Hi Dominic, On Dec 14, 1:34 pm, Dominic Mazzoni dmazz...@google.com wrote: What do you have GYP_DEFINES set to? I got a compilation error involving ffmpeg last week, but then I tried again with an empty GYP_DEFINES and it worked fine. $ echo $GYP_DEFINES returns nothing :( -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Cannot find -lffmpegasm
Hi Albert, On Dec 15, 4:47 am, Albert J. Wong (王重傑) ajw...@chromium.org wrote: There have been some changes to the ffmpeg.gyp file recently. Dominic makes a good point that the GYP_DEFINES will make a large difference. Thiago, what GYP_DEFINES do you have set? The output of '$ echo $GYP_DEFINES' returned nothing here. Note that ffmpeg_asm is not a build dependency. It's a target in the ffmpeg.gyp file that must somehow be getting excluded in your build. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Cannot find -lffmpegasm
I really don't know what was the problem exactly. After running build/install-build-deps.sh is that the problem started, so my guess is that some incompatible changes appeared because of that. So what I did was to download binutils-2.20.tar.gz, build and install it from sources. After doing that I was able to compile and link the dependencies again. So I'm thinking that the version of gold installed by install-build-deps would be the root of the problem. Now using this version: GNU ld (GNU Binutils) 2.20 is working fine *_again_* :) Sorry for all the noise, and thanks all for the answers :) -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Cannot find -lffmpegasm
Sorry for posting here, but I didn't find other place to ask, also I didn't find a solution too, so... I already tried everything, like, clobbering the out directory, synching again with 'gclient sync --force'. What I usually do is, in the trunk branch: $ git pull $ gclient sync $ time make CC=ccache gcc CXX=ccache g++ -k chrome But since friday this is not working and I'm getting weird errors. After some searching I ending up with this following line, but remaing this last error. $time make CC=ccache gcc CXX=ccache g++ LDFLAGS+=-ldl LDFLAGS+=- lpthread -k chrome SOLINK(target) out/Debug/lib.target/third_party/ffmpeg/ libffmpegsumo.so /usr/bin/ld: error: cannot find -lffmpegasm collect2: ld returned 1 exit status make: *** [out/Debug/lib.target/third_party/ffmpeg/libffmpegsumo.so] Error 1 make: Target `chrome' not remade because of errors. real1m3.344s user0m23.237s sys 0m7.532s I hope someone could give me a hint how to make this work again. Ah, I ran build/install-build-deps.sh to see if I was missing some dev package, but it says that everything is installed. PS: without these LDFLAGS , the compilation don't work also. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: FYI: a new problem with the latest patch for 2008 SP1 (from today/yesterday)
I'm in trouble with this problem. Now the deque have this problem too. I already removed the SP1, the hotfix, reinstalled everything, but nothing works. On Jul 29, 11:28 pm, Lei Zhang thes...@chromium.org wrote: I assume there's a similar patch for VS2005SP1. Does that have the same problem? On Wed, Jul 29, 2009 at 11:15 AM, nakroyoav.zilberb...@gmail.com wrote: if you get the latest patch of VS2008SP1 (released yesterday) you will not be able to compile chrome you will get errors relating to '_Swap_adl' i googled it a bit, and till MS fixes it i simply modified 2 files in the inc dir tuple xutility and changed '_Swap_adl' to 'swap' - note the lowercase also due to permissions you might not be able to modify the file, so i did this in an elevated cmd prompt ok, now you know, here is where i got most of the info from http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/4bc93a... --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Chromium crash
Yes, I'm compiling the code under debug build option. Everytime I try to type in omnibox this happens. On Jul 20, 4:02 pm, Scott Hess sh...@chromium.org wrote: Looks to me like the code in question wouldn't be compiled into release builds in the first place (it's under NDEBUG). So it might be problematic to match it to a known bug, since the known bugs would mostly look different. The general case of Started typing in omnibox and crashed is obviously not something which happens every time. That would certainly be noticed! -scott On Sun, Jul 19, 2009 at 2:48 PM, Thiago Farinathiago.far...@gmail.com wrote: I thought this problem was known. Thanks! On Jul 19, 6:33 pm, Peter Kasting pkast...@google.com wrote: On Sun, Jul 19, 2009 at 12:52 PM, Thiago Farina thiago.far...@gmail.comwrote: When I start typing in omnibox from Chromium (I'm debugging) the browser crashes... Since yo're debugging, you can track down what's going on. Then you can look it up in the bug database. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Getting Started with a New Project
Did you added the common project to your solution? On Jul 19, 12:40 pm, Kruncher leaha...@gmail.com wrote: For the purposes of practice I am trying to create an empty Win32 Exe project that uses the demonstration code from: http://dev.chromium.org/developers/design-documents/chromeviews To do this I have created a new solution and an empty project. I have then added the demonstration code, and in the project settings added the additional include/lib directories (which I copied from an Exe project from the Chromium trunk). However, when I try to build the project, I get the following compilation error: 1c:\chromium\src\quick_test\quick_test\views\main_window.cc(4) : fatal error C1083: Cannot open include file: 'chrome/common/gfx/ chrome_canvas.h': No such file or directory What steps are required to create a new solution/project of this nature? I would really like to use the views API that Chromium has to offer. Many thanks, Lea Hayes --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Chromium crash
When I start typing in omnibox from Chromium (I'm debugging) the browser crashes... I'm getting this error: [2148:3796:1738765:FATAL:autocomplete.cc(438)] Check failed: classification.size() == 0, Error initializing symbols(0). Dumping unresolved backtrace: --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Chromium crash
Hi Peter, How can I track down? Where is bug database located? In the Local\Chromium\User Data\Crash Reports directory, there is nothing. Thanks! On Jul 19, 6:33 pm, Peter Kasting pkast...@google.com wrote: On Sun, Jul 19, 2009 at 12:52 PM, Thiago Farina thiago.far...@gmail.comwrote: When I start typing in omnibox from Chromium (I'm debugging) the browser crashes... Since yo're debugging, you can track down what's going on. Then you can look it up in the bug database. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Chromium crash
I thought this problem was known. Thanks! On Jul 19, 6:33 pm, Peter Kasting pkast...@google.com wrote: On Sun, Jul 19, 2009 at 12:52 PM, Thiago Farina thiago.far...@gmail.comwrote: When I start typing in omnibox from Chromium (I'm debugging) the browser crashes... Since yo're debugging, you can track down what's going on. Then you can look it up in the bug database. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: vs2008 and gyp
Is safe to try this option? Nothing will be broken? Where I can set this variable? On Jun 4, 3:40 pm, Bradley Nelson bradnel...@google.com wrote: Hi All, If you don't have Visual Studio 2008 installed you can stop reading. As many of you have no doubt noticed, gyp emits something approximating vs2008 sln/vcproj files for the portion of the build it has swallowed. Currently it decides to emit vs2008 format if vs2008 is installed. The auto-detect has been a problem for several people, since the extent to which things build under vs2008 is unstable. I will be dropping a change in once the tree opens again to switch the default to vs2005. If you do want to play with the vs2008 option you can force it by setting GYP_MSVS_VERSION=2008 in your environment. Eventually we will add a vs2008 builder. But there seems like little point at the moment, since not everything has been gypified (so the import step still happens). If you feel strongly about what the eventual behavior should be, let me know. (Oh and for the folks that added in boost, I'll be adding in an MSVS_VERSION variable you'll be able to use at gyp time so you can have different behaviors). -BradN --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Point the browser to an URL
Maybe you can find what you want here:
http://dev.chromium.org/developers/design-documents
On Jul 10, 7:00 pm, Roberto Perez robj.pe...@gmail.com wrote:
I keep working on it,
The basic functionality of DnD is very simple, but call a browser method
isn't so :)
On Mac ( and i think that the same on windows and linux ) there is a
BaseView subclass called RenderWidgetHostViewMac that has an atributte of
the type RenderWidgetHost. I believe that i can use RenderWidgetHost to
communicate with RenderProcessHost in order to reach Browser class and call
OpenURL.
am I in the right direction to reach Browser class and make it to open an
URL?
Indeed, is there any document explaining the core architechture of
chromium?, I think it would be very useful to newbies :)
Roberto.
On Tue, Jul 7, 2009 at 6:58 AM, PhistucK phist...@gmail.com wrote:
If it is using the same functions as the Windows version uses for opening
URLs (and I believe it does, since this is a very basic core functionality
that should be unified), then search for the way the Go button goes to the
URL in toolbar. Generally, I found it in browser.h\cc (
http://src.chromium.org/svn/trunk/src/chrome/browser/browser.cc)-
OpenURL(url, referrer, disposition, transition);
For example -
OpenURL(file_url, GURL(), CURRENT_TAB, PageTransition::TYPED);
Actual function -
void Browser::OpenURL(const GURL url, const GURL referrer,
WindowOpenDisposition disposition,
PageTransition::Type transition) {
OpenURLFromTab(NULL, url, referrer, disposition, transition);
}
☆PhistucK
On Mon, Jul 6, 2009 at 23:54, Roberto robj.pe...@gmail.com wrote:
Hello,
I'm working in Drag'n Drop missing feature in Mac version. (issue
#12263)
I'm pretty new in Chrome develop and I'm very lost in many things.
Now, I capture de drop events and take the URL to navigate, ( I
place the code in cocoa/base_view.mm ) but i dont know how can I make
the browser to open that URL.
I'm investigating how autocomplete bar does the work hoping to find
light in it.
If you have any clues I would appreciate it :)
Greets
Roberto.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Hard coded
What would be the best place to put dialog message strings, chromium_strings or generated_resources.grd? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Issue Fixed status
I think there is another issue: http://crbug.com/3215 On Jul 9, 1:27 pm, dhhwai d...@chromium.org wrote: Jay's on the ball and has updatedhttp://crbug.com/15833 On Jul 9, 7:43 am, Thiago Farina thiago.far...@gmail.com wrote: Thanks dhhwai! I found another one. This issue was committed, but the status is assigned, so I'm not sure if it has to be marked as fixed:http://crbug.com/15833 On Jul 9, 3:52 am, dhhwai d...@chromium.org wrote: I have followed up and/or closed the above issues as appropriate. I expect Glen will update the status forhttp://crbug.com/5354assoon as he has committed the patch. On Jul 8, 8:31 pm, Thiago Farina thiago.far...@gmail.com wrote: Hi dhhwai, http://crbug.com/661http://crbug.com/5288 For this particulary issue, I've submitted the patch to Glen, so I'm waiting for he commit to me.http://crbug.com/5354 The flicker event in this issue still occuring, but the menu closes on second click.http://crbug.com/6242 These are the issues that I can remember now. On Jul 8, 5:03 pm, dhhwai d...@chromium.org wrote: Issue 7863 is fixed now. We can ask the fix committers to review the status of other unfixed issues. Do you have the issue numbers of other such issues? You can list them individually like: http://crbug.com/N On Jul 8, 7:45 am, Thiago Farina thiago.far...@gmail.com wrote: I noticed that the Issue 7863, that me and jcampan, we fixed, are available until now. I saw there are some other Issues are with the status: Available, but already well fixed. So some issues are being fixed but are not being updated in the Issue List. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Issue Fixed status
I reproduced the steps in this issue, but the next and previous buttons worked as expected, in version 2.0.172.33. http://crbug.com/6054 On Jul 9, 2:03 pm, Thiago Farina thiago.far...@gmail.com wrote: I think there is another issue:http://crbug.com/3215 On Jul 9, 1:27 pm, dhhwai d...@chromium.org wrote: Jay's on the ball and has updatedhttp://crbug.com/15833 On Jul 9, 7:43 am, Thiago Farina thiago.far...@gmail.com wrote: Thanks dhhwai! I found another one. This issue was committed, but the status is assigned, so I'm not sure if it has to be marked as fixed:http://crbug.com/15833 On Jul 9, 3:52 am, dhhwai d...@chromium.org wrote: I have followed up and/or closed the above issues as appropriate. I expect Glen will update the status forhttp://crbug.com/5354assoon as he has committed the patch. On Jul 8, 8:31 pm, Thiago Farina thiago.far...@gmail.com wrote: Hi dhhwai, http://crbug.com/661http://crbug.com/5288 For this particulary issue, I've submitted the patch to Glen, so I'm waiting for he commit to me.http://crbug.com/5354 The flicker event in this issue still occuring, but the menu closes on second click.http://crbug.com/6242 These are the issues that I can remember now. On Jul 8, 5:03 pm, dhhwai d...@chromium.org wrote: Issue 7863 is fixed now. We can ask the fix committers to review the status of other unfixed issues. Do you have the issue numbers of other such issues? You can list them individually like: http://crbug.com/N On Jul 8, 7:45 am, Thiago Farina thiago.far...@gmail.com wrote: I noticed that the Issue 7863, that me and jcampan, we fixed, are available until now. I saw there are some other Issues are with the status: Available, but already well fixed. So some issues are being fixed but are not being updated in the Issue List. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Issue Fixed status
Sorry I already deleted. On Jul 9, 2:42 pm, Peter Kasting pkast...@google.com wrote: On Thu, Jul 9, 2009 at 10:39 AM, Thiago Farina thiago.far...@gmail.comwrote: I reproduced the steps in this issue, but the next and previous buttons worked as expected, in version 2.0.172.33. http://crbug.com/6054 Please, stop mailing chromium-dev about individual bugs and just post comments (if they are useful) in the bugs themselves. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Issue Fixed status
Peter some times the issues hasn't an owner, so in this cases I can't simply answer in the issue. Like this: http://crbug.com/3078 On Jul 9, 2:43 pm, Thiago Farina thiago.far...@gmail.com wrote: Sorry I already deleted. On Jul 9, 2:42 pm, Peter Kasting pkast...@google.com wrote: On Thu, Jul 9, 2009 at 10:39 AM, Thiago Farina thiago.far...@gmail.comwrote: I reproduced the steps in this issue, but the next and previous buttons worked as expected, in version 2.0.172.33. http://crbug.com/6054 Please, stop mailing chromium-dev about individual bugs and just post comments (if they are useful) in the bugs themselves. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Issue Fixed status
So in the next cases, I will only comment in the issue, and wait for some answer. On Jul 9, 3:25 pm, Peter Kasting pkast...@google.com wrote: On Thu, Jul 9, 2009 at 11:21 AM, Thiago Farina thiago.far...@gmail.comwrote: Peter some times the issues hasn't an owner, so in this cases I can't simply answer in the issue. Like this:http://crbug.com/3078 It doesn't matter whether the issue has an owner. Eventually we will triage and note your comments. Mailing this list is sort of like trying to force us to triage the bug _now_, which is inefficient. Just let the various bug triagers get to your comments when they get to them. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Reviewers
Hi Dean, Thanks for commiting this patch to me. On Jul 8, 6:33 am, Dean McNamee de...@chromium.org wrote: I got it. Thanks On Wed, Jul 8, 2009 at 12:49 AM, Thiago Farinathiago.far...@gmail.com wrote: Lei can you review this patch for me? http://codereview.chromium.org/155078 On Jul 6, 11:56 pm, Lei Zhang thes...@chromium.org wrote: You didn't give enough context. It'll be more helpful if you put links to the patches you want reviewed. On Mon, Jul 6, 2009 at 7:47 PM, Thiago Farinathiago.far...@gmail.com wrote: When I don't know who can review some patch for me what I have to do? Currently I have 3 patchs waiting for review, but I haven't received any feedback or contact until now. What I have to do in this cases? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Issue Fixed status
I noticed that the Issue 7863, that me and jcampan, we fixed, are available until now. I saw there are some other Issues are with the status: Available, but already well fixed. So some issues are being fixed but are not being updated in the Issue List. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Chromium Teams
There is a place I can find a list which the teams of chromium and the names of their members? For example: UI Team: member's name; Extensions Team: member's name; Security Team:member's name; I'm asking this because I was writting a patch that changed the UI, and Glen said this have to be approved by UI team. So in this case for example, how should I proceed, how can I request approval for changes in UI? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Chromium Teams
I think it's good maintain the things simple, and I agree that all UI changes needs to be approved before starting code. Because I didn't know about that I started writting the patch without the approval. I think this feature is a good addition to chrome, because the firefox has this feature, many users from firefox will want this too in chrome. On Jul 9, 12:52 am, Glen Murphy g...@chromium.org wrote: I'm asking this because I was writting a patch that changed the UI, and Glen said this have to be approved by UI team. I am part of that team - the point was that UI changes should generally be run past the UI folk before work begins to avoid people doing work that is later rejected or that needs redesigning. That group of people is b...@chromium.org, g...@chromium.org, brakow...@chromium.org and nickb...@chromium.org - I am sending your screenshot from that patch to them to discuss. Typically we're pretty conservative when it comes to adding things. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Reviewers
Lei can you review this patch for me? http://codereview.chromium.org/155078 On Jul 6, 11:56 pm, Lei Zhang thes...@chromium.org wrote: You didn't give enough context. It'll be more helpful if you put links to the patches you want reviewed. On Mon, Jul 6, 2009 at 7:47 PM, Thiago Farinathiago.far...@gmail.com wrote: When I don't know who can review some patch for me what I have to do? Currently I have 3 patchs waiting for review, but I haven't received any feedback or contact until now. What I have to do in this cases? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Watchlist matching any part of a path
Interesting question. I have the same doubt. On Jul 7, 10:26 pm, Andrew Scherkus scher...@chromium.org wrote: Quick question because I have no clue where/how watchlists are implemented... According to the watchlist file, brettw is watching base from /src. kylep sent me a code review that only modifies touches files in /src/media/base, however brettw got added to the cc list. Is this intended behavior for watchlists or should they be more explicit on what they match? Thanks, Andrew --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Reviewers
Hi Lei, these are the patches that I have submitted: http://codereview.chromium.org/155060 http://codereview.chromium.org/155059 I have more but these two I have submitted three days ago. On Jul 6, 11:56 pm, Lei Zhang thes...@chromium.org wrote: You didn't give enough context. It'll be more helpful if you put links to the patches you want reviewed. On Mon, Jul 6, 2009 at 7:47 PM, Thiago Farinathiago.far...@gmail.com wrote: When I don't know who can review some patch for me what I have to do? Currently I have 3 patchs waiting for review, but I haven't received any feedback or contact until now. What I have to do in this cases? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Which means TBR and CL
In some reviews and patch I saw this abreviations, but I don't know what it means. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Some projects are always out of date
In my machine cygwin, ffmpeg_binaries, lastchange are always built when I click in F5 to start debugging chromium. But they don't take too long to be built. On Jul 5, 4:50 pm, Finnur Thorarinsson fin...@chromium.org wrote: Oh, right. When I look at the list of projects (from your email) again I realize that cygwin and lastchange are always built on my machine as well, but they take very little time to build. I don't see any ffmpeg projects getting built, though, and it certainly doesn't take a minute to build a small change, but then again I have a reasonably speedy machine. What project is taking a minute to build and what kind of hardware are you building on? Also, have you looked at the tips page on speeding up the build? I'd look it up for you, but I need to run... On Sun, Jul 5, 2009 at 12:37, tux316 tux...@gmail.com wrote: Those projects have their own custom build steps. So Visual Studio will always think that they are out of date, because those steps need to be called first. I am pretty sure this is normal, since it also happens with me and I use Visual Studio 2008. Hope that helps. - Juan Baez *From:* chromium-dev@googlegroups.com [mailto: chromium-...@googlegroups.com] *On Behalf Of *Finnur Thorarinsson *Sent:* Sunday, July 05, 2009 11:32 AM *To:* huas...@gmail.com *Cc:* Chromium-dev *Subject:* [chromium-dev] Re: Some projects are always out of date Yeah, I've had this happen a few times -- not these projects specifically, but for example when Visual Studio wants to build Webcore every time I make a change in the browser project. Most annoying, but usually it goes away if I rebuild. I would therefore suggest gclient sync and rebuild all. It will take some time, of course, so plan accordingly. :) On Fri, Jul 3, 2009 at 20:10, Hua huas...@gmail.com wrote: Hi, Every time I hit F5 in VS2005, it will pop up a dialog say: These projects are out of date: cygwin - Debug Win32 ffmpeg_binaries - Debug Win32 lastchange - Debug Win32 Would you like to build them? ... If I choose to build them, they will be built in a minute or so and then Chrome runs. But next time I hit F5 again (without any code changes), the same dialog will be shown again. Anyone else run into this? -- Hua --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] F5 Debug process
Anyone knows how to speed up the process of debugging chromium in Visual Studio 2008? Everytime I click in F5 to start debugging chromium it takes a long time to compile and build project test with him. How can I avoid the project tests like ipc_tests, interactive_ui_tests, perf_tests, etc, are compiled with chrome(exe) project? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: F5 Debug process
I was having exactly this problem. It this configuration now when I click F5 (with chrome as my startup project) they build only the project and dependencies, no more the projects tests. Thanks for your hint, it was exactly what I was looking for to avoid the compilation of project tests(that are not necessary for me to debug chromium). On Jul 3, 2:04 pm, Finnur Thorarinsson fin...@chromium.org wrote: I had a similar problem on VS 2005, maybe it is the same as yours. Turned out VS was set to build everything as opposed to just building what the project depended on. Not sure how to do it in VS2008, but in VS 2005, under Tools \ Options, go to: Projects and Solutions \ Build and Run Make sure Only build startup projects and dependencies on Run is checked. Then (if you make sure chrome is set as the startup project) it should not be building all those tests. Hope that helps. Finnur On Fri, Jul 3, 2009 at 09:32, Mohamed Mansour m...@chromium.org wrote: It depends on the machine you have. CPU power. HD etc. ... If you have incremental build turned on /MP it will take less time to compile as well. -- Mohamed Mansour On Fri, Jul 3, 2009 at 12:26 PM, PhistucK phist...@gmail.com wrote: At least in Visual Studio 2005, you can right click on the solution and in Configuration Options (or something like that), you can select what to build and what not to build.It does speed up the compiling process by at least half (for me). It still, generally, takes a lot of time. ☆PhistucK On Fri, Jul 3, 2009 at 19:21, Thiago Farina thiago.far...@gmail.comwrote: Anyone knows how to speed up the process of debugging chromium in Visual Studio 2008? Everytime I click in F5 to start debugging chromium it takes a long time to compile and build project test with him. How can I avoid the project tests like ipc_tests, interactive_ui_tests, perf_tests, etc, are compiled with chrome(exe) project? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Gmock compilation errors on VS2008SP1
I have the same problem with tuple. On Jun 15, 1:24 pm, Marc-Antoine Ruel mar...@chromium.org wrote: I'm fine with that if necessary. On Mon, Jun 15, 2009 at 12:11 PM, Albert J. Wong(王重傑)ajw...@chromium.org wrote: On Mon, Jun 15, 2009 at 9:03 AM, nakro yoav.zilberb...@gmail.com wrote: Hi albret, projects that fail : gmockj gmockmain here is an example out from gmockmain C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(498) : error C2065: '_Is_swap_move' : undeclared identifier 1 C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple (504) : see reference to class template instantiation 'std::_Move_operation_categorystd::tr1::tuple_Arg0,_Arg1,_Arg2,_Arg3,_Arg 4,_Arg5,_Arg6,_Arg7,_Arg8,_Arg9' being compiled 1C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(499) : error C2226: syntax error : unexpected type 'std::_Move_operation_category_Value::_Move_cat' 1C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(503) : error C2947: expecting '' to terminate template-argument-list, found '' 1C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(503) : error C2976: 'std::_If' : too few template arguments 1 C:\Program Files\Microsoft Visual Studio 9.0\VC\include \xutility(1018) : see declaration of 'std::_If' the solution on my machine is this to do HAS_TR1=0 (you have 1 by default) and to change gmock_port.h to include the boost version even on 2008, which initially your code goes to the tuple path That's a good workaround. Switching to the boost implementation would almost certainly work for now. I'll attempt to reproduce and figure out a long term fix (including just whacking the tr1 dependency out of gmock...started a discussion with zhanyong about this last week). If it gets bad enough, we could consider changing over the VS2008 builds to use boost as well, and then disable _HAS_TR1 as you described above, but that'll require a full clobber from everyone due to precompiled header issues. -Albert but i must have something wrong with my machine if i am the only one who is having this --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
