[chromium-dev] Re: Change to default build architecture

2009-10-20 Thread Ben Laurie

On Fri, Oct 16, 2009 at 1:28 AM, Michael Moss mm...@chromium.org wrote:

 http://codereview.chromium.org/271113 may require a clobber for Linux
 builds.

I should belatedly observe that the Linux make build, at least, is
supposed to detect command line changes and so should not need a
clobber. If anyone had to, I'd be interested to know what broke.

 The default build used to be 32-bit, but it will now be
 whatever your build host architecture is. If you are on a 64-bit
 machine, and haven't explicitly been setting 'target_arch' in gyp,
 your build will switch from 32-bit to 64-bit. If this breaks anything,
 clobbering or moving your existing build directory should fix it.

 If you want to continue building 32-bit on 64-bit hosts, you can force
 it by setting GYP_DEFINES=target_arch=ia32 in the environment.

 Michael

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Change to default build architecture

2009-10-19 Thread Issac



On Oct 15, 9:27 pm, Antoine Labour pi...@google.com wrote:
 On Thu, Oct 15, 2009 at 9:04 PM, Michael Moss mm...@chromium.org wrote:

  On Thu, Oct 15, 2009 at 8:59 PM, Fumitoshi Ukai (鵜飼文敏)
  u...@chromium.org wrote:
   On x86_64 machine, I couldn't build even if I clobber..

   /usr/bin/ld: skipping incompatible

  /usr/local/google/home/ukai/src/chromium1/src/sconsbuild/Release/lib/libnpG 
  oogleNaClPluginChrome.a
   when searching for -lnpGoogleNaClPluginChrome
   /usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
   collect2: ld returned 1 exit status

   Is this known issue?
   It is fine with GYP_DEFINES=target_arch=ia32, of course.

  I haven't looked into it yet, but NaCl apparently has it's own notion
  of target_arch. For now, the best bet is probably explicitly setting
  GYP_DEFINES as you're doing.

  Michael

 You can also disable NaCl with disable_nacl=1 in GYP_DEFINES.

I tried both ideas

GYP_DEFINES=disable_nacl=1 hammer chrome
GYP_DEFINES=target_arch=ia32 hammer chrome

but got the same error in both cases: /usr/bin/ld: cannot find -
lnpGoogleNaClPluginChrome.

In src/build/common.gypi I made this change

-'disable_nacl%': 0,
+'disable_nacl%': 1,

and ran rm -rf src/sconsbuild/Debug/   followed by  hammer chrome. It
still fails with

Copying /usr/local/google/home/issactrotts/dev/home/chrome-svn/tarball/
chromium/src/sconsbuild/Debug/obj/chrome/_chrome_intermediate/repack/
id.pak to /usr/local/google/home/issactrotts/dev/home/chrome-svn/
tarball/chromium/src/sconsbuild/Debug/locales/id.pak ...
/usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
collect2: ld returned 1 exit status

I'll keep looking...




--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Change to default build architecture

2009-10-19 Thread Thomas Van Lenten
You need it defined when doing the gclient sync/runhooks, not when building.
TVL


On Sun, Oct 18, 2009 at 12:46 AM, Issac issac.tro...@gmail.com wrote:




 On Oct 15, 9:27 pm, Antoine Labour pi...@google.com wrote:
  On Thu, Oct 15, 2009 at 9:04 PM, Michael Moss mm...@chromium.org
 wrote:
 
   On Thu, Oct 15, 2009 at 8:59 PM, Fumitoshi Ukai (鵜飼文敏)
   u...@chromium.org wrote:
On x86_64 machine, I couldn't build even if I clobber..
 
/usr/bin/ld: skipping incompatible
 
  
 /usr/local/google/home/ukai/src/chromium1/src/sconsbuild/Release/lib/libnpG
 oogleNaClPluginChrome.a
when searching for -lnpGoogleNaClPluginChrome
/usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
collect2: ld returned 1 exit status
 
Is this known issue?
It is fine with GYP_DEFINES=target_arch=ia32, of course.
 
   I haven't looked into it yet, but NaCl apparently has it's own notion
   of target_arch. For now, the best bet is probably explicitly setting
   GYP_DEFINES as you're doing.
 
   Michael
 
  You can also disable NaCl with disable_nacl=1 in GYP_DEFINES.

 I tried both ideas

 GYP_DEFINES=disable_nacl=1 hammer chrome
 GYP_DEFINES=target_arch=ia32 hammer chrome

 but got the same error in both cases: /usr/bin/ld: cannot find -
 lnpGoogleNaClPluginChrome.

 In src/build/common.gypi I made this change

 -'disable_nacl%': 0,
 +'disable_nacl%': 1,

 and ran rm -rf src/sconsbuild/Debug/   followed by  hammer chrome. It
 still fails with

 Copying /usr/local/google/home/issactrotts/dev/home/chrome-svn/tarball/
 chromium/src/sconsbuild/Debug/obj/chrome/_chrome_intermediate/repack/
 id.pak to /usr/local/google/home/issactrotts/dev/home/chrome-svn/
 tarball/chromium/src/sconsbuild/Debug/locales/id.pak ...
 /usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
 collect2: ld returned 1 exit status

 I'll keep looking...




 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Change to default build architecture

2009-10-16 Thread Lei Zhang

On Thu, Oct 15, 2009 at 5:28 PM, Michael Moss mm...@chromium.org wrote:
 If you want to continue building 32-bit on 64-bit hosts, you can force
 it by setting GYP_DEFINES=target_arch=ia32 in the environment.

FYI, I think $GYP_DEFINES overrides ~/.gyp/includes.gypi. You may get
unexpected results if you are using both of these.

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Change to default build architecture

2009-10-15 Thread 鵜飼文敏

On x86_64 machine, I couldn't build even if I clobber..

/usr/bin/ld: skipping incompatible
/usr/local/google/home/ukai/src/chromium1/src/sconsbuild/Release/lib/libnpGoogleNaClPluginChrome.a
when searching for -lnpGoogleNaClPluginChrome
/usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
collect2: ld returned 1 exit status

Is this known issue?
It is fine with GYP_DEFINES=target_arch=ia32, of course.

-- 
ukai

On Fri, Oct 16, 2009 at 9:28 AM, Michael Moss mm...@chromium.org wrote:

 http://codereview.chromium.org/271113 may require a clobber for Linux
 builds. The default build used to be 32-bit, but it will now be
 whatever your build host architecture is. If you are on a 64-bit
 machine, and haven't explicitly been setting 'target_arch' in gyp,
 your build will switch from 32-bit to 64-bit. If this breaks anything,
 clobbering or moving your existing build directory should fix it.

 If you want to continue building 32-bit on 64-bit hosts, you can force
 it by setting GYP_DEFINES=target_arch=ia32 in the environment.

 Michael

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Change to default build architecture

2009-10-15 Thread Michael Moss

On Thu, Oct 15, 2009 at 8:59 PM, Fumitoshi Ukai (鵜飼文敏)
u...@chromium.org wrote:
 On x86_64 machine, I couldn't build even if I clobber..

 /usr/bin/ld: skipping incompatible
 /usr/local/google/home/ukai/src/chromium1/src/sconsbuild/Release/lib/libnpGoogleNaClPluginChrome.a
 when searching for -lnpGoogleNaClPluginChrome
 /usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
 collect2: ld returned 1 exit status

 Is this known issue?
 It is fine with GYP_DEFINES=target_arch=ia32, of course.

I haven't looked into it yet, but NaCl apparently has it's own notion
of target_arch. For now, the best bet is probably explicitly setting
GYP_DEFINES as you're doing.

Michael


 On Fri, Oct 16, 2009 at 9:28 AM, Michael Moss mm...@chromium.org wrote:

 http://codereview.chromium.org/271113 may require a clobber for Linux
 builds. The default build used to be 32-bit, but it will now be
 whatever your build host architecture is. If you are on a 64-bit
 machine, and haven't explicitly been setting 'target_arch' in gyp,
 your build will switch from 32-bit to 64-bit. If this breaks anything,
 clobbering or moving your existing build directory should fix it.

 If you want to continue building 32-bit on 64-bit hosts, you can force
 it by setting GYP_DEFINES=target_arch=ia32 in the environment.

 Michael

 



--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Change to default build architecture

2009-10-15 Thread Antoine Labour
On Thu, Oct 15, 2009 at 9:04 PM, Michael Moss mm...@chromium.org wrote:


 On Thu, Oct 15, 2009 at 8:59 PM, Fumitoshi Ukai (鵜飼文敏)
 u...@chromium.org wrote:
  On x86_64 machine, I couldn't build even if I clobber..
 
  /usr/bin/ld: skipping incompatible
 
 /usr/local/google/home/ukai/src/chromium1/src/sconsbuild/Release/lib/libnpGoogleNaClPluginChrome.a
  when searching for -lnpGoogleNaClPluginChrome
  /usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
  collect2: ld returned 1 exit status
 
  Is this known issue?
  It is fine with GYP_DEFINES=target_arch=ia32, of course.

 I haven't looked into it yet, but NaCl apparently has it's own notion
 of target_arch. For now, the best bet is probably explicitly setting
 GYP_DEFINES as you're doing.

 Michael


You can also disable NaCl with disable_nacl=1 in GYP_DEFINES.

Antoine





  On Fri, Oct 16, 2009 at 9:28 AM, Michael Moss mm...@chromium.org
 wrote:
 
  http://codereview.chromium.org/271113 may require a clobber for Linux
  builds. The default build used to be 32-bit, but it will now be
  whatever your build host architecture is. If you are on a 64-bit
  machine, and haven't explicitly been setting 'target_arch' in gyp,
  your build will switch from 32-bit to 64-bit. If this breaks anything,
  clobbering or moving your existing build directory should fix it.
 
  If you want to continue building 32-bit on 64-bit hosts, you can force
  it by setting GYP_DEFINES=target_arch=ia32 in the environment.
 
  Michael
 
  
 
 

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---