[chromium-dev] Re: FAIL not catching image failures

2009-10-02 Thread Stephen White
I think that's a Release builder, and the tests are marked DEBUG, no?
Stephen

On Fri, Oct 2, 2009 at 12:34 PM, Avi Drissman a...@google.com wrote:

 Latest Mac pixel test result is here:
 http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Mac10.5/builds/4420/steps/webkit_tests/logs/stdio
 :

 Regressions: Unexpected failures (2):
   LayoutTests/svg/custom/js-late-marker-and-object-creation.svg = FAIL
   LayoutTests/svg/hixie/error/012.xml = FAIL

 Those are both image mismatches, but are both accounted for in the
 expectations file:

 // Flaky. The width of containing RenderBlocks sometimes becomes larger
 BUG21958 WIN MAC LINUX DEBUG : LayoutTests/svg/hixie/error/012.xml = FAIL
 PASS


 and

 // Regressions from WebKit Merge 42932:42994
 BUG11239 MAC DEBUG :
 LayoutTests/svg/custom/js-late-marker-and-object-creation.svg = FAIL PASS


 Why is the FAIL in those lines not catching the image failure?

 Avi

 



-- 
All truth passes through three stages. First, it is ridiculed. Second, it is
violently opposed. Third, it is accepted as being self-evident. --
Schopenhauer

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: FAIL not catching image failures

2009-10-02 Thread Dirk Pranke

Stephen's right; if that doesn't fix things, let me know and I'll look at it.

-- Dirk

On Fri, Oct 2, 2009 at 9:59 AM, Stephen White senorbla...@chromium.org wrote:
 I think that's a Release builder, and the tests are marked DEBUG, no?
 Stephen

 On Fri, Oct 2, 2009 at 12:34 PM, Avi Drissman a...@google.com wrote:

 Latest Mac pixel test result is here:
 http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Mac10.5/builds/4420/steps/webkit_tests/logs/stdio:

 Regressions: Unexpected failures (2):
   LayoutTests/svg/custom/js-late-marker-and-object-creation.svg = FAIL
   LayoutTests/svg/hixie/error/012.xml = FAIL

 Those are both image mismatches, but are both accounted for in the
 expectations file:

 // Flaky. The width of containing RenderBlocks sometimes becomes larger
 BUG21958 WIN MAC LINUX DEBUG : LayoutTests/svg/hixie/error/012.xml = FAIL
 PASS

 and

 // Regressions from WebKit Merge 42932:42994
 BUG11239 MAC DEBUG :
 LayoutTests/svg/custom/js-late-marker-and-object-creation.svg = FAIL PASS

 Why is the FAIL in those lines not catching the image failure?

 Avi

 



 --
 All truth passes through three stages. First, it is ridiculed. Second, it is
 violently opposed. Third, it is accepted as being self-evident. --
 Schopenhauer


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---