[chromium-dev] Re: Mac painting problems

[Nirnimesh]

r18363 introduced mem leaks in test_shell_tests and unit_tests.
It would be nice if they get sorted out with this too.

http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/1084/steps/valgrind%20test%3A%20test_shell/logs/stdio
http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/1084/steps/valgrind%20test%3A%20unit/logs/stdio


On Mon, Jun 15, 2009 at 10:08 PM, Mark Mentovai m...@chromium.org wrote:

 I see the problem here, I'll fix it.


 



-- 
../NiR

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Mac painting problems

[Mohamed Mansour]

I am not a mac person but since you cleaned
up:PlatformCanvasMac::Initialize(int
width, int height, bool is_opaque, int8_t* data)

to  call:
BitmapPlatformDevice::Create(NULL, width, height, is_opaque)

I have looked inside that function:
BitmapPlatformDevice::Create(CGContextRef context, int width, int height,
bool is_opaque)

And its doing:
if (!context) {
...
// Change the coordinate system to match WebCore's
CGContextTranslateCTM(context, 0, height);
CGContextScaleCTM(context, 1.0, -1.0);
CGColorSpaceRelease(color_space);
  }

Whereas the previous change was:
if (!context)
  return false;

// Change the coordinate system to match WebCore's
CGContextTranslateCTM(context, 0, height);
CGContextScaleCTM(context, 1.0, -1.0);

I don't have chromium installed on my mac (only win/linux) so I can't test.
I might be totally wrong.

-- Mohamed Mansour


On Sun, Jun 14, 2009 at 1:21 PM, Brett Wilson bre...@chromium.org wrote:


 I was informed that I may have broken mac tab contents painting in
 18363. I have to leave now, so if this is causing you problems you can
 back me out.

 If somebody wants to fix it instead, I'll make you chocolate chip cookies
 :)

 Brett

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---