[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit
Hi, LayoutTests has been moved from webkit/data to third_party/WebKit. You should sync your client and do the following after sync: -. If your client excludes LayoutTests, remove the following line from .gclient file after sync. No need to have the old one anymore. src/webkit/data/layout_tests/LayoutTests: None, You still need this line: src/third_party/WebKit/LayoutTests: None, -. If your client includes LayoutTests, manually remove directory src/webkit/data/layout_tests/LayoutTests to save space. I also updated the developer docs that will be affected by this change. If I miss any docs, feel free to change them from webkit/data/layout_tests/LayoutTests to third_party/WebKit/LayoutTests. Let me know if you have any questions. Thanks, Victor On Fri, Jul 10, 2009 at 1:31 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: Right. Victor is just switching the tests to reside where they needed to be, not dealing with test results. Test results is somewhat of a longer story and we're not tackling this yet. :DG On Fri, Jul 10, 2009 at 12:07 PM, Victor Wangvict...@chromium.org wrote: On Fri, Jul 10, 2009 at 11:11 AM, Ryosuke Niwa rn...@google.com wrote: On Thu, Jul 9, 2009 at 3:09 PM, Victor Wang vict...@chromium.org wrote: If you DO NOT check out chromium source code, you can stop reading. What's the change? To reduce people's confusion about the LayoutTests directory, I am moving it from src/webkit/data/layout_tests/LayoutTests to src/third_party/WebKit/LayoutTests. For details of this request, see issue: http://code.google.com/p/chromium/issues/detail?id=8765 Does this mean that in the future, all expected results will be in WebKit? i.e. we no longer need to update Chromium tree whenever WebKit changes expected results. I think eventually we will get rid of chrome and upstream platform. For now, I just move the LayoutTests directory. Ojan or Dimitri can correct me if I am wrong. Ryosuke --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit
On Mon, Jul 13, 2009 at 1:45 PM, Victor Wang vict...@chromium.org wrote: LayoutTests has been moved from webkit/data to third_party/WebKit. You should sync your client and do the following after sync: Reminder: if you don't have layout tests in your client, *before sync* you need to add: src/third_party/WebKit/LayoutTests: None, ...to your custom_deps section. There isn't some kind of system that does this for you automatically. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit
Since Subversion checkouts are hermetic, you can save yourself a ton time if you manually move your LayoutTest directory to the new location before running gclient sync. On Mon, Jul 13, 2009 at 5:05 PM, Peter Kasting pkast...@google.com wrote: On Mon, Jul 13, 2009 at 1:45 PM, Victor Wang vict...@chromium.org wrote: LayoutTests has been moved from webkit/data to third_party/WebKit. You should sync your client and do the following after sync: Reminder: if you don't have layout tests in your client, *before sync* you need to add: src/third_party/WebKit/LayoutTests: None, ...to your custom_deps section. There isn't some kind of system that does this for you automatically. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit
On Fri, Jul 10, 2009 at 11:11 AM, Ryosuke Niwa rn...@google.com wrote: On Thu, Jul 9, 2009 at 3:09 PM, Victor Wang vict...@chromium.org wrote: If you DO NOT check out chromium source code, you can stop reading. *What's the change?* To reduce people's confusion about the LayoutTests directory, I am moving it from *src/webkit/data/layout_tests/LayoutTests* to * src/third_party/WebKit/**LayoutTests*. For details of this request, see issue: http://code.google.com/p/chromium/issues/detail?id=8765 Does this mean that in the future, all expected results will be in WebKit? i.e. we no longer need to update Chromium tree whenever WebKit changes expected results. I think eventually we will get rid of chrome and upstream platform. For now, I just move the LayoutTests directory. Ojan or Dimitri can correct me if I am wrong. Ryosuke --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit
Right. Victor is just switching the tests to reside where they needed to be, not dealing with test results. Test results is somewhat of a longer story and we're not tackling this yet. :DG On Fri, Jul 10, 2009 at 12:07 PM, Victor Wangvict...@chromium.org wrote: On Fri, Jul 10, 2009 at 11:11 AM, Ryosuke Niwa rn...@google.com wrote: On Thu, Jul 9, 2009 at 3:09 PM, Victor Wang vict...@chromium.org wrote: If you DO NOT check out chromium source code, you can stop reading. What's the change? To reduce people's confusion about the LayoutTests directory, I am moving it from src/webkit/data/layout_tests/LayoutTests to src/third_party/WebKit/LayoutTests. For details of this request, see issue: http://code.google.com/p/chromium/issues/detail?id=8765 Does this mean that in the future, all expected results will be in WebKit? i.e. we no longer need to update Chromium tree whenever WebKit changes expected results. I think eventually we will get rid of chrome and upstream platform. For now, I just move the LayoutTests directory. Ojan or Dimitri can correct me if I am wrong. Ryosuke --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit
On Thu, Jul 9, 2009 at 3:09 PM, Victor Wang vict...@chromium.org wrote: If you DO NOT check out chromium source code, you can stop reading. *What's the change?* To reduce people's confusion about the LayoutTests directory, I am moving it from *src/webkit/data/layout_tests/LayoutTests* to * src/third_party/WebKit/**LayoutTests*. For details of this request, see issue: http://code.google.com/p/chromium/issues/detail?id=8765 Does this mean that in the future, all expected results will be in WebKit? i.e. we no longer need to update Chromium tree whenever WebKit changes expected results. Ryosuke --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
