[chromium-dev] Re: Naming things _views
Does this mean we can do something similar for GTK? It feels a bit unfair that we have to name everything browser/gtk/blah_gtk.cc and BrowserToolbarGtk, etc, while views gets the short name. For example views: views/info_bubble.cc and class name InfoBubble gtk: gtk/info_bubble_gtk.cc and class name InfoBubbleGtk On Thu, Jun 11, 2009 at 7:45 AM, Ben Goodger (Google)b...@chromium.org wrote: If you're porting a file in the browser/ directory and going to be renaming a file foo _views.cc/h, consider just moving the file into browser/views and not renaming it. -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Naming things _views
sure why not... the _platform suffix is supposed to be for files in a location where multiple platfomrs are built. -Ben On Thu, Jun 11, 2009 at 2:47 AM, Dean McNameede...@chromium.org wrote: Does this mean we can do something similar for GTK? It feels a bit unfair that we have to name everything browser/gtk/blah_gtk.cc and BrowserToolbarGtk, etc, while views gets the short name. For example views: views/info_bubble.cc and class name InfoBubble gtk: gtk/info_bubble_gtk.cc and class name InfoBubbleGtk On Thu, Jun 11, 2009 at 7:45 AM, Ben Goodger (Google)b...@chromium.org wrote: If you're porting a file in the browser/ directory and going to be renaming a file foo _views.cc/h, consider just moving the file into browser/views and not renaming it. -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Naming things _views
So the class name is the same too in this case? (InfoBubble and InfoBubble) Erik On Thu, Jun 11, 2009 at 10:46 AM, Ben Goodger (Google) b...@chromium.orgwrote: sure why not... the _platform suffix is supposed to be for files in a location where multiple platfomrs are built. -Ben On Thu, Jun 11, 2009 at 2:47 AM, Dean McNameede...@chromium.org wrote: Does this mean we can do something similar for GTK? It feels a bit unfair that we have to name everything browser/gtk/blah_gtk.cc and BrowserToolbarGtk, etc, while views gets the short name. For example views: views/info_bubble.cc and class name InfoBubble gtk: gtk/info_bubble_gtk.cc and class name InfoBubbleGtk On Thu, Jun 11, 2009 at 7:45 AM, Ben Goodger (Google)b...@chromium.org wrote: If you're porting a file in the browser/ directory and going to be renaming a file foo _views.cc/h, consider just moving the file into browser/views and not renaming it. -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Naming things _views
Well, class name is supposed to match the file name in Google style. -Ben On Thu, Jun 11, 2009 at 11:22 AM, Erik Kayerik...@chromium.org wrote: So the class name is the same too in this case? (InfoBubble and InfoBubble) Erik On Thu, Jun 11, 2009 at 10:46 AM, Ben Goodger (Google) b...@chromium.org wrote: sure why not... the _platform suffix is supposed to be for files in a location where multiple platfomrs are built. -Ben On Thu, Jun 11, 2009 at 2:47 AM, Dean McNameede...@chromium.org wrote: Does this mean we can do something similar for GTK? It feels a bit unfair that we have to name everything browser/gtk/blah_gtk.cc and BrowserToolbarGtk, etc, while views gets the short name. For example views: views/info_bubble.cc and class name InfoBubble gtk: gtk/info_bubble_gtk.cc and class name InfoBubbleGtk On Thu, Jun 11, 2009 at 7:45 AM, Ben Goodger (Google)b...@chromium.org wrote: If you're porting a file in the browser/ directory and going to be renaming a file foo _views.cc/h, consider just moving the file into browser/views and not renaming it. -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Naming things _views
FWIW, we don't use _cocoa or _mac in browser/cocoa at all, assuming it was implied. I assumed gtk was doing the same. On Thu, Jun 11, 2009 at 11:53 AM, Ben Goodger (Google)b...@chromium.org wrote: Well, class name is supposed to match the file name in Google style. -Ben On Thu, Jun 11, 2009 at 11:22 AM, Erik Kayerik...@chromium.org wrote: So the class name is the same too in this case? (InfoBubble and InfoBubble) Erik On Thu, Jun 11, 2009 at 10:46 AM, Ben Goodger (Google) b...@chromium.org wrote: sure why not... the _platform suffix is supposed to be for files in a location where multiple platfomrs are built. -Ben On Thu, Jun 11, 2009 at 2:47 AM, Dean McNameede...@chromium.org wrote: Does this mean we can do something similar for GTK? It feels a bit unfair that we have to name everything browser/gtk/blah_gtk.cc and BrowserToolbarGtk, etc, while views gets the short name. For example views: views/info_bubble.cc and class name InfoBubble gtk: gtk/info_bubble_gtk.cc and class name InfoBubbleGtk On Thu, Jun 11, 2009 at 7:45 AM, Ben Goodger (Google)b...@chromium.org wrote: If you're porting a file in the browser/ directory and going to be renaming a file foo _views.cc/h, consider just moving the file into browser/views and not renaming it. -Ben -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
