[chromium-dev] Re: question about helpwanted items (how it works)
http://codereview.chromium.org/147200 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
http://codereview.chromium.org/147202 (i didn't know how to use gcl properly, so i re-submitted and deleted the prev issue, prev was only up for a very short while) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
Thanks for writing this! I would personally use this feature frequently. The code looks good too. On Fri, Jun 26, 2009 at 4:35 AM, nakroyoav.zilberb...@gmail.com wrote: http://codereview.chromium.org/147202 (i didn't know how to use gcl properly, so i re-submitted and deleted the prev issue, prev was only up for a very short while) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
Yeah, this is great, thanks. On Fri, Jun 26, 2009 at 5:28 PM, Evan Martine...@chromium.org wrote: Thanks for writing this! I would personally use this feature frequently. The code looks good too. On Fri, Jun 26, 2009 at 4:35 AM, nakroyoav.zilberb...@gmail.com wrote: http://codereview.chromium.org/147202 (i didn't know how to use gcl properly, so i re-submitted and deleted the prev issue, prev was only up for a very short while) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
It means that it is a good bug to send patches for, that will not be fixed soon by a Chromium developer. If you want to start handling it, you should post a message to chromium-dev, after you briefly thought about how to implement it and show some kind of a brief design document, if needed, or just write briefly about the way you are going to implement it. If it is a small code change and nothing big, you can simply send a patch, but it is always good to announce here or in the bug itself (or both?) that you are starting to work on it, so it will be marked as Started and so that the work will not be duplicated (even among contributors). ☆PhistucK On Thu, Jun 25, 2009 at 13:37, nakro yoav.zilberb...@gmail.com wrote: when you mark an itemm as helpWanted, how is it supposed to work from there ? for example, i replied to http://code.google.com/p/chromium/issues/detail?id=6383 a week ago, saying i want to do it and got to response or do you expect one to submit code for review and link it to the help wanted item ? (btw, if you will respond to this, i prefer Ctrl+Shift for text only zoom) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
On Thu, Jun 25, 2009 at 3:37 AM, nakroyoav.zilberb...@gmail.com wrote: when you mark an itemm as helpWanted, how is it supposed to work from there ? If it's an obvious bug, like page fails to scroll if screen is in 16 bit color mode, then you can just comment on the bug that you're looking into it and then submit a patch. If it's a larger design issue, or feature request that changes the UI, it's good to bring it up on chromium-dev for discussion. Which you've done. :) for example, i replied to http://code.google.com/p/chromium/issues/detail?id=6383 a week ago, saying i want to do it and got to response If someone else was thinking about working on that bug, they would now look at it and see that you had mentioned you were working on it. They would then likely ask you if you were still working on it, or if you had given up and forgotten to update the bug. So it's effectively yours to work on, now. (btw, if you will respond to this, i prefer Ctrl+Shift for text only zoom) The options, from the bug, are Ctrl+Alt or Ctrl+Shift. I don't know how we'd choose, so I'd just pick one for your patch, implement it, and if there's a reason to change it it'd be pretty easy to switch. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
I agree, but no browser has a keyboard shortcut for this what FF and Safari have is a menu option to change the behavior of Zoom (via a check box) and IE only does full page zoom since chrome is so religious about minimal UI, i thought to have these options with no UI at all but i can easily add this feature to windows if needed but i think it makes more sense to have both options available via the keyboard as some pages are better for Full page zoom, while others look better with text only zoom but whatever you chose is fine by me, --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
I wasn't suggesting we should add a UI in addition/instead of a keyboard modifier. Since there is no standard modifier you should do as Evan suggested an just pick one. We can always change it. On Thu, Jun 25, 2009 at 08:14, nakro yoav.zilberb...@gmail.com wrote: I agree, but no browser has a keyboard shortcut for this what FF and Safari have is a menu option to change the behavior of Zoom (via a check box) and IE only does full page zoom since chrome is so religious about minimal UI, i thought to have these options with no UI at all but i can easily add this feature to windows if needed but i think it makes more sense to have both options available via the keyboard as some pages are better for Full page zoom, while others look better with text only zoom but whatever you chose is fine by me, --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
In any case, make sure to ping the @chromium.org person that added the HelpWanted flag! M-A On Thu, Jun 25, 2009 at 11:29 AM, Finnur Thorarinssonfin...@chromium.org wrote: I wasn't suggesting we should add a UI in addition/instead of a keyboard modifier. Since there is no standard modifier you should do as Evan suggested an just pick one. We can always change it. On Thu, Jun 25, 2009 at 08:14, nakro yoav.zilberb...@gmail.com wrote: I agree, but no browser has a keyboard shortcut for this what FF and Safari have is a menu option to change the behavior of Zoom (via a check box) and IE only does full page zoom since chrome is so religious about minimal UI, i thought to have these options with no UI at all but i can easily add this feature to windows if needed but i think it makes more sense to have both options available via the keyboard as some pages are better for Full page zoom, while others look better with text only zoom but whatever you chose is fine by me, --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
