If that was not enough of a trick question:
Suppose you checkin with 5 other people at the same time, and the tree goes
red as a consequence of that group's landing, but you are "sure" you didn't
break the tree. Are YOU responsible to help fix it?
Answer: *YES*, you are responsible.
For me, all too often (surely more than once) I've been dead sure,
absolutely sure, positively sure, it was not me.... but it WAS me.
When the tree goes red, it is the responsibility of ALL persons that
committed in that group to repair the tree, or to talk to each other *and*
the sheriff.
It is not the sheriff's job to revert.... The sheriff is the fallback, when
for good or bad reasons engineers drop the ball, and shirk their
responsibility.
If you're part of a group that adds color to the tree, and you don't *offer*
to revert, and explain (and convince other's) that it wasn't you, then you
are adding to the pile up. Not talking, explaining, and hanging around ends
up causing other folks (including clueless sheriffs like me) to spend a lot
of time evaluating your patch vs the others in your group. By not talking,
by not watching, by not helping to clear the redness, an engineer makes the
repair take longer. (...and of course, makes it ... er... um.... less
pleasant to be a sheriff).
If you don't have enough time to hang out, and wait till the FULL impact
(not just compilation) is seen in the tree, then get a buddy (or someone on
IRC?) to take help you fulfill your responsibility, or just wait till later
to land.
Please fly and land responsibly.
Thanks,
Jim (today's sheriff... but hopefully speaking of behalf of all sheriffs)
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
