Re: [chrony-users] libedit 20180525-3.1 escapes spaces in tab-completion

2018-06-11 Thread Lonnie Abelbeck


> On Jun 11, 2018, at 2:04 AM, Miroslav Lichvar  wrote:
> 
> On Fri, Jun 08, 2018 at 06:16:57PM -0500, Lonnie Abelbeck wrote:
>> Hi,
>> 
>> Our project did a version bump of libedit to 20180525-3.1 and noticed spaces 
>> are now being escaped with a backslash with chronyc's tab-completion.
> 
> Interesting.
> 
>> The change occurred with libedit revision 1.47 2017/10/15
>> http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/filecomplete.c.diff?r1=1.46=1.47
>> 
>> I took a stab at a fix by patching CPS_NormalizeLine() ...
> 
> I think the fix should be closer to the readline/editline-specific
> code.

I agree, if possible.

> Maybe there is an option to disable the new behavior?

I looked, and don't see an editline global option for this new feature.

In chronyc, the minimal code added for tab-completion is leveraged by using the 
filecomplete.c routines.

The question is, for chronyc should '\ ' input be handled as a ' ' or present 
an error.  Possibly a '\ ' could occur in other external ways ?

Lonnie


--
To unsubscribe email chrony-users-requ...@chrony.tuxfamily.org
with "unsubscribe" in the subject.
For help email chrony-users-requ...@chrony.tuxfamily.org
with "help" in the subject.
Trouble?  Email listmas...@chrony.tuxfamily.org.



Re: [chrony-users] libedit 20180525-3.1 escapes spaces in chronyc tab-completion

2018-06-11 Thread Miroslav Lichvar
On Fri, Jun 08, 2018 at 06:16:57PM -0500, Lonnie Abelbeck wrote:
> Hi,
> 
> Our project did a version bump of libedit to 20180525-3.1 and noticed spaces 
> are now being escaped with a backslash with chronyc's tab-completion.

Interesting.

> The change occurred with libedit revision 1.47 2017/10/15
> http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/filecomplete.c.diff?r1=1.46=1.47
> 
> I took a stab at a fix by patching CPS_NormalizeLine() ...

I think the fix should be closer to the readline/editline-specific
code. Maybe there is an option to disable the new behavior?

-- 
Miroslav Lichvar

-- 
To unsubscribe email chrony-users-requ...@chrony.tuxfamily.org 
with "unsubscribe" in the subject.
For help email chrony-users-requ...@chrony.tuxfamily.org 
with "help" in the subject.
Trouble?  Email listmas...@chrony.tuxfamily.org.