[Cin] Update: I tried to restore "Warn on EDL version mismatch' preference setting
There is much simpler version
diff --git a/cinelerra-5.1/cinelerra/mwindow.C
b/cinelerra-5.1/cinelerra/mwindow.C
index 04549fde..ded1603e 100644
--- a/cinelerra-5.1/cinelerra/mwindow.C
+++ b/cinelerra-5.1/cinelerra/mwindow.C
@@ -2211,8 +2211,9 @@ if(debug) printf("MWindow::load_filenames %d\n",
__LINE__);
if( strcmp(cin_version, CINELERRA_VERSION) &&
strcmp(cin_version, "Unify") &&
strcmp(cin_version, "5.1") ) {
+ if (preferences->warn_version)
eprintf(_("Warning: XML from cinelerra version
%s\n"
- "Session data may be incompatible."),
cin_version);
+"Session data may be incompatible."),
cin_version);
}
if( new_edl->load_xml(_file, LOAD_ALL) ) {
eprintf(_("Error: unable to load:\n %s"),
filename);
With this patch it shows warning in same window where plugin mismatch warn
shows it,
so it remain more compact..
Again, not sure if we want to extend or repair or remove this *toggle*
altogether .
I think this warning can be set to 'always display' now, when it doesn't spawn
their own window.
PS: My non-loading old project was simply because by now CinGG tries to 'Create
resources only' first
I switched it back to loading/replacing current proj, and it showed up.
diff --git a/cinelerra-5.1/cinelerra/mwindow.C b/cinelerra-5.1/cinelerra/mwindow.C
index 04549fde..ded1603e 100644
--- a/cinelerra-5.1/cinelerra/mwindow.C
+++ b/cinelerra-5.1/cinelerra/mwindow.C
@@ -2211,8 +2211,9 @@ if(debug) printf("MWindow::load_filenames %d\n", __LINE__);
if( strcmp(cin_version, CINELERRA_VERSION) &&
strcmp(cin_version, "Unify") &&
strcmp(cin_version, "5.1") ) {
+if (preferences->warn_version)
eprintf(_("Warning: XML from cinelerra version %s\n"
- "Session data may be incompatible."), cin_version);
+"Session data may be incompatible."), cin_version);
}
if( new_edl->load_xml(_file, LOAD_ALL) ) {
eprintf(_("Error: unable to load:\n %s"), filename);
--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin
[Cin] I tried to restore "Warn on EDL version mismatch' preference setting
I tested with with artificially modified project file (changed version to 5.0)
it seems to work, and now this psecific warning show up depending on
preferences setting/toggle.
---
diff --git a/cinelerra-5.1/cinelerra/mwindow.C
b/cinelerra-5.1/cinelerra/mwindow.C
index 04549fde..8551c2e3 100644
--- a/cinelerra-5.1/cinelerra/mwindow.C
+++ b/cinelerra-5.1/cinelerra/mwindow.C
@@ -2211,8 +2211,11 @@ if(debug) printf("MWindow::load_filenames %d\n",
__LINE__);
if( strcmp(cin_version, CINELERRA_VERSION) &&
strcmp(cin_version, "Unify") &&
strcmp(cin_version, "5.1") ) {
- eprintf(_("Warning: XML from cinelerra version
%s\n"
- "Session data may be incompatible."),
cin_version);
+ char string[BCTEXTLEN];
+snprintf(string, sizeof(string),
+ _("Warning: XML from cinelerra version
%s\n"
+ "Session data may be incompatible."),
cin_version);
+show_warning(>warn_version,
string);
}
if( new_edl->load_xml(_file, LOAD_ALL) ) {
eprintf(_("Error: unable to load:\n %s"),
filename);
---
But I have another warning coming from plugin server (because in old CinGG
plugin names were localized)
Still, old Cin 5.1 project can be loaded if I insist (load it again after
warning first show up)
Not sure if we should consider this bug or feature .
diff --git a/cinelerra-5.1/cinelerra/mwindow.C b/cinelerra-5.1/cinelerra/mwindow.C
index 04549fde..8551c2e3 100644
--- a/cinelerra-5.1/cinelerra/mwindow.C
+++ b/cinelerra-5.1/cinelerra/mwindow.C
@@ -2211,8 +2211,11 @@ if(debug) printf("MWindow::load_filenames %d\n", __LINE__);
if( strcmp(cin_version, CINELERRA_VERSION) &&
strcmp(cin_version, "Unify") &&
strcmp(cin_version, "5.1") ) {
-eprintf(_("Warning: XML from cinelerra version %s\n"
- "Session data may be incompatible."), cin_version);
+char string[BCTEXTLEN];
+snprintf(string, sizeof(string),
+ _("Warning: XML from cinelerra version %s\n"
+ "Session data may be incompatible."), cin_version);
+show_warning(>warn_version, string);
}
if( new_edl->load_xml(_file, LOAD_ALL) ) {
eprintf(_("Error: unable to load:\n %s"), filename);
--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin
[Cin] 'Warn on version mismatch' historical research ...
It seems this flag was introduced in this commit:
https://git.cinelerra-gg.org/git/?p=goodguy/history.git;a=commit;h=9e779f63289f91f132569a933ddc93f4c1487751
author Good Guy
Wed, 7 Sep 2016 01:18:17 +0300 (16:18 -0600)
committer Good Guy
Wed, 7 Sep 2016 01:18:17 +0300 (16:18 -0600)
rework svg plugin, fast flash flush, init resize pixmaps, test edl version
so, it was testing version in mwindow.C
https://git.cinelerra-gg.org/git/?p=goodguy/history.git;a=blobdiff;f=cinelerra-5.1/cinelerra/mwindow.C;h=15b29e5c4ce1d06b5b1bfbd89e34bf89f69e0df0;hp=27e0917ec7eabe59d3782ee1f8c5973d9e62fd2d;hb=9e779f63289f91f132569a933ddc93f4c1487751;hpb=5a7faba81bcd03755bfe651bacbc5980171fe9de
(sorry for ultralong line)
-
+ const char *cin_version = 0;
+ while( !xml_file.read_tag() ) {
+ if( xml_file.tag.title_is("EDL") ) {
+ cin_version =
xml_file.tag.get_property("VERSION");
+ break;
+ }
+ }
+ xml_file.rewind();
+ if( !cin_version ) {
+ eprintf(_("XML file %s\n not from
cinelerra."),filenames->get(i));
+ char string[BCTEXTLEN];
+ sprintf(string,_("Unknown %s"),
filenames->get(i));
+ gui->show_message(string);
+ result = 1;
+ break;
+ }
+ if( strcmp(cin_version, CINELERRA_VERSION) ) {
+ char string[BCTEXTLEN];
+ snprintf(string, sizeof(string),
+_("Warning: XML from cinelerra
version %s\n"
+ "Session data may be
incompatible."), cin_version);
+
show_warning(>warn_version, string);
+ }
hm ...
in current we have
https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blob;f=cinelerra-5.1/cinelerra/mwindow.C;h=04549fdedc984278e8ac6a5dfc8176c1fe7ba69b;hb=HEAD
2196 const char *cin_version = 0;
2197 while( !xml_file.read_tag() ) {
2198 if( xml_file.tag.title_is("EDL") ) {
2199 cin_version =
xml_file.tag.get_property("VERSION");
2200 break;
2201 }
2202 }
2203 xml_file.rewind();
2204 if( !cin_version ) {
2205 eprintf(_("XML file %s\n not from
cinelerra."),filename);
2206 char string[BCTEXTLEN];
2207 sprintf(string,_("Unknown %s"), filename);
2208 gui->show_message(string);
2209 break;
2210 }
2211 if( strcmp(cin_version, CINELERRA_VERSION) &&
2212 strcmp(cin_version, "Unify") &&
2213 strcmp(cin_version, "5.1") ) {
2214 eprintf(_("Warning: XML from cinelerra
version %s\n"
2215 "Session data may be
incompatible."), cin_version);
2216 }
so, IT SEEMS this preference simply unused now?
Should we try to repair it, or just remove this warning checkbox altogether?
(or possible replace it with 'unsafe_button_in_batchrender' preference?)
I think replacing eprintf with show_warning still will do work, but need to
check!
--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Debate on batch render
В сообщении от Wednesday 13 January 2021 08:18:34 Phyllis Smith via Cin написал(а): > RafaMar, > I apologize for using the wrong one -- working on 3 different issues today > + a big personal problem came up. Will wait to hear back from Andrew and > Andrea to see if they are amenable to commenting out the code or prefer to > use UNSAFE button workaround. Oh, sorry for upcoming problem - hopefully it will be resolved ... I think I prefer my version ( :} ) IF you can compile and make it work as expected. You may want to double-check git apply actually applied patch, if you use this tool. Run it with '-v' parameter, and use '-R' if you want to reverse applied patch for me it works like this: root@slax:/dev/shm/tmp/cinelerra-goodguy-20210112/cinelerra-5.1# LANG=C git apply -v /home/guest/botva/src/cinelerra-git/cin-5/disable_two_buttons_in_batchrender_gui-5.diff /home/guest/botva/src/cinelerra-git/cin-5/disable_two_buttons_in_batchrender_gui-5.diff:18: trailing whitespace. /home/guest/botva/src/cinelerra-git/cin-5/disable_two_buttons_in_batchrender_gui-5.diff:79: trailing whitespace. /home/guest/botva/src/cinelerra-git/cin-5/disable_two_buttons_in_batchrender_gui-5.diff:121: trailing whitespace. Checking patch cinelerra-5.1/cinelerra/batchrender.C... Applied patch cinelerra-5.1/cinelerra/batchrender.C cleanly. warning: 3 lines add whitespace errors. I think checkbox in Preferences control ANOTHER warning about EDL from different versions of Cinelerra... Probably some tooltips there will not hurt ... in https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=blob;f=cinelerra-5.1/cinelerra/appearanceprefs.C strange, I can't see where this version actually checked . I treied to load old Cin 5.1 project, and it shows warning about locally-encoded effect/plugin names and show nothing on timeline, but I guess this is different warning ... need to dig into history > > Glad to hear you can compile yourself now -- it will be important as the > GIT repository is updated so you can test early. For example, you should > now be able to see in the build you and the programmer did, the latest > Spanish translations you provided. > > On Tue, Jan 12, 2021 at 9:20 PM Rafa Mar Multimedia en Gnu\Linux via Cin < > cin@lists.cinelerra-gg.org> wrote: > [skip] -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Debate on batch render
RafaMar, I apologize for using the wrong one -- working on 3 different issues today + a big personal problem came up. Will wait to hear back from Andrew and Andrea to see if they are amenable to commenting out the code or prefer to use UNSAFE button workaround. Glad to hear you can compile yourself now -- it will be important as the GIT repository is updated so you can test early. For example, you should now be able to see in the build you and the programmer did, the latest Spanish translations you provided. On Tue, Jan 12, 2021 at 9:20 PM Rafa Mar Multimedia en Gnu\Linux via Cin < cin@lists.cinelerra-gg.org> wrote: > *Phyllis*, the image you attach is the result of the first attempt, once > tested it was corrected and that is why I made a second shipment, which if > you compile correctly the window looks exactly as before but without the > dangerous options. I have done several tests and they have all been correct. > I reattach the file that has been corrected, the one you should use. You > can see the differences if you compare it with the original. The one from > the first shipment is not right. This is the good one. > > [image: imagen.png] > > > > El mié, 13 ene 2021 a las 4:51, Phyllis Smith via Cin (< > cin@lists.cinelerra-gg.org>) escribió: > >> *RafaMar*, thanks for enlisting help from your programmer friend. Using >> the batchrender.C file you sent, the menu box is not lined up quite right >> as you can see in the attachment, but if we use this I think I might be >> able to fix it myself. >> >> *Andrew*, the other email shows I had a problem with the patch: >> disable_two_buttons_in_batchrender_gui-5.diff but maybe I did something >> wrong. >> >> *Andrea_Paz*, I agree with not deleting these buttons and really do not >> like to just comment them out, but are you totally opposed to doing so? >> >> On Tue, Jan 12, 2021 at 6:20 PM Rafa Mar Multimedia en Gnu\Linux via Cin < >> cin@lists.cinelerra-gg.org> wrote: >> >>> Who have a friend, have a treasure. >>> I have met with my programmer friend to see us and he has helped me to >>> compile Cinelerra from git sources. Now it even seems simple to me, he says >>> that it was very easy thanks to the good Cinelerra manual, where everything >>> is explained very well. I still don't understand anything. >>> He has tested the file that he had modified and it did not work as >>> expected, causing the application to close. >>> He has apologized, says that not at first he has not paid the attention >>> that he required such a good job and in 1 minute he has written a few lines >>> // of these and some like this /* and */ and the magic has been done, the >>> wizard no longer has dangerous options and works like a charm, without >>> errors of any kind. >>> He has praised how well written the file was. It is a pity that he is >>> not fond of audiovisuals, but he has told me that for specific matters like >>> this we can count on him ... the truth is that what has taken the longest >>> has been the compilation, because the file of the render window in 1 minute >>> has had it working. >>> >>> I attach the corrected file. >>> >>> Thank you very much to all the people who have participated in the >>> debate. >>> >>> P.S. Phyllis this is the good file to correct this issue. >>> He has not deleted anything, only commented, that's what he called it, >>> Maybe you should keep a copy of the original in case some suicidal user >>> has fun breaking their work by playing with the assistant. For me now it's >>> perfect. It can be explained in 4 lines and the only thing you need to know >>> is to add a new line before modifying the input and output routes. >>> Regards. >>> >>> El mar, 12 ene 2021 a las 22:44, Andrew Randrianasulu via Cin (< >>> cin@lists.cinelerra-gg.org>) escribió: >>> В сообщении от Tuesday 12 January 2021 22:14:43 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а): > Andrea Paz, I admire people who speak clearly and say what they think. It > never offends me that someone disagrees with me. I always start from the > assumption that I can be the one who can be totally wrong. The only thing I > can say is THANK YOU VERY MUCH FOR GIVING YOUR OPINION. > > @Phyllis, I need help, How do you compile a Cinelerra GG .tgz? I have tried > and it does not work for me, from the first line it gives me errors. > > > rafa@rafa-pc:~/cinelerra-5.1$ ./autogen.sh > + rm -f global_config configure Makefile Makefile.in > + rm -f aclocal.m4 depcomp compile install-sh ltmain.sh > + rm -f config.log config.guess config.h config.h.in config.sub > config.status missing > + rm -rf autom4te.cache m4 > + '[' '' = clean ']' > + mkdir m4 > + autoreconf --install > ./autogen.sh: línea 11: autoreconf: Command not found > <--> Try to install this package? On Ubuntu/Debian/Mint (I think) there is script in
Re: [Cin] Second attempt at simplifying BatchRender window
В сообщении от Wednesday 13 January 2021 06:45:58 Phyllis Smith via Cin
написал(а):
> *Andrew,* for the last patch called:
> disable_two_buttons_in_batchrender_gui-5.diff, I can not start the jobs
> but just get the warning box as you see in the attached - even though I
> have preferences warning disabled.
Strange, I compiled my current tree both with this define set to 1
(so I can set checkbox) and as 0 (so, it should ignore all settings
from batchrender.rc). I *can* start batch render
>
> On Tue, Jan 12, 2021 at 10:22 AM Andrew Randrianasulu via Cin <
> cin@lists.cinelerra-gg.org> wrote:
>
> > This time I hopefully found how to NOT initialize this variable, and not
> > load it from file either
> >
> > Try this patch instead of any my previous attempts ... sorry!
> >
> >
>
/*
* CINELERRA
* Copyright (C) 2011 Adam Williams
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
*/
#include "asset.h"
#include "batchrender.h"
#include "bcdisplayinfo.h"
#include "bcsignals.h"
#include "confirmsave.h"
#include "cstrdup.h"
#include "bchash.h"
#include "edits.h"
#include "edit.h"
#include "edl.h"
#include "edlsession.h"
#include "errorbox.h"
#include "file.h"
#include "filesystem.h"
#include "filexml.h"
#include "indexable.h"
#include "keyframe.h"
#include "keys.h"
#include "labels.h"
#include "language.h"
#include "localsession.h"
#include "mainerror.h"
#include "mainundo.h"
#include "mainsession.h"
#include "mutex.h"
#include "mwindow.h"
#include "mwindowgui.h"
#include "packagedispatcher.h"
#include "packagerenderer.h"
#include "plugin.h"
#include "pluginset.h"
#include "preferences.h"
#include "render.h"
#include "theme.h"
#include "tracks.h"
#include "transportque.h"
#include "vframe.h"
#include "dvdcreate.h"
#include "bdcreate.h"
#define UNSAFE_BUTTON 0
int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
const char *BatchRenderThread::column_titles[] = {
N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"), N_("Elapsed")
};
BatchRenderMenuItem::BatchRenderMenuItem(MWindow *mwindow)
: BC_MenuItem(_("Batch Render..."), _("Shift-B"), 'B')
{
set_shift(1);
this->mwindow = mwindow;
}
int BatchRenderMenuItem::handle_event()
{
mwindow->batch_render->start(1, 1);
return 1;
}
BatchRenderJob::BatchRenderJob(const char *tag,
Preferences *preferences, int labeled, int farmed)
{
this->tag = tag;
this->preferences = preferences;
this->labeled = labeled;
this->farmed = farmed >= 0 ? farmed : preferences->use_renderfarm;
asset = new Asset;
edl_path[0] = 0;
enabled = 1;
elapsed = 0;
}
BatchRenderJob::BatchRenderJob(Preferences *preferences, int labeled, int farmed)
: BatchRenderJob("JOB", preferences, labeled, farmed)
{
}
BatchRenderJob::~BatchRenderJob()
{
asset->Garbage::remove_user();
}
void BatchRenderJob::copy_from(BatchRenderJob *src)
{
enabled = src->enabled;
farmed = src->farmed;
labeled = src->labeled;
asset->copy_from(src->asset, 0);
strcpy(edl_path, src->edl_path);
elapsed = 0;
}
BatchRenderJob *BatchRenderJob::copy()
{
BatchRenderJob *t = new BatchRenderJob(tag, preferences, labeled, farmed);
t->copy_from(this);
return t;
}
void BatchRenderJob::load(FileXML *file)
{
int result = 0;
char job_title[BCSTRLEN];
strcpy(job_title, file->tag.title);
enabled = file->tag.get_property("ENABLED", enabled);
farmed = file->tag.get_property("FARMED", farmed);
labeled = file->tag.get_property("LABELED", labeled);
edl_path[0] = 0;
file->tag.get_property("EDL_PATH", edl_path);
elapsed = file->tag.get_property("ELAPSED", elapsed);
result = file->read_tag();
if( !result ) {
if( file->tag.title_is("ASSET") ) {
file->tag.get_property("SRC", asset->path);
asset->read(file, 0);
// The compression parameters are stored in the defaults to reduce
// coding maintenance. The defaults must now be stuffed into the XML for
// unique storage.
BC_Hash defaults;
defaults.load_string(file->read_text(job_title));
asset->load_defaults(,
"", 0, 1, 0, 0, 0);
}
}
}
void BatchRenderJob::save(FileXML *file)
{
char end_tag[BCSTRLEN]; end_tag[0] = '/';
strcpy(_tag[1], file->tag.get_title());
file->tag.set_property("ENABLED", enabled);
file->tag.set_property("FARMED", farmed);
file->tag.set_property("LABELED", labeled);
file->tag.set_property("EDL_PATH",
Re: [Cin] Debate on batch render
*RafaMar*, thanks for enlisting help from your programmer friend. Using the batchrender.C file you sent, the menu box is not lined up quite right as you can see in the attachment, but if we use this I think I might be able to fix it myself. *Andrew*, the other email shows I had a problem with the patch: disable_two_buttons_in_batchrender_gui-5.diff but maybe I did something wrong. *Andrea_Paz*, I agree with not deleting these buttons and really do not like to just comment them out, but are you totally opposed to doing so? On Tue, Jan 12, 2021 at 6:20 PM Rafa Mar Multimedia en Gnu\Linux via Cin < cin@lists.cinelerra-gg.org> wrote: > Who have a friend, have a treasure. > I have met with my programmer friend to see us and he has helped me to > compile Cinelerra from git sources. Now it even seems simple to me, he says > that it was very easy thanks to the good Cinelerra manual, where everything > is explained very well. I still don't understand anything. > He has tested the file that he had modified and it did not work as > expected, causing the application to close. > He has apologized, says that not at first he has not paid the attention > that he required such a good job and in 1 minute he has written a few lines > // of these and some like this /* and */ and the magic has been done, the > wizard no longer has dangerous options and works like a charm, without > errors of any kind. > He has praised how well written the file was. It is a pity that he is not > fond of audiovisuals, but he has told me that for specific matters like > this we can count on him ... the truth is that what has taken the longest > has been the compilation, because the file of the render window in 1 minute > has had it working. > > I attach the corrected file. > > Thank you very much to all the people who have participated in the debate. > > P.S. Phyllis this is the good file to correct this issue. > He has not deleted anything, only commented, that's what he called it, > Maybe you should keep a copy of the original in case some suicidal user > has fun breaking their work by playing with the assistant. For me now it's > perfect. It can be explained in 4 lines and the only thing you need to know > is to add a new line before modifying the input and output routes. > Regards. > > El mar, 12 ene 2021 a las 22:44, Andrew Randrianasulu via Cin (< > cin@lists.cinelerra-gg.org>) escribió: > >> В сообщении от Tuesday 12 January 2021 22:14:43 Rafa Mar Multimedia en >> Gnu\Linux via Cin написал(а): >> > Andrea Paz, I admire people who speak clearly and say what they think. >> It >> > never offends me that someone disagrees with me. I always start from the >> > assumption that I can be the one who can be totally wrong. The only >> thing I >> > can say is THANK YOU VERY MUCH FOR GIVING YOUR OPINION. >> > >> > @Phyllis, I need help, How do you compile a Cinelerra GG .tgz? I have >> tried >> > and it does not work for me, from the first line it gives me errors. >> > >> > >> > rafa@rafa-pc:~/cinelerra-5.1$ ./autogen.sh >> > + rm -f global_config configure Makefile Makefile.in >> > + rm -f aclocal.m4 depcomp compile install-sh ltmain.sh >> > + rm -f config.log config.guess config.h config.h.in config.sub >> > config.status missing >> > + rm -rf autom4te.cache m4 >> > + '[' '' = clean ']' >> > + mkdir m4 >> > + autoreconf --install >> > ./autogen.sh: línea 11: autoreconf: Command not found >> > <--> >> >> Try to install this package? >> On Ubuntu/Debian/Mint (I think) >> >> there is script in >> cinelerra-5.1/blds/bld_prepare.sh >> >> apt-get -f -y install apt-file sox nasm yasm g++ build-essential >> zlib1g-dev \ >> texinfo libpng-dev freeglut3-dev libxv-dev libasound2-dev libbz2-dev \ >> libncurses5-dev libxinerama-dev libfreetype6-dev libxft-dev >> libgif-dev \ >> libtiff5-dev exuberant-ctags ttf-bitstream-vera xfonts-75dpi >> xfonts-100dpi \ >> fonts-dejavu libopenexr-dev festival libfftw3-dev gdb >> libusb-1.0-0-dev \ >> libdc1394-22-dev libflac-dev libjbig-dev libvdpau-dev libva-dev \ >> inkscape libsndfile1-dev libtheora-dev cmake udftools libxml2-utils >> git \ >> autoconf automake debhelper libgtk2.0-dev libpulse-dev python >> >> but you can just run this script as root, it will install bunch of >> ...everything >> including autoconf >> >> >> >> > Let me explain, I asked a friend who is a programmer for help, I sent >> him >> > the batchrender.C file so that he could cancel the two mentioned >> buttons. >> > He forwarded it to me and told me to replace, in the folder where I >> > unzipped the tgz, this file for which he sent me back with the >> > aforementioned functions canceled. And to compile the application to >> test >> > ... but I am not able to do this step. He also told me that he had NOT >> > deleted any code, only "commented" so that the compilation would ignore >> it. >> > I don't understand any of this, and I can't test either, the only thing >> I >> > can do is append this file here in
Re: [Cin] Second attempt at simplifying BatchRender window
*Andrew,* for the last patch called: disable_two_buttons_in_batchrender_gui-5.diff, I can not start the jobs but just get the warning box as you see in the attached - even though I have preferences warning disabled. On Tue, Jan 12, 2021 at 10:22 AM Andrew Randrianasulu via Cin < cin@lists.cinelerra-gg.org> wrote: > This time I hopefully found how to NOT initialize this variable, and not > load it from file either > > Try this patch instead of any my previous attempts ... sorry! > > -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Debate on batch render
Who have a friend, have a treasure. I have met with my programmer friend to see us and he has helped me to compile Cinelerra from git sources. Now it even seems simple to me, he says that it was very easy thanks to the good Cinelerra manual, where everything is explained very well. I still don't understand anything. He has tested the file that he had modified and it did not work as expected, causing the application to close. He has apologized, says that not at first he has not paid the attention that he required such a good job and in 1 minute he has written a few lines // of these and some like this /* and */ and the magic has been done, the wizard no longer has dangerous options and works like a charm, without errors of any kind. He has praised how well written the file was. It is a pity that he is not fond of audiovisuals, but he has told me that for specific matters like this we can count on him ... the truth is that what has taken the longest has been the compilation, because the file of the render window in 1 minute has had it working. I attach the corrected file. Thank you very much to all the people who have participated in the debate. P.S. Phyllis this is the good file to correct this issue. He has not deleted anything, only commented, that's what he called it, Maybe you should keep a copy of the original in case some suicidal user has fun breaking their work by playing with the assistant. For me now it's perfect. It can be explained in 4 lines and the only thing you need to know is to add a new line before modifying the input and output routes. Regards. El mar, 12 ene 2021 a las 22:44, Andrew Randrianasulu via Cin (< cin@lists.cinelerra-gg.org>) escribió: > В сообщении от Tuesday 12 January 2021 22:14:43 Rafa Mar Multimedia en > Gnu\Linux via Cin написал(а): > > Andrea Paz, I admire people who speak clearly and say what they think. It > > never offends me that someone disagrees with me. I always start from the > > assumption that I can be the one who can be totally wrong. The only > thing I > > can say is THANK YOU VERY MUCH FOR GIVING YOUR OPINION. > > > > @Phyllis, I need help, How do you compile a Cinelerra GG .tgz? I have > tried > > and it does not work for me, from the first line it gives me errors. > > > > > > rafa@rafa-pc:~/cinelerra-5.1$ ./autogen.sh > > + rm -f global_config configure Makefile Makefile.in > > + rm -f aclocal.m4 depcomp compile install-sh ltmain.sh > > + rm -f config.log config.guess config.h config.h.in config.sub > > config.status missing > > + rm -rf autom4te.cache m4 > > + '[' '' = clean ']' > > + mkdir m4 > > + autoreconf --install > > ./autogen.sh: línea 11: autoreconf: Command not found > > <--> > > Try to install this package? > On Ubuntu/Debian/Mint (I think) > > there is script in > cinelerra-5.1/blds/bld_prepare.sh > > apt-get -f -y install apt-file sox nasm yasm g++ build-essential > zlib1g-dev \ > texinfo libpng-dev freeglut3-dev libxv-dev libasound2-dev libbz2-dev \ > libncurses5-dev libxinerama-dev libfreetype6-dev libxft-dev libgif-dev > \ > libtiff5-dev exuberant-ctags ttf-bitstream-vera xfonts-75dpi > xfonts-100dpi \ > fonts-dejavu libopenexr-dev festival libfftw3-dev gdb libusb-1.0-0-dev > \ > libdc1394-22-dev libflac-dev libjbig-dev libvdpau-dev libva-dev \ > inkscape libsndfile1-dev libtheora-dev cmake udftools libxml2-utils > git \ > autoconf automake debhelper libgtk2.0-dev libpulse-dev python > > but you can just run this script as root, it will install bunch of > ...everything > including autoconf > > > > > Let me explain, I asked a friend who is a programmer for help, I sent him > > the batchrender.C file so that he could cancel the two mentioned buttons. > > He forwarded it to me and told me to replace, in the folder where I > > unzipped the tgz, this file for which he sent me back with the > > aforementioned functions canceled. And to compile the application to test > > ... but I am not able to do this step. He also told me that he had NOT > > deleted any code, only "commented" so that the compilation would ignore > it. > > I don't understand any of this, and I can't test either, the only thing I > > can do is append this file here in case someone wants to test it. Or if > > someone is kind enough to show me the steps to compile so I can test. > > > > El mar, 12 ene 2021 a las 18:25, preobraz--- via Cin (< > > cin@lists.cinelerra-gg.org>) escribió: > > > > > "Piping Video to a Command Line" - this really bomb! I'm very want > > > comeback this feature. > > > -- > > > Ugin. > > > > > > 12.01.2021 18:33, Phyllis Smith via Cin пишет: > > > >> I would like to know how many people use this and that function, so > a > > > >> developer can make the right thing, if he is not a filmaker/editor. > > > >> > > > >> *Andrew*, in response to IgorB I am in favor of *commenting out the > code > > > > for the 2 buttons* - Save to EDL Path and Warn if jobs/session > > > mismatched. > > > > It would be less confusing
Re: [Cin] Debate on batch render
В сообщении от Tuesday 12 January 2021 22:14:43 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а): > Andrea Paz, I admire people who speak clearly and say what they think. It > never offends me that someone disagrees with me. I always start from the > assumption that I can be the one who can be totally wrong. The only thing I > can say is THANK YOU VERY MUCH FOR GIVING YOUR OPINION. > > @Phyllis, I need help, How do you compile a Cinelerra GG .tgz? I have tried > and it does not work for me, from the first line it gives me errors. > > > rafa@rafa-pc:~/cinelerra-5.1$ ./autogen.sh > + rm -f global_config configure Makefile Makefile.in > + rm -f aclocal.m4 depcomp compile install-sh ltmain.sh > + rm -f config.log config.guess config.h config.h.in config.sub > config.status missing > + rm -rf autom4te.cache m4 > + '[' '' = clean ']' > + mkdir m4 > + autoreconf --install > ./autogen.sh: línea 11: autoreconf: Command not found > <--> Try to install this package? On Ubuntu/Debian/Mint (I think) there is script in cinelerra-5.1/blds/bld_prepare.sh apt-get -f -y install apt-file sox nasm yasm g++ build-essential zlib1g-dev \ texinfo libpng-dev freeglut3-dev libxv-dev libasound2-dev libbz2-dev \ libncurses5-dev libxinerama-dev libfreetype6-dev libxft-dev libgif-dev \ libtiff5-dev exuberant-ctags ttf-bitstream-vera xfonts-75dpi xfonts-100dpi \ fonts-dejavu libopenexr-dev festival libfftw3-dev gdb libusb-1.0-0-dev \ libdc1394-22-dev libflac-dev libjbig-dev libvdpau-dev libva-dev \ inkscape libsndfile1-dev libtheora-dev cmake udftools libxml2-utils git \ autoconf automake debhelper libgtk2.0-dev libpulse-dev python but you can just run this script as root, it will install bunch of ...everything including autoconf > Let me explain, I asked a friend who is a programmer for help, I sent him > the batchrender.C file so that he could cancel the two mentioned buttons. > He forwarded it to me and told me to replace, in the folder where I > unzipped the tgz, this file for which he sent me back with the > aforementioned functions canceled. And to compile the application to test > ... but I am not able to do this step. He also told me that he had NOT > deleted any code, only "commented" so that the compilation would ignore it. > I don't understand any of this, and I can't test either, the only thing I > can do is append this file here in case someone wants to test it. Or if > someone is kind enough to show me the steps to compile so I can test. > > El mar, 12 ene 2021 a las 18:25, preobraz--- via Cin (< > cin@lists.cinelerra-gg.org>) escribió: > > > "Piping Video to a Command Line" - this really bomb! I'm very want > > comeback this feature. > > -- > > Ugin. > > > > 12.01.2021 18:33, Phyllis Smith via Cin пишет: > > >> I would like to know how many people use this and that function, so a > > >> developer can make the right thing, if he is not a filmaker/editor. > > >> > > >> *Andrew*, in response to IgorB I am in favor of *commenting out the code > > > for the 2 buttons* - Save to EDL Path and Warn if jobs/session > > mismatched. > > > It would be less confusing than creating an UNSAFE button. I made an > > > attempt to do this yesterday but ended up with SEGV as I am really > > > clueless. I do not want to delete the code because this way the > > > experienced users can recompile themselves and get the feature capability > > > back for their own use. > > > > > > In the past, deleting code has just led to having to put it back -- case > > in > > > point is "Piping Video to a Command Line". It was deleted and we got > > raked > > > over the coals because one person responded that it was the only feature > > of > > > CinelerraGG that he used. > > > > > > > > -- > > Cin mailing list > > Cin@lists.cinelerra-gg.org > > https://lists.cinelerra-gg.org/mailman/listinfo/cin > > > -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Debate on batch render
Andrea Paz, I admire people who speak clearly and say what they think. It
never offends me that someone disagrees with me. I always start from the
assumption that I can be the one who can be totally wrong. The only thing I
can say is THANK YOU VERY MUCH FOR GIVING YOUR OPINION.
@Phyllis, I need help, How do you compile a Cinelerra GG .tgz? I have tried
and it does not work for me, from the first line it gives me errors.
rafa@rafa-pc:~/cinelerra-5.1$ ./autogen.sh
+ rm -f global_config configure Makefile Makefile.in
+ rm -f aclocal.m4 depcomp compile install-sh ltmain.sh
+ rm -f config.log config.guess config.h config.h.in config.sub
config.status missing
+ rm -rf autom4te.cache m4
+ '[' '' = clean ']'
+ mkdir m4
+ autoreconf --install
./autogen.sh: línea 11: autoreconf: Command not found
<-->
Let me explain, I asked a friend who is a programmer for help, I sent him
the batchrender.C file so that he could cancel the two mentioned buttons.
He forwarded it to me and told me to replace, in the folder where I
unzipped the tgz, this file for which he sent me back with the
aforementioned functions canceled. And to compile the application to test
... but I am not able to do this step. He also told me that he had NOT
deleted any code, only "commented" so that the compilation would ignore it.
I don't understand any of this, and I can't test either, the only thing I
can do is append this file here in case someone wants to test it. Or if
someone is kind enough to show me the steps to compile so I can test.
El mar, 12 ene 2021 a las 18:25, preobraz--- via Cin (<
cin@lists.cinelerra-gg.org>) escribió:
> "Piping Video to a Command Line" - this really bomb! I'm very want
> comeback this feature.
> --
> Ugin.
>
> 12.01.2021 18:33, Phyllis Smith via Cin пишет:
> >> I would like to know how many people use this and that function, so a
> >> developer can make the right thing, if he is not a filmaker/editor.
> >>
> >> *Andrew*, in response to IgorB I am in favor of *commenting out the code
> > for the 2 buttons* - Save to EDL Path and Warn if jobs/session
> mismatched.
> > It would be less confusing than creating an UNSAFE button. I made an
> > attempt to do this yesterday but ended up with SEGV as I am really
> > clueless. I do not want to delete the code because this way the
> > experienced users can recompile themselves and get the feature capability
> > back for their own use.
> >
> > In the past, deleting code has just led to having to put it back -- case
> in
> > point is "Piping Video to a Command Line". It was deleted and we got
> raked
> > over the coals because one person responded that it was the only feature
> of
> > CinelerraGG that he used.
> >
> >
> --
> Cin mailing list
> Cin@lists.cinelerra-gg.org
> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>
/*
* CINELERRA
* Copyright (C) 2011 Adam Williams
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
*/
#include "asset.h"
#include "batchrender.h"
#include "bcdisplayinfo.h"
#include "bcsignals.h"
#include "confirmsave.h"
#include "cstrdup.h"
#include "bchash.h"
#include "edits.h"
#include "edit.h"
#include "edl.h"
#include "edlsession.h"
#include "errorbox.h"
#include "file.h"
#include "filesystem.h"
#include "filexml.h"
#include "indexable.h"
#include "keyframe.h"
#include "keys.h"
#include "labels.h"
#include "language.h"
#include "localsession.h"
#include "mainerror.h"
#include "mainundo.h"
#include "mainsession.h"
#include "mutex.h"
#include "mwindow.h"
#include "mwindowgui.h"
#include "packagedispatcher.h"
#include "packagerenderer.h"
#include "plugin.h"
#include "pluginset.h"
#include "preferences.h"
#include "render.h"
#include "theme.h"
#include "tracks.h"
#include "transportque.h"
#include "vframe.h"
#include "dvdcreate.h"
#include "bdcreate.h"
int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
const char *BatchRenderThread::column_titles[] = {
N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"), N_("Elapsed")
};
BatchRenderMenuItem::BatchRenderMenuItem(MWindow *mwindow)
: BC_MenuItem(_("Batch Render..."), _("Shift-B"), 'B')
{
set_shift(1);
this->mwindow = mwindow;
}
int BatchRenderMenuItem::handle_event()
{
mwindow->batch_render->start(1, 1);
return 1;
}
BatchRenderJob::BatchRenderJob(const char *tag,
Preferences *preferences,
Re: [Cin] Second attempt at simplifying BatchRender window
OK, trying this one now !! We really appreciate your work and do not care
if it takes a few tries.
On Tue, Jan 12, 2021 at 10:22 AM Andrew Randrianasulu via Cin <
cin@lists.cinelerra-gg.org> wrote:
> This time I hopefully found how to NOT initialize this variable, and not
> load it from file either
>
> Try this patch instead of any my previous attempts ... sorry!
>
>
> diff --git a/cinelerra-5.1/cinelerra/batchrender.C
> b/cinelerra-5.1/cinelerra/batchrender.C
> index 6dcdbc62..f9a91fff 100644
> --- a/cinelerra-5.1/cinelerra/batchrender.C
> +++ b/cinelerra-5.1/cinelerra/batchrender.C
> @@ -60,6 +60,8 @@
> #include "dvdcreate.h"
> #include "bdcreate.h"
>
> +#define UNSAFE_BUTTON 0
> +
> int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
> const char *BatchRenderThread::column_titles[] = {
> N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"),
> N_("EDL"), N_("Elapsed")
> @@ -197,7 +199,10 @@ BatchRenderThread::BatchRenderThread(MWindow *mwindow)
> default_job = 0;
> boot_defaults = 0;
> preferences = 0;
> +
> + if (UNSAFE_BUTTON)
> warn = 1;
> +
> render = 0;
> batch_path[0] = 0;
> do_farmed = 0;
> @@ -217,6 +222,7 @@ void BatchRenderThread::reset(const char *path)
> {
> if( path ) {
> strcpy(batch_path, path);
> + if (UNSAFE_BUTTON)
> warn = 1;
> }
> current_job = 0;
> @@ -268,6 +274,7 @@ void BatchRenderThread::load_jobs(char *path,
> Preferences *preferences)
> while( !result ) {
> if( !(result = file.read_tag()) ) {
> if( file.tag.title_is("JOBS") ) {
> + if (UNSAFE_BUTTON)
> warn = file.tag.get_property("WARN", 1);
> }
> else if( file.tag.title_is("JOB") ) {
> @@ -293,6 +300,7 @@ void BatchRenderThread::save_jobs(char *path)
> {
> FileXML file;
> file.tag.set_title("JOBS");
> + if (UNSAFE_BUTTON)
> file.tag.set_property("WARN", warn);
> file.append_tag();
> file.append_newline();
> @@ -382,6 +390,7 @@ void BatchRenderThread::use_current_edl()
> gui->edl_path_text->update(get_current_edl());
> }
>
> +
> void BatchRenderThread::update_selected_edl()
> {
> FileXML xml_file;
> @@ -792,8 +801,12 @@ void BatchRenderGUI::create_objects()
> y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
>
> x = x2; y = y2;
> +
> + if (UNSAFE_BUTTON) {
> add_subwindow(update_selected_edl = new
> BatchRenderUpdateEDL(thread, x, y));
> y += update_selected_edl->get_h() + mwindow->theme->widget_border;
> + }
> +
> add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread,
> x, y));
> y += use_current_edl->get_h() + mwindow->theme->widget_border;
> if( !mwindow->edl || !mwindow->edl->path[0] )
> use_current_edl->disable();
> @@ -805,8 +818,12 @@ void BatchRenderGUI::create_objects()
> x += savelist_batch->get_w() + mwindow->theme->widget_border;
> add_subwindow(loadlist_batch = new BatchRenderLoadList(thread, x,
> y));
> y += loadlist_batch->get_h() + mwindow->theme->widget_border;
> +
> + if (UNSAFE_BUTTON) {
> add_subwindow(warning = new BatchRenderWarning(thread, x2, y));
> y2 = y + warning->get_h() + mwindow->theme->widget_border;
> + }
> +
> if( y2 > y1 ) y1 = y2;
> x = mwindow->theme->batchrender_x1, y = y1;
>
> @@ -835,6 +852,7 @@ void BatchRenderGUI::button_disable()
> new_batch->disable();
> delete_batch->disable();
> use_current_edl->disable();
> + if (UNSAFE_BUTTON)
> update_selected_edl->disable();
> }
>
> @@ -844,6 +862,7 @@ void BatchRenderGUI::button_enable()
> delete_batch->enable();
> if( mwindow->edl && mwindow->edl->path[0] )
> use_current_edl->enable();
> + if (UNSAFE_BUTTON)
> update_selected_edl->enable();
> }
>
> @@ -876,8 +895,12 @@ int BatchRenderGUI::resize_event(int w, int h)
> y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
>
> x = x2; y = y2;
> +
> + if (UNSAFE_BUTTON) {
> update_selected_edl->reposition_window(x, y);
> y += update_selected_edl->get_h() + mwindow->theme->widget_border;
> + }
> +
> use_current_edl->reposition_window(x, y);
> y += use_current_edl->get_h() + mwindow->theme->widget_border;
> new_batch->reposition_window(x, y);
> @@ -889,9 +912,12 @@ int BatchRenderGUI::resize_event(int w, int h)
> x += savelist_batch->get_w() + mwindow->theme->widget_border;
> loadlist_batch->reposition_window(x, y);
> y += loadlist_batch->get_h() + mwindow->theme->widget_border;
> + if (UNSAFE_BUTTON) {
> warning->reposition_window(x2,
Re: [Cin] Debate on batch render
"Piping Video to a Command Line" - this really bomb! I'm very want comeback this feature. -- Ugin. 12.01.2021 18:33, Phyllis Smith via Cin пишет: I would like to know how many people use this and that function, so a developer can make the right thing, if he is not a filmaker/editor. *Andrew*, in response to IgorB I am in favor of *commenting out the code for the 2 buttons* - Save to EDL Path and Warn if jobs/session mismatched. It would be less confusing than creating an UNSAFE button. I made an attempt to do this yesterday but ended up with SEGV as I am really clueless. I do not want to delete the code because this way the experienced users can recompile themselves and get the feature capability back for their own use. In the past, deleting code has just led to having to put it back -- case in point is "Piping Video to a Command Line". It was deleted and we got raked over the coals because one person responded that it was the only feature of CinelerraGG that he used. -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
[Cin] Second attempt at simplifying BatchRender window
This time I hopefully found how to NOT initialize this variable, and not load
it from file either
Try this patch instead of any my previous attempts ... sorry!
diff --git a/cinelerra-5.1/cinelerra/batchrender.C
b/cinelerra-5.1/cinelerra/batchrender.C
index 6dcdbc62..f9a91fff 100644
--- a/cinelerra-5.1/cinelerra/batchrender.C
+++ b/cinelerra-5.1/cinelerra/batchrender.C
@@ -60,6 +60,8 @@
#include "dvdcreate.h"
#include "bdcreate.h"
+#define UNSAFE_BUTTON 0
+
int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
const char *BatchRenderThread::column_titles[] = {
N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"),
N_("Elapsed")
@@ -197,7 +199,10 @@ BatchRenderThread::BatchRenderThread(MWindow *mwindow)
default_job = 0;
boot_defaults = 0;
preferences = 0;
+
+ if (UNSAFE_BUTTON)
warn = 1;
+
render = 0;
batch_path[0] = 0;
do_farmed = 0;
@@ -217,6 +222,7 @@ void BatchRenderThread::reset(const char *path)
{
if( path ) {
strcpy(batch_path, path);
+ if (UNSAFE_BUTTON)
warn = 1;
}
current_job = 0;
@@ -268,6 +274,7 @@ void BatchRenderThread::load_jobs(char *path, Preferences
*preferences)
while( !result ) {
if( !(result = file.read_tag()) ) {
if( file.tag.title_is("JOBS") ) {
+ if (UNSAFE_BUTTON)
warn = file.tag.get_property("WARN", 1);
}
else if( file.tag.title_is("JOB") ) {
@@ -293,6 +300,7 @@ void BatchRenderThread::save_jobs(char *path)
{
FileXML file;
file.tag.set_title("JOBS");
+ if (UNSAFE_BUTTON)
file.tag.set_property("WARN", warn);
file.append_tag();
file.append_newline();
@@ -382,6 +390,7 @@ void BatchRenderThread::use_current_edl()
gui->edl_path_text->update(get_current_edl());
}
+
void BatchRenderThread::update_selected_edl()
{
FileXML xml_file;
@@ -792,8 +801,12 @@ void BatchRenderGUI::create_objects()
y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
x = x2; y = y2;
+
+ if (UNSAFE_BUTTON) {
add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x,
y));
y += update_selected_edl->get_h() + mwindow->theme->widget_border;
+ }
+
add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x,
y));
y += use_current_edl->get_h() + mwindow->theme->widget_border;
if( !mwindow->edl || !mwindow->edl->path[0] )
use_current_edl->disable();
@@ -805,8 +818,12 @@ void BatchRenderGUI::create_objects()
x += savelist_batch->get_w() + mwindow->theme->widget_border;
add_subwindow(loadlist_batch = new BatchRenderLoadList(thread, x, y));
y += loadlist_batch->get_h() + mwindow->theme->widget_border;
+
+ if (UNSAFE_BUTTON) {
add_subwindow(warning = new BatchRenderWarning(thread, x2, y));
y2 = y + warning->get_h() + mwindow->theme->widget_border;
+ }
+
if( y2 > y1 ) y1 = y2;
x = mwindow->theme->batchrender_x1, y = y1;
@@ -835,6 +852,7 @@ void BatchRenderGUI::button_disable()
new_batch->disable();
delete_batch->disable();
use_current_edl->disable();
+ if (UNSAFE_BUTTON)
update_selected_edl->disable();
}
@@ -844,6 +862,7 @@ void BatchRenderGUI::button_enable()
delete_batch->enable();
if( mwindow->edl && mwindow->edl->path[0] )
use_current_edl->enable();
+ if (UNSAFE_BUTTON)
update_selected_edl->enable();
}
@@ -876,8 +895,12 @@ int BatchRenderGUI::resize_event(int w, int h)
y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
x = x2; y = y2;
+
+ if (UNSAFE_BUTTON) {
update_selected_edl->reposition_window(x, y);
y += update_selected_edl->get_h() + mwindow->theme->widget_border;
+ }
+
use_current_edl->reposition_window(x, y);
y += use_current_edl->get_h() + mwindow->theme->widget_border;
new_batch->reposition_window(x, y);
@@ -889,9 +912,12 @@ int BatchRenderGUI::resize_event(int w, int h)
x += savelist_batch->get_w() + mwindow->theme->widget_border;
loadlist_batch->reposition_window(x, y);
y += loadlist_batch->get_h() + mwindow->theme->widget_border;
+ if (UNSAFE_BUTTON) {
warning->reposition_window(x2, y);
y1 = ys15 + BC_GenericButton::calculate_h() +
mwindow->theme->widget_border;
+ }
+
y2 = get_h() - y1 - batch_list->get_h();
y2 -= list_title->get_h() + mwindow->theme->widget_border;
@@ -1236,6 +1262,7 @@ int BatchRenderCurrentEDL::handle_event()
return 1;
}
+
BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
int x,
int y)
@@
Re: [Cin] Debate on batch render
В сообщении от Tuesday 12 January 2021 18:33:19 Phyllis Smith via Cin
написал(а):
> > I would like to know how many people use this and that function, so a
> > developer can make the right thing, if he is not a filmaker/editor.
> >
> > *Andrew*, in response to IgorB I am in favor of *commenting out the code
> for the 2 buttons* - Save to EDL Path and Warn if jobs/session mismatched.
I actually tried to remove both, but this can lead to situation where you set
this checkbox to warn,
and now you have no GUI way to change it back! (editing config file probably
will work)
So, I only touched 'Save to EDL Path' button.
---
diff --git a/cinelerra-5.1/cinelerra/batchrender.C
b/cinelerra-5.1/cinelerra/batchrender.C
index 6dcdbc62..ab830d05 100644
--- a/cinelerra-5.1/cinelerra/batchrender.C
+++ b/cinelerra-5.1/cinelerra/batchrender.C
@@ -60,6 +60,8 @@
#include "dvdcreate.h"
#include "bdcreate.h"
+#define UNSAFE_BUTTON 0
+
int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
const char *BatchRenderThread::column_titles[] = {
N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"),
N_("Elapsed")
@@ -382,6 +384,7 @@ void BatchRenderThread::use_current_edl()
gui->edl_path_text->update(get_current_edl());
}
+
void BatchRenderThread::update_selected_edl()
{
FileXML xml_file;
@@ -792,8 +795,12 @@ void BatchRenderGUI::create_objects()
y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
x = x2; y = y2;
+
+ if (UNSAFE_BUTTON) {
add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x,
y));
y += update_selected_edl->get_h() + mwindow->theme->widget_border;
+ }
+
add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x,
y));
y += use_current_edl->get_h() + mwindow->theme->widget_border;
if( !mwindow->edl || !mwindow->edl->path[0] )
use_current_edl->disable();
@@ -805,8 +812,10 @@ void BatchRenderGUI::create_objects()
x += savelist_batch->get_w() + mwindow->theme->widget_border;
add_subwindow(loadlist_batch = new BatchRenderLoadList(thread, x, y));
y += loadlist_batch->get_h() + mwindow->theme->widget_border;
+
add_subwindow(warning = new BatchRenderWarning(thread, x2, y));
y2 = y + warning->get_h() + mwindow->theme->widget_border;
+
if( y2 > y1 ) y1 = y2;
x = mwindow->theme->batchrender_x1, y = y1;
@@ -835,6 +844,7 @@ void BatchRenderGUI::button_disable()
new_batch->disable();
delete_batch->disable();
use_current_edl->disable();
+ if (UNSAFE_BUTTON)
update_selected_edl->disable();
}
@@ -844,6 +854,7 @@ void BatchRenderGUI::button_enable()
delete_batch->enable();
if( mwindow->edl && mwindow->edl->path[0] )
use_current_edl->enable();
+ if (UNSAFE_BUTTON)
update_selected_edl->enable();
}
@@ -876,8 +887,12 @@ int BatchRenderGUI::resize_event(int w, int h)
y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
x = x2; y = y2;
+
+ if (UNSAFE_BUTTON) {
update_selected_edl->reposition_window(x, y);
y += update_selected_edl->get_h() + mwindow->theme->widget_border;
+ }
+
use_current_edl->reposition_window(x, y);
y += use_current_edl->get_h() + mwindow->theme->widget_border;
new_batch->reposition_window(x, y);
@@ -1236,6 +1251,7 @@ int BatchRenderCurrentEDL::handle_event()
return 1;
}
+
BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
int x,
int y)
@@ -1244,8 +1260,10 @@
BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
this->thread = thread;
}
+
int BatchRenderUpdateEDL::handle_event()
{
+ if (UNSAFE_BUTTON)
thread->update_selected_edl();
return 1;
}
---
Can you (and/or others) try this version?
I probably can clear this warn-variable somewhere, so
there will be possibility to actually hide checkbox, too.
But this will take some more time
> It would be less confusing than creating an UNSAFE button. I made an
> attempt to do this yesterday but ended up with SEGV as I am really
> clueless. I do not want to delete the code because this way the
> experienced users can recompile themselves and get the feature capability
> back for their own use.
>
> In the past, deleting code has just led to having to put it back -- case in
> point is "Piping Video to a Command Line". It was deleted and we got raked
> over the coals because one person responded that it was the only feature of
> CinelerraGG that he used.
>
diff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C
index 6dcdbc62..ab830d05 100644
--- a/cinelerra-5.1/cinelerra/batchrender.C
+++ b/cinelerra-5.1/cinelerra/batchrender.C
@@ -60,6 +60,8 @@
#include "dvdcreate.h"
#include "bdcreate.h"
+#define UNSAFE_BUTTON 0
+
Re: [Cin] Debate on batch render
I, on the other hand, am not in favor of removing this feature. Rafa don't take it to heart, it's just my opinion. I agree that in the other NLEs the Batch rendering is simple, i.e. just associating the project with his render setup to a list. In Cin it doesn't work like that, the rendering setup is done in the Batch Rendering window and not in the project first. We can discuss if it's better or worse, but this way leads to an additional possibility: In the case of projects that derive from the same EDL and change only effects or cuts or output codec. In short, in the cases that we want to experiment with variations, we can do it from inside the Batch Rendering without having to load projects, edit them, save them, reset the render setup and put them back in the Batch queue. Will no one ever use this feature? It doesn't matter, it's one more possibility, which confirms CinGG as a different NLE from the others, not for beginners and suitable only for a niche of users. I don't think removing this feature makes CinGG suitable for people who don't read the manual! However, I agree that those big buttons in that position are dangerous, but I am in favor of their modification as proposed by Igor Vladimirsky, not their elimination. I don't know, maybe it is better not to recommend CinGG to beginners. Remember that the persons who tried to make Cinelerra more modern understood that them had to make a completely new and different program (Lumiera)! PS: I also don't understand the logic of leaving "Save current EDL", since it is also destructive. -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Debate on batch render
> I would like to know how many people use this and that function, so a > developer can make the right thing, if he is not a filmaker/editor. > > *Andrew*, in response to IgorB I am in favor of *commenting out the code for the 2 buttons* - Save to EDL Path and Warn if jobs/session mismatched. It would be less confusing than creating an UNSAFE button. I made an attempt to do this yesterday but ended up with SEGV as I am really clueless. I do not want to delete the code because this way the experienced users can recompile themselves and get the feature capability back for their own use. In the past, deleting code has just led to having to put it back -- case in point is "Piping Video to a Command Line". It was deleted and we got raked over the coals because one person responded that it was the only feature of CinelerraGG that he used. -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Attempt at disabling 'Save to EDL' in batchrender GUI at compile-time
Andrew, thanks. I am looking at this also and will test today. (I did
check into GIT the ru.po change anyway).
On Tue, Jan 12, 2021 at 4:14 AM Andrew Randrianasulu via Cin <
cin@lists.cinelerra-gg.org> wrote:
>
> This one survived actual batch render - I forgot about enable/disable
> button calls
>
> so, if you set UNSAFE_BUTTON to 1 it will appear, if you leave it at 0 it
> will be hidden.
> Now, if THIS patch actually works we can think about hooking it up to pref
> window .
>
>
> ---
>
> diff --git a/cinelerra-5.1/cinelerra/batchrender.C
> b/cinelerra-5.1/cinelerra/batchrender.C
> index 6dcdbc62..d85d0e8c 100644
> --- a/cinelerra-5.1/cinelerra/batchrender.C
> +++ b/cinelerra-5.1/cinelerra/batchrender.C
> @@ -60,6 +60,8 @@
> #include "dvdcreate.h"
> #include "bdcreate.h"
>
> +#define UNSAFE_BUTTON 0
> +
> int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
> const char *BatchRenderThread::column_titles[] = {
> N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"),
> N_("EDL"), N_("Elapsed")
> @@ -382,6 +384,7 @@ void BatchRenderThread::use_current_edl()
> gui->edl_path_text->update(get_current_edl());
> }
>
> +
> void BatchRenderThread::update_selected_edl()
> {
> FileXML xml_file;
> @@ -396,6 +399,8 @@ void BatchRenderThread::update_selected_edl()
> }
> }
>
> +
> +
> BatchRenderJob* BatchRenderThread::get_current_job()
> {
> return current_job >= 0 && current_job < jobs.total ?
> @@ -792,8 +797,11 @@ void BatchRenderGUI::create_objects()
> y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
>
> x = x2; y = y2;
> + if (UNSAFE_BUTTON) {
> add_subwindow(update_selected_edl = new
> BatchRenderUpdateEDL(thread, x, y));
> y += update_selected_edl->get_h() + mwindow->theme->widget_border;
> +}
> +
> add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread,
> x, y));
> y += use_current_edl->get_h() + mwindow->theme->widget_border;
> if( !mwindow->edl || !mwindow->edl->path[0] )
> use_current_edl->disable();
> @@ -835,6 +843,7 @@ void BatchRenderGUI::button_disable()
> new_batch->disable();
> delete_batch->disable();
> use_current_edl->disable();
> + if (UNSAFE_BUTTON)
> update_selected_edl->disable();
> }
>
> @@ -844,6 +853,7 @@ void BatchRenderGUI::button_enable()
> delete_batch->enable();
> if( mwindow->edl && mwindow->edl->path[0] )
> use_current_edl->enable();
> + if (UNSAFE_BUTTON)
> update_selected_edl->enable();
> }
>
> @@ -876,8 +886,10 @@ int BatchRenderGUI::resize_event(int w, int h)
> y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
>
> x = x2; y = y2;
> + if (UNSAFE_BUTTON) {
> update_selected_edl->reposition_window(x, y);
> y += update_selected_edl->get_h() + mwindow->theme->widget_border;
> +}
> use_current_edl->reposition_window(x, y);
> y += use_current_edl->get_h() + mwindow->theme->widget_border;
> new_batch->reposition_window(x, y);
> @@ -1236,6 +1248,7 @@ int BatchRenderCurrentEDL::handle_event()
> return 1;
> }
>
> +
> BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
> int x,
> int y)
> @@ -1244,8 +1257,10 @@
> BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
> this->thread = thread;
> }
>
> +
> int BatchRenderUpdateEDL::handle_event()
> {
> + if (UNSAFE_BUTTON)
> thread->update_selected_edl();
> return 1;
> }
>
>
> --
> Cin mailing list
> Cin@lists.cinelerra-gg.org
> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>
--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Attempt at disabling 'Save to EDL' in batchrender GUI at compile-time
*Thank you very much Andrew* for this excellent proposal. I do not even
believe that the power to activate dangerous options for our projects
should be included in the preferences, it is my thought.
I always thought that removing these buttons was about erasing the code,
but this is a topic that I can't talk about and just listen to because I
don't know anything about programming.
El mar, 12 ene 2021 a las 12:14, Andrew Randrianasulu via Cin (<
cin@lists.cinelerra-gg.org>) escribió:
>
> This one survived actual batch render - I forgot about enable/disable
> button calls
>
> so, if you set UNSAFE_BUTTON to 1 it will appear, if you leave it at 0 it
> will be hidden.
> Now, if THIS patch actually works we can think about hooking it up to pref
> window .
>
>
> ---
>
> diff --git a/cinelerra-5.1/cinelerra/batchrender.C
> b/cinelerra-5.1/cinelerra/batchrender.C
> index 6dcdbc62..d85d0e8c 100644
> --- a/cinelerra-5.1/cinelerra/batchrender.C
> +++ b/cinelerra-5.1/cinelerra/batchrender.C
> @@ -60,6 +60,8 @@
> #include "dvdcreate.h"
> #include "bdcreate.h"
>
> +#define UNSAFE_BUTTON 0
> +
> int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
> const char *BatchRenderThread::column_titles[] = {
> N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"),
> N_("EDL"), N_("Elapsed")
> @@ -382,6 +384,7 @@ void BatchRenderThread::use_current_edl()
> gui->edl_path_text->update(get_current_edl());
> }
>
> +
> void BatchRenderThread::update_selected_edl()
> {
> FileXML xml_file;
> @@ -396,6 +399,8 @@ void BatchRenderThread::update_selected_edl()
> }
> }
>
> +
> +
> BatchRenderJob* BatchRenderThread::get_current_job()
> {
> return current_job >= 0 && current_job < jobs.total ?
> @@ -792,8 +797,11 @@ void BatchRenderGUI::create_objects()
> y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
>
> x = x2; y = y2;
> + if (UNSAFE_BUTTON) {
> add_subwindow(update_selected_edl = new
> BatchRenderUpdateEDL(thread, x, y));
> y += update_selected_edl->get_h() + mwindow->theme->widget_border;
> +}
> +
> add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread,
> x, y));
> y += use_current_edl->get_h() + mwindow->theme->widget_border;
> if( !mwindow->edl || !mwindow->edl->path[0] )
> use_current_edl->disable();
> @@ -835,6 +843,7 @@ void BatchRenderGUI::button_disable()
> new_batch->disable();
> delete_batch->disable();
> use_current_edl->disable();
> + if (UNSAFE_BUTTON)
> update_selected_edl->disable();
> }
>
> @@ -844,6 +853,7 @@ void BatchRenderGUI::button_enable()
> delete_batch->enable();
> if( mwindow->edl && mwindow->edl->path[0] )
> use_current_edl->enable();
> + if (UNSAFE_BUTTON)
> update_selected_edl->enable();
> }
>
> @@ -876,8 +886,10 @@ int BatchRenderGUI::resize_event(int w, int h)
> y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
>
> x = x2; y = y2;
> + if (UNSAFE_BUTTON) {
> update_selected_edl->reposition_window(x, y);
> y += update_selected_edl->get_h() + mwindow->theme->widget_border;
> +}
> use_current_edl->reposition_window(x, y);
> y += use_current_edl->get_h() + mwindow->theme->widget_border;
> new_batch->reposition_window(x, y);
> @@ -1236,6 +1248,7 @@ int BatchRenderCurrentEDL::handle_event()
> return 1;
> }
>
> +
> BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
> int x,
> int y)
> @@ -1244,8 +1257,10 @@
> BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
> this->thread = thread;
> }
>
> +
> int BatchRenderUpdateEDL::handle_event()
> {
> + if (UNSAFE_BUTTON)
> thread->update_selected_edl();
> return 1;
> }
>
>
> --
> Cin mailing list
> Cin@lists.cinelerra-gg.org
> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>
--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Debate on batch render
@Andrew Randrianasulu thank you very much, a batch render window like the one in the image you just attached would be perfect. This is what is really expected of a Batch render wizard, that it is simple and without options that can destroy your work by a single unfortunate click. Thank you very much for getting involved in improving the user experience and making the Cinelerra GG editor more secure. @Igor the only thing I can tell you is that I would never use an assistant that can ruin my work and with options that give errors, which have even motivated the opening of tickets due to malfunctions. What we could do is two versions of batch render, one for normal people who do not like to complicate their lives or play with fire and another for suicides who maybe losing their job can cause great joy, but this It is not my case, so I continue to bet on making an assistant for normal people that does not carry unnecessary risks for their video projects. P.S. I am having a hard time convincing people to use Cinelerra, yesterday a user had a sudden shutdown, I quoted something around here ... the last message from him says like this. Thank you very much Rafa, I do not doubt that Cinelerra is very professional and following your recommendations and tutorials I decided to try it, but I am a simple amateur and perhaps it is my fault for not having save regularly, as you always recommended in the kdenlive tutorials . I tried the method you told me, but unfortunately I was getting a blank project, like when I open Cinelerra before loading a project. I really appreciate your help. I think that due to being an amateur with little knowledge, it is better that I continue using Kdenlive, that despite its errors thanks to your tutorials I manage to make my videos satisfactorily and if it closes by mistake then it simply reopens my work without losing much of it. (there is more message but this is the most important) And here the question now is, is it really the fault of this bad experience is a novice user, or these pitfall options that ruin your work? I believe that the problem is the options that should not exist in a serious application, so that it can be used by both amateurs and professionals. At the moment Cinelerra seems to me to be a wonderful editor and the work that GG did with it is admirable, but not everything can be perfect and from my point of view dangerous options such as those that Andrew has removed in the batch render and this option to save the copy Security should be removed to avoid situations that frustrate users. Greetings to all the people who are participating in this debate. El mar, 12 ene 2021 a las 10:51, Igor BEGHETTO via Cin (< cin@lists.cinelerra-gg.org>) escribió: > My quickly reply. > I read all this long debate and the igor_ubuntu's article in his blog > about "Batch Render". > I think that the problem is How many users use that features? > I don't use them but, maybe, somebody yes, as I always said in MantisBT; > then you can not decide if delete/hide a function that is used (?) by > other users, I think. Would be better that a modal window, with a > warning, came out before overwrite a project? Yes. > > I think that a user can do a test on a short video/project (or create a > backup for your own important works) before going on some feature like > Batch Rendering, and reading the Manual: many people are doing a lot of > work to write it. > > I would like to know how many people use this and that function, so a > developer can make the right thing, if he is not a filmaker/editor. > > IgorBeg > -- > Cin mailing list > Cin@lists.cinelerra-gg.org > https://lists.cinelerra-gg.org/mailman/listinfo/cin > -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
[Cin] Attempt at disabling 'Save to EDL' in batchrender GUI at compile-time
This one survived actual batch render - I forgot about enable/disable button
calls
so, if you set UNSAFE_BUTTON to 1 it will appear, if you leave it at 0 it will
be hidden.
Now, if THIS patch actually works we can think about hooking it up to pref
window .
---
diff --git a/cinelerra-5.1/cinelerra/batchrender.C
b/cinelerra-5.1/cinelerra/batchrender.C
index 6dcdbc62..d85d0e8c 100644
--- a/cinelerra-5.1/cinelerra/batchrender.C
+++ b/cinelerra-5.1/cinelerra/batchrender.C
@@ -60,6 +60,8 @@
#include "dvdcreate.h"
#include "bdcreate.h"
+#define UNSAFE_BUTTON 0
+
int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
const char *BatchRenderThread::column_titles[] = {
N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"),
N_("Elapsed")
@@ -382,6 +384,7 @@ void BatchRenderThread::use_current_edl()
gui->edl_path_text->update(get_current_edl());
}
+
void BatchRenderThread::update_selected_edl()
{
FileXML xml_file;
@@ -396,6 +399,8 @@ void BatchRenderThread::update_selected_edl()
}
}
+
+
BatchRenderJob* BatchRenderThread::get_current_job()
{
return current_job >= 0 && current_job < jobs.total ?
@@ -792,8 +797,11 @@ void BatchRenderGUI::create_objects()
y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
x = x2; y = y2;
+ if (UNSAFE_BUTTON) {
add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x,
y));
y += update_selected_edl->get_h() + mwindow->theme->widget_border;
+}
+
add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x,
y));
y += use_current_edl->get_h() + mwindow->theme->widget_border;
if( !mwindow->edl || !mwindow->edl->path[0] )
use_current_edl->disable();
@@ -835,6 +843,7 @@ void BatchRenderGUI::button_disable()
new_batch->disable();
delete_batch->disable();
use_current_edl->disable();
+ if (UNSAFE_BUTTON)
update_selected_edl->disable();
}
@@ -844,6 +853,7 @@ void BatchRenderGUI::button_enable()
delete_batch->enable();
if( mwindow->edl && mwindow->edl->path[0] )
use_current_edl->enable();
+ if (UNSAFE_BUTTON)
update_selected_edl->enable();
}
@@ -876,8 +886,10 @@ int BatchRenderGUI::resize_event(int w, int h)
y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
x = x2; y = y2;
+ if (UNSAFE_BUTTON) {
update_selected_edl->reposition_window(x, y);
y += update_selected_edl->get_h() + mwindow->theme->widget_border;
+}
use_current_edl->reposition_window(x, y);
y += use_current_edl->get_h() + mwindow->theme->widget_border;
new_batch->reposition_window(x, y);
@@ -1236,6 +1248,7 @@ int BatchRenderCurrentEDL::handle_event()
return 1;
}
+
BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
int x,
int y)
@@ -1244,8 +1257,10 @@
BatchRenderUpdateEDL::BatchRenderUpdateEDL(BatchRenderThread *thread,
this->thread = thread;
}
+
int BatchRenderUpdateEDL::handle_event()
{
+ if (UNSAFE_BUTTON)
thread->update_selected_edl();
return 1;
}
diff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C
index 6dcdbc62..d85d0e8c 100644
--- a/cinelerra-5.1/cinelerra/batchrender.C
+++ b/cinelerra-5.1/cinelerra/batchrender.C
@@ -60,6 +60,8 @@
#include "dvdcreate.h"
#include "bdcreate.h"
+#define UNSAFE_BUTTON 0
+
int BatchRenderThread::column_widths[] = { 42, 42, 42, 222, 222, 150 };
const char *BatchRenderThread::column_titles[] = {
N_("Enabled"), N_("Labeled"), N_("Farmed"), N_("Output"), N_("EDL"), N_("Elapsed")
@@ -382,6 +384,7 @@ void BatchRenderThread::use_current_edl()
gui->edl_path_text->update(get_current_edl());
}
+
void BatchRenderThread::update_selected_edl()
{
FileXML xml_file;
@@ -396,6 +399,8 @@ void BatchRenderThread::update_selected_edl()
}
}
+
+
BatchRenderJob* BatchRenderThread::get_current_job()
{
return current_job >= 0 && current_job < jobs.total ?
@@ -792,8 +797,11 @@ void BatchRenderGUI::create_objects()
y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border;
x = x2; y = y2;
+ if (UNSAFE_BUTTON) {
add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y));
y += update_selected_edl->get_h() + mwindow->theme->widget_border;
+}
+
add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x, y));
y += use_current_edl->get_h() + mwindow->theme->widget_border;
if( !mwindow->edl || !mwindow->edl->path[0] ) use_current_edl->disable();
@@ -835,6 +843,7 @@ void BatchRenderGUI::button_disable()
new_batch->disable();
delete_batch->disable();
use_current_edl->disable();
+ if (UNSAFE_BUTTON)
update_selected_edl->disable();
}
@@ -844,6 +853,7 @@ void BatchRenderGUI::button_enable()
delete_batch->enable();
if( mwindow->edl &&
[Cin] UPD: Re: Debate on batch render
OH, NO, this patch actually breaks batch render :/ some more thinking needed even just for hiding this element . SORRY! PS; I see you can use batch render window _without_ any project loaded on timeline -- Пересланное сообщение -- Тема: Re: [Cin] Debate on batch render Дата: Вторник 12 января 2021 Отправитель: Andrew Randrianasulu Получатель: "Cinelerra.GG" В сообщении от Tuesday 12 January 2021 11:13:56 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а): > Thanks again Andrew. I hardly know how to add a repository and if it > doesn't work or doesn't work correctly I go back to the previous one. > Regards. Ok, I think I disabled them by just commenting out their initialization. Button and checkbox disappeared, but probably some state still will be around, so this is NOT for merging, just for testing by interested parties . diff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C index 6dcdbc62..35822142 100644 --- a/cinelerra-5.1/cinelerra/batchrender.C +++ b/cinelerra-5.1/cinelerra/batchrender.C @@ -792,8 +792,8 @@ void BatchRenderGUI::create_objects() y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border; x = x2; y = y2; - add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); - y += update_selected_edl->get_h() + mwindow->theme->widget_border; +// add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); +// y += update_selected_edl->get_h() + mwindow->theme->widget_border; add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x, y)); y += use_current_edl->get_h() + mwindow->theme->widget_border; if( !mwindow->edl || !mwindow->edl->path[0] ) use_current_edl->disable(); @@ -805,8 +805,8 @@ void BatchRenderGUI::create_objects() x += savelist_batch->get_w() + mwindow->theme->widget_border; add_subwindow(loadlist_batch = new BatchRenderLoadList(thread, x, y)); y += loadlist_batch->get_h() + mwindow->theme->widget_border; - add_subwindow(warning = new BatchRenderWarning(thread, x2, y)); - y2 = y + warning->get_h() + mwindow->theme->widget_border; +// add_subwindow(warning = new BatchRenderWarning(thread, x2, y)); +// y2 = y + warning->get_h() + mwindow->theme->widget_border; if( y2 > y1 ) y1 = y2; x = mwindow->theme->batchrender_x1, y = y1; --- Does new window look safer? If you think so - patch sources and try your workflow while I'm thinking/learning about how to add warnings or conditionally show/hide those :} I think my tooltips patch still applicable because it touches different block of code --- -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Debate on batch render
My quickly reply. I read all this long debate and the igor_ubuntu's article in his blog about "Batch Render". I think that the problem is How many users use that features? I don't use them but, maybe, somebody yes, as I always said in MantisBT; then you can not decide if delete/hide a function that is used (?) by other users, I think. Would be better that a modal window, with a warning, came out before overwrite a project? Yes. I think that a user can do a test on a short video/project (or create a backup for your own important works) before going on some feature like Batch Rendering, and reading the Manual: many people are doing a lot of work to write it. I would like to know how many people use this and that function, so a developer can make the right thing, if he is not a filmaker/editor. IgorBeg -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Debate on batch render
В сообщении от Tuesday 12 January 2021 11:13:56 Rafa Mar Multimedia en Gnu\Linux via Cin написал(а): > Thanks again Andrew. I hardly know how to add a repository and if it > doesn't work or doesn't work correctly I go back to the previous one. > Regards. Ok, I think I disabled them by just commenting out their initialization. Button and checkbox disappeared, but probably some state still will be around, so this is NOT for merging, just for testing by interested parties . diff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C index 6dcdbc62..35822142 100644 --- a/cinelerra-5.1/cinelerra/batchrender.C +++ b/cinelerra-5.1/cinelerra/batchrender.C @@ -792,8 +792,8 @@ void BatchRenderGUI::create_objects() y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border; x = x2; y = y2; - add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); - y += update_selected_edl->get_h() + mwindow->theme->widget_border; +// add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); +// y += update_selected_edl->get_h() + mwindow->theme->widget_border; add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x, y)); y += use_current_edl->get_h() + mwindow->theme->widget_border; if( !mwindow->edl || !mwindow->edl->path[0] ) use_current_edl->disable(); @@ -805,8 +805,8 @@ void BatchRenderGUI::create_objects() x += savelist_batch->get_w() + mwindow->theme->widget_border; add_subwindow(loadlist_batch = new BatchRenderLoadList(thread, x, y)); y += loadlist_batch->get_h() + mwindow->theme->widget_border; - add_subwindow(warning = new BatchRenderWarning(thread, x2, y)); - y2 = y + warning->get_h() + mwindow->theme->widget_border; +// add_subwindow(warning = new BatchRenderWarning(thread, x2, y)); +// y2 = y + warning->get_h() + mwindow->theme->widget_border; if( y2 > y1 ) y1 = y2; x = mwindow->theme->batchrender_x1, y = y1; --- Does new window look safer? If you think so - patch sources and try your workflow while I'm thinking/learning about how to add warnings or conditionally show/hide those :} I think my tooltips patch still applicable because it touches different block of code diff --git a/cinelerra-5.1/cinelerra/batchrender.C b/cinelerra-5.1/cinelerra/batchrender.C index 6dcdbc62..35822142 100644 --- a/cinelerra-5.1/cinelerra/batchrender.C +++ b/cinelerra-5.1/cinelerra/batchrender.C @@ -792,8 +792,8 @@ void BatchRenderGUI::create_objects() y2 = y + edl_path_browse->get_h() + mwindow->theme->widget_border; x = x2; y = y2; - add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); - y += update_selected_edl->get_h() + mwindow->theme->widget_border; +// add_subwindow(update_selected_edl = new BatchRenderUpdateEDL(thread, x, y)); +// y += update_selected_edl->get_h() + mwindow->theme->widget_border; add_subwindow(use_current_edl = new BatchRenderCurrentEDL(thread, x, y)); y += use_current_edl->get_h() + mwindow->theme->widget_border; if( !mwindow->edl || !mwindow->edl->path[0] ) use_current_edl->disable(); @@ -805,8 +805,8 @@ void BatchRenderGUI::create_objects() x += savelist_batch->get_w() + mwindow->theme->widget_border; add_subwindow(loadlist_batch = new BatchRenderLoadList(thread, x, y)); y += loadlist_batch->get_h() + mwindow->theme->widget_border; - add_subwindow(warning = new BatchRenderWarning(thread, x2, y)); - y2 = y + warning->get_h() + mwindow->theme->widget_border; +// add_subwindow(warning = new BatchRenderWarning(thread, x2, y)); +// y2 = y + warning->get_h() + mwindow->theme->widget_border; if( y2 > y1 ) y1 = y2; x = mwindow->theme->batchrender_x1, y = y1; -- Cin mailing list Cin@lists.cinelerra-gg.org https://lists.cinelerra-gg.org/mailman/listinfo/cin
Re: [Cin] Debate on batch render
Thanks again Andrew. I hardly know how to add a repository and if it doesn't work or doesn't work correctly I go back to the previous one. Regards. El mar, 12 ene 2021 a las 2:40, Andrew Randrianasulu via Cin (< cin@lists.cinelerra-gg.org>) escribió: > В сообщении от Tuesday 12 January 2021 03:27:41 Rafa Mar Multimedia en > Gnu\Linux via Cin написал(а): > > Thanks Andrew, I don't know how to deactivate these buttons, and it's not > > my place to deactivate them either, I simply recommend from my experience > > to improve Cinelerra and make it interesting and without kamikaze > functions. > > Well, at the beginning I also know nothing about this particular codebase > :} > Try to look at code and guess what line does this or that comment it > out, recompile, try to launch > > > > > I have Audacity 2.4.2 backport from Debian upstream running perfectly on > > Linux Mint 19.3, the only drawback is that the Calf effects interfaces > are > > not graphically pretty, but I don't care, they work just as well with its > > retro-style interface from the late 90s. > > :} > > Yeah, sometimes binary distributions are fine, but mostly when someone > already solved little things like > > https://forum.audacityteam.org/viewtopic.php?t=105237 > https://forum.audacityteam.org/viewtopic.php?f=19=104224 > (I hit error related to re-building right in source tree, instead of > 'build' directory) > > The I realized portaudio was patched in Ubuntu/Debian etc: > > > https://portaudio.music.columbia.narkive.com/rju8OHIE/pa-getstreamhostapitype > > then I realized audacity will not link until you apply > > > https://gitweb.gentoo.org/repo/gentoo.git/tree/media-sound/audacity/files/audacity-2.3.3-Fix-building-against-system-portaudio.patch > > :} > > so, a lot of adventuring, but at least you can see CinGG is not only > software using custom/patched libs ... > > > I don't know what distribution you use, and I'm sure you know 1000 times > > more about this than I do, but just in case, the repositories that have > > allowed me to have Audacity 2.4.2 working perfectly are the ones on this > > website: > > https://launchpad.net/~ubuntuhandbook1/+archive/ubuntu/audacity > > > > El lun, 11 ene 2021 a las 23:51, Andrew Randrianasulu via Cin (< > > cin@lists.cinelerra-gg.org>) escribió: > > > > > В сообщении от Tuesday 12 January 2021 00:57:48 Rafa Mar Multimedia en > > > Gnu\Linux via Cin написал(а): > > > > I have forwarded this valuable information to you, and I hope it is > not > > > too > > > > late. > > > > I understand that a programmer likes to play with the code and do > > > wonders, > > > > but you should consider that a video application is focused on > people who > > > > are NOT computer scientists and that their knowledge is very basic. > > > > > > Well, unlike closed-source applications you also can disable (at least) > > > buttons you do not like > > > _locally_. Yes, such patch may create inconvience later on, if there > will > > > be changes in this area upstream. > > > > > > Sorry, I'm puzzled by another crash (Audacity 2.3.3 crash on launch, > while > > > 2.3.2 works ?! on my system), > > > so I'm a bit distracted from CinelerraGG hacking right now > > > > > > > > > > And > > > > these options "cheat" rather than facilitate the work they make it > > > > difficult. The audiovisual technicians must be given the simple > tools. I > > > do > > > > not know of any application that I work with in my audiovisual > > > professional > > > > field that has the ability to step on a backup by user interaction. > > > > To justify this I would tell you an anecdote that happened during the > > > > production of "Finding Nemo" by Andrew Stanton at Pixar. But I think > I > > > bore > > > > you with my long writings and I don't see an initiative to correct > these > > > > "traps" that Cinelerra contains. Rather the opposite, a strong > attitude > > > in > > > > maintaining them. > > > > Perhaps it could be done as in Kdenlive, Adobe etc.., which after a > > > sudden > > > > shutdown at the next start gives the option to recover the file that > was > > > > being worked with. But I usually go to practicality and if something > is > > > not > > > > useful I eliminate it, I think that eliminating these options (also > the > > > > batch render option) is easier than making special menus for them or > > > what I > > > > just mentioned from kdenlive, which is usually what What > applications do > > > > after a sudden shutdown. > > > > Anyway, thank you very much for the information, I know that some > time > > > ago > > > > you mentioned this about the backup, but I did not remember very well > > > what > > > > it was like, and this user I suppose that when he wrote to me he > would > > > have > > > > already done tests that they will have overwritten this .prev file > > > > Greetings Phyllis. > > > > > > > > El lun, 11 ene 2021 a las 21:56, Phyllis Smith via Cin (< > > > > cin@lists.cinelerra-gg.org>) escribió: > > > > > > >
