Re: [Clfs-dev] Travis-CI?
On Sun, 21 Apr 2019 09:49:52 -0400 Andrew Bradford wrote: > On Sat, Apr 20, 2019 at 7:01 PM William Harrington > wrote: > > > On Apr 19, 2019, at 14:29, Andrew Bradford wrote: > > >> On Tue, Apr 16, 2019 at 11:02 AM Andrew Bradford > > >> wrote: > > >> I'd like to integrate the Travis-CI continuous build solution into at > > >> least the embedded CLFS book. The goal is that any pull requests > > >> would at least get the book to be built by Travis first before > > >> allowing to be merged. This should prevent any merges from happening > > >> where building the book breaks (we've had some issues with this in the > > >> past). Travis seems to have decent integration with Github and I've > > >> observed other projects use Github+Travis together like this. > > > > > > I've gone ahead and implemented this for the Embedded book. > > Not a good move. We are a guide, not a product to deploy to prod. > > Take your CI CD CT mentality elsewhere. Won’t work here. Think about it. > > OK. I'm sorry, I didn't mean to get anyone riled up. I know that we > have existing mechanisms for building the book but thought it might be > valuable to look at other solutions, too. If this is not desired by > core contributors to the book then that's OK. > > I've removed Travis from the Github group, it won't have access to any > repositories any longer. Travis only ever had access to the Embedded > book repository. I'll remove the Embedded book .travis.yml file > shortly. > > Sorry for the noise, > Andrew > ___ > Clfs-dev mailing list > Clfs-dev@lists.clfs.org > http://lists.clfs.org/listinfo.cgi/clfs-dev-clfs.org Hello Andrew, Sorry for my noise. I was a bit hasty. Before commiting any changes, we do a local build to make sure nothing is broke. Of course, the git hook will build the book on the server, too. I'm not sure the value of Travis-CI for the book itself. Maybe some others will chime in. Sincerely, -- Berzerkula ___ Clfs-dev mailing list Clfs-dev@lists.clfs.org http://lists.clfs.org/listinfo.cgi/clfs-dev-clfs.org
Re: [Clfs-dev] Travis-CI?
On Sat, Apr 20, 2019 at 7:01 PM William Harrington wrote: > > On Apr 19, 2019, at 14:29, Andrew Bradford wrote: > >> On Tue, Apr 16, 2019 at 11:02 AM Andrew Bradford wrote: > >> I'd like to integrate the Travis-CI continuous build solution into at > >> least the embedded CLFS book. The goal is that any pull requests > >> would at least get the book to be built by Travis first before > >> allowing to be merged. This should prevent any merges from happening > >> where building the book breaks (we've had some issues with this in the > >> past). Travis seems to have decent integration with Github and I've > >> observed other projects use Github+Travis together like this. > > > > I've gone ahead and implemented this for the Embedded book. > Not a good move. We are a guide, not a product to deploy to prod. > Take your CI CD CT mentality elsewhere. Won’t work here. Think about it. OK. I'm sorry, I didn't mean to get anyone riled up. I know that we have existing mechanisms for building the book but thought it might be valuable to look at other solutions, too. If this is not desired by core contributors to the book then that's OK. I've removed Travis from the Github group, it won't have access to any repositories any longer. Travis only ever had access to the Embedded book repository. I'll remove the Embedded book .travis.yml file shortly. Sorry for the noise, Andrew ___ Clfs-dev mailing list Clfs-dev@lists.clfs.org http://lists.clfs.org/listinfo.cgi/clfs-dev-clfs.org
Re: [Clfs-dev] Travis-CI?
> On Apr 19, 2019, at 14:29, Andrew Bradford wrote: > > Hi All, > >> On Tue, Apr 16, 2019 at 11:02 AM Andrew Bradford wrote: >> I'd like to integrate the Travis-CI continuous build solution into at >> least the embedded CLFS book. The goal is that any pull requests >> would at least get the book to be built by Travis first before >> allowing to be merged. This should prevent any merges from happening >> where building the book breaks (we've had some issues with this in the >> past). Travis seems to have decent integration with Github and I've >> observed other projects use Github+Travis together like this. > > I've gone ahead and implemented this for the Embedded book. It seems > to work well. You can have a look at pull request #18's "checks" > [18] to see how it looks or at the Travis build [travis]. > > [18]: https://github.com/cross-lfs/clfs-embedded/pull/18/checks > [travis]: https://travis-ci.com/cross-lfs/clfs-embedded/builds/109002701 > > Travis automatically picks up any pull requests and will build them > and mark the pull request as good/bad. This is my first time using > Travis but the integration wasn't too bad, if anyone else wants to > adopt a similar ability for the other books I'm happy to help provide > guidance. > Not a good move. We are a guide, not a product to deploy to prod. Take your CI CD CT mentality elsewhere. Won’t work here. Think about it. > Thanks! > -Andrew > ___ > Clfs-dev mailing list > Clfs-dev@lists.clfs.org > http://lists.clfs.org/listinfo.cgi/clfs-dev-clfs.org ___ Clfs-dev mailing list Clfs-dev@lists.clfs.org http://lists.clfs.org/listinfo.cgi/clfs-dev-clfs.org
Re: [Clfs-dev] Travis-CI?
Hi All, On Tue, Apr 16, 2019 at 11:02 AM Andrew Bradford wrote: > I'd like to integrate the Travis-CI continuous build solution into at > least the embedded CLFS book. The goal is that any pull requests > would at least get the book to be built by Travis first before > allowing to be merged. This should prevent any merges from happening > where building the book breaks (we've had some issues with this in the > past). Travis seems to have decent integration with Github and I've > observed other projects use Github+Travis together like this. I've gone ahead and implemented this for the Embedded book. It seems to work well. You can have a look at pull request #18's "checks" [18] to see how it looks or at the Travis build [travis]. [18]: https://github.com/cross-lfs/clfs-embedded/pull/18/checks [travis]: https://travis-ci.com/cross-lfs/clfs-embedded/builds/109002701 Travis automatically picks up any pull requests and will build them and mark the pull request as good/bad. This is my first time using Travis but the integration wasn't too bad, if anyone else wants to adopt a similar ability for the other books I'm happy to help provide guidance. Thanks! -Andrew ___ Clfs-dev mailing list Clfs-dev@lists.clfs.org http://lists.clfs.org/listinfo.cgi/clfs-dev-clfs.org
