Re: [ClojureScript] Clojurescript 1.10.238 fails to compile when using node modules for browser target in windows

2018-03-27 Thread Marat Khafizov
I've been able to reproduce the same thing with the moment.js.

There's opened issue on the 
JIRA: https://dev.clojure.org/jira/browse/CLJS-2708

вторник, 27 марта 2018 г., 21:46:30 UTC+3 пользователь David Nolen написал:
>
> I believe there are issues with React 16 and Google Closure Compiler 
> module processing, try React 15 instead for now.
>
> David
>
> On Tue, Mar 27, 2018 at 3:24 AM, Marat Khafizov  > wrote:
>
>> Hey there.
>>
>> I'm trying to use node destribution of reactjs with js module require.
>>
>> (defproject compile-cljs-node-modules-react "0.1.0-SNAPSHOT"
>>   :description "FIXME: write description"
>>   :url "http://example.com/FIXME";
>>   :license {:name "Eclipse Public License"
>> :url "http://www.eclipse.org/legal/epl-v10.html"}
>>   :dependencies [[org.clojure/clojure "1.8.0"]
>>  [org.clojure/clojurescript "1.10.238"]]
>>   :plugins [[lein-cljsbuild "1.1.7"]]
>>   
>>   :cljsbuild 
>>   {:builds {:app
>>   {:source-paths ["src"]
>>:compiler
>>{:main   "compile-cljs-node-modules-react.core"
>> :asset-path"/js/out"
>> :output-to "target/cljsbuild/public/js/app.js"
>> :output-dir"target/cljsbuild/public/js/out"
>> :source-maptrue
>> :npm-deps  {:react "16.2.0" :react-dom "16.2.0"}
>> :install-deps  true
>> :optimizations :none
>> :pretty-print  true)
>>
>>
>> SImple cljs file:
>> (ns compile-cljs-node-modules-react.core
>>   (:require ["react-dom/server" :as dom-server]
>> [react :as react]))
>>   
>> (defn render-simple-markup []
>>   (dom-server/renderToString (react/createElement "div" nil "Hello, 
>> world!")))
>>
>> When I run
>> lein cljsbuild once app
>>
>> I get the following error:
>> [eval]:85
>> !id.startsWith(goog:);
>>
>>
>> SyntaxError: missing ) after argument list
>> at createScript (vm.js:80:10)
>> at Object.runInThisContext (vm.js:139:10)
>> at Object. ([eval]-wrapper:6:22)
>> at Module._compile (module.js:635:30)
>> at evalScript (bootstrap_node.js:462:27)
>> at startup (bootstrap_node.js:163:9)
>> at bootstrap_node.js:608:3
>>
>> OS: windows 7
>> npm version: 5.5.1
>> node v8.9.3
>>
>> -- 
>> Note that posts from new members are moderated - please be patient with 
>> your first post.
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "ClojureScript" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to clojurescrip...@googlegroups.com .
>> To post to this group, send email to clojur...@googlegroups.com 
>> .
>> Visit this group at https://groups.google.com/group/clojurescript.
>>
>
>

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.


Re: [ClojureScript] Clojurescript 1.10.238 fails to compile when using node modules for browser target in windows

2018-03-27 Thread David Nolen
I believe there are issues with React 16 and Google Closure Compiler module
processing, try React 15 instead for now.

David

On Tue, Mar 27, 2018 at 3:24 AM, Marat Khafizov  wrote:

> Hey there.
>
> I'm trying to use node destribution of reactjs with js module require.
>
> (defproject compile-cljs-node-modules-react "0.1.0-SNAPSHOT"
>   :description "FIXME: write description"
>   :url "http://example.com/FIXME";
>   :license {:name "Eclipse Public License"
> :url "http://www.eclipse.org/legal/epl-v10.html"}
>   :dependencies [[org.clojure/clojure "1.8.0"]
>  [org.clojure/clojurescript "1.10.238"]]
>   :plugins [[lein-cljsbuild "1.1.7"]]
>
>   :cljsbuild
>   {:builds {:app
>   {:source-paths ["src"]
>:compiler
>{:main   "compile-cljs-node-modules-react.core"
> :asset-path"/js/out"
> :output-to "target/cljsbuild/public/js/app.js"
> :output-dir"target/cljsbuild/public/js/out"
> :source-maptrue
> :npm-deps  {:react "16.2.0" :react-dom "16.2.0"}
> :install-deps  true
> :optimizations :none
> :pretty-print  true)
>
>
> SImple cljs file:
> (ns compile-cljs-node-modules-react.core
>   (:require ["react-dom/server" :as dom-server]
> [react :as react]))
>
> (defn render-simple-markup []
>   (dom-server/renderToString (react/createElement "div" nil "Hello,
> world!")))
>
> When I run
> lein cljsbuild once app
>
> I get the following error:
> [eval]:85
> !id.startsWith(goog:);
>
>
> SyntaxError: missing ) after argument list
> at createScript (vm.js:80:10)
> at Object.runInThisContext (vm.js:139:10)
> at Object. ([eval]-wrapper:6:22)
> at Module._compile (module.js:635:30)
> at evalScript (bootstrap_node.js:462:27)
> at startup (bootstrap_node.js:163:9)
> at bootstrap_node.js:608:3
>
> OS: windows 7
> npm version: 5.5.1
> node v8.9.3
>
> --
> Note that posts from new members are moderated - please be patient with
> your first post.
> ---
> You received this message because you are subscribed to the Google Groups
> "ClojureScript" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clojurescript+unsubscr...@googlegroups.com.
> To post to this group, send email to clojurescript@googlegroups.com.
> Visit this group at https://groups.google.com/group/clojurescript.
>

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.


[ClojureScript] Clojurescript 1.10.238 fails to compile with node_modules for browser build

2018-03-27 Thread Marat Khafizov
Hey there.

I'm trying to use node distribution of react 16 with reagent 0.8.0-alpha2. 
I do:

   1. lein new reagent reagent-app
   2. Change reagent version to 0.8.0-alpha2
   3. npm install react react-dom
   4. lein cljsbuild once app

Actual result:

[eval]:85
!id.startsWith(goog:);
   

SyntaxError: missing ) after argument list
at createScript (vm.js:80:10)
at Object.runInThisContext (vm.js:139:10)
at Object. ([eval]-wrapper:6:22)
at Module._compile (module.js:635:30)
at evalScript (bootstrap_node.js:462:27)
at startup (bootstrap_node.js:163:9)
at bootstrap_node.js:608:3

OS: windows 7
npm version: 5.5.1
node v8.9.3


Related issue for 
reagent: https://github.com/reagent-project/reagent/issues/357


Thanks


-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.


[ClojureScript] Clojurescript 1.10.238 fails to compile when using node modules for browser target in windows

2018-03-27 Thread Marat Khafizov
Hey there.

I'm trying to use node destribution of reactjs with js module require.

(defproject compile-cljs-node-modules-react "0.1.0-SNAPSHOT"
  :description "FIXME: write description"
  :url "http://example.com/FIXME";
  :license {:name "Eclipse Public License"
:url "http://www.eclipse.org/legal/epl-v10.html"}
  :dependencies [[org.clojure/clojure "1.8.0"]
 [org.clojure/clojurescript "1.10.238"]]
  :plugins [[lein-cljsbuild "1.1.7"]]
  
  :cljsbuild 
  {:builds {:app
  {:source-paths ["src"]
   :compiler
   {:main   "compile-cljs-node-modules-react.core"
:asset-path"/js/out"
:output-to "target/cljsbuild/public/js/app.js"
:output-dir"target/cljsbuild/public/js/out"
:source-maptrue
:npm-deps  {:react "16.2.0" :react-dom "16.2.0"}
:install-deps  true
:optimizations :none
:pretty-print  true)


SImple cljs file:
(ns compile-cljs-node-modules-react.core
  (:require ["react-dom/server" :as dom-server]
[react :as react]))
  
(defn render-simple-markup []
  (dom-server/renderToString (react/createElement "div" nil "Hello, 
world!")))

When I run
lein cljsbuild once app

I get the following error:
[eval]:85
!id.startsWith(goog:);
   

SyntaxError: missing ) after argument list
at createScript (vm.js:80:10)
at Object.runInThisContext (vm.js:139:10)
at Object. ([eval]-wrapper:6:22)
at Module._compile (module.js:635:30)
at evalScript (bootstrap_node.js:462:27)
at startup (bootstrap_node.js:163:9)
at bootstrap_node.js:608:3

OS: windows 7
npm version: 5.5.1
node v8.9.3

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.


[ClojureScript] Differences in eval-str between ClojureScript 1.9.946 and 1.10.238 ?

2018-03-27 Thread Richard Davies
Hi,

This code
  (cjs/eval-str (cjs/empty-state) "(+ 1 1)" "some.name" {:context :expr 
:eval cjs/js-eval} identity)

executes as expected under 1.9.946, but in 1.10.238 returns nil. Do I need 
to set different compiler options now, or is this a bug?

I have tried eval under both versions and it behaves the same way; it's 
only eval-str that seems to show a difference between versions.

Regards,
Richard

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.