Re: [ClojureScript] Re: Question about code-splitting and loading of dependent modules.

2019-02-01 Thread Khalid Jebbari
Yes I did. Calling load :a loads :b in XHR then nothing, doesn't load :a
afterwards.

On Fri, Feb 1, 2019, 10:44 PM Thomas Heller  You didn't show your config but did you correctly configure that :a
> depends on :b? eg. :depends-on #{:b}? That can't be inferred so you must
> manually configure it.
>
> On Friday, February 1, 2019 at 1:11:20 PM UTC+1, Khalid Jebbari wrote:
>>
>> In case it wasn't clear, the javascript file for :cljs-base is included
>> as a script tag in the html, and it loads :a.
>>
>> On Friday, February 1, 2019 at 1:01:33 PM UTC+1, Khalid Jebbari wrote:
>>>
>>> Hello,
>>>
>>> I create 3 modules in the :modules configuration, say :cljs-base, :a &
>>> :b, and know that module :a depends on code in the module :b (and in
>>> :cljs-base of course). If I manually load only :a with `(cljs.loader/load
>>> :a)`, will it automatically load :b? My local testing seems to show that it
>>> doesn't.
>>>
>>> --
> Note that posts from new members are moderated - please be patient with
> your first post.
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "ClojureScript" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/clojurescript/NwRtAgr9ltc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> clojurescript+unsubscr...@googlegroups.com.
> To post to this group, send email to clojurescript@googlegroups.com.
> Visit this group at https://groups.google.com/group/clojurescript.
>

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.


[ClojureScript] Re: Question about code-splitting and loading of dependent modules.

2019-02-01 Thread Thomas Heller
You didn't show your config but did you correctly configure that :a depends 
on :b? eg. :depends-on #{:b}? That can't be inferred so you must manually 
configure it.

On Friday, February 1, 2019 at 1:11:20 PM UTC+1, Khalid Jebbari wrote:
>
> In case it wasn't clear, the javascript file for :cljs-base is included as 
> a script tag in the html, and it loads :a.
>
> On Friday, February 1, 2019 at 1:01:33 PM UTC+1, Khalid Jebbari wrote:
>>
>> Hello,
>>
>> I create 3 modules in the :modules configuration, say :cljs-base, :a & 
>> :b, and know that module :a depends on code in the module :b (and in 
>> :cljs-base of course). If I manually load only :a with `(cljs.loader/load 
>> :a)`, will it automatically load :b? My local testing seems to show that it 
>> doesn't.
>>
>>

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.


[ClojureScript] Re: Question about code-splitting and loading of dependent modules.

2019-02-01 Thread Khalid Jebbari
In case it wasn't clear, the javascript file for :cljs-base is included as 
a script tag in the html, and it loads :a.

On Friday, February 1, 2019 at 1:01:33 PM UTC+1, Khalid Jebbari wrote:
>
> Hello,
>
> I create 3 modules in the :modules configuration, say :cljs-base, :a & :b, 
> and know that module :a depends on code in the module :b (and in :cljs-base 
> of course). If I manually load only :a with `(cljs.loader/load :a)`, will 
> it automatically load :b? My local testing seems to show that it doesn't.
>
>

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.


[ClojureScript] Question about code-splitting and loading of dependent modules.

2019-02-01 Thread Khalid Jebbari
Hello,

I create 3 modules in the :modules configuration, say :cljs-base, :a & :b, 
and know that module :a depends on code in the module :b (and in :cljs-base 
of course). If I manually load only :a with `(cljs.loader/load :a)`, will 
it automatically load :b? My local testing seems to show that it doesn't.

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.


[ClojureScript] Re: ANN: ClojureScript 1.10.516

2019-02-01 Thread Khalid Jebbari
I get it. Maybe in the future the type inference could inform the Closure 
Compiler of the types, so that it could emit smaller code ? Really curious 
about it.

On Friday, February 1, 2019 at 11:06:49 AM UTC+1, Thomas Heller wrote:
>
>
>
> On Friday, February 1, 2019 at 5:54:13 AM UTC+1, Khalid Jebbari wrote:
>>
>> Can it make bundles smaller ?
>>
>
> Yes in theory, but only by a very small fraction. The cljs.core/str macro 
> may emit less code in certain situations for example but after :advanced 
> optimizations the difference will be very small. So I wouldn't expect any 
> substantial reductions overall, it is mostly about the compile time 
> warnings.
>

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.


[ClojureScript] Re: ANN: ClojureScript 1.10.516

2019-02-01 Thread Thomas Heller


On Friday, February 1, 2019 at 5:54:13 AM UTC+1, Khalid Jebbari wrote:
>
> Can it make bundles smaller ?
>

Yes in theory, but only by a very small fraction. The cljs.core/str macro 
may emit less code in certain situations for example but after :advanced 
optimizations the difference will be very small. So I wouldn't expect any 
substantial reductions overall, it is mostly about the compile time 
warnings.

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at https://groups.google.com/group/clojurescript.