Re: Add net.ifnames=0 to Atomic host
On 12/10/2015 11:11 AM, Colin Walters wrote: On Thu, Dec 10, 2015, at 11:09 AM, Dusty Mabe wrote: This commit is against master.. Can you apply the change to the f23 branch? Done: https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?h=f23 This worked. The device inside the vm is eth0. Can someone confirm this is the case on the virtualbox vagrant box? - Dusty ___ cloud mailing list cloud@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/cloud@lists.fedoraproject.org
Re: Add net.ifnames=0 to Atomic host
On Thu, Dec 10, 2015, at 11:09 AM, Dusty Mabe wrote: > This commit is against master.. Can you apply the change to the f23 branch? Done: https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?h=f23 ___ cloud mailing list cloud@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/cloud@lists.fedoraproject.org
Re: Add net.ifnames=0 to Atomic host
On 09/12/15, Colin Walters wrote:
> On Wed, Dec 9, 2015, at 11:40 AM, Dusty Mabe wrote:
> >
> >
> >
> On 12/04/2015 02:16 PM, Colin Walters wrote:
> > > On Mon, Nov 23, 2015, at 10:35 AM, Dusty Mabe wrote:
> >>
> >>
> >> Right, this would affect them all. As you mention below we were
> >> intending for this ("eth0") to be the case for a long time so I
> >> figured we should fix it. You are right that this would be a change
> >> over how we released F23 atomic and it does have implications for
> >> other environments.
> >
> > Based on that, my instinct here is to only do this change for the
> > Vagrant box. WDYT?
> >
> >
> Ok can you merge the attached patch then?
>
> Done, thank you!
>
> https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?id=80eeba2146f8165b274348113b54b81070116ba7
Same failure [1] in today's tests.
[1] https://apps.fedoraproject.org/autocloud/jobs/828/output
Kushal
--
Fedora Cloud Engineer
CPython Core Developer
CentOS Cloud SIG lead
http://kushaldas.in
___
cloud mailing list
cloud@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/cloud@lists.fedoraproject.org
Re: Add net.ifnames=0 to Atomic host
On 12/09/2015 01:45 PM, Colin Walters wrote:
On Wed, Dec 9, 2015, at 11:40 AM, Dusty Mabe wrote:
On 12/04/2015 02:16 PM, Colin Walters wrote:
> On Mon, Nov 23, 2015, at 10:35 AM, Dusty Mabe wrote: >> >> >> Right, this would affect them all. As you mention below we
were >> intending for this ("eth0") to be the case for a long time so
I >> figured we should fix it. You are right that this would be a
change >> over how we released F23 atomic and it does have
implications for >> other environments. > > Based on that, my
instinct here is to only do this change for > the Vagrant box. WDYT?
Ok can you merge the attached patch then?
Done, thank you!
https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?id=80eeba2146f8165b274348113b54b81070116ba7
This commit is against master.. Can you apply the change to the f23 branch?
Dusty
___
cloud mailing list
cloud@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/cloud@lists.fedoraproject.org
Re: Add net.ifnames=0 to Atomic host
On 12/04/2015 02:16 PM, Colin Walters wrote:
On Mon, Nov 23, 2015, at 10:35 AM, Dusty Mabe wrote: >> >> >> Right, this would affect them all. As you mention below we
were >> intending for this ("eth0") to be the case for a long time so I
>> figured we should fix it. You are right that this would be a change
>> over how we released F23 atomic and it does have implications for >>
other environments. > > Based on that, my instinct here is to only do
this change for > the Vagrant box. WDYT?
Ok can you merge the attached patch then?
>From 70d102865a2f2b6b0bbcf1b2f25b3bdca71c0f32 Mon Sep 17 00:00:00 2001
From: Dusty Mabe
Date: Wed, 9 Dec 2015 11:36:17 -0500
Subject: [PATCH] Fix f23 vagrant atomic host not having eth0 net device name.
Fixes https://fedorahosted.org/cloud/ticket/141
---
fedora-cloud-atomic-vagrant.ks | 7 +++
1 file changed, 7 insertions(+)
diff --git a/fedora-cloud-atomic-vagrant.ks b/fedora-cloud-atomic-vagrant.ks
index 5f5d8ff..0ad0586 100644
--- a/fedora-cloud-atomic-vagrant.ks
+++ b/fedora-cloud-atomic-vagrant.ks
@@ -8,6 +8,13 @@ services --disabled=cloud-init,cloud-init-local,cloud-config,cloud-final
user --name=vagrant --password=vagrant
rootpw vagrant
+# The addition of the net.ifnames=0 and biosdevnames=0 option ensures that
+# even on VirtualBox virt, we get a primary network device with "eth0" as the name
+# This simplifies things and allows a single disk image for both supported Vagrant
+# platforms (virtualbox and kvm)
+bootloader --timeout=1 --append="no_timer_check console=tty1 console=ttyS0,115200n8 net.ifnames=0 biosdevname=0"
+
+
%post --erroronfail
# Work around cloud-init being both disabled and enabled; need
--
2.4.3
___
cloud mailing list
cloud@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/cloud@lists.fedoraproject.org
Re: Add net.ifnames=0 to Atomic host
On Wed, Dec 9, 2015, at 11:40 AM, Dusty Mabe wrote:
>
>
>
On 12/04/2015 02:16 PM, Colin Walters wrote:
> > On Mon, Nov 23, 2015, at 10:35 AM, Dusty Mabe wrote:
>>
>>
>> Right, this would affect them all. As you mention below we were
>> intending for this ("eth0") to be the case for a long time so I
>> figured we should fix it. You are right that this would be a change
>> over how we released F23 atomic and it does have implications for
>> other environments.
>
> Based on that, my instinct here is to only do this change for the
> Vagrant box. WDYT?
>
>
Ok can you merge the attached patch then?
Done, thank you!
https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?id=80eeba2146f8165b274348113b54b81070116ba7
___
cloud mailing list
cloud@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/cloud@lists.fedoraproject.org
Re: Add net.ifnames=0 to Atomic host
On 09/12/15, Colin Walters wrote:
> On Wed, Dec 9, 2015, at 11:40 AM, Dusty Mabe wrote:
> >
> >
> >
> On 12/04/2015 02:16 PM, Colin Walters wrote:
> > > On Mon, Nov 23, 2015, at 10:35 AM, Dusty Mabe wrote:
> >>
> >>
> >> Right, this would affect them all. As you mention below we were
> >> intending for this ("eth0") to be the case for a long time so I
> >> figured we should fix it. You are right that this would be a change
> >> over how we released F23 atomic and it does have implications for
> >> other environments.
> >
> > Based on that, my instinct here is to only do this change for the
> > Vagrant box. WDYT?
> >
> >
> Ok can you merge the attached patch then?
>
> Done, thank you!
>
> https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?id=80eeba2146f8165b274348113b54b81070116ba7
Means we have to wait for the next nightly build to see if it passes or
not. Thanks a lot for the work :)
Kushal
--
Fedora Cloud Engineer
CPython Core Developer
CentOS Cloud SIG lead
http://kushaldas.in
___
cloud mailing list
cloud@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/cloud@lists.fedoraproject.org
Re: Add net.ifnames=0 to Atomic host
On Mon, Nov 23, 2015, at 10:35 AM, Dusty Mabe wrote:
>
>
>
Right, this would affect them all. As you mention below we were
>
intending for this ("eth0") to be the case for a long time so I
>
figured we should fix it. You are right that this would be a change
>
over how we released F23 atomic and it does have implications for
>
other environments.
Based on that, my instinct here is to only do this change for the
Vagrant box. WDYT?
___
cloud mailing list
cloud@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/cloud@lists.fedoraproject.org
Re: Add net.ifnames=0 to Atomic host
On Fri, Nov 20, 2015, at 01:25 PM, Dusty Mabe wrote: > See attached patch for making atomic host have eth0 be the interface by > default: So this is something like the addition of dracut-network by default for PXE-to-Live got us networking in the initramfs, which in turn broke the ifnames change? Your link was only talking about Vagrant, but this change will affect *all* uses of the cloud image, such as EC2, OpenStack, etc. Now, we were clearly *intending* to do this for a long time, going back to what (I believe) mattdm did with the original Fedora Cloud image. That said, while clearly a number of people just do cloud instances with one NIC and hence predictable = eth0 is fine, it's really quite valid to use multiple NICs in any kind of nontrivial situation. And once one does that, the rationale for PIN becomes apparent. I admit I'm only a light EC2 user, so I can't comment on this patch from that angle. From an OpenStack (specifically KVM) point of view, one really important thing to note is that recently virtio-net enumeration order was declared stable: https://github.com/systemd/systemd/commit/54683f0f9b97a8f88aaf4fbb45b4d729057b101c Which definitely affects upgrades. It's worth noting that *currently* on KVM on Fedora 23 one gets PIN due to that change, and this would revert it. I'd like to explore this vagrant issue more to understand how PIN is breaking it. ___ cloud mailing list cloud@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/cloud@lists.fedoraproject.org
