[Cloud-init-dev] [Build #17278385] amd64 build of cloud-init 19.1-2096-ga785462-0ubuntu1+1433~trunk~ubuntu16.04.1 in ubuntu xenial RELEASE [~cloud-init-dev/ubuntu/daily]

[Launchpad Buildd System]

 * Source Package: cloud-init
 * Version: 19.1-2096-ga785462-0ubuntu1+1433~trunk~ubuntu16.04.1
 * Architecture: amd64
 * Archive: ~cloud-init-dev/ubuntu/daily
 * Component: main
 * State: Failed to build
 * Duration: 2 minutes
 * Build Log: 
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+build/17278385/+files/buildlog_ubuntu-xenial-amd64.cloud-init_19.1-2096-ga785462-0ubuntu1+1433~trunk~ubuntu16.04.1_BUILDING.txt.gz
 * Builder: https://launchpad.net/builders/lgw01-amd64-060
 * Source: not available



If you want further information about this situation, feel free to
contact us by asking a question on Launchpad
(https://answers.launchpad.net/launchpad/+addquestion).

-- 
amd64 build of cloud-init 19.1-2096-ga785462-0ubuntu1+1433~trunk~ubuntu16.04.1 
in ubuntu xenial RELEASE
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+build/17278385

You are receiving this email because you created this version of this
package.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

[Cloud-init-dev] [Build #17278386] amd64 build of cloud-init 19.1-2096-ga785462-0ubuntu1+1690~trunk~ubuntu18.10.1 in ubuntu cosmic RELEASE [~cloud-init-dev/ubuntu/daily]

[Launchpad Buildd System]

 * Source Package: cloud-init
 * Version: 19.1-2096-ga785462-0ubuntu1+1690~trunk~ubuntu18.10.1
 * Architecture: amd64
 * Archive: ~cloud-init-dev/ubuntu/daily
 * Component: main
 * State: Failed to build
 * Duration: 2 minutes
 * Build Log: 
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+build/17278386/+files/buildlog_ubuntu-cosmic-amd64.cloud-init_19.1-2096-ga785462-0ubuntu1+1690~trunk~ubuntu18.10.1_BUILDING.txt.gz
 * Builder: https://launchpad.net/builders/lcy01-amd64-004
 * Source: not available



If you want further information about this situation, feel free to
contact us by asking a question on Launchpad
(https://answers.launchpad.net/launchpad/+addquestion).

-- 
amd64 build of cloud-init 19.1-2096-ga785462-0ubuntu1+1690~trunk~ubuntu18.10.1 
in ubuntu cosmic RELEASE
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+build/17278386

You are receiving this email because you created this version of this
package.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

[Cloud-init-dev] [Build #17278384] amd64 build of cloud-init 19.1-2096-ga785462-0ubuntu1+1656~trunk~ubuntu18.04.1 in ubuntu bionic RELEASE [~cloud-init-dev/ubuntu/daily]

[Launchpad Buildd System]

 * Source Package: cloud-init
 * Version: 19.1-2096-ga785462-0ubuntu1+1656~trunk~ubuntu18.04.1
 * Architecture: amd64
 * Archive: ~cloud-init-dev/ubuntu/daily
 * Component: main
 * State: Failed to build
 * Duration: 2 minutes
 * Build Log: 
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+build/17278384/+files/buildlog_ubuntu-bionic-amd64.cloud-init_19.1-2096-ga785462-0ubuntu1+1656~trunk~ubuntu18.04.1_BUILDING.txt.gz
 * Builder: https://launchpad.net/builders/lgw01-amd64-039
 * Source: not available



If you want further information about this situation, feel free to
contact us by asking a question on Launchpad
(https://answers.launchpad.net/launchpad/+addquestion).

-- 
amd64 build of cloud-init 19.1-2096-ga785462-0ubuntu1+1656~trunk~ubuntu18.04.1 
in ubuntu bionic RELEASE
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+build/17278384

You are receiving this email because you created this version of this
package.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

[Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/debian-ntp-template into cloud-init:master

[Dan Watkins]

The proposal to merge ~raharper/cloud-init:fix/debian-ntp-template into 
cloud-init:master has been updated.

Commit message changed to:

templates/ntp.conf.debian.tmpl: fix missing newline for pools

The debian ntp.conf template did not contain a newline for the
comment used to mark the rendered ntp pools configured.  This
resulted in an invalid line:

'# poolspool 0.int.pool.ntp.org iburst'

rather than:

'# pools
 pool 0.int.pool.ntp.org iburst'

This patch fixes the template and updates the unittest to
verify that the rendered templates puts servers and pools
at the beginning of a line.

LP: #1836598

For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/370213
-- 
Your team cloud-init commiters is requested to review the proposed merge of 
~raharper/cloud-init:fix/debian-ntp-template into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

[Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/debian-ntp-template into cloud-init:master

[Ryan Harper]

Ryan Harper has proposed merging ~raharper/cloud-init:fix/debian-ntp-template 
into cloud-init:master.

Commit message:
templates/nto.conf.debian.tmpl: fix missing newline for pools

The debian ntp.conf template did not contain a newline for the
comment used to mark the rendered ntp pools configured.  This
resulted in an invalid line:

'# poolspool 0.int.pool.ntp.org iburst'

rather than:

'# pools
 pool 0.int.pool.ntp.org iburst'

This patch fixes the template and updates the unittest to
verify that the rendered templates puts servers and pools
at the beginning of a line.

LP: #1836598


Requested reviews:
  Server Team CI bot (server-team-bot): continuous-integration
  cloud-init commiters (cloud-init-dev)
Related bugs:
  Bug #1836598 in cloud-init: "cc_ntp generates wrong config for ntpd in debian 
(buster)"
  https://bugs.launchpad.net/cloud-init/+bug/1836598

For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/370213
-- 
Your team cloud-init commiters is requested to review the proposed merge of 
~raharper/cloud-init:fix/debian-ntp-template into cloud-init:master.
diff --git a/templates/ntp.conf.debian.tmpl b/templates/ntp.conf.debian.tmpl
index 3f07eea..affe983 100644
--- a/templates/ntp.conf.debian.tmpl
+++ b/templates/ntp.conf.debian.tmpl
@@ -19,7 +19,8 @@ filegen clockstats file clockstats type day enable
 # pool.ntp.org maps to about 1000 low-stratum NTP servers.  Your server will
 # pick a different set every time it starts up.  Please consider joining the
 # pool: 
-{% if pools -%}# pools{% endif %}
+{% if pools %}# pools
+{% endif %}
 {% for pool in pools -%}
 pool {{pool}} iburst
 {% endfor %}
diff --git a/tests/unittests/test_handler/test_handler_ntp.py b/tests/unittests/test_handler/test_handler_ntp.py
index 0f22e57..79db2e8 100644
--- a/tests/unittests/test_handler/test_handler_ntp.py
+++ b/tests/unittests/test_handler/test_handler_ntp.py
@@ -268,17 +268,20 @@ class TestNtp(FilesystemMockingTestCase):
  template_fn=template_fn)
 content = util.load_file(confpath)
 if client in ['ntp', 'chrony']:
-expected_servers = '\n'.join([
-'server {0} iburst'.format(srv) for srv in servers])
+content_lines = content.splitlines()
+expected_servers = [
+'server {0} iburst'.format(srv) for srv in servers]
 print('distro=%s client=%s' % (distro, client))
-self.assertIn(expected_servers, content,
-  ('failed to render {0} conf'
-   ' for distro:{1}'.format(client, distro)))
-expected_pools = '\n'.join([
-'pool {0} iburst'.format(pool) for pool in pools])
-self.assertIn(expected_pools, content,
-  ('failed to render {0} conf'
-   ' for distro:{1}'.format(client, distro)))
+for sline in expected_servers:
+self.assertIn(sline, content_lines,
+  ('failed to render {0} conf'
+   ' for distro:{1}'.format(client, distro)))
+expected_pools = [
+'pool {0} iburst'.format(pool) for pool in pools]
+for pline in expected_pools:
+self.assertIn(pline, content_lines,
+  ('failed to render {0} conf'
+   ' for distro:{1}'.format(client, distro)))
 elif client == 'systemd-timesyncd':
 expected_content = (
 "# cloud-init generated file\n" +
___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

[Cloud-init-dev] [Merge] ~med/cloud-init:typo_verbatim into cloud-init:master

[Server Team CI bot]

The proposal to merge ~med/cloud-init:typo_verbatim into cloud-init:master has 
been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~med/cloud-init/+git/cloud-init/+merge/367722
-- 
Your team cloud-init commiters is requested to review the proposed merge of 
~med/cloud-init:typo_verbatim into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

[Cloud-init-dev] [Merge] ~med/cloud-init:typo_verbatim into cloud-init:master

[Ryan Harper]

The proposal to merge ~med/cloud-init:typo_verbatim into cloud-init:master has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~med/cloud-init/+git/cloud-init/+merge/367722
-- 
Your team cloud-init commiters is requested to review the proposed merge of 
~med/cloud-init:typo_verbatim into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Cloud-init-dev] [Merge] ~med/cloud-init:typo_verbatim into cloud-init:master

[Server Team CI bot]

Review: Approve continuous-integration

PASSED: Continuous integration, rev:56b5b09cb7382df8e3780c80ed820dc04e41d6ac
https://jenkins.ubuntu.com/server/job/cloud-init-ci/787/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu LTS: Integration
IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/787/rebuild

-- 
https://code.launchpad.net/~med/cloud-init/+git/cloud-init/+merge/367722
Your team cloud-init commiters is requested to review the proposed merge of 
~med/cloud-init:typo_verbatim into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

[Cloud-init-dev] [Merge] ~med/cloud-init:typo_verbatim into cloud-init:master

[David Medberry]

David Medberry has proposed merging ~med/cloud-init:typo_verbatim into 
cloud-init:master.

Commit message:
Fix typo in publicly viewable documentation.

Requested reviews:
  Ryan Harper (raharper)
  Dan Watkins (daniel-thewatkins)
  cloud-init commiters (cloud-init-dev): trivial

For more details, see:
https://code.launchpad.net/~med/cloud-init/+git/cloud-init/+merge/367722

s/verbatum/verbatim/g # single line changed
-- 
Your team cloud-init commiters is requested to review the proposed merge of 
~med/cloud-init:typo_verbatim into cloud-init:master.
diff --git a/doc/examples/cloud-config-datasources.txt b/doc/examples/cloud-config-datasources.txt
index 2651c02..52a2476 100644
--- a/doc/examples/cloud-config-datasources.txt
+++ b/doc/examples/cloud-config-datasources.txt
@@ -38,7 +38,7 @@ datasource:
 # these are optional, but allow you to basically provide a datasource
 # right here
 user-data: |
-   # This is the user-data verbatum
+   # This is the user-data verbatim
 meta-data:
instance-id: i-87018aed
local-hostname: myhost.internal
___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Cloud-init-dev] [Merge] ~med/cloud-init:typo_verbatim into cloud-init:master

[Ryan Harper]

Review: Approve

Thanks!
-- 
https://code.launchpad.net/~med/cloud-init/+git/cloud-init/+merge/367722
Your team cloud-init commiters is requested to review the proposed merge of 
~med/cloud-init:typo_verbatim into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master

[Chad Smith]

Waiting on this change of behavior until after 19.2 upstream release
-- 
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792
Your team cloud-init commiters is requested to review the proposed merge of 
~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master

[Chad Smith]

The proposal to merge ~chad.smith/cloud-init:feature/ec2-secondary-nics into 
cloud-init:master has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792
-- 
Your team cloud-init commiters is requested to review the proposed merge of 
~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/net-wait-for-interfaces into cloud-init:master

[Server Team CI bot]

Review: Needs Fixing continuous-integration

FAILED: Continuous integration, rev:13440971487dba5f8708a22ef6745e8172bcd642
https://jenkins.ubuntu.com/server/job/cloud-init-ci/784/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/784/rebuild

-- 
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/37
Your team cloud-init commiters is requested to review the proposed merge of 
~raharper/cloud-init:fix/net-wait-for-interfaces into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp