Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-integration-snappy into cloud-init:master
Updated the test content to check that snapd is installed using dpkg output rather than relying on --version output. -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324430 Your team cloud-init commiters is requested to review the proposed merge of ~powersj/cloud-init:fix-integration-snappy into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-integration-snappy into cloud-init:master
Review: Approve continuous-integration PASSED: Continuous integration, rev:201e100de762c6ce47e0639eaf12449f29253344 https://jenkins.ubuntu.com/server/job/cloud-init-ci/373/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/373 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-arm64/373 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-ppc64el/373 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-s390x/373 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=vm-i386/373 Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/373/rebuild -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324430 Your team cloud-init commiters is requested to review the proposed merge of ~powersj/cloud-init:fix-integration-snappy into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-integration-snappy into cloud-init:master
We could have a version-based check, however the version that breaks this, 2.26, is in proposed and about to migrate to all supported releases at any day. I certainly expect this to be fixed unless someone tells me that what we are doing (e.g. running snapd in a container) isn't allowed. My original intent with the test was to confirm that "system_snappy: auto" works by setting up and install snapd on the target system and using 'snap --version' seemed like the best method to confirm that is installed. However, this bug has shown that the output of --version changes based on whether snapd is even running. Thoughts? -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324430 Your team cloud-init commiters is requested to review the proposed merge of ~powersj/cloud-init:fix-integration-snappy into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp