Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
it builds in an schroot because your schroot has 'udevadm' and 'systemd-detect-virt', but those are not build-dependencies so they are not guaranteed, and not present in launchpad provided schroots. On Fri, Aug 17, 2018 at 8:38 AM Louis Bouchard wrote: > Hello, > > Sorry for the long delay, I was away on vacation. > > Indeed, I could not make sense of your suggestion and I was about to ask. > > I just merged your suggestion & uploaded to my branch so it should fix the > build. I still don't understand why it builds in a schroot and not on the > builder though. > > Kind regards, > > ...Louis > -- > https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/349420 > You are subscribed to branch cloud-init:master. > -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/349420 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Hello, Sorry for the long delay, I was away on vacation. Indeed, I could not make sense of your suggestion and I was about to ask. I just merged your suggestion & uploaded to my branch so it should fix the build. I still don't understand why it builds in a schroot and not on the builder though. Kind regards, ...Louis -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/349420 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Bah. i realize i didn'tpaste what I thought i did. fail. Louis, this is better: http://paste.ubuntu.com/p/M9fsfvbWZf/ Please let me know if you have any questions. -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/349420 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Louis, Here is a commit that will fix your unit tests to not run 'udevadm settle'. They're failing because udevadm is not in the package build environment. http://paste.ubuntu.com/p/hb2xG6Cb8h/ -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/349420 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Hello, Looks like the CI problem is not caused by the MR but by a missing package, like the previous MR. -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/349420 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:5a5d3d991c21f87b769810b32721af7775766814 https://jenkins.ubuntu.com/server/job/cloud-init-ci/163/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests FAILED: Ubuntu LTS: Build Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/163/rebuild -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/349420 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:5a5d3d991c21f87b769810b32721af7775766814 https://jenkins.ubuntu.com/server/job/cloud-init-ci/162/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests FAILED: Ubuntu LTS: Build Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/162/rebuild -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c57a17e96e71c061001b03b87accc80802d04b97 https://jenkins.ubuntu.com/server/job/cloud-init-ci/161/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/161/rebuild -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:94be424ac8eea55397e8d20cca28c67089b40aad https://jenkins.ubuntu.com/server/job/cloud-init-ci/160/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/160/rebuild -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Louis, Chad's code to add "event types" is landed in master now at be9ecc12823 [1]. I'd like to see this branch utilize that. Chad has started changes for Azure to take advantage of "per boot" (EventType.BOOT) network changes at [2]. That should give you a good reference to go from. If you have any questions, please feel free to ask. [1] https://git.launchpad.net/cloud-init/commit/?id=be9ecc12823 [2] https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/348704 Scott -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Hello, Is it possible to have an update on the status of this merge request ? Scaleway has now deployed cloud-init and we are obliged to maintain our own version of the Network Enabled datasource while this is being processed. Thank you for your help, ...Louis -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Hello Scott, Thanks for your help. Scaleway users have the possibility of changing IP adresses of their instances between reboots, so such a change would not be taken into account if the DataSourceScaleway cannot redo the network configuration at each boot. Prior to that, this was done by a systemd enabled script. It is particularly required for our IPv6 configuration that fails when done by cloud-init atm. I am not against changing our way of doing things though. My first idea was to add the network config in /etc/cloud/cloud.cfg.d which worked but only once and then got stomped by a reboot. So I am opened to suggestions. As a side node, I will prepare a second MR for the check_instance_id() method. Kind regards, ...Louis -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Louis, I adjusted the subject line of the 'commit' message above. In your commit message, you say: "DEP_NETWORK is removed since the network config must run at each boot.". The behavior described there "run at each boot." is actually a bug. At this point, cloud-init is supposed to only render networking information once per instance-id. That way it won't stomp on users changes. Normally, cloud-init will check "is this a new instance" before re-writing networking infrormation. The reason you probably are seeing "at each boot" is that Scaleway is missing a 'check_instance_id'. See as example the Azure definition: def check_instance_id(self, sys_cfg): # quickly (local check only) if self.instance_id is still valid return sources.instance_id_matches_system_uuid(self.get_instance_id()) We are actually doing some work right now to allow networking configuration to be done more frequently than "per-instance", with the ultimate goal of being able to have cloud-init handle hot-plug or new IP addresses available in the metadata service. So.. Do you *need* cloud-init to render this more than once per instance? Will the result change in the life of an instance? Scott -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Louis, Sorry for the slow reply. I think this will help you out. http://paste.ubuntu.com/p/3YVFKhG83Z/ the issue is that udevadm was getting called, and it is not present in the build enviornment. so we have to mock out the call to m_fallback_nic. we could probably stand to re-oganize some of this so that we didn't have to mock so much, but the patch above should solve your issue. -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:8005b83789ff2f256067aa866dae9e27f4894957 https://jenkins.ubuntu.com/server/job/cloud-init-ci/91/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests FAILED: Ubuntu LTS: Build Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/91/rebuild -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:0aebca0e636b905f02b132c8855ab0e46e3aade0 https://jenkins.ubuntu.com/server/job/cloud-init-ci/90/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/90/rebuild -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev: https://jenkins.ubuntu.com/server/job/cloud-init-ci/83/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/83/rebuild -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:d99396dd52b69d3ee54beeaf97c99e23620b7a0c https://jenkins.ubuntu.com/server/job/cloud-init-ci/82/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/82/rebuild -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Branch fixed & force pushed. -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:ff0c6a2a4805ee8abe5e753886aa74218aedcec0 https://jenkins.ubuntu.com/server/job/cloud-init-ci/81/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/81/rebuild -- https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973 Your team cloud-init commiters is requested to review the proposed merge of ~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
