Re: [Cluster-devel] [PATCH] resource-agents: Find any descendant IP resource of a service

2011-09-30 Thread Michael Bunk
Am 28.09.2011 22:35, schrieb Lon Hohberger:
 On 09/28/2011 07:19 AM, Michael Bunk wrote:
 Not just immediate children.  This fixes errors in sylog like this:

 rgmanager[]: Looking For IP Addresses [apache:apache]  Failed -
 No IP Addresses Found
 
 I -think- it was intentional; if it's not at the top level, you can do
 things like:
 
   service
 apache
   ip/
 /apache
   /service
 
 The // will then find that IP, but the configuration generated by apache
 resource agent will be incorrect and cause the Apache instance to fail
 to start: it will try to bind to the IP address.
 
 I suppose that's a degenerate case, however.

Yes, that is pathological... but our case - which worked in RHEL 4 -
looks like this:

service
  script ref=tiebreaker
 script file=/etc/cluster/drbd0 name=drbd0 ...
fs device=/dev/drbd0 ...
  ip ...
apache/
  /ip
/fs
  /script
/script
/service

It doesn't feel right to make the ip resource a sibling of the
tiebreaker script.

If ip resources are required to be put directly under service, then
the docs (without having read them every word) should mention this and
the XML schema for cluster.conf should enforce it.

Michael



Re: [Cluster-devel] dlm: master - dlm_controld: remove ccs and new Makefile

2011-09-30 Thread Fabio M. Di Nitto
On 09/30/2011 12:02 AM, David Teigland wrote:

 add a normal, sane Makefile

If you plan to drop autoconf+autotool, that is your call (I disagree for
several reasons, but it's your project and I am not going to argue), but
you need to do it all over the tree, basically going back to something
similar in what's in STABLE31.

Placing a Makefile there, will be overridden by ./autogen.sh +
configure, that looks obvious to use since they are there in the top dir.

If you just need help to include those new options you need in
Makefile.am, I am more than happy to help you.

Fabio



Re: [Cluster-devel] dlm: master - dlm_controld: remove ccs and new Makefile

2011-09-30 Thread David Teigland
On Fri, Sep 30, 2011 at 01:07:01PM +0200, Fabio M. Di Nitto wrote:
 On 09/30/2011 12:02 AM, David Teigland wrote:
 
  add a normal, sane Makefile
 
 If you plan to drop autoconf+autotool, that is your call (I disagree for
 several reasons, but it's your project and I am not going to argue), but
 you need to do it all over the tree, 

yep, I'm getting there



Re: [Cluster-devel] dlm: master - dlm: clear out old stuff and build system

2011-09-30 Thread Fabio M. Di Nitto
Hi David,

you have gone a bit too heavy handed on this one :)

On 09/30/2011 11:57 PM, David Teigland wrote:

dlm: clear out old stuff and build system

Signed-off-by: David Teigland teigl...@redhat.com
---

 dlm/libdlm/libdlm.pc.in   |   11 -
 dlm/libdlm/libdlm_lt.pc.in|   11 -

dropping the .pc file is going to break dlm users.

pc files are used by different build systems (not just
autotools/autoconf) to detect libdlm and link against it correctly.

Similar to what you use for libxml2 in your new build system, they
provide pkg-config information.

 doc/COPYING.applications  |  339 
 doc/COPYING.libraries |  510 
 doc/COPYRIGHT |   42 -
 doc/README.licence|   33 -

You need those files to keep the project under the proper licence and
copyright to the right people.

Even if they are not in this exact form, you will need COPYING.app|libs
and a COPYRIGHT file. Alternatively you need to add those info to each
file in the project.

Fabio