[Cluster-devel] [GFS2 PATCH] GFS2: call d_add for a NULL entry when an inode lookup fails
Hi,
This patch was originally written by Benjamin Coddington (credit where
credit is due).
GFS2's inode lookup wasn't hashing the dentry when an inode wasn't found.
That caused the dentry/inode to get an early cleanup attempt through
dentry_kill when a create op cleaned up the filehandle. That caused the
entry to hang around until unmount time, which means if the file was
created then deleted, its space and inode were not reclaimed until then.
This problem was introduced by gfs2's new atomic open code. The patch
simply adds the d_add (as other file systems do) when inode lookups fail.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
---
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index e62e594..9317ddc 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -840,8 +840,10 @@ static struct dentry *__gfs2_lookup(struct inode *dir,
struct dentry *dentry,
int error;
inode = gfs2_lookupi(dir, &dentry->d_name, 0);
- if (!inode)
+ if (inode == NULL) {
+ d_add(dentry, NULL);
return NULL;
+ }
if (IS_ERR(inode))
return ERR_CAST(inode);
Re: [Cluster-devel] [Pacemaker] [Linux-HA] [RFC] Organizing HA Summit 2015
On 09/09/14 12:36 PM, Fabio M. Di Nitto wrote: On 09/09/2014 06:31 PM, Alan Robertson wrote: My apologizes for spamming everyone. I thought I deleted all the other email addresses. I failed. Apologies :-( I think it's good that we have an open discussion with all parties involved. I hardly fail to see that as an issue. Apologies not accepted ;) Fabio +1 to err'ing on the side of too much talk. :) -- Digimer Papers and Projects: https://alteeve.ca/w/ What if the cure for cancer is trapped in the mind of a person without access to education?
Re: [Cluster-devel] [Linux-HA] [RFC] Organizing HA Summit 2015
My apologizes for spamming everyone. I thought I deleted all the other email addresses. I failed. Apologies :-( -- Alan Robertson al...@unix.sh
Re: [Cluster-devel] [Linux-HA] [RFC] Organizing HA Summit 2015
Hi Fabio, Do you know much about the Brno DevConf? I was wondering if the Assimilation Project might be interesting to the audience there. http://assimilationsystems.com/ http://assimproj.org/ It's related to High Availability in that we monitor systems and services with zero configuration - we even use OCF RAs ;-). Because of that, we could eventually intervene in systems - restarting services, or even migrating them. That's not in current plans, but it is technically very possible. But it's so much more than that - and HUGELY scalable - 10K servers without breathing hard, and 100K servers without proxies, etc. It also discovers systems, services, dependencies, switch connections, and lots of other things. Basically everything is done with near-zero configuration. We wind up with a graph database describing everything in great detail - and it's continually up to date. I don't know if you know me, but I founded the Linux-HA project and led it for about 10 years. -- Alan Robertson al...@unix.sh On 09/08/2014 04:30 AM, Fabio M. Di Nitto wrote: > All, > > it's been almost 6 years since we had a face to face meeting for all > developers and vendors involved in Linux HA. > > I'd like to try and organize a new event and piggy-back with DevConf in > Brno [1]. > > DevConf will start Friday the 6th of Feb 2015 in Red Hat Brno offices. > > My suggestion would be to have a 2 days dedicated HA summit the 4th and > the 5th of February. > > The goal for this meeting is to, beside to get to know each other and > all social aspect of those events, tune the directions of the various HA > projects and explore common areas of improvements. > > I am also very open to the idea of extending to 3 days, 1 one dedicated > to customers/users and 2 dedicated to developers, by starting the 3rd. > > Thoughts? > > Fabio > > PS Please hit reply all or include me in CC just to make sure I'll see > an answer :) > > [1] http://devconf.cz/ > ___ > Linux-HA mailing list > linux...@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha > See also: http://linux-ha.org/ReportingProblems
Re: [Cluster-devel] [Linux-HA] [RFC] Organizing HA Summit 2015
On 09/09/2014 06:31 PM, Alan Robertson wrote: > My apologizes for spamming everyone. > > I thought I deleted all the other email addresses. > > I failed. > > Apologies :-( I think it's good that we have an open discussion with all parties involved. I hardly fail to see that as an issue. Apologies not accepted ;) Fabio
Re: [Cluster-devel] [Linux-HA] [RFC] Organizing HA Summit 2015
Hi Alan, On 09/09/2014 03:11 PM, Alan Robertson wrote: > Hi Fabio, > > Do you know much about the Brno DevConf? It would be my first visit to DevConf so not much really :) > > I was wondering if the Assimilation Project might be interesting to the > audience there. > http://assimilationsystems.com/ > http://assimproj.org/ > > It's related to High Availability in that we monitor systems and > services with zero configuration - we even use OCF RAs ;-). Because of > that, we could eventually intervene in systems - restarting services, or > even migrating them. That's not in current plans, but it is technically > very possible. I don't see why not. HA Summit != pacemaker ;) Having a pool of presentations from other HA related project would be cool. > > But it's so much more than that - and HUGELY scalable - 10K servers > without breathing hard, and 100K servers without proxies, etc. It also > discovers systems, services, dependencies, switch connections, and lots > of other things. Basically everything is done with near-zero > configuration. We wind up with a graph database describing everything > in great detail - and it's continually up to date. sounds interesting. Would you be willing to join us for a presentation/demo? > > I don't know if you know me, but I founded the Linux-HA project and led > it for about 10 years. Yeps, your name is very well known :) Cheers Fabio > > -- Alan Robertson > al...@unix.sh > > > On 09/08/2014 04:30 AM, Fabio M. Di Nitto wrote: >> All, >> >> it's been almost 6 years since we had a face to face meeting for all >> developers and vendors involved in Linux HA. >> >> I'd like to try and organize a new event and piggy-back with DevConf in >> Brno [1]. >> >> DevConf will start Friday the 6th of Feb 2015 in Red Hat Brno offices. >> >> My suggestion would be to have a 2 days dedicated HA summit the 4th and >> the 5th of February. >> >> The goal for this meeting is to, beside to get to know each other and >> all social aspect of those events, tune the directions of the various HA >> projects and explore common areas of improvements. >> >> I am also very open to the idea of extending to 3 days, 1 one dedicated >> to customers/users and 2 dedicated to developers, by starting the 3rd. >> >> Thoughts? >> >> Fabio >> >> PS Please hit reply all or include me in CC just to make sure I'll see >> an answer :) >> >> [1] http://devconf.cz/ >> ___ >> Linux-HA mailing list >> linux...@lists.linux-ha.org >> http://lists.linux-ha.org/mailman/listinfo/linux-ha >> See also: http://linux-ha.org/ReportingProblems
