Re: [clutter] gnome-shell crashes using clutter git master repository

[Piñeiro]

From: Neil Roberts n...@linux.intel.com
 I found this commit:
 
 commit 380e7b8b5d0f3a12e8132a24c637151cc0f07261
 Author: Neil Roberts n...@linux.intel.com
 Date:   Mon May 24 12:40:11 2010 +0100
 
 cogl: Use a CoglBitmask to store the list of used texcoord arrays
 
 I've just tested it with git master and it is working fine for me. We
 had a problem with an accidental ABI break in a59bd4cfbb recently. Could

Urgh, this commit is from a patch of mine...

 it be that you've caught this commit and built gnome shell against it,
 then upgraded to master which fixes the ABI break so your gnome shell
 build is broken? It would be good if you could rebuild everything that
 depends on Clutter to verify this.

Well, IMHO, this is very unlikely. This morning I made an additional
test, using git master but removing just this specific commit (git
rebase -i is wonderful), and it works fine. In the same, as far as I
remember, while I was trying to check it, I mostly compile
mutter/gnome-shell using -afc.

Anyway, I will try to rebuild everything as you suggested. I will
report that soon.

 That problem might explain why it doesn't crash in a sensible place. The
 ABI break could make it jump to an invalid address.

Well, the two previous cases I had a weird behaviour with Clutter was
due NVIDIA drivers, this is the reason I pointed that. Have you tried
with NVIDIA drivers?

BR

===
API (apinhe...@igalia.com)
-- 
To unsubscribe send a mail to clutter+unsubscr...@o-hand.com

Re: [clutter] gnome-shell crashes using clutter git master repository

[Neil Roberts]

I could also replicate the problem on an nvidia box and I've pushed the
patch below which seems to fix it. test-conformance was also failing on
nvidia. I messed up the texcoord array caching patch so it wasn't
disabling arrays properly and it would probably end up reading stale
memory in glDrawArrays. Presumably we were getting away with this on
Mesa.

commit 401892af1188073dc3107832b8e2e908c5c0e79e
Author: Neil Roberts n...@linux.intel.com
Date:   Thu May 27 14:51:44 2010 +0100

cogl: Record new enabled arrays in _cogl_disable_other_texcoord_arrays

When _cogl_disable_other_texcoord_arrays is called it disables the
neccessary texcoord arrays and then removes the bits for the disabled
arrays in ctx-texcoord_arrays_enabled. However none of the places
that call the function then set any bits in ctx-texcoord_arrays_enabled
so the arrays would never get marked and they would never get disabled
again.

This patch just changes it so that _cogl_disable_other_texcoord_arrays
also sets the corresponding bits in ctx-texcoord_arrays_enabled.

- Neil
-- 
To unsubscribe send a mail to clutter+unsubscr...@o-hand.com