Re: [cmake-developers] [PATCH] LoadCommand test: cleanup
On Mon, Oct 17, 2011 at 9:18 AM, Rolf Eike Beer e...@sf-mail.de wrote:
On 10/6/2011 8:24 AM, Rolf Eike Beer wrote:
Bill, that Watcom stuff was introduced by you in
9891260a6dab66c9ea44b5c2e244f3128625baf5.
I simply assumed it was a debug leftover as setting a variable to the
value
it already has looks pretty pointless to me.
diff --git a/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
b/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
index 953d05c..5cdbc59 100644
--- a/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
+++ b/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
@@ -5,9 +5,6 @@ IF (MUDSLIDE_TYPE MATCHES MUCHO)
ADD_DEFINITIONS(-DMUCHO_MUDSLIDE)
ENDIF (MUDSLIDE_TYPE MATCHES MUCHO)
-IF(WATCOM)
- SET(CMAKE_C_FLAGS ${CMAKE_C_FLAGS})
-ENDIF(WATCOM)
Hmmm... It could be some sort of odd escape thing going on that an
extra pass by the CMake parser fixes... I guess we can push it into the
dashboard and see if it fails. I can not remember at this point, but
watcom is a picky odd compiler.
Is anyone going to pick this patch up?
Eike
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Why is this patch important?
Sometimes, some of the useless checking that we do in the CMake test
suite is to make sure there's better code coverage on the dashboard,
even if the results of checks are not used. I don't think that's the
case here... but there are sometime non-obvious reasons behind some of
the lines in our tests.
Since this is just in the test suite, I see no reason to rush it into
a release at the last minute.
(But if it's important to you, I'm willing to be convinced that it
should be in the release... But you'll have to convince me.)
Thanks,
David
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] Fixes to ExternalProject and it's tests
On Tue, Nov 1, 2011 at 1:52 PM, Rolf Eike Beer e...@sf-mail.de wrote: These two patches address some issues I found: -ExternalProject_Add(... DEPENDS something) does not work if that something is not itself created by ExternalProject_Add(). Fixed and testcase added. -The testcases for ExternalProject fail to detect on my German system my Subversion version. We had the issue back in the FindSubversion.cmake some time again and fixed it there, no need to duplicate the old wrong code here. The patches are independent of each other. Greetings, Eike -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers I'm not convinced the DEPENDS patch makes things better... ExternalProject works best (and is easiest to think about) when it is used in a SuperBuild sort of scenario in which *all* the targets are ExternalProject targets. Encouraging users to mix EP targets and non-EP targets is a mistake, I think. While it is allowed and achievable to mix things, it is certainly not easy, and requires mucho understanding and thought. Besides, you can easily do an add_dependencies after adding an ExternalProject if it depends on something else in your build that is not an ExternalProject. I'm not dead set against the DEPENDS patch, but I don't see it as urgent. What do others here think? The subversion patch, though, looks pretty reasonable. I'll merge that and push to 'next' later today. Thanks, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] LoadCommand test: cleanup
On Mon, Oct 17, 2011 at 9:18 AM, Rolf Eike Beer e...@sf-mail.de wrote:
On 10/6/2011 8:24 AM, Rolf Eike Beer wrote:
Bill, that Watcom stuff was introduced by you in
9891260a6dab66c9ea44b5c2e244f3128625baf5.
I simply assumed it was a debug leftover as setting a variable to the
value it already has looks pretty pointless to me.
diff --git a/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
b/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
index 953d05c..5cdbc59 100644
--- a/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
+++ b/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
@@ -5,9 +5,6 @@ IF (MUDSLIDE_TYPE MATCHES MUCHO)
ADD_DEFINITIONS(-DMUCHO_MUDSLIDE)
ENDIF (MUDSLIDE_TYPE MATCHES MUCHO)
-IF(WATCOM)
- SET(CMAKE_C_FLAGS ${CMAKE_C_FLAGS})
-ENDIF(WATCOM)
Hmmm... It could be some sort of odd escape thing going on that an
extra pass by the CMake parser fixes... I guess we can push it into
the
dashboard and see if it fails. I can not remember at this point, but
watcom is a picky odd compiler.
Is anyone going to pick this patch up?
Why is this patch important?
Sometimes, some of the useless checking that we do in the CMake test
suite is to make sure there's better code coverage on the dashboard,
even if the results of checks are not used. I don't think that's the
case here... but there are sometime non-obvious reasons behind some of
the lines in our tests.
Since this is just in the test suite, I see no reason to rush it into
a release at the last minute.
(But if it's important to you, I'm willing to be convinced that it
should be in the release... But you'll have to convince me.)
Well, I don't think it's that important that you should do an extra test
or whatever for the next release. It's just that this code, well, looks
totally wrong. And I would like for this to eventually go upstream. No
problem if you put it in some branch and wait for it until the development
for 2.8.8 opens.
Otherwise this code just looks wrong (tm). If this actually changes
anything this looks like a real bug we should find better sooner than
later, no? ;)
About the coverage: I thought about this, but putting stuff in some
totally unrelated tests just doesn't feel right at all. We should try to
get some coverage e.g. for the CheckSymbolExists testcase that could prove
why this is broken for some gcc optimization settings so that the
FindThreads patch I sent didn't work. So if coverage is a problem this
should go into it's own test that clearly states what it is testing and
why and not being hidden in some other random test.
Greetings,
Eike
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Git fun
I used to be able to push directly to next, because I'm a Module maintainer. Now I get this: $ git push origin next Enter passphrase for key '/Users/jbigler/.ssh/id_rsa': Counting objects: 12, done. Delta compression using up to 2 threads. Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 1001 bytes, done. Total 7 (delta 5), reused 0 (delta 0) -- James Bigler jamesbig...@gmail.com may not push directly to this repository. Use the CMake Topic Stage to merge your topic: http://www.cmake.org/Wiki/CMake/Git#Topic_Stage -- error: hook declined to update refs/heads/next To g...@cmake.org:cmake.git ! [remote rejected] next - next (hook declined) error: failed to push some refs to 'g...@cmake.org:cmake.git' OK. So I tried to do a stage merge: $ git checkout CUDAv3.2PathChanges Switched to branch 'CUDAv3.2PathChanges' $ git push stage HEAD fatal: 'stage' does not appear to be a git repository fatal: The remote end hung up unexpectedly $ git branch * CUDAv3.2PathChanges master next topics/CudaRTEmuLibraryForCUDA30 topics/FindCUDA-allow-g3 topics/FixCudaVersionAfterFirstRun Can anyone help with with my ignorance of Git? The only thing I used Git for is CMake and I just don't use it enough to learn all the nooks and crannies of this tool. Thanks, James -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Git fun
James, You have not defined stage as the nickname for the remote repository. If you set it up with `git remote add stage g...@cmake.org:stage/cmake.git`, then your push syntax should work. Alternately, `git push g...@cmake.org:stage/cmake.git CUDAv3.2PathChanges` would push using the full name. Richard On Dec 5, 2011, at 4:41 PM, James Bigler wrote: I used to be able to push directly to next, because I'm a Module maintainer. Now I get this: $ git push origin next Enter passphrase for key '/Users/jbigler/.ssh/id_rsa': Counting objects: 12, done. Delta compression using up to 2 threads. Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 1001 bytes, done. Total 7 (delta 5), reused 0 (delta 0) -- James Bigler jamesbig...@gmail.com may not push directly to this repository. Use the CMake Topic Stage to merge your topic: http://www.cmake.org/Wiki/CMake/Git#Topic_Stage -- error: hook declined to update refs/heads/next To g...@cmake.org:cmake.git ! [remote rejected] next - next (hook declined) error: failed to push some refs to 'g...@cmake.org:cmake.git' OK. So I tried to do a stage merge: $ git checkout CUDAv3.2PathChanges Switched to branch 'CUDAv3.2PathChanges' $ git push stage HEAD fatal: 'stage' does not appear to be a git repository fatal: The remote end hung up unexpectedly $ git branch * CUDAv3.2PathChanges master next topics/CudaRTEmuLibraryForCUDA30 topics/FindCUDA-allow-g3 topics/FixCudaVersionAfterFirstRun Can anyone help with with my ignorance of Git? The only thing I used Git for is CMake and I just don't use it enough to learn all the nooks and crannies of this tool. Thanks, James -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Git fun
Thanks, that fixed it. I also updated the wiki page, so the next poor person to come along doesn't beat their head over it. http://www.cmake.org/Wiki/CMake/Git/Develop#Share_a_Topic James On Mon, Dec 5, 2011 at 3:57 PM, Richard Wackerbarth rich...@nfsnet.orgwrote: James, You have not defined stage as the nickname for the remote repository. If you set it up with `git remote add stage g...@cmake.org:stage/cmake.git`, then your push syntax should work. Alternately, `git push g...@cmake.org:stage/cmake.git CUDAv3.2PathChanges` would push using the full name. Richard On Dec 5, 2011, at 4:41 PM, James Bigler wrote: I used to be able to push directly to next, because I'm a Module maintainer. Now I get this: $ git push origin next Enter passphrase for key '/Users/jbigler/.ssh/id_rsa': Counting objects: 12, done. Delta compression using up to 2 threads. Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 1001 bytes, done. Total 7 (delta 5), reused 0 (delta 0) -- James Bigler jamesbig...@gmail.com may not push directly to this repository. Use the CMake Topic Stage to merge your topic: http://www.cmake.org/Wiki/CMake/Git#Topic_Stage -- error: hook declined to update refs/heads/next To g...@cmake.org:cmake.git ! [remote rejected] next - next (hook declined) error: failed to push some refs to 'g...@cmake.org:cmake.git' OK. So I tried to do a stage merge: $ git checkout CUDAv3.2PathChanges Switched to branch 'CUDAv3.2PathChanges' $ git push stage HEAD fatal: 'stage' does not appear to be a git repository fatal: The remote end hung up unexpectedly $ git branch * CUDAv3.2PathChanges master next topics/CudaRTEmuLibraryForCUDA30 topics/FindCUDA-allow-g3 topics/FixCudaVersionAfterFirstRun Can anyone help with with my ignorance of Git? The only thing I used Git for is CMake and I just don't use it enough to learn all the nooks and crannies of this tool. Thanks, James -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Git fun
On 12/5/2011 6:22 PM, James Bigler wrote: Thanks, that fixed it. I also updated the wiki page, so the next poor person to come along doesn't beat their head over it. http://www.cmake.org/Wiki/CMake/Git/Develop#Share_a_Topic Thanks. I missed that when writing the instructions. I updated your edit to put the one-time setup instructions up with the others at the top of the page and reference them from that step. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
