Re: [cmake-developers] Ninja: files per second

2012-07-30 Thread Shlomi Fish
Hi Peter,

On Sat, 28 Jul 2012 14:03:48 +0200
Peter Kümmel syntheti...@gmx.net wrote:

 On 28.07.2012 11:43, Shlomi Fish wrote:
 
  Nice.
 
  I was now able to get the Freecell Solver test suite to pass with ninja 
  test,
  but there is one problem: when I run ninja -vv test, then ninja displays 
  the
  line
  [1/1] cd /home/shlomif/progs/freecell/git/fc-solve/fc-solve/source/n
  perl /home/shlomif/progs/freecell/git/fc-solve/fc-solve/source/run-tests.pl
 
  and then it waits for the entire test suite to run, and only then displays 
  its
  output. This is frustrating because I want to see the output while the test
  suite is running. Is there anyway to do it like that?
 
 No, this is by design, ninja collects the whole output so it is not 
 interweaved
 with the output of other processes.
 
 Peter

Well, when I run ninja test, then eventually there's only one process running
and this it the test harness (for which I don't want to wait to finish to view
intermediate output). Can you consider integrating Nicolas’ solution from:

http://public.kitware.com/pipermail/cmake-developers/2012-July/004701.html

Regards,

Shlomi Fish

-- 
-
Shlomi Fish   http://www.shlomifish.org/
First stop for Perl beginners - http://perl-begin.org/

English spelling aims to be consistent. Publicly and methodically.

Please reply to list if it's a mailing list post - http://shlom.in/reply .
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

[cmake-developers] Patch to support SVN externals in CTest update

2012-07-30 Thread Xavier Besseron
Hello,

I am affected by the issue in bug 12630
(http://public.kitware.com/Bug/view.php?id=12630), so I prepared a
patch.

This patch adds support for svn externals during CTest update. I
tested it successfully  with svn 1.6/1.7, Linux/Windows and with
nested externals as well.

Summary of the modifications:
- Add SVNInfo structure to hold info about each repository
- Get the list of external repositories (using 'svn status' and
ExternalParser)
- Run 'svn info' for all repositories, before and after the update
- Run 'svn log' for all repositories
- Build the correct path for all updated files (ie add the
external prefix and remove the svn base)

Let me know if you have any questions or comments.


Xavier


ctest_svn_externals.patch
Description: Binary data
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] Patch to support SVN externals in CTest update

2012-07-30 Thread Brad King
On 07/30/2012 09:45 AM, Xavier Besseron wrote:
 I am affected by the issue in bug 12630
 (http://public.kitware.com/Bug/view.php?id=12630), so I prepared a
 patch.

Thanks for working on this!

 This patch adds support for svn externals during CTest update. I
 tested it successfully  with svn 1.6/1.7, Linux/Windows and with
 nested externals as well.
 
 Summary of the modifications:
 - Add SVNInfo structure to hold info about each repository
 - Get the list of external repositories (using 'svn status' and
 ExternalParser)
 - Run 'svn info' for all repositories, before and after the update
 - Run 'svn log' for all repositories
 - Build the correct path for all updated files (ie add the
 external prefix and remove the svn base)
 
 Let me know if you have any questions or comments.

The changes will be much easier to review in smaller pieces.
Please split this patch into a series.  For example, the first
patch should add the SVNInfo infrastructure with no functional
changes.  Each step in the series should still compile and
pass the UpdateSVN test.

Separately, please also extend the UpdateSVN test to exercise
the new functionality.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


[cmake-developers] Github pull request for Ninja on OS X

2012-07-30 Thread Brad King
Hi Folks,

Please take a look at this pull request:

 https://github.com/Kitware/CMake/pull/22

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


[cmake-developers] find_package without REQUIRED can cause fatal error now

2012-07-30 Thread Bill Hoffman

Alex added this check:
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a2be068c

It guards against broken installations of packages.  This is a good 
thing.  However, it is causing a failed test:



http://open.cdash.org/buildSummary.php?buildid=2465838


--Checking FindVTK
CMake Error at //lib/vtk-5.8/VTKTargets-debug.cmake:996 (MESSAGE):
  The imported target vtkWrapTcl references the file

 //bin/vtkWrapTcl

  but this file does not exist.  Possible reasons include:


So, there is a bad config file for VTK on this machine.

However, if someone does an optional find_package it should not error 
out.   If you were building a project that you did not write the cmake 
files for and came across this error for an optional part of the system 
you might be stuck.  Not sure how to make the required bit propagate 
down to where this error is produced...


Thoughts?

-Bill
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] find_package without REQUIRED can cause fatal error now

2012-07-30 Thread David Cole
Seems like message(FATAL_ERROR/SEND_ERROR needs to know whether it's
in the middle of a find_package( OPTIONAL ) call or not.

What would happen if the only line of code in a project config file is:

  message(FATAL_ERROR not implemented yet)

And then somebody did a find_package(OPTIONAL on that package?

The contents of hand-written project config files are arbitrary, and
we can't stop people from putting FATAL_ERRORs in them. So we should
deal with it generically internal to CMake somehow.


  David C.


On Mon, Jul 30, 2012 at 10:33 AM, Bill Hoffman bill.hoff...@kitware.com wrote:
 Alex added this check:
  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a2be068c

 It guards against broken installations of packages.  This is a good thing.
 However, it is causing a failed test:


 http://open.cdash.org/buildSummary.php?buildid=2465838


 --Checking FindVTK
 CMake Error at //lib/vtk-5.8/VTKTargets-debug.cmake:996 (MESSAGE):
   The imported target vtkWrapTcl references the file

  //bin/vtkWrapTcl

   but this file does not exist.  Possible reasons include:


 So, there is a bad config file for VTK on this machine.

 However, if someone does an optional find_package it should not error out.
 If you were building a project that you did not write the cmake files for
 and came across this error for an optional part of the system you might be
 stuck.  Not sure how to make the required bit propagate down to where this
 error is produced...

 Thoughts?

 -Bill
 --

 Powered by www.kitware.com

 Visit other Kitware open-source projects at
 http://www.kitware.com/opensource/opensource.html

 Please keep messages on-topic and check the CMake FAQ at:
 http://www.cmake.org/Wiki/CMake_FAQ

 Follow this link to subscribe/unsubscribe:
 http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] find_package without REQUIRED can cause fatal error now

2012-07-30 Thread Brad King
On 07/30/2012 10:41 AM, David Cole wrote:
 Seems like message(FATAL_ERROR/SEND_ERROR needs to know whether it's
 in the middle of a find_package( OPTIONAL ) call or not.
 
 What would happen if the only line of code in a project config file is:
 
   message(FATAL_ERROR not implemented yet)
 
 And then somebody did a find_package(OPTIONAL on that package?
 
 The contents of hand-written project config files are arbitrary, and
 we can't stop people from putting FATAL_ERRORs in them. So we should
 deal with it generically internal to CMake somehow.

One could also have:

 $ cat lib/cmake/myproj/MyProjConfig.cmake
 Oops, this is not a CMake language file.  Uh oh.

and find_package could deal with it only by sandboxing the entire
load process.  This problem was not created by Alex's check.  His
check is only one instance of the conditions for the underlying
problem.

Sandboxing the entire operation is not achievable in our
current CMake language implementation.  It's not even fully
possible because the scripts could always do things that are
externally visible and not reversible like execute_process.

I'm not sure sandboxing any and all errors inside package
configuration files is the right thing either.  As a user
expecting find_package to locate a particular installation
that I do not know is corrupted I might bang my head against
the desk wondering why CMake is ignoring it.  We would have
to dump the entire output from the attempted/failed load as
a warning.

What do we do after such failure?  Ignore the instance and
continue to search for another one?  Consider the package
to be not found?  The answer should be consistent with what
happens since this change:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=16c0c737

when a package config file sets package_FOUND to FALSE.

-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


[cmake-developers] [CMake 0013445]: file glob with relative path containing '.'

2012-07-30 Thread Mantis Bug Tracker

The following issue has been SUBMITTED. 
== 
http://www.cmake.org/Bug/view.php?id=13445 
== 
Reported By:nagger
Assigned To:
== 
Project:CMake
Issue ID:   13445
Category:   (No Category)
Reproducibility:always
Severity:   minor
Priority:   normal
Status: new
== 
Date Submitted: 2012-07-30 11:43 EDT
Last Modified:  2012-07-30 11:43 EDT
== 
Summary:file glob with relative path containing '.'
Description: 
At a call of file(GLOB var RELATIVE ${absdir} ...), if absdir contains /./
parts the resulting relative path is wrong

Steps to Reproduce: 
cmake_minimum_required(VERSION 2.8)
file(GLOB var1 *.txt)
file(GLOB var2 RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.txt)
file(GLOB var3 RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}/. *.txt)
file(GLOB var4 RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}/./. *.txt)
message(var1: '${var1}')
message(var2: '${var2}')
message(var3: '${var3}')
message(var4: '${var4}')

---
output:
var1: 'D:/src/CMake_globrelative/CMakeLists.txt'
var2: 'CMakeLists.txt'
var3: '../CMakeLists.txt'
var4: '../../CMakeLists.txt'
---
expected output:
var1: 'D:/src/CMake_globrelative/CMakeLists.txt'
var2: 'CMakeLists.txt'
var3: 'CMakeLists.txt'
var4: 'CMakeLists.txt'

== 

Issue History 
Date ModifiedUsername   FieldChange   
== 
2012-07-30 11:43 nagger New Issue
==

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] find_package without REQUIRED can cause fatal error now

2012-07-30 Thread Alexander Neundorf
On Monday 30 July 2012, Bill Hoffman wrote:
 Alex added this check:
   http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a2be068c
 
 It guards against broken installations of packages.  This is a good
 thing.  However, it is causing a failed test:
 
 
 http://open.cdash.org/buildSummary.php?buildid=2465838
 
 
 --Checking FindVTK
 CMake Error at //lib/vtk-5.8/VTKTargets-debug.cmake:996 (MESSAGE):
The imported target vtkWrapTcl references the file
 
   //bin/vtkWrapTcl
 
but this file does not exist.  Possible reasons include:
 
 
 So, there is a bad config file for VTK on this machine.
 
 However, if someone does an optional find_package it should not error
 out.   If you were building a project that you did not write the cmake
 files for and came across this error for an optional part of the system
 you might be stuck.

The idea was that this is a sign of a broken install.
Can you uninstall the vtk-devel package (does this exist ?), because it is 
broken, i.e. does not contain everything is claims to ?

I understand that this is maybe not expected behaviour for an optional 
package, but maybe Brad is right ?

Alex
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] CMake, Xcode 4.4, and Mountain Lion

2012-07-30 Thread Óscar Fuentes
Ho Cheung hocheun...@gmail.com writes:

[snip]

 Since Xcode uses clang but CMAKE_C_COMPILER is set to gcc, the gcc
 compiler flags are being passed to clang.

Something related to this issue is being commented on the LLVM ml rigth
now: while searching for compilers, CMake prefers gcc over cc and that
is causing trouble:

http://comments.gmane.org/gmane.comp.compilers.llvm.devel/52263


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers