Re: [cmake-developers] execute_process inconsitancy
On Mon, Sep 3, 2012 at 7:50 PM, David Cole david.c...@kitware.com wrote: That's not a workaround, that's the solution. The quotes don't belong there. I dunno seems to be an application specific failure On Sep 3, 2012, at 10:24 PM, J Decker d3c...@gmail.com wrote: I do have a workaround by taking the quotes out of the path... On Mon, Sep 3, 2012 at 7:23 PM, J Decker d3c...@gmail.com wrote: On Mon, Sep 3, 2012 at 3:58 PM, David Cole david.c...@kitware.com wrote: OK... Is hg.exe in the PATH? Do you get different results if you use the full path to hg.exe rather than just hg? hg is in the path; although, when hg is not in the path, the result is the same. hg.exe is the same result PATH=C:\Windows;C:\Windows\system32;c:\develop\tools;c:\ftn3000\bin;c:\ftn3000\utility;;c:\Develop\tools\startups\..\..\tools\unix;c:\Develo p\tools\startups\..\..\tools\nasm;c:\Develop\tools\startups\..\..\tools\watcom\binnt;c:\Develop\tools\startups\..\..\tools\watcom\binw;c:\De velop\tools\startups\..\..\tools\unix\cmake\bin;C:\Program Files\TortoiseHg\ the following is the search... C:\Develop\tools\unix\cmake\bin\hg.exe cmake_source_dir 32bit c:\windows\syswow64 c:\windows\system.hg.exe c:\windows\hg.exe 32bit c:\windows\syswow64 c:\develop\tools c:\ftn3000\bin c:\ftn3000.. (path up to) c:\develop\tools\unix\cmake\bin\hg.exe then (and I think this is where it's wrong, I don't know how it would have created this path) M:\sack\c:\program files\tortoisehg\\hg.exe then it does the same search but looking for 'hg.exe id' instead of just 'hg.exe' On Mon, Sep 3, 2012 at 5:48 PM, J Decker d3c...@gmail.com wrote: dir c:\Program Files\tortoisehg Volume in drive C has no label. Volume Serial Number is F05B-C5AF Directory of c:\Program Files\tortoisehg 08/20/2012 10:47 PM33,544 hg.exe I don't know what hy.py would be . On Mon, Sep 3, 2012 at 2:37 PM, David Cole david.c...@kitware.com wrote: On Mon, Sep 3, 2012 at 5:15 PM, J Decker d3c...@gmail.com wrote: On Mon, Sep 3, 2012 at 1:04 PM, Brad King brad.k...@kitware.com wrote: On 09/03/2012 03:04 PM, J Decker wrote: I use this command to get the current repository version number. Under windows I have to use 'cmd /c ...' under linux or I obviously can't use that. Is there a test I can do in a cmakelists to test the shell processor? Is there something I can do to make this the same command? Under windows, without cmd /c the output variable is blank. if( WIN32 ) execute_process( COMMAND cmd /c hg id -i WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} OUTPUT_VARIABLE TMP_CURRENT_REPO_REVISION ) else( WIN32 ) execute_process( COMMAND hg id -i WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} OUTPUT_VARIABLE TMP_CURRENT_REPO_REVISION ) execute_process( COMMAND hg id -i WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} OUTPUT_VARIABLE TMP_CURRENT_REPO_REVISION ERROR_VARIABLE TMP_CURRENT_REPO_REVISION2 ) message( 1) ${TMP_CURRENT_REPO_REVISION} ) message( 1) ${TMP_CURRENT_REPO_REVISION2} ) both revision and revision2 are blank, (without cmd /c before) endif( WIN32 ) The command operates the same way on both platforms. My guess is that hg is printing to stderr on Windows. Try this: execute_process( COMMAND hg id -i WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} OUTPUT_VARIABLE TMP_CURRENT_REPO_REVISION ERROR_VARIABLE TMP_CURRENT_REPO_REVISION ) -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers On Windows, hg is not an executable file, so execute_process is probably not even running it. If you instead say: COMMAND C:/python26/python.exe C:/path/to/hg.py (... args ...) does that work? -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] execute_process inconsitancy
On Tue, Sep 4, 2012 at 2:19 AM, J Decker d3c...@gmail.com wrote: On Mon, Sep 3, 2012 at 7:50 PM, David Cole david.c...@kitware.com wrote: That's not a workaround, that's the solution. The quotes don't belong there. I dunno seems to be an application specific failure Python: c:\set PATH=c:\Python;C:\Windows\system32;C:\Windows c:\python -c import subprocess; subprocess.call(['hg','--version']) WindowsError: [Error 2] The system cannot find the file specified c:\set PATH=C:\Program Files\Mercurial;c:\Python;C:\Windows\system32;C:\Windows c:\python -c import subprocess; subprocess.call(['hg','--version']) WindowsError: [Error 2] The system cannot find the file specified c:\set PATH=C:\Program Files\Mercurial;c:\Python;C:\Windows\system32;C:\Windows c:\python -c import subprocess; subprocess.call(['hg','--version']) Mercurial Distributed SCM (version 2.1) CMake: c:\type test.cmake execute_process(COMMAND hg --version RESULT_VARIABLE failure) if(failure) message(STATUS failed to run hg: ${failure}) endif() c:\set PATH=c:\Program Files (x86)\CMake 2.8\bin;C:\Windows\system32;C:\Windows c:\cmake -P test.cmake -- failed to run hg: The system cannot find the file specified c:\set PATH=C:\Program Files\Mercurial;c:\Program Files (x86)\CMake 2.8\bin;C:\Windows\system32;C:\Windows c:\cmake -P test.cmake -- failed to run hg: The system cannot find the file specified c:\set PATH=C:\Program Files\Mercurial;c:\Program Files (x86)\CMake 2.8\bin;C:\Windows\system32;C:\Windows c:\cmake -P test.cmake Mercurial Distributed SCM (version 2.1) If you use execute_process's RESULT_VARIABLE you can get the real result of the process instead of just assuming success. It will either be an integer return code or a message indicating a problem launching the process. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] ninja test failing again...
The BuildDepends test has been failing for some time now: http://open.cdash.org/viewUpdate.php?buildid=2522326 It seems to be from this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4a35bd0e69e5cfaf7ca9604c90b609d1d333bb37 Here is the first failure: http://open.cdash.org/testDetails.php?test=156781454build=2522326 Any ideas? Maybe cmcldeps is not working for some reason? -Bill -- Bill Hoffman Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 bill.hoff...@kitware.com http://www.kitware.com 518 881-4905 (Direct) 518 371-3971 x105 Fax (518) 371-4573 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Questions on staged topic branches
On 09/04/2012 02:12 PM, Peter Kümmel wrote: The problem is $ENV{DESTDIR}${CMAKE_INSTALL_PREFIX} because $ENV{DESTDIR} is absolute without final / and is relative without initial /. see http://public.kitware.com/Bug/view.php?id=11785 I re-started discussion in the issue tracker entry. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Questions on staged topic branches
By the way, James, you may be able to rebase your topic on current 'master' if you think it would make your change better to depend on the recently added compiler id available everywhere for all generators feature: # feature added in this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=66cb3356 # merged to 'master' here: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=34a02846 On Tue, Sep 4, 2012 at 1:48 PM, David Cole david.c...@kitware.com wrote: If you are on the To line, please reply to this email, and answer the questions below: Brad and I have questions on these staged topic branches before we consider them for merging to 'master'. ## # Peter Kuemmel and Eric Noulard: #cpack-stripping | master=0 next=1 This one should not be necessary. Can you tell us what problem it fixes? The only valid install path that should ever go under DESTDIR has to be an absolute path already anyways. So it will either start with a / already, or a $ because it begins with ${CMAKE_INSTALL_PREFIX}... so this change is unnecessary, and in fact harmful in the case where DESTDIR doesn't end with a / but the install rule does begin with ${CMAKE_INSTALL_PREFIX}. (Or are we misreading this somehow?) ## # Eric Noulard: # CPackRPM_handleAttrDirectiveProperly | master=0 next=1 The character set used in the REGEX here has errors in it: [A-Za-z\(\)-\,] 1) The comma does not need to be escaped in this character set context, but \\ does if you mean to include the backslash character. 2) The hyphen, if meant to be matched is not matched here, but used as a range separator from the \) to the \, What's the intent of the change? To handle commas and hyphens, you would add ,- at the end of the existing character set. If more characters need to be matched, then add them, but keep the hyphen last or make it first or escape it in order to match it here. ## # James Bigler: # topics/FindCUDA/Add-CUDA_HOST_COMPILER | master=0 next=1 Is CUDA_HOST_COMPILER a path to a directory or a file? It appears to take on different values depending on which if branch you go through. Is that true? Or should it always be a full path to the compiler? Thanks all -- depending on the answers, we may take these next time we merge, or they might need additional work first. David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Questions on staged topic branches
2012/9/4 David Cole david.c...@kitware.com: If you are on the To line, please reply to this email, and answer the questions below: Brad and I have questions on these staged topic branches before we consider them for merging to 'master'. ## # Peter Kuemmel and Eric Noulard: #cpack-stripping | master=0 next=1 This one should not be necessary. Can you tell us what problem it fixes? The only valid install path that should ever go under DESTDIR has to be an absolute path already anyways. So it will either start with a / already, or a $ because it begins with ${CMAKE_INSTALL_PREFIX}... so this change is unnecessary, and in fact harmful in the case where DESTDIR doesn't end with a / but the install rule does begin with ${CMAKE_INSTALL_PREFIX}. (Or are we misreading this somehow?) ## # Eric Noulard: # CPackRPM_handleAttrDirectiveProperly | master=0 next=1 The character set used in the REGEX here has errors in it: [A-Za-z\(\)-\,] 1) The comma does not need to be escaped in this character set context, but \\ does if you mean to include the backslash character. Only comma and hypen should be matched. Not backslash. 2) The hyphen, if meant to be matched is not matched here, but used as a range separator from the \) to the \, Right really sorry I overlooked that one. What's the intent of the change? To handle commas and hyphens, you would add ,- at the end of the existing character set. If more characters need to be matched, then add them, but keep the hyphen last or make it first or escape it in order to match it here. I'll do that, but may be only this Week-End. This corresponds to this bug http://public.kitware.com/Bug/view.php?id=0013468 I did reopen it. -- Erk Le gouvernement représentatif n'est pas la démocratie -- http://www.le-message.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] ninja test failing again...
On 09/04/2012 02:16 PM, Peter Kümmel wrote: On 04.09.2012 18:56, Bill Hoffman wrote: The BuildDepends test has been failing for some time now: http://open.cdash.org/viewUpdate.php?buildid=2522326 It seems to be from this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4a35bd0e69e5cfaf7ca9604c90b609d1d333bb37 Here is the first failure: http://open.cdash.org/testDetails.php?test=156781454build=2522326 Any ideas? Maybe cmcldeps is not working for some reason? -Bill fixed it shortly before your email ;) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9b8b4c11d8e7807c0b8e6d9bea490f20f3ad0367 The try_compile command has two signature forms. One is meant to build a single source file in an auto-generated project in a discard-able temp dir. The other is meant to build a given source tree in a given build tree and keep the results around. Any optimization that skips dependency checks should be done only for the first form, and never for the second form. This distinction should cover the BuildDepends test case too. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0013513]: There's no operator in command.com, so commands starting with aren't executed by command.com
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=13513 == Reported By:Flávio J. Saraiva Assigned To: == Project:CMake Issue ID: 13513 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2012-09-04 21:04 WEST Last Modified: 2012-09-04 21:04 WEST == Summary:There's no operator in command.com, so commands starting with aren't executed by command.com Description: There's no operator in command.com, so the echo nul that was added in 269a4b876a34483c5cb664499dc6b1634fa453ff (for commands that start with ) will make the whole line a no-op. I'm using the NMake Makefiles generator. (the Visual Studio 6 generator also fails but haven't checked if it's the same issue) == Issue History Date ModifiedUsername FieldChange == 2012-09-04 21:04 Flávio J. SaraivaNew Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Proposal: An IRC dev meeting to chat about CMake stuff
David Cole wrote: This is a good idea. How many people would join in if we had a CMake meeting in #cmake IRC? Is there any conclusion on this now? Eike -- signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support
On Mon, 03 Sep 2012 11:02:22 -0400, Brad King wrote: On 09/03/2012 10:52 AM, Patrick Gansterer wrote: I saw that Brad merged one of my changes. Are there any other changes the WinCE stuff depends on to get merged? Please rebase the remainder of the topic on upstream master, at least as recent as commit 25b0d946. Your changes will need to account for at least this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f3ddfef1 Sorry to create these conflicts for you but I've wanted to modernize the MSVC platform files for years and the last barrier was recently removed (by the ide-compiler-id topic). I rebased the code and pushed it as ce to https://gitorious.org/~paroga/cmake/parogas-cmake (git://gitorious.org/~paroga/cmake/parogas-cmake.git) -- Patrick -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Proposal: An IRC dev meeting to chat about CMake stuff
On Tue, Sep 4, 2012 at 4:08 PM, Rolf Eike Beer e...@sf-mail.de wrote: David Cole wrote: This is a good idea. How many people would join in if we had a CMake meeting in #cmake IRC? Is there any conclusion on this now? Let's make one: I will send out a Calendar appointment for Mondays at 2:00 PM Eastern time US. (8:00 pm in Lyon and Berlin) That will give us a chance to discuss anything we need to talk about before our usual Tuesday merge sessions. Looking forward to it! -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Proposal: An IRC dev meeting to chat about CMake stuff
On Tue, Sep 4, 2012 at 4:20 PM, David Cole david.c...@kitware.com wrote: On Tue, Sep 4, 2012 at 4:08 PM, Rolf Eike Beer e...@sf-mail.de wrote: David Cole wrote: This is a good idea. How many people would join in if we had a CMake meeting in #cmake IRC? Is there any conclusion on this now? Let's make one: I will send out a Calendar appointment for Mondays at 2:00 PM Eastern time US. (8:00 pm in Lyon and Berlin) That will give us a chance to discuss anything we need to talk about before our usual Tuesday merge sessions. Looking forward to it! Of course, as soon as I said this, I realize I won't be around on the next Monday, 9/10... but we can start it up on the 17th: https://www.google.com/calendar/event?action=TEMPLATEtmeid=cnByNDU5ZHQyaG41dnQzY3J1a3NhYTFnNnNfMjAxMjA5MTdUMTgwMDAwWiBkYXZpZC5jb2xlQGtpdHdhcmUuY29ttmsrc=david.cole%40kitware.com That should give you a Google calendar entry that starts on Monday Sept. 17th from 2:00 to 3:00 pm Eastern time US, and repeats every Monday after that. Put it on your calendars, and we'll see you on #cmake Cheers, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support
On 09/04/2012 04:18 PM, Patrick Gansterer wrote: I rebased the code and pushed it as ce to https://gitorious.org/~paroga/cmake/parogas-cmake (git://gitorious.org/~paroga/cmake/parogas-cmake.git) Thanks! I'm looking at the first commit that adds the WindowsCE platform files. These lines look strange: set(MSVC_C_ARCHITECTURE_ID ${CMAKE_SYSTEM_PROCESSOR}) set(MSVC_CXX_ARCHITECTURE_ID ${CMAKE_SYSTEM_PROCESSOR}) Normally the ARCHITECTURE_ID values are detected by Modules/CMakePlatformId.h.in which is built by running CMAKE_(C|CXX)_COMPILER, which should be set by the toolchain file to the proper compiler for WinCE. Shouldn't that be taught about the architectures in question? Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] ninja test failing again...
On 04.09.2012 21:56, Brad King wrote: On 09/04/2012 02:16 PM, Peter Kümmel wrote: On 04.09.2012 18:56, Bill Hoffman wrote: The BuildDepends test has been failing for some time now: http://open.cdash.org/viewUpdate.php?buildid=2522326 It seems to be from this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4a35bd0e69e5cfaf7ca9604c90b609d1d333bb37 Here is the first failure: http://open.cdash.org/testDetails.php?test=156781454build=2522326 Any ideas? Maybe cmcldeps is not working for some reason? -Bill fixed it shortly before your email ;) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9b8b4c11d8e7807c0b8e6d9bea490f20f3ad0367 The try_compile command has two signature forms. One is meant to build a single source file in an auto-generated project in a discard-able temp dir. The other is meant to build a given source tree in a given build tree and keep the results around. Any optimization that skips dependency checks should be done only for the first form, and never for the second form. This distinction should cover the BuildDepends test case too. -Brad http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=34b0cf6a3823e0d54958a0f337308b4c35342cc3 Is this better? Peter -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers