Re: [cmake-developers] Tests with custom launchers and Not Run
David Cole wrote: I don't like it. Existing tests that run and return, for example, a number of errors that occurred, will magically appear as not run when that number just so happens to be 77. If there are enough people who think this is simple and works and are not concerned about the accidental matching of an intentional return value of 77 that does NOT mean not run ... then I will relent and say, so be it, and allow it in. But only if there are some people who speak up here or add notes to the bug. It just seems wrong to me to treat 77 as some special number here. I would still go and make that a target property where you can set the return code where something is considered skipped. The only question is: how to name the property? Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Tests with custom launchers and Not Run
On 19/09/12 08:18, Rolf Eike Beer wrote: David Cole wrote: I don't like it. Existing tests that run and return, for example, a number of errors that occurred, will magically appear as not run when that number just so happens to be 77. If there are enough people who think this is simple and works and are not concerned about the accidental matching of an intentional return value of 77 that does NOT mean not run ... then I will relent and say, so be it, and allow it in. But only if there are some people who speak up here or add notes to the bug. It just seems wrong to me to treat 77 as some special number here. I would still go and make that a target property where you can set the return code where something is considered skipped. The only question is: how to name the property? Eike -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers I already suggested to use a test property three years ago (see issue #8466). At that time David was very much against it, fearing to find a ***huueee*** can of worms right underneath the surface. Seems I'm slowly getting more fellow thinkers ;) Regards, Marcel Loose. attachment: loose.vcf-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] conditionals in generator expressions
Brad King wrote: I think it would make sense to rewrite the branch to squash the whitespace fixes before merging to master though. Yes, I can do this when the topic is done. I saw that it didn't get into master yesterday. Does this mean it won't get in until next week? If that is the case then I should rebase/rewrite it now instead of waiting for you to do it in a week. I have another two branches (use-generator- targets, include_directories-generator-expressions) which depend on this branch, but I want to rebase them on the *rebased* version of this branch. If next wednesday is the last time I can get them into 2.8.10, then I have to rebase generator-expression-refactor now and rebase my other patches onto it so that all 3 can be merged next Wednesday. I'll do the revert-in-next+rebase+re-merge-to-next later today unless there's an objection. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0013549]: FindMPI.cmake isn't quiet
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=13549 == Reported By:Joe Lindström Assigned To: == Project:CMake Issue ID: 13549 Category: Modules Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2012-09-19 04:38 EDT Last Modified: 2012-09-19 04:38 EDT == Summary:FindMPI.cmake isn't quiet Description: When I use: find_package(MPI QUIET) on a system without MPI installed (and CMake 2.8.9), I get the following messages: Could NOT find MPI_C (missing: MPI_C_LIBRARIES MPI_C_INCLUDE_PATH) Could NOT find MPI_CXX (missing: MPI_CXX_LIBRARIES MPI_CXX_INCLUDE_PATH) CMake 2.8.3 seems to stay quiet. Also the deprecated MPI_EXTRA_LIBRARY and MPI_LIBRARY show up in my cache, should be marked as advanced? Steps to Reproduce: 1. Use the attached example CMakeLists.txt on a system with CMake 2.8.9 and without MPI installed. == Issue History Date ModifiedUsername FieldChange == 2012-09-19 04:38 Joe Lindström New Issue 2012-09-19 04:38 Joe Lindström File Added: CMakeLists.txt == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] conditionals in generator expressions
On 09/19/2012 04:17 AM, Stephen Kelly wrote: Brad King wrote: I think it would make sense to rewrite the branch to squash the whitespace fixes before merging to master though. Yes, I can do this when the topic is done. I saw that it didn't get into master yesterday. Does this mean it won't get in until next week? If that is the case then I should rebase/rewrite it now instead of waiting for you to do it in a week. I have another two branches (use-generator- targets, include_directories-generator-expressions) which depend on this branch, but I want to rebase them on the *rebased* version of this branch. If next wednesday is the last time I can get them into 2.8.10, then I have to rebase generator-expression-refactor now and rebase my other patches onto it so that all 3 can be merged next Wednesday. I'll do the revert-in-next+rebase+re-merge-to-next later today unless there's an objection. I did the rebase/squash yesterday. In order to make the result cleaner and identical to the original net change on the topic I wanted to add one commit to it. I needed that to run overnight on the dashboard. Now that it has run cleanly I can replace the topic with the squashed one. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] conditionals in generator expressions
Brad King wrote: I'll do the revert-in-next+rebase+re-merge-to-next later today unless there's an objection. I did the rebase/squash yesterday. In order to make the result cleaner and identical to the original net change on the topic I wanted to add one commit to it. I needed that to run overnight on the dashboard. Now that it has run cleanly I can replace the topic with the squashed one. Great, thanks for that. Everything is back on schedule :) I've pushed the use-generator-target topic to next. It does more porting to cmGeneratorTarget - enough to use it in GetIncludeDirectories. Hopefully it will stabilize quickly on the dashboard and I'll be able to get the include directories generator expressions in soon too. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Hacking kwsys processor detection
Brad King wrote: On 09/08/2012 12:45 PM, Rolf Eike Beer wrote: I was a bit bored and decided to hack a bit on a bug I filed long ago (http://cmake.org/Bug/view.php?id=10895). I have attached the first 3 patches I came up with. I think #1 should just be applied without any further checks ;) The copy of KWSys in VTK has had more development on this: http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=595216ab http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=32f08e67 http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=72deb33e I haven't had time to cherry-pick the changes into CMake and deal with all the problems on platforms where CMake builds but VTK does not (if any). If this happens, please also rename MakeCindentifier to MakeCidentifier or add a new method without the typo for compatibility. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0013550]: CMAKE_C_COMPILE_OPTIONS_PIE not set for Clang
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=13550
==
Reported By:Alexander
Assigned To:
==
Project:CMake
Issue ID: 13550
Category: CMake
Reproducibility:always
Severity: minor
Priority: normal
Status: new
==
Date Submitted: 2012-09-19 13:57 EDT
Last Modified: 2012-09-19 13:57 EDT
==
Summary:CMAKE_C_COMPILE_OPTIONS_PIE not set for Clang
Description:
I'm trying to use CMAKE_C_COMPILE_OPTIONS_PIE and CMAKE_CXX_COMPILE_OPTIONS_PIE
variables, but they are not set when using Clang.
I found this in /usr/share/cmake/Modules/Compiler/GNU.cmake :
if(NOT CMAKE_${lang}_COMPILER_VERSION VERSION_LESS 3.4)
set(CMAKE_${lang}_COMPILE_OPTIONS_PIE -fPIE)
endif()
Clang is a GNU-compatible compiler (I have version 3.1), but it doesn't pass the
check.
Thanks
==
Issue History
Date ModifiedUsername FieldChange
==
2012-09-19 13:57 Alexander New Issue
==
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Adding Qt5 Support
What files did you have to change? The files needed to get projects to work with Qt 5 should all ship and be built/installed as part of Qt 5 now. Steve Kelly has been doing this work, and can chime in here to correct me if there's more to it than that. Thanks, David On Wed, Sep 19, 2012 at 3:16 PM, Luis Kabongo lkabo...@vicomtech.orgwrote: Hello everyone, First of all I would like to apologize for any possible mistake/incoherence/stupidity in the following message(s), since this is my first contribution here. Even if Qt 5.0.0 is still under beta 1, I am working on trying to get Qt5 to work with our own libraries and had to patch some of the existing files in the Qt Module in order to make it work. I would like to contribute with my current changes to the main repository and see if they are still compatible on different platforms/configurations/etc. Up to now I'm following the instructions here: http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer So I'm at step 4: Wait for response, discussion, and acceptance before proceeding to the following steps. Regards. -- Luis Kabongo Vicomtech-IK4 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Adding Qt5 Support
I changed FintQt.cmake and created the following: FindQt5.cmake UseQt5.cmake Regards. -- Luis Kabongo Vicomtech-IK4 On 19 September 2012 21:20, David Cole david.c...@kitware.com wrote: What files did you have to change? The files needed to get projects to work with Qt 5 should all ship and be built/installed as part of Qt 5 now. Steve Kelly has been doing this work, and can chime in here to correct me if there's more to it than that. Thanks, David On Wed, Sep 19, 2012 at 3:16 PM, Luis Kabongo lkabo...@vicomtech.orgwrote: Hello everyone, First of all I would like to apologize for any possible mistake/incoherence/stupidity in the following message(s), since this is my first contribution here. Even if Qt 5.0.0 is still under beta 1, I am working on trying to get Qt5 to work with our own libraries and had to patch some of the existing files in the Qt Module in order to make it work. I would like to contribute with my current changes to the main repository and see if they are still compatible on different platforms/configurations/etc. Up to now I'm following the instructions here: http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer So I'm at step 4: Wait for response, discussion, and acceptance before proceeding to the following steps. Regards. -- Luis Kabongo Vicomtech-IK4 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Exporting dependent library targets in multiple export sets
On Tuesday 18 September 2012, Brad King wrote: On 09/18/2012 04:12 PM, Alexander Neundorf wrote: How about defining a variable which can be set by Config-files which holds an error message for the case that the Config-file has set package_FOUND to FALSE ? Like e.g. package_FIND_FAILURE_MESSAGE ? This could then be printed by cmFindPackage and/or FPHSA ? It sounds okay to me. Hmm, I was almost done implementing it... when creating the export file, we do not know how the Config file will be named, i.e. we do not know the name of the package, so we cannot set package_FOUND to FALSE... Am I missing something ? Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Adding Qt5 Support
Those files shouldn't be necessary with Qt 5. Qt 5 itself installs a CMake project config file so that CMake's find_package can just find it without any Find module necessary. It is the IDEAL. WE LOVE not having a find module, but still being able to find_package!! :-) Cheers, David On Wed, Sep 19, 2012 at 3:29 PM, Luis Kabongo lkabo...@vicomtech.orgwrote: I changed FintQt.cmake and created the following: FindQt5.cmake UseQt5.cmake Regards. -- Luis Kabongo Vicomtech-IK4 On 19 September 2012 21:20, David Cole david.c...@kitware.com wrote: What files did you have to change? The files needed to get projects to work with Qt 5 should all ship and be built/installed as part of Qt 5 now. Steve Kelly has been doing this work, and can chime in here to correct me if there's more to it than that. Thanks, David On Wed, Sep 19, 2012 at 3:16 PM, Luis Kabongo lkabo...@vicomtech.orgwrote: Hello everyone, First of all I would like to apologize for any possible mistake/incoherence/stupidity in the following message(s), since this is my first contribution here. Even if Qt 5.0.0 is still under beta 1, I am working on trying to get Qt5 to work with our own libraries and had to patch some of the existing files in the Qt Module in order to make it work. I would like to contribute with my current changes to the main repository and see if they are still compatible on different platforms/configurations/etc. Up to now I'm following the instructions here: http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer So I'm at step 4: Wait for response, discussion, and acceptance before proceeding to the following steps. Regards. -- Luis Kabongo Vicomtech-IK4 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Adding Qt5 Support
Qt5ConfigDependentSettings.cmake and Qt5Macros.cmake may need to be added also. You might be right, the thing is that I needed support for a non installed version compiled with specific options without crashing my other versions (you can imagine 64 bits, sql, etc), but in Qt5 beta version some files do not seem to be provided or installed and support is definitely not straight forward for now, this is why I started. But you're right, I'm going to check again if they are not meant to be created and installed automatically. Thanks for your answer. Regards. -- Luis Kabongo Vicomtech-IK4 On 19 September 2012 22:06, David Cole david.c...@kitware.com wrote: Those files shouldn't be necessary with Qt 5. Qt 5 itself installs a CMake project config file so that CMake's find_package can just find it without any Find module necessary. It is the IDEAL. WE LOVE not having a find module, but still being able to find_package!! :-) Cheers, David On Wed, Sep 19, 2012 at 3:29 PM, Luis Kabongo lkabo...@vicomtech.orgwrote: I changed FintQt.cmake and created the following: FindQt5.cmake UseQt5.cmake Regards. -- Luis Kabongo Vicomtech-IK4 On 19 September 2012 21:20, David Cole david.c...@kitware.com wrote: What files did you have to change? The files needed to get projects to work with Qt 5 should all ship and be built/installed as part of Qt 5 now. Steve Kelly has been doing this work, and can chime in here to correct me if there's more to it than that. Thanks, David On Wed, Sep 19, 2012 at 3:16 PM, Luis Kabongo lkabo...@vicomtech.orgwrote: Hello everyone, First of all I would like to apologize for any possible mistake/incoherence/stupidity in the following message(s), since this is my first contribution here. Even if Qt 5.0.0 is still under beta 1, I am working on trying to get Qt5 to work with our own libraries and had to patch some of the existing files in the Qt Module in order to make it work. I would like to contribute with my current changes to the main repository and see if they are still compatible on different platforms/configurations/etc. Up to now I'm following the instructions here: http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer So I'm at step 4: Wait for response, discussion, and acceptance before proceeding to the following steps. Regards. -- Luis Kabongo Vicomtech-IK4 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Exporting dependent library targets in multiple export sets
On Wednesday 19 September 2012, Alexander Neundorf wrote: On Tuesday 18 September 2012, Brad King wrote: On 09/18/2012 04:12 PM, Alexander Neundorf wrote: How about defining a variable which can be set by Config-files which holds an error message for the case that the Config-file has set package_FOUND to FALSE ? Like e.g. package_FIND_FAILURE_MESSAGE ? This could then be printed by cmFindPackage and/or FPHSA ? It sounds okay to me. Hmm, I was almost done implementing it... when creating the export file, we do not know how the Config file will be named, i.e. we do not know the name of the package, so we cannot set package_FOUND to FALSE... Am I missing something ? cmFindPackage could set a CMAKE_FIND_PACKAGE_NAME variable, which I could use then... Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Adding Qt5 Support
On 9/19/2012 4:11 PM, Luis Kabongo wrote: Qt5ConfigDependentSettings.cmake and Qt5Macros.cmake may need to be added also. You might be right, the thing is that I needed support for a non installed version compiled with specific options without crashing my other versions (you can imagine 64 bits, sql, etc), but in Qt5 beta version some files do not seem to be provided or installed and support is definitely not straight forward for now, this is why I started. But you're right, I'm going to check again if they are not meant to be created and installed automatically. Here are some links: http://www.kdab.com/using-cmake-with-qt-5/ http://doc-snapshot.qt-project.org/5.0/cmake-manual.html -- Bill Hoffman Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 bill.hoff...@kitware.com http://www.kitware.com 518 881-4905 (Direct) 518 371-3971 x105 Fax (518) 371-4573 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Adding Qt5 Support
Bill Hoffman wrote: Here are some links: http://www.kdab.com/using-cmake-with-qt-5/ http://doc-snapshot.qt-project.org/5.0/cmake-manual.html Thanks for that. Those are the correct links. However, there is another one: http://qt-project.org/wiki/Qt500beta1KnownIssues The CMake files are not installed on Windows and Mac. To get them you need to build a more recent snapshot (or git) from source. I fixed the issue several days before the beta, but unfortunately the Qt project is still trying to find its feet while changing hands, and the beta release came as a complete surprise to those of us working on testing it. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
