[cmake-developers] Alias targets for 2.8.12

2013-08-01 Thread Stephen Kelly

Hi there,

it would be useful for KDE Frameworks to have ALIAS targets in CMake 2.8.12.

 http://thread.gmane.org/gmane.comp.kde.devel.core/80233/focus=80247

I finished the topic and pushed it to next in case it can go into that 
release. 

I won't be available most of today to change it if needed, but I can fix it 
up tomorrow if needed.

Thanks,

Steve.


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] Alias targets for 2.8.12

2013-08-01 Thread Brad King
On 08/01/2013 05:26 AM, Stephen Kelly wrote:
 it would be useful for KDE Frameworks to have ALIAS targets in CMake 2.8.12.
 
  http://thread.gmane.org/gmane.comp.kde.devel.core/80233/focus=80247
 
 I finished the topic and pushed it to next in case it can go into that 
 release. 
 
 I won't be available most of today to change it if needed, but I can fix it 
 up tomorrow if needed.

The topic looks like a great start.  I won't promise to take it
for 2.8.12 yet but let's proceed with review.

- The documentation in add_library and add_executable lists a bunch
  of things one can't do but not an example of what one can do.
  I think this documentation should have an explicit list of what
  is intended and allowed and then exclude everything else.  That
  way if we missed a use case we can treat it as a bug later and
  add the error case.

- Should add_executable be (dis)allowed to add a library alias,
  and vice-versa for add_library?

- The documentation does not mention that alias targets cannot be
  installed or exported.

- Add more positive use cases (or negative if not allowed)
  to the test suite:

  - add_custom_command/add_custom_target COMMAND argv0 translation
  - add_test NAME/COMMAND signature argv0 translation
  - generator expression references e.g. $TARGET_FILE:... in
add_test and add_custom_* commands
  - Alias for an object library with $TARGET_OBJECTS:...
  - Look for other uses of cmMakefile FindTargetToUse and
FindTarget; all of them need tests for alias behavior and/or
should be preceded by !IsAlias checks (many are already done).

- How does this interact with $TARGET_PROPERTY:NAME?

- When if(TARGET xyz) returns true how can one tell from CMake
  code whether xyz is an alias or a real target?  Can one get the
  real target if it is an alias?

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


[cmake-developers] [CMake 0014331]: Generating projects for visual studio (2010, 2012, others?) creates corrupt projects if path includes ''

2013-08-01 Thread Mantis Bug Tracker

The following issue has been SUBMITTED. 
== 
http://public.kitware.com/Bug/view.php?id=14331 
== 
Reported By:d3x0r
Assigned To:
== 
Project:CMake
Issue ID:   14331
Category:   CMake
Reproducibility:always
Severity:   minor
Priority:   high
Status: new
== 
Date Submitted: 2013-08-01 14:41 EDT
Last Modified:  2013-08-01 14:41 EDT
== 
Summary:Generating projects for visual studio (2010,2012,
others?) creates corrupt projects if path includes ''
Description: 
This simple make file creates corrupt .vcxproj files (files that visual studio
refuses to load).

---
cmake_minimum_required(VERSION 2.8)

FILE( WRITE test.c int main(){ return 0;}   )
include_directories( a  b )
add_executable( test test.c )


the project file is expected to be XML, so it parses first using those rules,
and '' should be emitted as 'amp;' instead.

Steps to Reproduce: 
use visual studio generator on the attached CMakeLists.txt, then load the .sln
produced.  None of the projects will load.
== 

Issue History 
Date ModifiedUsername   FieldChange   
== 
2013-08-01 14:41 d3x0r  New Issue
2013-08-01 14:41 d3x0r  File Added: CMakeLists.txt
==

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] Please review CXXFeatures.cmake

2013-08-01 Thread Rolf Eike Beer
Alexander Neundorf wrote:
 On Friday 19 July 2013, Rolf Eike Beer wrote:

  Ok, I've pushed an updated version to the rework branch. A test for the
  component check is missing, but all of your other suggestions should have
  been addressed.
 
 The variable is case-sensitive, so it is CXXFeatures_FIND_COMPONENTS, not
 CXXFEATURES_FIND_COMPONENTS.

Fixed.

 I'm not sure I would have made this a find-module, instead of a simple
 module which can be included and then provides a function, but I think this
 doesn't matter much.

Because I get things like components for free then ;)

 And of course, before merging into cmake, the cmake_minimum_required() call
 can be removed.

Yes, and some other minor things. I have a list somewhere, probably on my 
other machine.

Eike
-- 

signature.asc
Description: This is a digitally signed message part.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers