[cmake-developers] [CMake 0014786]: Imported targets always require an IMPORTED_LOCATION
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=14786
==
Reported By:Philipp Möller
Assigned To:
==
Project:CMake
Issue ID: 14786
Category: CMake
Reproducibility:always
Severity: minor
Priority: normal
Status: new
==
Date Submitted: 2014-03-05 08:06 EST
Last Modified: 2014-03-05 08:06 EST
==
Summary:Imported targets always require an IMPORTED_LOCATION
Description:
When creating an imported target importtarget and not setting the
IMPORTED_LOCATION property, targets linking against the imported target will
have a dependency on importtarget-NOTFOUND, making it impossible to build.
A common use case is to manually create imported targets from the result of a
find_package call for easy reference to the dependency in various places in the
build system. Some libraries (like core Boost, Eigen) don't have any libraries.
Steps to Reproduce:
Use:
cmake_minimum_required(VERSION 2.8)
project(Foo)
add_executable(main main.cpp)
add_library(Header_only_lib IMPORTED)
set_target_properties(${lib} PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES /usr/include/my_lib
)
target_link_libraries(main Header_only_lib)
cmake .
make main # boom
Additional Information:
AFAIK this is going to be resolved with add_library(foo INTERFACE IMPORTED), but
a work-around for earlier CMake versions would be much appreciated.
==
Issue History
Date ModifiedUsername FieldChange
==
2014-03-05 08:06 Philipp Möller New Issue
==
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Introduction and volunteering for the Matlab package
Hello, My name is Raffi Enficiaud. I am volunteering myself for maintaining the Matlab package. In fact, I wrote a Matlab package that I am currently using on Mac and Win in Bamboo continuous build (and in the near future on Ubuntu). I already gave some of the functionalities in the following mantis ticket: http://www.cmake.org/Bug/view.php?id=14641 I would like to release this to the cmake community and to maintain it. Waiting for your feedbacks, Best, Raffi Enficiaud -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014787]: Unable to include a directory named after a Visual Studio macro.
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14787 == Reported By:tibur Assigned To: == Project:CMake Issue ID: 14787 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2014-03-05 09:12 EST Last Modified: 2014-03-05 09:12 EST == Summary:Unable to include a directory named after a Visual Studio macro. Description: I am trying to include a directory defined by a Visual Studio macro name ($(BlahBlahBlah)). Using the following CMakeLists.txt, CMake concatenates the project working dir (d:/taf/Blah) with my macro name, leading to a wrong include directory. Steps to Reproduce: cmake_minimum_required(VERSION 2.8) include_directories(c:/) include_directories($(BlahBlahBlah)) include_directories(d:/) add_executable(Blah main.cpp) Produces: AdditionalIncludeDirectoriesc:\;d:\Taf\Blah\$(BlahBlahBlah);d:\;%(AdditionalIncludeDirectories)/AdditionalIncludeDirectories == Issue History Date ModifiedUsername FieldChange == 2014-03-05 09:12 tibur New Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Fwd: [Bug 1072964] New: Could NOT find PythonInterp
So, I reverted the patch in Fedora to that stated in
http://cmake.org/Bug/view.php?id=13794 and that seems to have
immediately broken things.
I'm attaching the version that Fedora has been carrying (and seemingly
working).
BTW - This seems to be a duplicate: http://cmake.org/Bug/view.php?id=10077
- Orion
Original Message
Subject: [Bug 1072964] New: Could NOT find PythonInterp
Date: Wed, 05 Mar 2014 13:58:41 +
From: bugzi...@redhat.com
To: or...@cora.nwra.com
https://bugzilla.redhat.com/show_bug.cgi?id=1072964
Bug ID: 1072964
Summary: Could NOT find PythonInterp
Product: Fedora
Version: rawhide
Component: cmake
Assignee: or...@cora.nwra.com
Reporter: akozu...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: jrez...@redhat.com, lti...@redhat.com,
or...@cora.nwra.com, pertu...@free.fr,
pmach...@redhat.com, rdie...@math.unl.edu
Hello, DNF rawhide builds started to fail today:
http://kojipkgs.fedoraproject.org//work/tasks/4/664/build.log
The most relevant part is below. dgilmore noticed there has been this
change in
CMake:
[14:49]dgilmore akozumpl: cmake-3.0.0-0.3.rc1.fc21
[14:49]dgilmore
[14:49]dgilmore * Mon Mar 03 2014 Orion Poplawski or...@cora.nwra.com -
3.0.0-0.3.rc1
[14:49]dgilmore - Update to upstreams version of FindPythonLibs patch
so we think it's probable cmake is causing this. mock builds are passing so
far.
-- Found PythonLibs: /usr/lib64/libpython3.3m.so (found suitable version
3.3.2, minimum required is 3.0)
CMake Error at
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:136
(message):
Could NOT find PythonInterp: Found unsuitable version 2.7.6, but
required
is at least 3.0 (found /usr/bin/python)
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:341
(_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake/Modules/FindPythonInterp.cmake:153
(FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:18 (FIND_PACKAGE)
-- Configuring incomplete, errors occurred!
See also /builddir/build/BUILD/dnf/py3/CMakeFiles/CMakeOutput.log.
error: Bad exit status from /var/tmp/rpm-tmp.eGxvxC (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.eGxvxC (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/dnf.spec']
Traceback (most recent call last):
File /usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py, line
70, in trace
result = func(*args, **kw)
File /usr/lib/python2.7/site-packages/mockbuild/util.py, line 376, in do
raise mockbuild.exception.Error, (Command failed. See logs for
output.\n #
%s % (command,), child.returncode)
Error: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/dnf.spec']
LEAVE do -- EXCEPTION RAISED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
diff -rupN cmake/Modules/FindPythonLibs.cmake new/Modules/FindPythonLibs.cmake
--- cmake/Modules/FindPythonLibs.cmake 2013-04-12 14:09:08.470669049 -0500
+++ new/Modules/FindPythonLibs.cmake 2013-04-12 15:41:15.789496153 -0500
@@ -69,10 +69,21 @@ endif()
# Set up the versions we know about, in the order we will search. Always add
# the user supplied additional versions to the front.
-set(_Python_VERSIONS
- ${Python_ADDITIONAL_VERSIONS}
- ${_PYTHON_FIND_OTHER_VERSIONS}
- )
+# If FindPythonInterp has already found the major and minor version,
+# insert that version between the user supplied versions and the stock
+# version list.
+if(DEFINED PYTHON_VERSION_MAJOR AND DEFINED PYTHON_VERSION_MINOR)
+ set(_Python_VERSIONS
+${Python_ADDITIONAL_VERSIONS}
+${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}
+${_PYTHON_FIND_OTHER_VERSIONS}
+)
+else()
+ set(_Python_VERSIONS
+${Python_ADDITIONAL_VERSIONS}
+${_PYTHON_FIND_OTHER_VERSIONS}
+)
+endif()
unset(_PYTHON_FIND_OTHER_VERSIONS)
unset(_PYTHON1_VERSIONS)
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Cmake contribution for Open Watcom (patch)
On 02/28/2014 02:38 PM, Jiri Malak wrote: FYI, you can run the test suite with the Open Watcom compiler by configuring to build with another compiler but setting CMAKE_TEST_GENERATOR and CMAKE_TEST_MAKEPROGRAM to be Watcom WMake and c:/path/to/wmake.exe, respectively. Then after building, open a terminal in an environment set up for Open Watcom and run bin\ctest to run the tests. Add options -j 8 for parallel testing or -R someregex to run a subset of tests or -V to see verbose test output. Thanks for hint, it is very useful. After working that way for years, by coincidence I just changed testing for Open Watcom to use another approach that will be easier to generalize for other compilers. Now after building CMake with another compiler, open a terminal with the environment configured for Open Watcom and do: mkdir CMake-ow-build cd CMake-ow-build cmake ../CMake -G Watcom WMake -DCMake_TEST_EXTERNAL_CMAKE=... where the ... value is a path to the directory containing the cmake, ctest, and cpack executables to be tested, such as: c:/path/to/CMake-other-build/bin Then run wmake in case there are any test-only binaries to build. Finally run ctest to launch the tests. The ctest -j/-R/-V/etc. options will still work. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [Review request] Topic FindPkgConfig_Extend-PKG_CONFIG_PATH
On 03/04/2014 10:07 PM, Daniele E. Domenichelli wrote: Follow up to this thread: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8369 Please review the topic FindPkgConfig_Extend-PKG_CONFIG_PATH. Nice! Please revise the documentation to use proper cross-reference syntax to link to other variables instead of just inline literals: ``SOME_VARIABLE`` = :variable:`SOME_VARIABLE` Also it looks like some logic is taken from GNUInstallDirs. Is there enough in common to try to factor that out into a helper module? Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Fwd: [Bug 1072964] New: Could NOT find PythonInterp
On 03/05/2014 10:29 AM, Orion Poplawski wrote: So, I reverted the patch in Fedora to that stated in http://cmake.org/Bug/view.php?id=13794 and that seems to have immediately broken things. I re-opened the issue, thanks. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Fwd: [Bug 1072964] New: Could NOT find PythonInterp
On 03/05/2014 12:02 PM, Orion Poplawski wrote: On 03/05/2014 09:53 AM, Brad King wrote: On 03/05/2014 10:29 AM, Orion Poplawski wrote: http://cmake.org/Bug/view.php?id=13794 I re-opened the issue, thanks. Thanks - but I don't seem to be able to comment on it. Oops, I think I picked the wrong state. Please try again. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Introduction and volunteering for the Matlab package
On 03/05/2014 08:49 AM, Raffi Enficiaud wrote: I am volunteering myself for maintaining the Matlab package. Great, thanks! I already gave some of the functionalities in the following mantis ticket: http://www.cmake.org/Bug/view.php?id=14641 In answer to your questions from there: - What should I do now? - What is the release process? Posting here was a good first step. See full instructions here: http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer Please post the proposed module as an attachment here for discussion and review. Once things are in good shape then we will ask you to sign up for Git access. - If I release this script with the BSD-3 license, it is ok right? What about the Boost v1 license that I am currently using? We require the BSD 3-Clause license, please. The developer manual: http://www.cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#find-modules specifies the exact format in which the legal notice must appear. The test suite verifies it. - How to update the documentation then? Should the package be released with a text file documenting the functionalities? The documentation goes in the module as described here: http://www.cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#module-documentation Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] pause on new topics please
Hi Folks, Please do not merge any new topics to 'next' until further notice. It should just be for a day or two. Ben has been working for a while on sweeping API changes in the dev/string-apis topic to improve performance and reduce the mix of std::string and char* APIs. He has patiently rebased on every topic that has been coming through but is now ready to test it on the dashboards. The topic will likely conflict with most other changes. After it is clean I will merge it to master and lift the freeze. Then all active topics can be rebased on it to resolve the conflicts. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [Patch] fix archive library build by Open Watcom
Hi, I enclosed fix for archive library (Utility) build by Open Watcom Regards JiriFrom 7bf955a4f1ffb5117063e17023d74fb11edf30a5 Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Tue, 4 Mar 2014 16:35:44 +0100 Subject: [PATCH] fix archive library build by Open Watcom --- Utilities/cmlibarchive/libarchive/archive.h | 2 +- Utilities/cmlibarchive/libarchive/archive_entry.h | 4 ++-- Utilities/cmlibarchive/libarchive/archive_windows.h | 5 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Utilities/cmlibarchive/libarchive/archive.h b/Utilities/cmlibarchive/libarchive/archive.h index 1a1d32a..83d2c16 100644 --- a/Utilities/cmlibarchive/libarchive/archive.h +++ b/Utilities/cmlibarchive/libarchive/archive.h @@ -54,7 +54,7 @@ /* Get appropriate definitions of standard POSIX-style types. */ /* These should match the types used in 'struct stat' */ -#if defined(_WIN32) !defined(__CYGWIN__) +#if defined(_WIN32) !defined(__CYGWIN__) !defined(__WATCOMC__) # define __LA_INT64_T __int64 # if defined(_SSIZE_T_DEFINED) || defined(_SSIZE_T_) # define __LA_SSIZE_T ssize_t diff --git a/Utilities/cmlibarchive/libarchive/archive_entry.h b/Utilities/cmlibarchive/libarchive/archive_entry.h index 85ea885..ae6a76e 100644 --- a/Utilities/cmlibarchive/libarchive/archive_entry.h +++ b/Utilities/cmlibarchive/libarchive/archive_entry.h @@ -48,7 +48,7 @@ #endif /* Get a suitable 64-bit integer type. */ -#if defined(_WIN32) !defined(__CYGWIN__) +#if defined(_WIN32) !defined(__CYGWIN__) !defined(__WATCOMC__) # define __LA_INT64_T __int64 #else #include unistd.h @@ -63,7 +63,7 @@ #if ARCHIVE_VERSION_NUMBER = 3999000 /* Switch to plain 'int' for libarchive 4.0. It's less broken than 'mode_t' */ # define __LA_MODE_T int -#elif defined(_WIN32) !defined(__CYGWIN__) !defined(__BORLANDC__) +#elif defined(_WIN32) !defined(__CYGWIN__) !defined(__BORLANDC__) !defined(__WATCOMC__) # define __LA_MODE_T unsigned short #else # define __LA_MODE_T mode_t diff --git a/Utilities/cmlibarchive/libarchive/archive_windows.h b/Utilities/cmlibarchive/libarchive/archive_windows.h index 620810c..1dd61b6 100644 --- a/Utilities/cmlibarchive/libarchive/archive_windows.h +++ b/Utilities/cmlibarchive/libarchive/archive_windows.h @@ -188,6 +188,9 @@ #define S_ISDIR(m) (((m) S_IFMT) == S_IFDIR) /* directory */ #define S_ISREG(m) (((m) S_IFMT) == S_IFREG) /* regular file */ #endif + +#if !defined(__WATCOMC__) + #define S_ISLNK(m) (((m) S_IFMT) == S_IFLNK) /* Symbolic link */ #define S_ISSOCK(m) (((m) S_IFMT) == S_IFSOCK) /* Socket */ @@ -227,6 +230,8 @@ #define S_IWOTH_S_IWOTH #define S_IROTH_S_IROTH +#endif + #define F_DUPFD 0 /* Duplicate file descriptor. */ #define F_GETFD 1 /* Get file descriptor flags. */ #define F_SETFD 2 /* Set file descriptor flags. */ -- 1.8.1.4 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Introduction and volunteering for the Matlab package
Hi, So, I began writing the doc of the module and changed the license according to the instructions. I am attaching the module to the email. FindMatlab.cmake Description: Binary data From what I see in the instructions, there are some issues with the proposed module: - the error messages are more or less message(STATUS... and sometimes message(FATAL_ERROR, rather than using Xxx_NOT_FOUND_MESSAGE. So basically if I set this variable to the error message and just call “return()” from the module scope, it will do the job? - it looks like I am making too much use of the CACHE. However, I do not know if the variables like Xxx_INCLUDE_DIRS should go to the CACHE or to the PARENT_SCOPE. What are the good practices for these variables ? - some of the variables should be renamed - the version matching should be performed in the module, right ? Best, Raffi Enficiaud On 05 Mar 2014, at 18:50, Brad King brad.k...@kitware.com wrote: On 03/05/2014 08:49 AM, Raffi Enficiaud wrote: I am volunteering myself for maintaining the Matlab package. Great, thanks! I already gave some of the functionalities in the following mantis ticket: http://www.cmake.org/Bug/view.php?id=14641 In answer to your questions from there: - What should I do now? - What is the release process? Posting here was a good first step. See full instructions here: http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer Please post the proposed module as an attachment here for discussion and review. Once things are in good shape then we will ask you to sign up for Git access. - If I release this script with the BSD-3 license, it is ok right? What about the Boost v1 license that I am currently using? We require the BSD 3-Clause license, please. The developer manual: http://www.cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#find-modules specifies the exact format in which the legal notice must appear. The test suite verifies it. - How to update the documentation then? Should the package be released with a text file documenting the functionalities? The documentation goes in the module as described here: http://www.cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#module-documentation Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Who does CMake contract work?
Hi all, Are there any companies/individuals out there that have a history of contributions to CMake that would be interested in adding Android.mk generator and an NSight Tegra (Visual Studio plugin) generator? Details: Modify CMake to be able to generate Android.mk files usable by ndk-build Prove correct operation by building all LiquidFun targets using Android.mk files generated by CMake. Modify open source CMake to be able to generate NSight Tegra project files. Prove correct operation by building all LiquidFun targets using NSight Tegra files generated by CMake. Submit a patch to LiquidFun with working CMake files. (with copyright assignment) LiquidFun - http://google-opensource.blogspot.com/2013/12/liquidfun-rigid-body-physics-library.html (High probability of ongoing work as we port more CMake based open source projects to Android) Thanks, Vince -- Vince Harron | Technical Lead Manager | vhar...@google.com | 858-442-0868 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
