Re: [cmake-developers] [Review Request] Topic CMakePackageConfigHelpers_build_tree

2014-08-07 Thread Daniele E. Domenichelli
On 04/08/14 20:35, Brad King wrote:
 Please also add a check that the value given to the INSTALL_PREFIX
 option passes if(IS_ABSOLUTE).  It does not make sense to have a
 relative value here.

Done and merged to next.

Thanks,
 Daniele

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] [CMake 0015067]: include does not find files in current directory if module path discovered through CMAKE_PREFIX_PATH

2014-08-07 Thread Mantis Bug Tracker

The following issue has been SUBMITTED. 
== 
http://www.cmake.org/Bug/view.php?id=15067 
== 
Reported By:Alexander Jones
Assigned To:
== 
Project:CMake
Issue ID:   15067
Category:   CMake
Reproducibility:always
Severity:   minor
Priority:   normal
Status: new
== 
Date Submitted: 2014-08-07 06:56 EDT
Last Modified:  2014-08-07 06:56 EDT
== 
Summary:include does not find files in current directory if
module path discovered through CMAKE_PREFIX_PATH
Description: 
Setup:

someprefix/share/mytest/cmake/MyTestConfig.cmake:

  include(somethingspecific)

---

someprefix/share/mytest/cmake/somethingspecific.cmake:

  message(Hello, World!)

---

somesourcecode/CMakeLists.txt

  cmake_minimum_required(VERSION 3.0)

  find_package(MyTest REQUIRED CONFIG)

---

Build with

cmake .. -DCMAKE_PREFIX_PATH=someprefix

CMake Error at (snip)/someprefix/share/mytest/cmake/MyTestConfig.cmake:1
(include):
  include could not find load file:

somethingspecific
Call Stack (most recent call first):
  CMakeLists.txt:3 (find_package)


This is the setup LLVM has for its config, and it does not work in our setup for
the same reason.

Manually adding someprefix/share/mytest/cmake to the CMAKE_MODULE_PATH fixes
this, but is that not implied from someprefix being on the CMAKE_PREFIX_PATH?

Our scenario is that we have many isolated package installations distributed
across many prefixes, each with an entry on CMAKE_PREFIX_PATH.

Thanks
== 

Issue History 
Date ModifiedUsername   FieldChange   
== 
2014-08-07 06:56 Alexander JonesNew Issue
2014-08-07 06:56 Alexander JonesFile Added: cmakebugtest.tar.gz 
  
==

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] [CMake 0015068]: Eclipse cannot run Makefile (mingw)

2014-08-07 Thread Mantis Bug Tracker

The following issue has been SUBMITTED. 
== 
http://public.kitware.com/Bug/view.php?id=15068 
== 
Reported By:A. Klitzing
Assigned To:
== 
Project:CMake
Issue ID:   15068
Category:   CMake
Reproducibility:always
Severity:   minor
Priority:   normal
Status: new
== 
Date Submitted: 2014-08-07 10:44 EDT
Last Modified:  2014-08-07 10:44 EDT
== 
Summary:Eclipse cannot run Makefile (mingw)
Description: 
Since cmake 3.0 we cannot build from eclipse (tried Kepler and Luna). We uses
the eclipse cdt4 mingw-generator on windows to create the projects. After
import in eclipse there will be no reaction if we try to run the build or a
special target of the Makefile.

The same workflow works with cmake 2.8.x flawlessly.

The build with cmake 3 works without problems if we use the terminal and run it
manually with mingw32-make.

Steps to Reproduce: 
1. Take your project
2. Run cmake-gui and configure the project
3. Select eclipse cdt4 mingw generator
4. Import from existing project in eclipse
5. Select build all or double click on a special target
6. Eclipse does nothing

Expected:
Run the makefile
== 

Issue History 
Date ModifiedUsername   FieldChange   
== 
2014-08-07 10:44 A. KlitzingNew Issue
==

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] [patch] fix Info.plist parser

2014-08-07 Thread Tim Blechmann
hi all,

attached patch adds support for parsing Info.plist files which are
generated with mac os9-style line endings (\r).

would be great if this fix can be applied (and if it would make it into
3.0.2).

thanks,
tim
From 0b1420c8c22885f3a4a086510a2041bc80be7732 Mon Sep 17 00:00:00 2001
From: Tim Blechmann t...@klingt.org
Date: Thu, 7 Aug 2014 19:30:27 +0200
Subject: [PATCH] cmake: allow Info.plist files which use os9-style \r line
 endings

Signed-off-by: Tim Blechmann t...@klingt.org
---
 Modules/BundleUtilities.cmake | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Modules/BundleUtilities.cmake b/Modules/BundleUtilities.cmake
index b896de2..60d01b5 100644
--- a/Modules/BundleUtilities.cmake
+++ b/Modules/BundleUtilities.cmake
@@ -237,6 +237,7 @@ function(get_bundle_main_executable bundle result_var)
 file(READ ${bundle}/Contents/Info.plist info_plist)
 string(REGEX REPLACE ; ; info_plist ${info_plist})
 string(REGEX REPLACE \n ${eol_char}; info_plist ${info_plist})
+string(REGEX REPLACE \r ${eol_char}; info_plist ${info_plist})
 
 # Scan the lines for keyCFBundleExecutable/key - the line after that
 # is the name of the main executable.
-- 
2.0.4

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] [PATCH] New module: FindIce.cmake

2014-08-07 Thread Roger Leigh
Hi,

I've written a module for finding the details of a ZeroC ICE installation,
attached, which I thought might be of interest to a wider audience and be
suitable for direct inclusion into cmake.  I've attached the patch for this.
The docs should be correct, but I'm not yet totally familiar with the cmake
docs build, so it might possibly need some minor tweaking.


Kind regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
From d797fef2c883b5fc9e6d19267b21c4f818befe50 Mon Sep 17 00:00:00 2001
From: Roger Leigh r.le...@dundee.ac.uk
Date: Thu, 7 Aug 2014 18:37:36 +0100
Subject: [PATCH] FindIce: New module to find ZeroC Ice

- autodetects Ice on all major platforms
- allows building with all supported Visual Studio versions on Windows
- autodetects the slice path on most platforms
- separately detects the Ice programs, headers, slice files and
  libraries so that any Ice configuration or installation errors can
  be accurately reported, making diagnosis of Ice problems simpler
---
 Help/manual/cmake-modules.7.rst |   1 +
 Help/module/FindIce.rst |   1 +
 Modules/FindIce.cmake   | 507 
 3 files changed, 509 insertions(+)
 create mode 100644 Help/module/FindIce.rst
 create mode 100644 Modules/FindIce.cmake

diff --git a/Help/manual/cmake-modules.7.rst b/Help/manual/cmake-modules.7.rst
index 91fffe9..737057c 100644
--- a/Help/manual/cmake-modules.7.rst
+++ b/Help/manual/cmake-modules.7.rst
@@ -114,6 +114,7 @@ All Modules
/module/FindHg
/module/FindHSPELL
/module/FindHTMLHelp
+   /module/FindIce
/module/FindIcotool
/module/FindImageMagick
/module/FindITK
diff --git a/Help/module/FindIce.rst b/Help/module/FindIce.rst
new file mode 100644
index 000..3af9405
--- /dev/null
+++ b/Help/module/FindIce.rst
@@ -0,0 +1 @@
+.. cmake-module:: ../../Modules/FindIce.cmake
diff --git a/Modules/FindIce.cmake b/Modules/FindIce.cmake
new file mode 100644
index 000..f42b4ee
--- /dev/null
+++ b/Modules/FindIce.cmake
@@ -0,0 +1,507 @@
+#.rst:
+# FindIce
+# ---
+#
+# Find the ZeroC Internet Communication Engine (ICE) programs,
+# libraries and datafiles.
+#
+# Use this module by invoking find_package with the form::
+#
+#   find_package(Ice
+# [version] [EXACT]  # Minimum or EXACT version e.g. 3.5.1
+# [REQUIRED] # Fail with error if Ice is not found
+#
+# This module reports information about the Ice installation in
+# several variables.  General variables::
+#
+#   Ice_VERSION - Ice release version
+#   Ice_FOUND - true if the main programs and libraries were found
+#
+# Ice programs are reported in::
+#
+#   SLICE2CPP_EXECUTABLE - path to slice2cpp executable
+#   SLICE2CS_EXECUTABLE - path to slice2cs executable
+#   SLICE2FREEZEJ_EXECUTABLE - path to slice2freezej executable
+#   SLICE2FREEZE_EXECUTABLE - path to slice2freeze executable
+#   SLICE2HTML_EXECUTABLE - path to slice2html executable
+#   SLICE2JAVA_EXECUTABLE - path to slice2java executable
+#   SLICE2PHP_EXECUTABLE - path to slice2php executable
+#   SLICE2PY_EXECUTABLE - path to slice2py executable
+#   SLICE2RB_EXECUTABLE - path to slice2rb executable
+#
+# Ice libraries are reported in::
+#
+#   FREEZE_LIBRARY - Freeze library
+#   GLACIER2_LIBRARY - Glacier2 library
+#   ICE_LIBRARY - Ice library
+#   ICEBOX_LIBRARY - IceBox library
+#   ICEDB_LIBRARY - IceDB library
+#   ICEGRID_LIBRARY - IceGrid library
+#   ICEPATCH2_LIBRARY - IcePatch library
+#   ICESSL_LIBRARY - IceSSL library
+#   ICESTORM_LIBRARY - IceStorm library
+#   ICEUTIL_LIBRARY - IceUtil library
+#   ICEXML_LIBRARY - IceXML library
+#   SLICE_LIBRARY - Slice library
+#
+# Ice directories for C++ includes and slice includes are reported
+# in::
+#
+#   ICE_BINARY_DIR - the directory containing the Ice programs
+#   ICE_INCLUDE_DIR - the directory containing the Ice headers
+#   ICE_SLICE_DIR - the directory containing the Ice slice interface definitions
+#   ICE_LIBRARY_DIR - the directory containing the Ice libraries
+#
+# This module reads hints about search results from variables::
+#
+#   ICE_HOME - the root of the Ice installation
+#   ICE_BINARY_DIR - the directory containing the Ice programs
+#   ICE_INCLUDE_DIR - the directory containing the Ice headers
+#   ICE_SLICE_DIR - the directory containing the Ice slice interface definitions
+#   ICE_LIBRARY_DIR - the directory containing the Ice libraries
+#
+# The environment variable :envvar:`ICE_HOME` may also be used, unless
+# overridden by setting the ICE_HOME variable.
+#
+# .. note::
+#
+#   These variables are not all required to be set, and in most cases
+#   will not require setting at all unless multiple Ice versions are
+#   available and a specific version is required.  On Windows,
+#   ICE_HOME is usually sufficient 

Re: [cmake-developers] [patch] fix Info.plist parser

2014-08-07 Thread Brad King
On 08/07/2014 01:36 PM, Tim Blechmann wrote:
 would be great if this fix can be applied

I applied the patch with a slight revision to resolve conflicts
with master:

 BundleUtilities: Allow Info.plist files which use CR line endings
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=810f5cce

Once it works there I will consider backporting it to 3.0.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] [CMake 0015069]: Add support for OpenRISC 1000 (or1k)

2014-08-07 Thread Mantis Bug Tracker

The following issue has been SUBMITTED. 
== 
http://public.kitware.com/Bug/view.php?id=15069 
== 
Reported By:mafm
Assigned To:
== 
Project:CMake
Issue ID:   15069
Category:   (No Category)
Reproducibility:always
Severity:   feature
Priority:   normal
Status: new
== 
Date Submitted: 2014-08-07 14:13 EDT
Last Modified:  2014-08-07 14:13 EDT
== 
Summary:Add support for OpenRISC 1000 (or1k)
Description: 
From Debian bug report: 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749004

From: Christian Svensson deb...@cmd.nu
Date: Fri, 23 May 2014 01:05:56 +0200

Package: cmake
Version: 2.8.12.1-1.2
Severity: wishlist
Tags: upstream patch

Dear Maintainer,

Attached is a patch to add support for the OpenRISC 1000 architecture.

== 

Issue History 
Date ModifiedUsername   FieldChange   
== 
2014-08-07 14:13 mafm   New Issue
2014-08-07 14:13 mafm   File Added: cmake-or1k.patch
==

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] [patch] fix Info.plist parser

2014-08-07 Thread Tim Blechmann
 would be great if this fix can be applied
 
 I applied the patch with a slight revision to resolve conflicts
 with master:
 
  BundleUtilities: Allow Info.plist files which use CR line endings
  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=810f5cce
 
 Once it works there I will consider backporting it to 3.0.

great! thanks a lot!

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] [CMake 0015070]: CMake doesn't escape # properly in add_compile_options with Makefile generator

2014-08-07 Thread Mantis Bug Tracker

The following issue has been SUBMITTED. 
== 
http://www.cmake.org/Bug/view.php?id=15070 
== 
Reported By:Vitali
Assigned To:
== 
Project:CMake
Issue ID:   15070
Category:   CMake
Reproducibility:always
Severity:   minor
Priority:   normal
Status: new
== 
Date Submitted: 2014-08-07 15:02 EDT
Last Modified:  2014-08-07 15:02 EDT
== 
Summary:CMake doesn't escape # properly in
add_compile_options with Makefile generator
Description: 
add_compile_options appears to generate the wrong escape sequence for:
add_compile_options(-Wno-error=#warnings)

when used in conjuction with the Makefile generator

Steps to Reproduce: 
add_compile_options(-Wno-error=#warnings)

Use makefile generator

Look at flags.make:
CXX_FLAGS = ... -Wno-error=#warnings ...
It should be:
CXX_FLAGS = -Wno-error=\#warnings
due to shell-expansion (otherwise # gets treated as a comment).

Additional Information: 
No amount of escaping in CMake fixes this.
It looks like CMake is already aware of \ escaping for the Makefile generator
but not for #:

add_compile_options(-Wno-error=\#warnings)
CXX_FLAGS = ... -Wno-error=#warnings ...

add_compile_options(-Wno-error=\\#warnings)
CXX_FLAGS = ... -Wno-error=\\#warnings ...

add_compile_options(-Wno-error=\\\#warnings)
CXX_FLAGS = ... -Wno-error=\\#warnings ...
== 

Issue History 
Date ModifiedUsername   FieldChange   
== 
2014-08-07 15:02 Vitali New Issue
==

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers