Re: [cmake-developers] [PATCH] ninja generator: don't initialize language for files marked, as header-only

2015-04-08 Thread Tim Blechmann
 not sure if there is a better way to resolve this issue:
 declaring .RC files as header-only break ninja builds on non-windows
 platforms.

note: this is necessary when the the language is set explicitly.

 ---8---
 
 cmake currently tries to initialize the language rules for all source
 files. when HEADER_FILE_ONLY is used to mark files which should be added
 to the generated project, but should not be compiled, this will
 nevertheless try to initialize the language, which might fail on that
 specific platform. this is a practical issue when declaring .RC files as
 header-only on non-windows platforms.
 
 
 


-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] ninja generator: don't initialize language for files marked, as header-only

2015-04-08 Thread Brad King
On 04/08/2015 07:54 AM, Tim Blechmann wrote:
 not sure if there is a better way to resolve this issue:
 declaring .RC files as header-only break ninja builds on non-windows
 platforms.
 
 note: this is necessary when the the language is set explicitly.

Thanks.  Would you please update the patch to include a change
to the test suite to cover this?

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] FW: FW: Initial Attempt at Green Hill MULTI IDE Generator Support

2015-04-08 Thread Brad King
On 04/08/2015 01:20 AM, Geoffrey Viola wrote:
 Attached is a patch based off of the previous commit.

I get conflicts applying on commit ff7ecb92.  Please resolve.

 target_compile_options(${TARGET_NAME} PUBLIC
 :optionsFile=\${ABS_PATH}/rel/path/filename\)

The COMPILE_OPTIONS are supposed to be given flags exactly as
you'd like the tools to receive them, and CMake is supposed to
take care of the quoting.  This is different than the older
COMPILE_FLAGS value that is just a command line string.

Therefore I think you should be writing:

 target_compile_options(${TARGET_NAME} PUBLIC
 :optionsFile=${ABS_PATH}/rel/path/filename)

which is expected to work even if there is a space in the ABS_PATH
value.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] [CMake 0015507]: CMake.App bundle is malformed which prevents code signing it

2015-04-08 Thread Mantis Bug Tracker

The following issue has been SUBMITTED. 
== 
http://www.cmake.org/Bug/view.php?id=15507 
== 
Reported By:Eric Wing
Assigned To:
== 
Project:CMake
Issue ID:   15507
Category:   CMake
Reproducibility:have not tried
Severity:   minor
Priority:   normal
Status: new
== 
Date Submitted: 2015-04-08 18:28 EDT
Last Modified:  2015-04-08 18:28 EDT
== 
Summary:CMake.App bundle is malformed which prevents code
signing it
Description: 
CMake should be code signable so somebody can potentially sign it for Mac
deployment. When it is not code signed, Apple's GateKeeper will block it by
default. (I'm actually distributing it internally, and wanted to code sign it
with my own key just to avoid headaches.)

CMake.app's internals have a few flaws which prevent code signing. The majority
are not in CMake itself, but in the embedded Qt frameworks.

Steps to Reproduce: 
This will fail with errors.
codesign --force --verbose --sign Developer ID --deep CMake.app



Additional Information: 
I tested with CMake 3.0, but not the latest, but I suspect the issue still
exists in the latest.

The flaws are as follows:
- QtCore and QtGui must have an Info.plist in Versions/4/Resources directory
- There should be a Current symlink to the 4 directory
- QtGui puts the Resources directory in the wrong place
- In my copy of CMake, there are two executables in Contents/MacOS instead of
just one, which confuses the code signing. The second is an executable with a
version number in the name. That shouldn't exist. (But you can manually code
sign both to make the overall code sign work.)


Below is my script that basically works around the problems. Ideally, the
underlying flaws would be fixed instead of worked around.


#!/bin/zsh

# gets the script path
# script_path=${0:a}
# gets the directory in which the script resides
SCRIPT_DIR=${0:a:h}


CODE_SIGN_IDENTITY=Developer ID

if [ -z $1 ]; then
echo Usage: codesign_cmake /path/CMake.app
exit 1
fi

CMAKE_DIR=$1


# Hack to fix mangled frameworks:
mkdir $CMAKE_DIR/Contents/Frameworks/QtCore.framework/Versions/4/Resources
mkdir $CMAKE_DIR/Contents/Frameworks/QtGui.framework/Versions/4/Resources
cp $SCRIPT_DIR/QtCore.Info.plist
$CMAKE_DIR/Contents/Frameworks/QtCore.framework/Versions/4/Resources/Info.plist
cp $SCRIPT_DIR/QtGui.Info.plist
$CMAKE_DIR/Contents/Frameworks/QtGui.framework/Versions/4/Resources/Info.plist
(cd $CMAKE_DIR/Contents/Frameworks/QtCore.framework/Versions
ln -s 4 Current
)
(cd $CMAKE_DIR/Contents/Frameworks/QtGui.framework/Versions
ln -s 4 Current
)
(cd $CMAKE_DIR/Contents/Frameworks/QtGui.framework
mv Resources/* Versions/4/Resources/
rmdir Resources
ln -s Versions/Current/Resources Resources
)


codesign --force --verbose --sign $CODE_SIGN_IDENTITY
$CMAKE_DIR/Contents/Frameworks/QtCore.framework/Versions/4/QtCore 
codesign --force --verbose --sign $CODE_SIGN_IDENTITY
$CMAKE_DIR/Contents/Frameworks/QtGui.framework/Versions/4/QtGui
find $CMAKE_DIR/Contents/bin -type f -exec codesign --force --verbose --sign
$CODE_SIGN_IDENTITY {} \;
find $CMAKE_DIR/Contents/MacOS -type f -exec codesign --force --verbose --sign
$CODE_SIGN_IDENTITY {} \;

codesign --force --verbose --sign $CODE_SIGN_IDENTITY $CMAKE_DIR


== 

Issue History 
Date ModifiedUsername   FieldChange   
== 
2015-04-08 18:28 Eric Wing  New Issue
==

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers