Re: [cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-21 Thread Gilles Khouzam via cmake-developers
I've changed it to the Debug Universal C-Runtime which should be included with 
the SDK.

This also leverages the version of the SDK to match the other extensions 
reducing the risk of failures.

-Original Message-
From: Brad King [mailto:brad.k...@kitware.com] 
Sent: Tuesday, June 21, 2016 07:32
To: Gilles Khouzam 
Cc: cmake-developers@cmake.org
Subject: Re: Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

On 06/20/2016 10:48 AM, Brad King wrote:
>  VS: Add VS_SDK_REFERENCES target property to reference external SDKs  
> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ccc6270d

This caused the VSWinStorePhone tests to fail, e.g.:

 https://open.cdash.org/testDetails.php?test=457508384=4422066
 (ResolveSDKReferences target) ->
  C:\Program Files 
(x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(2049,5): error 
MSB3774: Could not find SDK "Microsoft.NET.Native.Runtime.1.1, Version=1.1".

The problem is that the hard-coded VS_SDK_REFERENCES value in the test names a 
SDK that does not exist on the test machine.  Some other approach will be 
needed to know what SDK can be referenced by the test.

Thanks,
-Brad



0001-FixVS_SDK_REFERENCES.PATCH
Description: 0001-FixVS_SDK_REFERENCES.PATCH
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Using a custom DSL compiler in CMake

2016-06-21 Thread Chris Bieneman
Brad,

Thanks for the detailed response. This all makes a lot of sense. I’ll have to 
stew on this a bit and see where it leads me. In general it sounds to me like 
there is no easy solution here.

Thanks,
-Chris

> On Jun 21, 2016, at 1:05 PM, Brad King  wrote:
> 
> On 06/21/2016 02:18 PM, Chris Bieneman wrote:
>> Our current solution to work with this tool in CMake
> 
> For reference, a quick look at LLVM's `cmake/modules/TableGen.cmake`
> indicates that the current solution is based on add_custom_command.
> 
>> The harder part is that our DSL supports C-like includes.
> 
> The add_custom_command signature has an IMPLICIT_DEPENDS option
> for this, but it only works for Makefile generators.
> 
>> Our DSL compiler can generate .d files, but hooking that up to
>> CMake is a harder problem.
> 
> With some work it may be possible to teach our Ninja generator how
> to consume .d files in custom commands.  Perhaps such support could
> even be extended to the Makefile generators instead of using our
> approximate scanning implementation.
> 
> In general implicit dependencies cannot be cleanly supported by
> the Visual Studio or Xcode generators.  Those environments provide
> no hooks for custom build-time dependency scanning.  At best one
> can have the custom command produce a file as a side effect that
> can be consumed by CMake on the next run.  This would work for
> all generators but causes lots of CMake re-runs.
> 
>> My thought was to try and treat TableGen as a language.
>> There are some complications with that because we don’t
>> actually have a compiler for it at configuration time.
> 
> I don't think that is a good approach both because we won't
> be able to enable the language without the compiler already
> existing and because custom languages do not work well in
> the IDE generators (and will have the same dependency scanning
> problems as above).  See above approaches instead.
> 
> -Brad
> 

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Using a custom DSL compiler in CMake

2016-06-21 Thread Brad King
On 06/21/2016 02:18 PM, Chris Bieneman wrote:
> Our current solution to work with this tool in CMake

For reference, a quick look at LLVM's `cmake/modules/TableGen.cmake`
indicates that the current solution is based on add_custom_command.

> The harder part is that our DSL supports C-like includes.

The add_custom_command signature has an IMPLICIT_DEPENDS option
for this, but it only works for Makefile generators.

> Our DSL compiler can generate .d files, but hooking that up to
> CMake is a harder problem.

With some work it may be possible to teach our Ninja generator how
to consume .d files in custom commands.  Perhaps such support could
even be extended to the Makefile generators instead of using our
approximate scanning implementation.

In general implicit dependencies cannot be cleanly supported by
the Visual Studio or Xcode generators.  Those environments provide
no hooks for custom build-time dependency scanning.  At best one
can have the custom command produce a file as a side effect that
can be consumed by CMake on the next run.  This would work for
all generators but causes lots of CMake re-runs.

> My thought was to try and treat TableGen as a language.
> There are some complications with that because we don’t
> actually have a compiler for it at configuration time.

I don't think that is a good approach both because we won't
be able to enable the language without the compiler already
existing and because custom languages do not work well in
the IDE generators (and will have the same dependency scanning
problems as above).  See above approaches instead.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Using a custom DSL compiler in CMake

2016-06-21 Thread Roger Leigh

On 21/06/2016 18:18, Chris Bieneman wrote:

Hello cmake-developers,

I’m trying to find a solution to a long running problem in our build. In LLVM 
we have a domain specific language named TableGen that we use to generate 
header files used throughout the project. Our current solution to work with 
this tool in CMake is pretty terrible for a number of reasons.

The biggest problem is that we don’t have good dependency handling around the 
inputs and outputs from the DSL. Some of this is caused by our CMake targets 
not being granular (which I know how to fix). The harder part is that our DSL 
supports C-like includes.

Our DSL compiler can generate .d files, but hooking that up to CMake is a 
harder problem. My thought was to try and treat TableGen as a language. There 
are some complications with that because we don’t actually have a compiler for 
it at configuration time.

Any thoughts and guidance would be greatly appreciated. I feel as if I’m about 
to fall into a deep and scary rabbit hole.


In one of the projects I maintain at work, we generate a lot of 
different C++ sources and headers using a custom generator tool.  It 
consumes an XML schema, and then processes it to turn that formal data 
model into a set of C++ classes, enums and serialisation functions, 
using a series of templates.


I needed to make this work seamlessly with CMake, and so I wrote a set 
of functions to introspect the dependencies and then generate all the 
necessary targets with appropriate dependencies.  While I can't claim 
this is going to be the best use of CMake in the world, it's quite 
functional and does its job well.



https://github.com/openmicroscopy/bioformats/blob/develop/cpp/cmake/XsdFu.cmake

This contains helper macros to do the introspection.  We basically run 
the generator twice for each "target" using --print-generated and 
--print-depends options.  These cause the corresponding files to be 
dumped to stdout.  We then use these file lists as the OUTPUT and 
DEPENDS lists for add_custom_command.  NB. This tool outputs multiple 
source files at once which all go into the OUTPUT.


You can then see those macros in use here:

https://github.com/openmicroscopy/bioformats/blob/develop/cpp/lib/ome/xml/CMakeLists.txt#L42
where we then add those outputs to a regular library target.

While I think this is too custom to be of direct use, it might be useful 
for inspiration.  The essential point is to introspect the dependencies 
and outputs as you run cmake (which can emit the includes you mentioned 
as dependencies), and then use that information to generate the 
appropriate custom commands.  Everything will then be built at build 
time, in parallel.  How you do the introspection is entirely up to you. 
I added support to the generator itself since it already had the 
relevant information (it's a python tool) and was quick and easy to add. 
 You could also parse the files directly with cmake, or with a custom 
script in any language you like.



Hope that's at least provided some ideas!


Regards,
Roger

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] Using a custom DSL compiler in CMake

2016-06-21 Thread Chris Bieneman
Hello cmake-developers,

I’m trying to find a solution to a long running problem in our build. In LLVM 
we have a domain specific language named TableGen that we use to generate 
header files used throughout the project. Our current solution to work with 
this tool in CMake is pretty terrible for a number of reasons.

The biggest problem is that we don’t have good dependency handling around the 
inputs and outputs from the DSL. Some of this is caused by our CMake targets 
not being granular (which I know how to fix). The harder part is that our DSL 
supports C-like includes.

Our DSL compiler can generate .d files, but hooking that up to CMake is a 
harder problem. My thought was to try and treat TableGen as a language. There 
are some complications with that because we don’t actually have a compiler for 
it at configuration time.

Any thoughts and guidance would be greatly appreciated. I feel as if I’m about 
to fall into a deep and scary rabbit hole.

Thanks,
-Chris
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] can't upgrade cmake 2.8 on CentOS

2016-06-21 Thread Brad King
On 06/21/2016 02:25 PM, Thomas Beaudry wrote:
> in the root directory I see the following directories:
>   bin  doc  man  share
> I tried doing a "make && make install" or a "cmake ."

Those are prebuilt binaries.  You don't need to build anything.
You can run `bin/cmake` right out of the extracted tree.

> How should i go about upgrading my version of cmake?

If you prefer to build from source you can download
`cmake-3.5.2.tar.gz` from the download page where you
got the binaries.  There is a README.rst file that explains
how to build: `./bootstrap && make && make install`.

-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] can't upgrade cmake 2.8 on CentOS

2016-06-21 Thread Thomas Beaudry
Hi,

I am trying to upgrade my cmake 2.8 on CentOS.  I have tried unsuccessfully 
installing both versions 3.4.3 and 3.5.2  (i tried using both the .sh and 
.tar.gz).

After downloading and unzipping, in the root directory I see the following 
directories:

bin  doc  man  share

I tried doing a "make && make install"  or a "cmake ."  but i get the following 
error:

CMake Error: The source directory "/data/opt/cmake/cmake-3.4.3-Linux-x86_64" 
does not appear to contain CMakeLists.txt.


How should i go about upgrading my version of cmake?

Thanks In advance!
Thomas


-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [patch] iOS combined, some fixes

2016-06-21 Thread Ruslan Baratov via cmake-developers

Is the patch applied? Let me know if there are any questions left about it.

On 15-Jun-16 23:38, Ruslan Baratov via cmake-developers wrote:

On 15-Jun-16 22:59, Gregor Jasny wrote:

Hello,

Thanks for the patch!

On 15/06/16 16:41, Ruslan Baratov wrote:

Sending some fixes found by testing with Xcode 7.3

We were chasing some errors regarding the unified build some time ago.
But it appeared some for of heisenbug: the more I looked the less likely
it happened.

Is the error 100% reproducible for you?

Yes - for the Travis VM with xcode7.3 image. Not - for my local machine.


  And do you know what goes wrong?
Yes, I've leaved a note in the comments section. There are some 
messages in error stream, they are not related to lipo location. Here 
is example of the log with error:


CMake Error at

/Users/travis/build/ingenue/hunter/_ci/cmake/share/cmake-3.5/Modules/CMakeIOSInstallCombined.cmake:102
(message):
Command failed (File name too long): 2016-05-31 18:37:15.058
xcodebuild[6590:18239] Build settings from command line:
2016-05-31 18:37:15.059 xcodebuild[6590:18239] TOOLCHAINS =
com.apple.dt.toolchain.XcodeDefault
2016-05-31 18:37:15.059 xcodebuild[6590:18239]
XCODE_DEFAULT_TOOLCHAIN_OVERRIDE =

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo;-info;/Users/travis/build/ingenue/hunter/_testing/Hunter/_Base/7f9eaa4/f53c868/1c14a4b/Build/GTest/Build/GTest-Release-prefix/src/GTest-Release-build/googlemock/Release-iphonesimulator/libgmock.a



Does the

list(LENGTH _lipo_path len)
if(NOT len EQUAL 1)

take paths with spaces into account?
Nope as far as I know. In fact it doesn't catch the error I've seen, I 
decide to add some sanity checks just to be sure.


Ruslo




-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-21 Thread Gilles Khouzam via cmake-developers
I'll take a look to find an sdk that is included.



Sent from my Windows 10 phone



From: Brad King
Sent: Tuesday, June 21, 2016 7:31
To: Gilles Khouzam
Cc: cmake-developers@cmake.org
Subject: Re: Patch: Add the ability to specify SDK_REFERENCES for Visual Studio



On 06/20/2016 10:48 AM, Brad King wrote:
>  VS: Add VS_SDK_REFERENCES target property to reference external SDKs
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ccc6270d

This caused the VSWinStorePhone tests to fail, e.g.:

 https://open.cdash.org/testDetails.php?test=457508384=4422066
 (ResolveSDKReferences target) ->
  C:\Program Files 
(x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(2049,5): error 
MSB3774: Could not find SDK "Microsoft.NET.Native.Runtime.1.1, Version=1.1".

The problem is that the hard-coded VS_SDK_REFERENCES value in the
test names a SDK that does not exist on the test machine.  Some other
approach will be needed to know what SDK can be referenced by the test.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-21 Thread Brad King
On 06/20/2016 10:48 AM, Brad King wrote:
>  VS: Add VS_SDK_REFERENCES target property to reference external SDKs
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ccc6270d

This caused the VSWinStorePhone tests to fail, e.g.:

 https://open.cdash.org/testDetails.php?test=457508384=4422066
 (ResolveSDKReferences target) ->
  C:\Program Files 
(x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(2049,5): error 
MSB3774: Could not find SDK "Microsoft.NET.Native.Runtime.1.1, Version=1.1".

The problem is that the hard-coded VS_SDK_REFERENCES value in the
test names a SDK that does not exist on the test machine.  Some other
approach will be needed to know what SDK can be referenced by the test.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] CMake 32 and 64 bit packages on Windows

2016-06-21 Thread Nils Gladitz

On 06/21/2016 03:37 PM, Brad King wrote:


Nils, the installers in question were produced from your WiX
installer work (thanks again for that!).  Is this something wrong
with the 64-bit installer or simply a Windows/MSI subtlety/bug?




I can't try this out here right now but looking at the windows installer 
documentation[1] applications should be automatically notified about 
environment variable changes performed by the .msi by the 
WM_SETTINGCHANGE message.


I am not sure which processes listen and act on the message.

Nils

[1] 
https://msdn.microsoft.com/en-us/library/windows/desktop/aa372883(v=vs.85).aspx

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] How to set startup project in Visual Studio

2016-06-21 Thread Brad King
On 06/20/2016 05:11 PM, Stephen Kelly wrote:
> documentation which directory to set the DIRECTORY property on.

I've updated the documentation:

 Help: Clarify VS_STARTUP_PROJECT documentation
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d3e538ea

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] CMake 32 and 64 bit packages on Windows

2016-06-21 Thread Brad King
On 06/20/2016 05:10 PM, Stephen Kelly wrote:
> * Install the CMake 3.6 RC 64 bit package
> ** The install location for CMake 3.6 RC 64 bit was not added to my PATH?

I just un-installed my 64-bit RC and re-installed it with the option
to manipulate the system PATH.  At this point the PATH as reported in
the Windows system settings dialog contains the proper modification.
However, when I start a command prompt through a shortcut (e.g. in
the start menu) the prompt does not have the path.  If I instead do
Start -> Run -> `c:\Windows\system32\cmd.exe` then that prompt gets
the PATH with the modification.  I logged out and logged back in and
then everything gets the proper PATH.

Then I un-installed again and had to logout/login again to get the
PATH updated for programs launched through shortcuts.

> * Install the CMake 3.6 RC 32 bit package
> ** This added the correct directory to my PATH

I suspect the above may be a problem in Windows with interaction
between 64-bit configuration updates and a 32-bit explorer.exe
environment running the login session, but I'm not familiar enough
with this area of Windows to know.

Nils, the installers in question were produced from your WiX
installer work (thanks again for that!).  Is this something wrong
with the 64-bit installer or simply a Windows/MSI subtlety/bug?

Thanks,
-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

2016-06-21 Thread Brad King
On 06/21/2016 05:33 AM, Farbos a wrote:
> I am not sure to understand why you removed GLEW_LIBRARY:
> 
> -mark_as_advanced(GLEW_INCLUDE_DIR GLEW_LIBRARY)
> +mark_as_advanced(GLEW_INCLUDE_DIR)

We no longer define the GLEW_LIBRARY cache entry ourselves, only
read it for legacy reasons, so we are not responsible for marking
it advanced.

See discussion about the same thing in FindFreetype here:

 
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/16573/focus=16709

I've updated FindZLIB accordingly:

 FindZLIB: Do not mark unused variable as advanced
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4bb83514

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] speed up package with mingw on Windows host

2016-06-21 Thread Brad King
On 06/20/2016 05:05 PM, laurent wrote:
> Could you make the correction by yourself or do I need to re-send my
> patch with correct full name ?

Applied, thanks:

 GetPrerequisites: Optimize on Windows by filtering `objdump` output
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=867b73e2

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

2016-06-21 Thread Farbos a
I am not sure to understand why you removed GLEW_LIBRARY:

-mark_as_advanced(GLEW_INCLUDE_DIR GLEW_LIBRARY)
+mark_as_advanced(GLEW_INCLUDE_DIR)


2016-06-20 21:09 GMT+02:00 Brad King :
> On 06/20/2016 10:52 AM, Farbos a wrote:
>> Here is the patch fixed.
>
> Thanks, applied:
>
>  FindGLEW: Search for debug and release configurations separately
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6087b9e4
>
> -Brad
>



-- 
Arnaud FARBOS
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] How can we add Find****

2016-06-21 Thread Nils Gladitz

On 06/21/2016 10:57 AM, Farbos a wrote:

I was wondering how can we add new Find.cmake. For examples I
don't see any FindTBB, FindJsonCpp ... and I think some of them are
used a lot.

So my question is, Who decide if we can add new Find*** ?


See https://cmake.org/Wiki/CMake:Module_Maintainers

Nils
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers