Re: [cmake-developers] [PATCH 0/5] IMPORTED targets for some Find modules
On 06/20/2014 05:00 PM, Philipp Möller wrote: To simplify exporting targets I added IMPORTED targets to some of the Find modules. Thanks! I've applied the first three: FindZLIB: Add imported target and documentation http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5a7ff421 FindGLEW: Add imported target and documentation http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3d82a223 FindX11: fix documentation formatting error http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c90c7fca I will respond to the individual patch messages for the other two. Unfortunately targets behave differently than variables and can give different results when multiple find_package calls with different hints or options are made. That is not really supported anyway because we have only one CMakeCache.txt so there is only one FOO_LIBRARY variable. A project can achieve it with careful handling and typically by keeping the find_package calls in separate directories where imported targets are scoped apart anyway. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 0/5] IMPORTED targets for some Find modules
On 06/24/2014 08:32 AM, Brad King wrote: I will respond to the individual patch messages for the other two. Thanks for the revisions. I've applied them now as: FindGLUT.cmake: Add imported targets and documentation http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=144b255b FindBoost.cmake: Add Boost::boost and Boost::C targets and documentation http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=38da974d The transition to a modularized Boost will be tricky and hard to predict so I do not want it to hold back this support now. We can introduce a policy for compatibility later if needed. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] [PATCH 0/5] IMPORTED targets for some Find modules
To simplify exporting targets I added IMPORTED targets to some of the Find modules. Unfortunately targets behave differently than variables and can give different results when multiple find_package calls with different hints or options are made. There could be possible work-arounds (e.g. versioned namespaces), but I opted for the simplest solution and the use-case seems unusual to me. Philipp Möller (5): FindZLIB.cmake: Add imported target and documentation FindGLEW.cmake: Add imported target and documentation FindX11.cmake: fix documentation conversion error FindGLUT.cmake: Add imported targets and documentation FindBoost.cmake: Add Boost::boost and Boost::C targets and documentation Modules/FindBoost.cmake | 52 +- Modules/FindGLEW.cmake | 16 +++ Modules/FindGLUT.cmake | 58 +- Modules/FindX11.cmake | 75 - Modules/FindZLIB.cmake | 31 ++-- 5 files changed, 183 insertions(+), 49 deletions(-) -- 2.0.0 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
