[cmake-developers] [Review request] FindwxWidgets: Improve path detection logic when cross-compiling.
Simple logic update to check if we're cross-compiling to determine if unix or win32 path find style should be used. FindwxWidgets: Improve path detection logic when cross-compiling. Thanks, Richard -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [Review request] FindwxWidgets: Improve path detection logic when cross-compiling.
On 08/22/2014 12:39 PM, Richard Shaw wrote: Simple logic update to check if we're cross-compiling to determine if unix or win32 path find style should be used. FindwxWidgets: Improve path detection logic when cross-compiling. [snip] +else(WIN32 AND NOT CYGWIN AND NOT MSYS AND NOT CMAKE_CROSSCOMPILING) + set(wxWidgets_FIND_STYLE unix) +endif(WIN32 AND NOT CYGWIN AND NOT MSYS AND NOT CMAKE_CROSSCOMPILING) Please use empty else() and endif(). Otherwise, looks good. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [Review request] FindwxWidgets: Improve path detection logic when cross-compiling.
On Fri, Aug 22, 2014 at 12:08 PM, Brad King brad.k...@kitware.com wrote: On 08/22/2014 12:39 PM, Richard Shaw wrote: Simple logic update to check if we're cross-compiling to determine if unix or win32 path find style should be used. FindwxWidgets: Improve path detection logic when cross-compiling. [snip] +else(WIN32 AND NOT CYGWIN AND NOT MSYS AND NOT CMAKE_CROSSCOMPILING) + set(wxWidgets_FIND_STYLE unix) +endif(WIN32 AND NOT CYGWIN AND NOT MSYS AND NOT CMAKE_CROSSCOMPILING) Please use empty else() and endif(). Otherwise, looks good. Fixed: http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=33286235048495ceafb636d549d9a4e8891967ae Thanks, Richard -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [Review request] FindwxWidgets: Improve path detection logic when cross-compiling.
On 08/22/2014 01:23 PM, Richard Shaw wrote: Please use empty else() and endif(). Otherwise, looks good. Fixed: [snip] #= +# Determine whether unix or win32 paths should be used #= -if(WIN32 AND NOT CYGWIN AND NOT MSYS) +if(WIN32 AND NOT CYGWIN AND NOT MSYS AND NOT CMAKE_CROSSCOMPILING) set(wxWidgets_FIND_STYLE win32) else() - if(UNIX OR MSYS) -set(wxWidgets_FIND_STYLE unix) - endif() + set(wxWidgets_FIND_STYLE unix) endif() Good, thanks. Please merge for testing. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
