[cmake-developers] CMP0053 - Simplify variable reference and escape sequence evaluation - regression

2014-10-06 Thread Nils Gladitz

CMP0053 warns/fails on $ENV{ProgramFiles(x86)}.

Could () be added to the legal set of characters when within an $ENV{} 
expansion?


Nils
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] CMP0053 - Simplify variable reference and escape sequence evaluation - regression

2014-10-06 Thread Brad King
On 10/06/2014 06:39 AM, Nils Gladitz wrote:
 CMP0053 warns/fails on $ENV{ProgramFiles(x86)}.
 
 Could () be added to the legal set of characters when within an $ENV{} 
 expansion?

We considered that case and decided to ask users to use a
nested variable reference for that case.  There is a similar
workaround in Modules/Platform/WindowsPaths.cmake.

One reason is that adding more characters to the allowed set,
especially as a special case for $ENV{}, triggers extra tests
and branches inside a tight loop that is used everywhere.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] CMP0053 - Simplify variable reference and escape sequence evaluation - regression

2014-10-06 Thread Nils Gladitz

On 10/06/2014 02:48 PM, Brad King wrote:

On 10/06/2014 06:39 AM, Nils Gladitz wrote:

CMP0053 warns/fails on $ENV{ProgramFiles(x86)}.

Could () be added to the legal set of characters when within an $ENV{}
expansion?


We considered that case and decided to ask users to use a
nested variable reference for that case.  There is a similar
workaround in Modules/Platform/WindowsPaths.cmake.

One reason is that adding more characters to the allowed set,
especially as a special case for $ENV{}, triggers extra tests
and branches inside a tight loop that is used everywhere.


All right, no problem; I'll work around it.

Thanks!

Nils

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers