Re: [cmake-developers] Review Request for ExternalProjects: Only update certain git submodules
Hi, Any success with this patch? I was hoping to get this done soon :-) Cheers, Gereon On 01/15/2014 04:21 PM, Jean-Christophe Fillion-Robin wrote: Hi Folks, That would be a great contribution. I will give a try to the patch by the beginning of next week. This is something that would be useful for CTK [1]. Thanks for working on this, Jc [1] http://www.commontk.org On Wed, Jan 15, 2014 at 10:03 AM, Brad King brad.k...@kitware.com mailto:brad.k...@kitware.com wrote: On 01/10/2014 08:58 AM, David Cole wrote: Not that I'm a skeptic (well, ok, maybe a smidge...) but I would like to have *independent* confirmation from somebody else that it at least works for them before we merge this into CMake. The silence in this thread indicates no one is planning to step forward for this. David, if the implementation looks correct, the smoke test case works, and no existing test cases regress then I think this is ready. Please shepherd this topic through 'next'. Thanks, -Brad -- Powered by www.kitware.com http://www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- +1 919 869 8849 -- Gereon Kremer Lehr- und Forschungsgebiet Theorie Hybrider Systeme RWTH Aachen Tel: +49 241 80 21242 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review Request for ExternalProjects: Only update certain git submodules
On 01/28/2014 11:55 AM, Gereon Kremer wrote: Any success with this patch? I think others have had long enough to provide pre-integration feedback. I was hoping to get this done soon :-) I've put the changes in 'next' for testing: ExternalProject: Add option GIT_SUBMODULES http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=819015ef Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review Request for ExternalProjects: Only update certain git submodules
On 01/10/2014 08:58 AM, David Cole wrote: Not that I'm a skeptic (well, ok, maybe a smidge...) but I would like to have *independent* confirmation from somebody else that it at least works for them before we merge this into CMake. The silence in this thread indicates no one is planning to step forward for this. David, if the implementation looks correct, the smoke test case works, and no existing test cases regress then I think this is ready. Please shepherd this topic through 'next'. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review Request for ExternalProjects: Only update certain git submodules
Hi Folks, That would be a great contribution. I will give a try to the patch by the beginning of next week. This is something that would be useful for CTK [1]. Thanks for working on this, Jc [1] http://www.commontk.org On Wed, Jan 15, 2014 at 10:03 AM, Brad King brad.k...@kitware.com wrote: On 01/10/2014 08:58 AM, David Cole wrote: Not that I'm a skeptic (well, ok, maybe a smidge...) but I would like to have *independent* confirmation from somebody else that it at least works for them before we merge this into CMake. The silence in this thread indicates no one is planning to step forward for this. David, if the implementation looks correct, the smoke test case works, and no existing test cases regress then I think this is ready. Please shepherd this topic through 'next'. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- +1 919 869 8849 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review Request for ExternalProjects: Only update certain git submodules
Hi,
Attached is a patch for the ExternalProject test that simply passes an
empty list.
I'd like to pass further testing, i.e. checking against a submodule
being another local git, to someone who is more familiar with this
testing setup...
We have an external project with many submodules (- boost...) and
confirm that only the submodules given in the option are cloned and updated.
However I guess, you want a confirmation from somebody else... :-)
Cheers,
Gereon
On 01/09/2014 08:31 PM, David Cole wrote:
This looks like a reasonable patch to me (just by eye, have not tried
it personally). *Although* it would be even better if there were an
additional case added in the ExternalProject test that handles passing
in (1) an empty git submodule list, and (2) a valid list. Although,
unless you add code to the setup of the test git repo for that test,
it won't have any submodules in it. And we don't want to introduce any
network dependencies to the test suite, so no referencing a real live
git repo on the internet.
I'd like to see a follow up patch to this one that adds *some*
testing, too, even if just of the empty list smoke test variety...
Does anybody listening here have a project with some git submodules,
and some time to give this a test drive? If so, please do, and let us
know the results. If they're positive, we could take the follow up to
this patch and get it into CMake 'next'.
Thanks,
David C.
--
Gereon Kremer
Lehr- und Forschungsgebiet Theorie Hybrider Systeme
RWTH Aachen
Tel: +49 241 80 21242
From 1e0a213d4dc1876939d5fc210772e75a1e732040 Mon Sep 17 00:00:00 2001
From: Gereon Kremer gereon.kre...@cs.rwth-aachen.de
Date: Fri, 10 Jan 2014 10:04:31 +0100
Subject: [PATCH] Added a simple testcase for GIT_SUBMODULES option passing an
empty list.
---
Tests/ExternalProject/CMakeLists.txt | 16
1 file changed, 16 insertions(+)
diff --git a/Tests/ExternalProject/CMakeLists.txt b/Tests/ExternalProject/CMakeLists.txt
index 602ff0f..d9344ec 100644
--- a/Tests/ExternalProject/CMakeLists.txt
+++ b/Tests/ExternalProject/CMakeLists.txt
@@ -512,6 +512,22 @@ if(do_git_tests)
LOG_UPDATE 1
)
set_property(TARGET ${proj} PROPERTY FOLDER GIT)
+
+ # git by explicit branch/tag with empty submodule list
+ #
+ set(proj TutorialStep1-GIT-bytag-withsubmodules)
+ ExternalProject_Add(${proj}
+GIT_REPOSITORY ${local_git_repo}
+GIT_TAG origin/master
+GIT_SUBMODULES
+UPDATE_COMMAND
+CMAKE_GENERATOR ${CMAKE_GENERATOR}
+CMAKE_ARGS -DCMAKE_INSTALL_PREFIX:PATH=INSTALL_DIR
+INSTALL_COMMAND
+DEPENDS SetupLocalGITRepository
+ )
+ set_property(TARGET ${proj} PROPERTY FOLDER GIT)
+
endif()
set(do_hg_tests 0)
--
1.8.5.2
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review Request for ExternalProjects: Only update certain git submodules
Attached is a patch for the ExternalProject test that simply passes an empty list. Thanks, that's completely reasonable for a first-time contributor to CMake. I understand it's not easy to jump right in and understand how all the tests operate... I'd like to pass further testing, i.e. checking against a submodule being another local git, to someone who is more familiar with this testing setup... Also completely reasonable. I wouldn't hold up getting it into CMake for this, but if anybody else has time to work on a test with git submodules, but no network requirements, that would be most welcome. We have an external project with many submodules (- boost...) and confirm that only the submodules given in the option are cloned and updated. However I guess, you want a confirmation from somebody else... :-) Not that I'm a skeptic (well, ok, maybe a smidge...) but I would like to have *independent* confirmation from somebody else that it at least works for them before we merge this into CMake. Thanks, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review Request for ExternalProjects: Only update certain git submodules
This looks like a reasonable patch to me (just by eye, have not tried it personally). *Although* it would be even better if there were an additional case added in the ExternalProject test that handles passing in (1) an empty git submodule list, and (2) a valid list. Although, unless you add code to the setup of the test git repo for that test, it won't have any submodules in it. And we don't want to introduce any network dependencies to the test suite, so no referencing a real live git repo on the internet. I'd like to see a follow up patch to this one that adds *some* testing, too, even if just of the empty list smoke test variety... Does anybody listening here have a project with some git submodules, and some time to give this a test drive? If so, please do, and let us know the results. If they're positive, we could take the follow up to this patch and get it into CMake 'next'. Thanks, David C. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
