Re: [cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS
Peter Collingbourne wrote: On Sun, May 13, 2012 at 11:59:20PM +0200, Stephen Kelly wrote: Stephen Kelly wrote: Furthermore, there is no need to make paths within the build directory absolute. Each command must be invoked from the home output directory (i.e. the build root directory), so each command's directory attribute should be set to that directory, rather than the start output directory as in your patch. Fixed now, If I understood you correctly. I've pushed this to the CMake stage repo now. Peter, could you verify that I should always use the same directory for the directory JSON property as I do in the patch? Yes, this looks fine now. Great, thanks. I've merged it to next. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS
On Sun, May 13, 2012 at 11:59:20PM +0200, Stephen Kelly wrote: Stephen Kelly wrote: Furthermore, there is no need to make paths within the build directory absolute. Each command must be invoked from the home output directory (i.e. the build root directory), so each command's directory attribute should be set to that directory, rather than the start output directory as in your patch. Fixed now, If I understood you correctly. I've pushed this to the CMake stage repo now. Peter, could you verify that I should always use the same directory for the directory JSON property as I do in the patch? Yes, this looks fine now. Thanks, -- Peter -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS
Oops. Please remove that branch from stage. I was keeping it off there to get some initial feedback first. I can push it to stage later (I can commit to cmake too :) ). OK deleted. I've force pushed the branch to my own repo again. In particular I was wondering about the first patch 'Make the Ninja generator generate includes with full paths'. This was because of a unit test on Windows. But as Peter C. said the wrong way. I wonder if anybody care about ninja on Windows? It's useless without the dependency tracking. Is there a reason it hasn't used the full path up to now? A reason not to change it like this? But when I run the unit test under linux, 'ctest -R CompileCommandOutput' it fails. Should it work with most recent ninja? It was generating invalid JSON before, but I've fixed that now. Thanks, Steve. -- Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS
Peter Kuemmel wrote: Hi, I've pushed a new branch to my clone for review to make the CMAKE_EXPORT_COMPILE_COMMANDS option work with the Ninja generator. https://gitorious.org/~steveire/cmake/steveires-cmake Thanks, Steve. I've rebased 'Ninja-EXPORT_COMPILE_COMMANDS' on origin/master and pushed the branch to stage: http://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/Ninja- EXPORT_COMPILE_COMMANDS Oops. Please remove that branch from stage. I was keeping it off there to get some initial feedback first. I can push it to stage later (I can commit to cmake too :) ). I've force pushed the branch to my own repo again. In particular I was wondering about the first patch 'Make the Ninja generator generate includes with full paths'. Is there a reason it hasn't used the full path up to now? A reason not to change it like this? But when I run the unit test under linux, 'ctest -R CompileCommandOutput' it fails. Should it work with most recent ninja? It was generating invalid JSON before, but I've fixed that now. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Review request: Ninja-EXPORT_COMPILE_COMMANDS
Hi, I've pushed a new branch to my clone for review to make the CMAKE_EXPORT_COMPILE_COMMANDS option work with the Ninja generator. https://gitorious.org/~steveire/cmake/steveires-cmake Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
