[cmake-developers] ninja support

2013-07-16 Thread clinton
Is there someone that can offer some ninja support? There is a regression from 
a while back exposed by a commit of mine yesterday. 
http://open.cdash.org/testDetails.php?test=199232514build=2967911 

With the framework refactor work, the soname for frameworks were fixed. As a 
result, code in the makefile generator to create symlinks was triggered. 
In the generator, it was suppressed in the case of frameworks because 
cmOSXBundleGenerator takes care of making the symlinks. 

But for the ninja generator, I just realized it isn't suppressed. And my 
attempt to fix that leads to a broken ninja file. 

Thanks, 
Clint 
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] ninja support

2013-07-16 Thread clinton
- Original Message -

 Is there someone that can offer some ninja support? There is a regression
 from a while back exposed by a commit of mine yesterday.
 http://open.cdash.org/testDetails.php?test=199232514build=2967911

 With the framework refactor work, the soname for frameworks were fixed. As a
 result, code in the makefile generator to create symlinks was triggered.
 In the generator, it was suppressed in the case of frameworks because
 cmOSXBundleGenerator takes care of making the symlinks.

 But for the ninja generator, I just realized it isn't suppressed. And my
 attempt to fix that leads to a broken ninja file.

 Thanks,
 Clint

Never mind... I've got it figured out. The ninja generator needs changed to not 
try to create symlinks and not use the framework symlink. So, the build.ninja 
files look the same as before. 
http://cmake.org/gitweb?p=cmake.git;a=commit;h=90993b 

Clint 
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers