Re: [cmake-developers] ninja test failing again...
On 09/04/2012 07:46 PM, Peter Kümmel wrote: Any optimization that skips dependency checks should be done only for the first form, and never for the second form. This distinction should cover the BuildDepends test case too. http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=34b0cf6a3823e0d54958a0f337308b4c35342cc3 Is this better? Yes, thanks. Please revert the other topic and merge this one instead. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] ninja test failing again...
On 05.09.2012 13:31, Brad King wrote: On 09/04/2012 07:46 PM, Peter Kümmel wrote: Any optimization that skips dependency checks should be done only for the first form, and never for the second form. This distinction should cover the BuildDepends test case too. http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=34b0cf6a3823e0d54958a0f337308b4c35342cc3 Is this better? Yes, thanks. Please revert the other topic and merge this one instead. OK, I merged this: http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=7b2bf28e183b5eacc22fe3030f0439853746f0bd -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] ninja test failing again...
The BuildDepends test has been failing for some time now: http://open.cdash.org/viewUpdate.php?buildid=2522326 It seems to be from this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4a35bd0e69e5cfaf7ca9604c90b609d1d333bb37 Here is the first failure: http://open.cdash.org/testDetails.php?test=156781454build=2522326 Any ideas? Maybe cmcldeps is not working for some reason? -Bill -- Bill Hoffman Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 bill.hoff...@kitware.com http://www.kitware.com 518 881-4905 (Direct) 518 371-3971 x105 Fax (518) 371-4573 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] ninja test failing again...
On 09/04/2012 02:16 PM, Peter Kümmel wrote: On 04.09.2012 18:56, Bill Hoffman wrote: The BuildDepends test has been failing for some time now: http://open.cdash.org/viewUpdate.php?buildid=2522326 It seems to be from this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4a35bd0e69e5cfaf7ca9604c90b609d1d333bb37 Here is the first failure: http://open.cdash.org/testDetails.php?test=156781454build=2522326 Any ideas? Maybe cmcldeps is not working for some reason? -Bill fixed it shortly before your email ;) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9b8b4c11d8e7807c0b8e6d9bea490f20f3ad0367 The try_compile command has two signature forms. One is meant to build a single source file in an auto-generated project in a discard-able temp dir. The other is meant to build a given source tree in a given build tree and keep the results around. Any optimization that skips dependency checks should be done only for the first form, and never for the second form. This distinction should cover the BuildDepends test case too. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] ninja test failing again...
On 04.09.2012 21:56, Brad King wrote: On 09/04/2012 02:16 PM, Peter Kümmel wrote: On 04.09.2012 18:56, Bill Hoffman wrote: The BuildDepends test has been failing for some time now: http://open.cdash.org/viewUpdate.php?buildid=2522326 It seems to be from this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4a35bd0e69e5cfaf7ca9604c90b609d1d333bb37 Here is the first failure: http://open.cdash.org/testDetails.php?test=156781454build=2522326 Any ideas? Maybe cmcldeps is not working for some reason? -Bill fixed it shortly before your email ;) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9b8b4c11d8e7807c0b8e6d9bea490f20f3ad0367 The try_compile command has two signature forms. One is meant to build a single source file in an auto-generated project in a discard-able temp dir. The other is meant to build a given source tree in a given build tree and keep the results around. Any optimization that skips dependency checks should be done only for the first form, and never for the second form. This distinction should cover the BuildDepends test case too. -Brad http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=34b0cf6a3823e0d54958a0f337308b4c35342cc3 Is this better? Peter -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
