Re: [cmake-developers] suggestion: rename FindXerces to FindXercesC
On Fri, Dec 05, 2014 at 09:04:19AM -0500, Brad King wrote: > On 12/04/2014 05:54 PM, Roger Leigh wrote: > > No. Either is fine with me; I didn't expect this to be problematic > > to omit the C suffix, but happy to have it added if it will avoid > > confusion. > > > > I just saw your other mail saying you'd made a patch. Do you need me > > to do anything else? > > Please just test the renamed module to verify it still works for your > original use case (besides the name change). With Erik's confirmation > I will merge this for the next 3.1 release candidate anyway, but more > testing is better ;) I've tested it and it's all working fine, so good to merge from me! -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] suggestion: rename FindXerces to FindXercesC
On 12/04/2014 05:54 PM, Roger Leigh wrote: > No. Either is fine with me; I didn't expect this to be problematic > to omit the C suffix, but happy to have it added if it will avoid > confusion. > > I just saw your other mail saying you'd made a patch. Do you need me > to do anything else? Please just test the renamed module to verify it still works for your original use case (besides the name change). With Erik's confirmation I will merge this for the next 3.1 release candidate anyway, but more testing is better ;) Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] suggestion: rename FindXerces to FindXercesC
The patch worked for me. cheers, Erik Sjölund On Thu, Dec 4, 2014 at 4:52 PM, Brad King wrote: > On 12/04/2014 10:32 AM, Brad King wrote: >> Roger, as the contributor of this module do you have any reason >> not to change the name? > > I've constructed a commit to perform the rename and merged to 'next' > for testing: > > Modules: Rename FindXerces to FindXercesC > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=27141eed > > Please let me know if it works. I'd like to get feedback before > merging to 'master' or 'release'. > > Thanks, > -Brad > -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] suggestion: rename FindXerces to FindXercesC
On Thu, Dec 04, 2014 at 10:32:53AM -0500, Brad King wrote: > On 12/04/2014 10:09 AM, Erik Sjölund wrote: > > I think it is a good idea to rename FindXerces to FindXercesC or > > something similar, just to indicate that is about the C++ > > implementation. > > Thanks for pointing out the distinct implementations. The module > is new in CMake 3.1 so our last chance to rename it now before the > final release of that version. Actually it looks like we're missing > a release note for it too. > > The documentation of the module starts off with: > > "Find the Apache Xerces-C++ validating XML parser..." > > which is pretty clear, though that is not visible at the call > sites of find_package(Xerces). > > Roger, as the contributor of this module do you have any reason > not to change the name? No. Either is fine with me; I didn't expect this to be problematic to omit the C suffix, but happy to have it added if it will avoid confusion. I just saw your other mail saying you'd made a patch. Do you need me to do anything else? Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] suggestion: rename FindXerces to FindXercesC
On 12/04/2014 10:32 AM, Brad King wrote: > Roger, as the contributor of this module do you have any reason > not to change the name? I've constructed a commit to perform the rename and merged to 'next' for testing: Modules: Rename FindXerces to FindXercesC http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=27141eed Please let me know if it works. I'd like to get feedback before merging to 'master' or 'release'. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] suggestion: rename FindXerces to FindXercesC
On 12/04/2014 10:09 AM, Erik Sjölund wrote: > I think it is a good idea to rename FindXerces to FindXercesC or > something similar, just to indicate that is about the C++ > implementation. Thanks for pointing out the distinct implementations. The module is new in CMake 3.1 so our last chance to rename it now before the final release of that version. Actually it looks like we're missing a release note for it too. The documentation of the module starts off with: "Find the Apache Xerces-C++ validating XML parser..." which is pretty clear, though that is not visible at the call sites of find_package(Xerces). Roger, as the contributor of this module do you have any reason not to change the name? Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] suggestion: rename FindXerces to FindXercesC
As there are two implementations of Xerces, one in C++ http://xerces.apache.org/xerces-c/ and one in Java http://xerces.apache.org/xerces-j/ I think it is a good idea to rename FindXerces to FindXercesC or something similar, just to indicate that is about the C++ implementation. cheers, Erik Sjölund -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
