Re: [cmake-developers] [PATCH] UsePkgConfig: improve documentation

2011-09-29 Thread Rolf Eike Beer
 On Thursday, September 22, 2011 03:00:33 PM Rolf Eike Beer wrote:

 Indeed, I did not have the extra typo in it. Another chance for me to send
 a patch ;)

Ping? Not that someone is going to release 2.8.6 with this typo in it.

Eike
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] UsePkgConfig: improve documentation

2011-09-29 Thread Alexander Neundorf
On Tuesday 27 September 2011, Rolf Eike Beer wrote:
  On Thursday, September 22, 2011 03:00:33 PM Rolf Eike Beer wrote:
   On Thursday, September 22, 2011 01:52:51 PM Rolf Eike Beer wrote:
   From 3f500a5c655cc4c12ecf6f774602b2a10cae0365 Mon Sep 17 00:00:00
  
  2001
  
   From: Rolf Eike Beer e...@sf-mail.de
   Date: Thu, 22 Sep 2011 13:48:15 +0200
   
   Tell the people in the documentation which module to use instead.
   
   Thanks, merged into next (the MinorPkgConfigDocImprovement branch)
  
  Well, wrong. You took the patch and committed the changes, so once again
  
  Nitpicking: what I committed were actually not exactly your changes, but
  fixes
  inspired by your patch ;-)
 
 Indeed, I did not have the extra typo in it. Another chance for me to send
 a patch ;)

Ok, committed.

Alex
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] UsePkgConfig: improve documentation

2011-09-29 Thread David Cole
On Thu, Sep 29, 2011 at 1:45 PM, Alexander Neundorf neund...@kde.org wrote:
 On Tuesday 27 September 2011, Rolf Eike Beer wrote:
  On Thursday, September 22, 2011 03:00:33 PM Rolf Eike Beer wrote:
   On Thursday, September 22, 2011 01:52:51 PM Rolf Eike Beer wrote:
   From 3f500a5c655cc4c12ecf6f774602b2a10cae0365 Mon Sep 17 00:00:00
 
  2001
 
   From: Rolf Eike Beer e...@sf-mail.de
   Date: Thu, 22 Sep 2011 13:48:15 +0200
  
   Tell the people in the documentation which module to use instead.
  
   Thanks, merged into next (the MinorPkgConfigDocImprovement branch)
 
  Well, wrong. You took the patch and committed the changes, so once again
 
  Nitpicking: what I committed were actually not exactly your changes, but
  fixes
  inspired by your patch ;-)

 Indeed, I did not have the extra typo in it. Another chance for me to send
 a patch ;)

 Ok, committed.

 Alex
 --

 Powered by www.kitware.com

 Visit other Kitware open-source projects at 
 http://www.kitware.com/opensource/opensource.html

 Please keep messages on-topic and check the CMake FAQ at: 
 http://www.cmake.org/Wiki/CMake_FAQ

 Follow this link to subscribe/unsubscribe:
 http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Thanks, Alex. We'll get this merged in...
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] UsePkgConfig: improve documentation

2011-09-27 Thread Rolf Eike Beer
 On Thursday, September 22, 2011 03:00:33 PM Rolf Eike Beer wrote:
  On Thursday, September 22, 2011 01:52:51 PM Rolf Eike Beer wrote:
  From 3f500a5c655cc4c12ecf6f774602b2a10cae0365 Mon Sep 17 00:00:00
 2001
  From: Rolf Eike Beer e...@sf-mail.de
  Date: Thu, 22 Sep 2011 13:48:15 +0200
 
  Tell the people in the documentation which module to use instead.
 
  Thanks, merged into next (the MinorPkgConfigDocImprovement branch)

 Well, wrong. You took the patch and committed the changes, so once again

 Nitpicking: what I committed were actually not exactly your changes, but
 fixes
 inspired by your patch ;-)

Indeed, I did not have the extra typo in it. Another chance for me to send
a patch ;)

From 25147c08a1843e315c0ed52a0b8fe40e7ee2b250 Mon Sep 17 00:00:00 2001
From: Rolf Eike Beer e...@sf-mail.de
Date: Tue, 27 Sep 2011 09:54:38 +0200
Subject: [PATCH] Fix typo in UsePkgConfig.cmake

---
 Modules/UsePkgConfig.cmake |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Modules/UsePkgConfig.cmake b/Modules/UsePkgConfig.cmake
index 3db9e43..7f4318f 100644
--- a/Modules/UsePkgConfig.cmake
+++ b/Modules/UsePkgConfig.cmake
@@ -1,4 +1,4 @@
-# - Osolete pkg-config module for CMake, use FindPkgConfig instead.
+# - Obsolete pkg-config module for CMake, use FindPkgConfig instead.
 #
 # This module defines the following macro:
 #
-- 
1.7.6.3

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] UsePkgConfig: improve documentation

2011-09-22 Thread Rolf Eike Beer
 On Thursday, September 22, 2011 01:52:51 PM Rolf Eike Beer wrote:
 From 3f500a5c655cc4c12ecf6f774602b2a10cae0365 Mon Sep 17 00:00:00 2001
 From: Rolf Eike Beer e...@sf-mail.de
 Date: Thu, 22 Sep 2011 13:48:15 +0200

 Tell the people in the documentation which module to use instead.

 Thanks, merged into next (the MinorPkgConfigDocImprovement branch)

Well, wrong. You took the patch and committed the changes, so once again
the information who wrote this was lost. And your Alex line at the
bottom isn't really needed at all as both the author (what should have
been me) and the commiter (you) are visible in history at any time.

You should have saved my email to disk, and then from the CMake git tree do:

git am patch-from-eike.mbox

This would have done things right (tm).

Greetings,

Eike
___
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] [PATCH] UsePkgConfig: improve documentation

2011-09-22 Thread Alexander Neundorf
On Thursday, September 22, 2011 03:00:33 PM Rolf Eike Beer wrote:
  On Thursday, September 22, 2011 01:52:51 PM Rolf Eike Beer wrote:
  From 3f500a5c655cc4c12ecf6f774602b2a10cae0365 Mon Sep 17 00:00:00 2001
  From: Rolf Eike Beer e...@sf-mail.de
  Date: Thu, 22 Sep 2011 13:48:15 +0200
  
  Tell the people in the documentation which module to use instead.
  
  Thanks, merged into next (the MinorPkgConfigDocImprovement branch)
 
 Well, wrong. You took the patch and committed the changes, so once again

Nitpicking: what I committed were actually not exactly your changes, but fixes 
inspired by your patch ;-)

Alex
___
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers