Re: [cmake-developers] [RESEND] [PATCH] x32-abi support #15994 (without line wrapping!)
On 02/28/2017 03:38 PM, Rolf Eike Beer wrote: >> +/usr/local/libx32 >> /usr/local/lib64 >> /usr/local/lib >> +/usr/libx32 >> /usr/lib64 >> /usr/lib >> /usr/X11R6/include > And so on… > > Shouldn't we think of providing some sort of variable that holds those > things? Actually with the auto lib -> lib conversion that find_library does most of these lists aren't even needed. Some of the lists can be removed instead of extended. Such discussion is better held in the MR [1] though. -Brad [1] https://gitlab.kitware.com/cmake/cmake/merge_requests/532 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [RESEND] [PATCH] x32-abi support #15994 (without line wrapping!)
> + PATH_SUFFIXES libx32 lib64 lib lib32
> + PATH_SUFFIXES lib64 libx32)
> +/usr/local/libx32
> /usr/local/lib64
> /usr/local/lib
> +/usr/libx32
> /usr/lib64
> /usr/lib
> /usr/X11R6/include
> + list(APPEND ice_library_suffixes "libx32" "${_lib64}" "lib${_x64}" "lib")
And so on…
Shouldn't we think of providing some sort of variable that holds those things?
Maybe one that even knows what kind of distro is used (I remember there is
some sort of lib64 special casing for Debian), so the chance of a direct hit
is bigger?
Yes, there will always be modules that need to override this (e.g. for
Windows), but it could make things a lot easier for the "normal case".
Something like GNUInstallDirs backwards or so.
Eike
--
signature.asc
Description: This is a digitally signed message part.
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [RESEND] [PATCH] x32-abi support #15994 (without line wrapping!)
On 02/27/2017 08:50 AM, Steven Newbury wrote: >> we now use gitlab.kitware.com merge requests. > > Right, I'll do that. For reference, the MR is [1]. Thanks, -Brad [1] https://gitlab.kitware.com/cmake/cmake/merge_requests/532 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [RESEND] [PATCH] x32-abi support #15994 (without line wrapping!)
On Mon, 2017-02-27 at 08:36 -0500, Brad King wrote: > On 02/26/2017 08:30 PM, Steven Newbury wrote: > > This is based on the patch attached to the > > original Manits bug: > > https://cmake.org/Bug/view.php?id=15994#c40584 > > > > I have cleaned up all the hard coded paths so > > hopefully it has now no effect on non-x32 systems. > > > > It probably needs tests to be updated to support > > x32 where appropriate. > > Thanks! > > Since the related LIB_SUFFIX thread was started our preferred > path for contributions has changed. Instead of posting patches > on the mailing list, we now use gitlab.kitware.com merge requests. > Please see `CONTRIBUTING.rst` for details. > > Thanks, > -Brad Right, I'll do that. signature.asc Description: This is a digitally signed message part -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [RESEND] [PATCH] x32-abi support #15994 (without line wrapping!)
On 02/26/2017 08:30 PM, Steven Newbury wrote: > This is based on the patch attached to the > original Manits bug: > https://cmake.org/Bug/view.php?id=15994#c40584 > > I have cleaned up all the hard coded paths so > hopefully it has now no effect on non-x32 systems. > > It probably needs tests to be updated to support > x32 where appropriate. Thanks! Since the related LIB_SUFFIX thread was started our preferred path for contributions has changed. Instead of posting patches on the mailing list, we now use gitlab.kitware.com merge requests. Please see `CONTRIBUTING.rst` for details. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
