RE: SQLTransformer bug
Thanks Brian! David -Mensaje original- De: Brian Johnson [mailto:[EMAIL PROTECTED] Enviado el: jueves, 29 de mayo de 2003 22:30 Para: [EMAIL PROTECTED] Asunto: Re: SQLTransformer bug I reported this bug and posted a fix many months ago, but nothing has been done with it. It seems to only affect certain databases. I'd be glad to forward you the code. Brian On Wednesday, May 28, 2003, at 09:36 AM, Carmona Perez, David wrote: > Dear Cocooners, > > I've think I found a bug in the SQLTransformer in Cocoon 2.0.4, at > least under Informix. > > I use a simple query (select * from table) and it fails. After having > investigated a bit, I've come to the conclusion that it tries to do > the following > > open connection > create prepared statement > get resultset > close connection > navigate through the gathered resultset > > Of course when navigating through the resultset, you get an > SQLException. > If I comment out the connection closing, everything works ok. > > The right order would need to be: > > open connection > create prepared statement > get resultset > navigate through the gathered resultset > close connection > > > Has this happened to anyone else? > > > David > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: SQLTransformer bug
According to bugzilla, It looks like the patch was applied back in January, but I don't see that anything has changed. Am I missing something? On Thursday, May 29, 2003, at 04:52 PM, Andreas Kuckartz wrote: That seems to be this one: [PATCH] SQLTransformer Query object prematurely closes connection causing NullPointerException when accessing ResultSet http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12173 Andreas - Original Message - From: "Brian Johnson" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, May 29, 2003 10:30 PM Subject: Re: SQLTransformer bug I reported this bug and posted a fix many months ago, but nothing has been done with it. It seems to only affect certain databases. I'd be glad to forward you the code. Brian On Wednesday, May 28, 2003, at 09:36 AM, Carmona Perez, David wrote: Dear Cocooners, I've think I found a bug in the SQLTransformer in Cocoon 2.0.4, at least under Informix. I use a simple query (select * from table) and it fails. After having investigated a bit, I've come to the conclusion that it tries to do the following open connection create prepared statement get resultset close connection navigate through the gathered resultset Of course when navigating through the resultset, you get an SQLException. If I comment out the connection closing, everything works ok. The right order would need to be: open connection create prepared statement get resultset navigate through the gathered resultset close connection Has this happened to anyone else? David - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: SQLTransformer bug
That seems to be this one: [PATCH] SQLTransformer Query object prematurely closes connection causing NullPointerException when accessing ResultSet http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12173 Andreas - Original Message - From: "Brian Johnson" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, May 29, 2003 10:30 PM Subject: Re: SQLTransformer bug > I reported this bug and posted a fix many months ago, but nothing has > been done with it. It seems to only affect certain databases. I'd be > glad to forward you the code. > Brian > > On Wednesday, May 28, 2003, at 09:36 AM, Carmona Perez, David wrote: > > > Dear Cocooners, > > > > I've think I found a bug in the SQLTransformer in Cocoon 2.0.4, at > > least under Informix. > > > > I use a simple query (select * from table) and it fails. After having > > investigated a bit, I've come to the conclusion that it tries to do > > the following > > > > open connection > > create prepared statement > > get resultset > > close connection > > navigate through the gathered resultset > > > > Of course when navigating through the resultset, you get an > > SQLException. > > If I comment out the connection closing, everything works ok. > > > > The right order would need to be: > > > > open connection > > create prepared statement > > get resultset > > navigate through the gathered resultset > > close connection > > > > > > Has this happened to anyone else? > > > > > > David > > > > > > - > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: SQLTransformer bug
I reported this bug and posted a fix many months ago, but nothing has been done with it. It seems to only affect certain databases. I'd be glad to forward you the code. Brian On Wednesday, May 28, 2003, at 09:36 AM, Carmona Perez, David wrote: Dear Cocooners, I've think I found a bug in the SQLTransformer in Cocoon 2.0.4, at least under Informix. I use a simple query (select * from table) and it fails. After having investigated a bit, I've come to the conclusion that it tries to do the following open connection create prepared statement get resultset close connection navigate through the gathered resultset Of course when navigating through the resultset, you get an SQLException. If I comment out the connection closing, everything works ok. The right order would need to be: open connection create prepared statement get resultset navigate through the gathered resultset close connection Has this happened to anyone else? David - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: SQLTransformer bug that appears under load
A Dangerous fix. But if I had to speculate: I imagine conn.close() is
synchronized. Secondly, I imagine its logged. Cause this to be a
warning (not be logged) and there should be a performance increase..
Cause conn.close() to not be synchronized (haven't looked...just a
guess) and there should be a performance increase. close() probably
doesn't need to be synchronized necessarily. (again, just guesses).
-Andy
On Mon, 2002-04-08 at 03:38, neil wrote:
> I've been load testing my cocoon app with jmeter and I think I've found a
> SQLTransformer bug.
> My (MS SQL Server) JDBC driver was complaining about attempts to use various
> objects after they had been closed (Connections, ResultSets and Statements).
>
> In Query.execute() I think this bit should be removed:
> } finally {
> conn.close();
> conn = null;// To make sure we don't use this
> connection again.
> }
>
> as it's incorrect to close the connection before you've finished with the
> ResultSets, Statements etc.
> The connection is closed later when SQLTransformer.executeQuery() calls
> Query.close() anyway.
>
> I know Connection.close() doesn't really close the connection to the DB
> (because its a pooled connection it just allows it to be recycled), but I
> think its reuse under load does cause problems. By removing these lines I
> was able to get my app to work correctly under heavy loads on a dual CPU
> Windows 2000 box.
>
>
> -
> Please check that your question has not already been answered in the
> FAQ before posting.
>
> To unsubscribe, e-mail: <[EMAIL PROTECTED]>
> For additional commands, e-mail: <[EMAIL PROTECTED]>
>
--
http://www.superlinksoftware.com
http://jakarta.apache.org/poi - port of Excel/Word/OLE 2 Compound
Document
format to java
http://developer.java.sun.com/developer/bugParade/bugs/4487555.html
- fix java generics!
The avalanche has already started. It is too late for the pebbles to
vote.
-Ambassador Kosh
-
Please check that your question has not already been answered in the
FAQ before posting.
To unsubscribe, e-mail: <[EMAIL PROTECTED]>
For additional commands, e-mail: <[EMAIL PROTECTED]>
