[codenameone-discussions] Re: Study On Rejected Refactorings

2020-08-11 Thread Shai Almog
Hi,
as far as I recall there weren't many (or even any) refactoring PRs.
I think I recall one and it was a pain because so much of our API is stable 
and public. As such backward compatibility is key and refactoring makes 
this pretty hard to keep. 

Also due to the breadth and depth of the project it's pretty hard to do 
wide sweeping changes as a third party contributor.

On Wednesday, August 12, 2020 at 12:39:04 AM UTC+3 Jevgenija wrote:

> Dear contributors,
>
> As part of a research team from Università della Svizzera italiana 
> (Switzerland) and University of Sannio (Italy), we have analyzed 
> refactoring pull requests in codenameone/CodenameOne repository and are 
> looking for developers for a short 5-10 min survey (
> https://usi.eu.qualtrics.com/jfe/form/SV_cO6Ayah0D6q4eSF). Would you 
> please spare your time by answering some questions about 
> refactoring-related contributions? We would greatly appreciate your input — 
> it would help us understand how developers can improve the quality of 
> refactoring contributions, and benefit the development process. The 
> responses will be anonymized and handled confidentially! Thank you a lot!
>
> If you consider this message to be spam, I'm very sorry! There will be no 
> follow-up to bother you.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/73d2ab7f-712a-464c-82ec-8df4900e51e5n%40googlegroups.com.


[codenameone-discussions] Re: I cannot change dialog background

2020-08-11 Thread Shai Almog
Hi,
the dialog uses a border to style it. You need to override the border to 
set it to a different color.

On Tuesday, August 11, 2020 at 12:34:36 PM UTC+3 juraj...@axasoft.eu wrote:

> Hi, there, 
>
> I use Dialog.show to pops up the message, but I'm not able to change the 
> dialog backgroud. On android it is still grey on iOS it changed correctly. 
> I use Dialog, DialogBody classes.
>

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/82fe41dd-db4a-465d-a08a-f72c6a9c3440n%40googlegroups.com.


[codenameone-discussions] Re: CTRL key deletes words in CEF BrowserComponent with text editing

2020-08-11 Thread Shai Almog
Can you please file an issue with a simple test case/platform etc?

On Tuesday, August 11, 2020 at 11:41:05 AM UTC+3 P5music wrote:

> It does happen also with a normal google page, in the search text field.
> In Chrome I do not see anything useful to debug.
> Regards
>
> Il giorno martedì 11 agosto 2020 03:57:43 UTC+2, Shai Almog ha scritto:
>>
>> Does this happen for a generic website? E.g. if you open Google.com?
>> Do you see something while debugging on chrome?
>>
>> On Monday, August 10, 2020 at 9:14:01 PM UTC+3 P5music wrote:
>>
>>> My app has a BrowserComponent as a mean for the user to edit some text. 
>>> I am testing the new CEF BrowserComponent.
>>> I noticed that when I enter the field to edit the text (there is some 
>>> default text) and press just the CTRL key, a word disappears. If I press it 
>>> again another word disappears.
>>> Maybe this is a bug, I do not know.
>>> Thanks in advance
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/dec89c3f-7866-4b73-b5b5-07c8484884c1n%40googlegroups.com.


[codenameone-discussions] Re: Setting the size of the new CEF BrowserComponent programmatically

2020-08-11 Thread Shai Almog
The size of the browser component must be deterministic. That means If you 
place the hierarchy or the browser component in NORTH it will size it based 
on preferred size which is 0 and that won't end up well.

If your layout is more complex than those two options you'd either need to 
explicitly invoke setPreferredSize() (no the browser component) or simplify 
the layout.

On Tuesday, August 11, 2020 at 11:36:32 AM UTC+3 P5music wrote:

> My layout is more complex than a BC in a Table layout. The "detail" part 
> on the right features that BC but it is not the only control, some space  
> are used NORTH for other controls, and some space has to remain empty 
> SOUTH, even if I had to put the BC in the center of a BorderLayout. I 
> accomplished your suggestions, but the point was the BC was tiny. I used 
> the Containers as you said but in a more complex way, combinating them one 
> inside the other.
> Now I need that the BC has a certain height, it was my original goal. I 
> cannot set the TL cell height because the BC is not the entire cell, maybe 
> I did not understand what you mean.
> Thanks in advance
>
>
> Il giorno martedì 11 agosto 2020 03:55:50 UTC+2, Shai Almog ha scritto:
>>
>> If it's in the center it takes up the whole set of available space. You 
>> can see this using the component inspector tool. 
>> I explained to you in your previous post how you can use TableLayout with 
>> BrowserComponent. You just need to disable form scrolling and make sure to 
>> define a height/width constraint to the cell.
>>
>> On Monday, August 10, 2020 at 12:12:03 PM UTC+3 P5music wrote:
>>
>>> I am using the new CEF BrowserComponent.
>>> I put it inside a BorderLayout, at the center, so it takes the space 
>>> according to the content (the surrounding form/container have been set 
>>> correctly to allow this layout to happen).
>>> I need to set the height to a certain size, like 200px, or 4 lines of 
>>> text, for example.
>>> If I set the page to an HTML string with text inside, I see the text and 
>>> no scrollbars (that instead appear in other cases), so it seems that the 
>>> size is not as tall as the remaining space. It is good for my layout but I 
>>> need to set the height exactly before there is text inside, and It has not 
>>> to resize automatically.
>>> The setHeight method does not work, not even after the onload event.
>>> Thanks in advance
>>>
>>>
>>>

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/a9eb7caf-6eeb-4969-a9bc-8b6a5eea27afn%40googlegroups.com.


[codenameone-discussions] Re: CEF BrowserComponent (simulator) does not always update immediately after inserting images in text with Javascript.

2020-08-11 Thread Shai Almog
Can you file an issue on this?
I'm not sure if we can fix this directly since we need a reproducible test 
case but I'm guessing other issues will include those. Once we fix those 
issues I'd like this to be in the tracker so we can verify this was fixed. 
If not we'll need to go over that.

On Tuesday, August 11, 2020 at 11:29:23 AM UTC+3 P5music wrote:

> I do not see any message in the devtools console. But it is possible I am 
> not using it correctly.
> In the attached images you can see what's in Chrome. 
> The depicted screen is the BrowserComponent. It does not resemble what I 
> have on my layout, that is, a BC with text inside as usual. When inserting 
> the image, regardless it is the case that it appears or not in the BC, a 
> blue rectangle appears in the above mentioned screen, then if I click again 
> on the BC the rectangle becomes gray, then next time it disappears.
> Notice that when the image is correctly inserted in the DOM it is 
> highlighted in blue first, then it becomes normal.
>
>
> Il giorno martedì 11 agosto 2020 03:59:26 UTC+2, Shai Almog ha scritto:
>>
>> Odd. It might be a refresh problem. I'm assuming there's nothing obvious 
>> in the JavaScript console. Right?
>>
>> On Monday, August 10, 2020 at 9:28:07 PM UTC+3 P5music wrote:
>>
>>> I think this could be an issue for the CEF BrowserComponent so I report 
>>> it.
>>> My app has this BrowserComponent for text editing. There is some 
>>> functionality that encompasses creating an image in text, at certain offset.
>>> I can easily do that but the BC behaviour changes accordingly to the 
>>> offset or sometimes in erratic fashion.
>>> Here's what happens. When the offset is 0 or the last position the image 
>>> does not appear just after inserting in the DOM as expected, instead I have 
>>> to enter the editing field again to see it (and the size of the BC changes 
>>> at this time, not before, so it is updated at this time and not before). 
>>> This happens every time for those offset positions, but sometimes it 
>>> happens in intermediate positions.
>>> No matter whether I call focus() or other methods on the element (in 
>>> Javascript), or other workarounds, the behaviour is solid, like it is an 
>>> issue.
>>> Thanks in advance
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/3ce4d867-89d8-497a-b00a-7e4d2e43dd5an%40googlegroups.com.


[codenameone-discussions] Study On Rejected Refactorings

2020-08-11 Thread Jevgenija


Dear contributors,

As part of a research team from Università della Svizzera italiana 
(Switzerland) and University of Sannio (Italy), we have analyzed 
refactoring pull requests in codenameone/CodenameOne repository and are 
looking for developers for a short 5-10 min survey 
(https://usi.eu.qualtrics.com/jfe/form/SV_cO6Ayah0D6q4eSF). Would you 
please spare your time by answering some questions about 
refactoring-related contributions? We would greatly appreciate your input — 
it would help us understand how developers can improve the quality of 
refactoring contributions, and benefit the development process. The 
responses will be anonymized and handled confidentially! Thank you a lot!

If you consider this message to be spam, I'm very sorry! There will be no 
follow-up to bother you.

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/bdccf80d-b31a-4a64-a218-9a7827276b4eo%40googlegroups.com.


[codenameone-discussions] I cannot change dialog background

2020-08-11 Thread Juraj Balaz
Hi, there, 

I use Dialog.show to pops up the message, but I'm not able to change the 
dialog backgroud. On android it is still grey on iOS it changed correctly. 
I use Dialog, DialogBody classes.

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/89e2fd56-a0c4-4871-9893-2032aa1af5a1o%40googlegroups.com.


[codenameone-discussions] Re: CTRL key deletes words in CEF BrowserComponent with text editing

2020-08-11 Thread 'P5music' via CodenameOne Discussions
It does happen also with a normal google page, in the search text field.
In Chrome I do not see anything useful to debug.
Regards

Il giorno martedì 11 agosto 2020 03:57:43 UTC+2, Shai Almog ha scritto:
>
> Does this happen for a generic website? E.g. if you open Google.com?
> Do you see something while debugging on chrome?
>
> On Monday, August 10, 2020 at 9:14:01 PM UTC+3 P5music wrote:
>
>> My app has a BrowserComponent as a mean for the user to edit some text. I 
>> am testing the new CEF BrowserComponent.
>> I noticed that when I enter the field to edit the text (there is some 
>> default text) and press just the CTRL key, a word disappears. If I press it 
>> again another word disappears.
>> Maybe this is a bug, I do not know.
>> Thanks in advance
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/2fb25a8a-f24a-4ea5-b1d0-d7f174bb2370o%40googlegroups.com.


[codenameone-discussions] Re: Setting the size of the new CEF BrowserComponent programmatically

2020-08-11 Thread 'P5music' via CodenameOne Discussions
My layout is more complex than a BC in a Table layout. The "detail" part on 
the right features that BC but it is not the only control, some space  are 
used NORTH for other controls, and some space has to remain empty SOUTH, 
even if I had to put the BC in the center of a BorderLayout. I accomplished 
your suggestions, but the point was the BC was tiny. I used the Containers 
as you said but in a more complex way, combinating them one inside the 
other.
Now I need that the BC has a certain height, it was my original goal. I 
cannot set the TL cell height because the BC is not the entire cell, maybe 
I did not understand what you mean.
Thanks in advance

Il giorno martedì 11 agosto 2020 03:55:50 UTC+2, Shai Almog ha scritto:
>
> If it's in the center it takes up the whole set of available space. You 
> can see this using the component inspector tool. 
> I explained to you in your previous post how you can use TableLayout with 
> BrowserComponent. You just need to disable form scrolling and make sure to 
> define a height/width constraint to the cell.
>
> On Monday, August 10, 2020 at 12:12:03 PM UTC+3 P5music wrote:
>
>> I am using the new CEF BrowserComponent.
>> I put it inside a BorderLayout, at the center, so it takes the space 
>> according to the content (the surrounding form/container have been set 
>> correctly to allow this layout to happen).
>> I need to set the height to a certain size, like 200px, or 4 lines of 
>> text, for example.
>> If I set the page to an HTML string with text inside, I see the text and 
>> no scrollbars (that instead appear in other cases), so it seems that the 
>> size is not as tall as the remaining space. It is good for my layout but I 
>> need to set the height exactly before there is text inside, and It has not 
>> to resize automatically.
>> The setHeight method does not work, not even after the onload event.
>> Thanks in advance
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/8bb84771-9a2a-45bb-b737-c8ad6b2f0fbco%40googlegroups.com.


[codenameone-discussions] Re: CEF BrowserComponent (simulator) does not always update immediately after inserting images in text with Javascript.

2020-08-11 Thread 'P5music' via CodenameOne Discussions
I do not see any message in the devtools console. But it is possible I am 
not using it correctly.
In the attached images you can see what's in Chrome. 
The depicted screen is the BrowserComponent. It does not resemble what I 
have on my layout, that is, a BC with text inside as usual. When inserting 
the image, regardless it is the case that it appears or not in the BC, a 
blue rectangle appears in the above mentioned screen, then if I click again 
on the BC the rectangle becomes gray, then next time it disappears.
Notice that when the image is correctly inserted in the DOM it is 
highlighted in blue first, then it becomes normal.

Il giorno martedì 11 agosto 2020 03:59:26 UTC+2, Shai Almog ha scritto:
>
> Odd. It might be a refresh problem. I'm assuming there's nothing obvious 
> in the JavaScript console. Right?
>
> On Monday, August 10, 2020 at 9:28:07 PM UTC+3 P5music wrote:
>
>> I think this could be an issue for the CEF BrowserComponent so I report 
>> it.
>> My app has this BrowserComponent for text editing. There is some 
>> functionality that encompasses creating an image in text, at certain offset.
>> I can easily do that but the BC behaviour changes accordingly to the 
>> offset or sometimes in erratic fashion.
>> Here's what happens. When the offset is 0 or the last position the image 
>> does not appear just after inserting in the DOM as expected, instead I have 
>> to enter the editing field again to see it (and the size of the BC changes 
>> at this time, not before, so it is updated at this time and not before). 
>> This happens every time for those offset positions, but sometimes it 
>> happens in intermediate positions.
>> No matter whether I call focus() or other methods on the element (in 
>> Javascript), or other workarounds, the behaviour is solid, like it is an 
>> issue.
>> Thanks in advance
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to codenameone-discussions+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/codenameone-discussions/fa3a1533-c890-4a8e-ba25-260d5ce714b6o%40googlegroups.com.