[GitHub] trafodion pull request #1514: [TRAFODION-3022] Add web site link to Apache C...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1514


---

[GitHub] trafodion pull request #1522: [TRAFODION-3009] Streamline error handling in ...

[selvaganesang]

Github user selvaganesang commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1522#discussion_r182166447
  
--- Diff: core/sql/executor/ExExeUtilCli.cpp ---
@@ -1119,7 +1119,7 @@ Lng32 ExeCliInterface::executeImmediate(const char * 
stmtStr,
 {
   // Allocate the diagnostics area if needed
   // and populate the diagnostics conditions
-  if (*globalDiags == NULL && retcode != 0) {
+  if (*globalDiags == NULL && retcode != 0 && retcode != 100) {
--- End diff --

Returning retcode with a value of 100 is ok and should be treated as end of 
result by the callers. This additional check just avoids creating a 
ComDiagsArea if the return code is just 100.


---

[GitHub] trafodion pull request #1523: [TRAFODION-3023] Add more enum files to analyz...

[DaveBirdsall]

GitHub user DaveBirdsall opened a pull request:

https://github.com/apache/trafodion/pull/1523

[TRAFODION-3023] Add more enum files to analyzeMessageGuide.py

This set of changes does the following:

1. Adds sort/SortError.h and udrserv/udrdefs.h to the list of error message 
enum files known to the script analyzeMessageGuide.py

2. Adds an enum name to sort/SortError.h to make it easier for 
analyzeMessageGuide.py to process

3. Converts defines to a named enum in udrserv/udrdefs.h to make it easier 
for analyzeMessageGuide.py to process, and deletes some redundant and unused 
symbols

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaveBirdsall/trafodion Trafodion3023

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1523


commit 3444e174ce80c4753b5505b63701a3a92f6e18f7
Author: Dave Birdsall 
Date:   2018-04-17T16:14:28Z

[TRAFODION-3023] Add more enum files to analyzeMessageGuide.py




---